René's URL Explorer Experiment


Title: recompute character to column when comparing indentations by vladima · Pull Request #12375 · microsoft/TypeScript · GitHub

Open Graph Title: recompute character to column when comparing indentations by vladima · Pull Request #12375 · microsoft/TypeScript

X Title: recompute character to column when comparing indentations by vladima · Pull Request #12375 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - recompute character to column when comparing indentations by vladima · Pull Request #12375 · microsoft/TypeScript

Open Graph Description: we always compute indentation as column so in order to compare it with character position in line - character position must be converted to column as well. fixes #12175

X Description: we always compute indentation as column so in order to compare it with character position in line - character position must be converted to column as well. fixes #12175

Opengraph URL: https://github.com/microsoft/TypeScript/pull/12375

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3d654757-94b2-4d0c-0705-f1853bdb368e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBB76:36A403:4BC29:6DF75:6AFC541B
html-safe-nonce912079bf9d29b09d66b3e4a4a7af5310d5cbc93005302506d7868fc47a59d8aa
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjc2OjM2QTQwMzo0QkMyOTo2REY3NTo2QUZDNTQxQiIsInZpc2l0b3JfaWQiOiI2NTg1NTUyODI2NTMxNTk5Mzg3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace8a3cfaecd98d399ccc378a0ba4ecbf34301500563395528780f4a51eb472d82
hovercard-subject-tagpull_request:94472491
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/12375/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/af74aac4f882c5748b142e2c44c5f140a30843252531a08826dbcd2969085199/microsoft/TypeScript/pull/12375
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/af74aac4f882c5748b142e2c44c5f140a30843252531a08826dbcd2969085199/microsoft/TypeScript/pull/12375
og:image:altwe always compute indentation as column so in order to compare it with character position in line - character position must be converted to column as well. fixes #12175
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevladima
hostnamegithub.com
expected-hostnamegithub.com
Noneb63557e0027d8014589e873df28328da74a4356701bb1a9eab49dbf012ba8fa6
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release0243355b0352c83733a042e0dfb3d75149b51261
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/12375#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F12375
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F12375
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/12375
Reloadhttps://github.com/microsoft/TypeScript/pull/12375
Reloadhttps://github.com/microsoft/TypeScript/pull/12375
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests338 (338)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/pulse
https://github.com/microsoft/TypeScript
Vladimir Matveev (vladima)https://github.com/vladima
masterhttps://github.com/microsoft/TypeScript/tree/master
vladima/12175https://github.com/microsoft/TypeScript/tree/vladima/12175
Conversationhttps://github.com/microsoft/TypeScript/pull/12375
Commits2 (2)https://github.com/microsoft/TypeScript/pull/12375/commits
Checkshttps://github.com/microsoft/TypeScript/pull/12375/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/12375/files
recompute character to column when comparing indentationshttps://github.com/microsoft/TypeScript/pull/12375#top
Vladimir Matveev (vladima)https://github.com/vladima
masterhttps://github.com/microsoft/TypeScript/tree/master
vladima/12175https://github.com/microsoft/TypeScript/tree/vladima/12175
https://github.com/vladima
Vladimir Matveev (vladima)https://github.com/vladima
Nov 19, 2016https://github.com/microsoft/TypeScript/pull/12375#issue-190479607
#12175https://github.com/microsoft/TypeScript/issues/12175
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/12375
https://github.com/vladima
recompute character to column when comparing indentationshttps://github.com/microsoft/TypeScript/pull/12375/commits/6f179bf48e3d2a93e09a30f28c9ed1ddeec06fba
6f179bfhttps://github.com/microsoft/TypeScript/pull/12375/commits/6f179bf48e3d2a93e09a30f28c9ed1ddeec06fba
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-not-required https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required
Nov 19, 2016https://github.com/microsoft/TypeScript/pull/12375#event-865268537
https://github.com/CyrusNajmabadi
Cyrus Najmabadi (CyrusNajmabadi)https://github.com/CyrusNajmabadi
Nov 19, 2016 https://github.com/microsoft/TypeScript/pull/12375#pullrequestreview-9340399
View reviewed changes https://github.com/microsoft/TypeScript/pull/12375/files/6f179bf48e3d2a93e09a30f28c9ed1ddeec06fba
src/services/formatting/formatting.tshttps://github.com/microsoft/TypeScript/pull/12375/files/6f179bf48e3d2a93e09a30f28c9ed1ddeec06fba#diff-853328a69fa29e01eda0b7b5e4ef672c45640a0bacae48a031159ea916761834
Cyrus Najmabadi (CyrusNajmabadi)https://github.com/CyrusNajmabadi
Nov 19, 2016https://github.com/microsoft/TypeScript/pull/12375#discussion_r88773890
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/12375
Cyrus Najmabadi (CyrusNajmabadi)https://github.com/CyrusNajmabadi
Nov 19, 2016https://github.com/microsoft/TypeScript/pull/12375#discussion_r88773905
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/12375
Vladimir Matveev (vladima)https://github.com/vladima
Nov 19, 2016https://github.com/microsoft/TypeScript/pull/12375#discussion_r88773925
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/12375
https://github.com/vladima
Vladimir Matveev (vladima)https://github.com/vladima
Nov 19, 2016https://github.com/microsoft/TypeScript/pull/12375#issuecomment-261697874
#12376https://github.com/microsoft/TypeScript/pull/12376
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/12375
https://github.com/vladima
update column computation mathhttps://github.com/microsoft/TypeScript/pull/12375/commits/5c5ee58d00ba3ce16914571bd69732367eca67d0
5c5ee58https://github.com/microsoft/TypeScript/pull/12375/commits/5c5ee58d00ba3ce16914571bd69732367eca67d0
https://github.com/waderyan
Wade Anderson (waderyan)https://github.com/waderyan
Nov 21, 2016 https://github.com/microsoft/TypeScript/pull/12375#ref-issue-188719675
Formatter is broken when using tabs #12175 https://github.com/microsoft/TypeScript/issues/12175
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Nov 21, 2016 https://github.com/microsoft/TypeScript/pull/12375#pullrequestreview-9524659
View reviewed changes https://github.com/microsoft/TypeScript/pull/12375/files/5c5ee58d00ba3ce16914571bd69732367eca67d0
https://github.com/vladima
Vladimir Matveev (vladima)https://github.com/vladima
b060107https://github.com/microsoft/TypeScript/commit/b060107b516b04c37081419770374a62b99c2bed
Nov 21, 2016https://github.com/microsoft/TypeScript/pull/12375#event-867102515
https://github.com/vladima
Vladimir Matveev (vladima)https://github.com/vladima
November 21, 2016 19:34https://github.com/microsoft/TypeScript/pull/12375#event-867102554
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Nov 21, 2016https://github.com/microsoft/TypeScript/pull/12375#issuecomment-262044459
Vladimir Matveev (@vladima)https://github.com/vladima
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/12375
Vladimir Matveev (vladima)https://github.com/vladima
Nov 21, 2016 https://github.com/microsoft/TypeScript/pull/12375#ref-commit-7f023c4
https://github.com/vladima
recompute character to column when comparing indentations (https://github.com/microsoft/TypeScript/commit/7f023c418f4177c8613a23195737313ef8375a4d
#12375https://github.com/microsoft/TypeScript/pull/12375
)https://github.com/microsoft/TypeScript/commit/7f023c418f4177c8613a23195737313ef8375a4d
7f023c4https://github.com/microsoft/TypeScript/commit/7f023c418f4177c8613a23195737313ef8375a4d
https://github.com/vladima
Vladimir Matveev (vladima)https://github.com/vladima
Nov 21, 2016 https://github.com/microsoft/TypeScript/pull/12375#ref-pullrequest-190817899
recompute character to column when comparing indentations (#12375) #12418 https://github.com/microsoft/TypeScript/pull/12418
https://github.com/vladima
Vladimir Matveev (vladima)https://github.com/vladima
Nov 21, 2016https://github.com/microsoft/TypeScript/pull/12375#issuecomment-262047704
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/12375
Vladimir Matveev (vladima)https://github.com/vladima
Nov 21, 2016 https://github.com/microsoft/TypeScript/pull/12375#ref-commit-4c8cdb4
https://github.com/vladima
recompute character to column when comparing indentations (https://github.com/microsoft/TypeScript/commit/4c8cdb41e6cbd6d2cd5265e0ea2d23646e72c485
#12375https://github.com/microsoft/TypeScript/pull/12375
) (https://github.com/microsoft/TypeScript/commit/4c8cdb41e6cbd6d2cd5265e0ea2d23646e72c485
#…https://github.com/microsoft/TypeScript/pull/12418
4c8cdb4https://github.com/microsoft/TypeScript/commit/4c8cdb41e6cbd6d2cd5265e0ea2d23646e72c485
…12418https://github.com/microsoft/TypeScript/pull/12418
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 19, 2018https://github.com/microsoft/TypeScript/pull/12375#event-1689922017
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F12375
https://github.com/CyrusNajmabadi
Cyrus Najmabadi (CyrusNajmabadi) https://github.com/CyrusNajmabadi
https://github.com/microsoft/TypeScript/pull/12375/files/6f179bf48e3d2a93e09a30f28c9ed1ddeec06fba
https://github.com/mhegazy
Mohamed Hegazy (mhegazy) https://github.com/mhegazy
https://github.com/microsoft/TypeScript/pull/12375/files/5c5ee58d00ba3ce16914571bd69732367eca67d0
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/12375
Formatter is broken when using tabs https://github.com/microsoft/TypeScript/issues/12175
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/12375
https://github.com/vladima
https://github.com/mhegazy
https://github.com/CyrusNajmabadi
https://github.com/msftclas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.