René's URL Explorer Experiment


Title: Fix type predicates with structurally identical types by ahejlsberg · Pull Request #12251 · microsoft/TypeScript · GitHub

Open Graph Title: Fix type predicates with structurally identical types by ahejlsberg · Pull Request #12251 · microsoft/TypeScript

X Title: Fix type predicates with structurally identical types by ahejlsberg · Pull Request #12251 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Fix type predicates with structurally identical types by ahejlsberg · Pull Request #12251 · microsoft/TypeScript

Open Graph Description: The special casing we implemented for instanceof in #10216 also ended up also applying to similar type predicates. This fix reverts type predicates to their original behavior. Fixes #12235.

X Description: The special casing we implemented for instanceof in #10216 also ended up also applying to similar type predicates. This fix reverts type predicates to their original behavior. Fixes #12235.

Opengraph URL: https://github.com/microsoft/TypeScript/pull/12251

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f84de5a7-f0bf-b7ae-d478-199ef46230cc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCA30:A20F9:F8304B:14AA581:6B0107F4
html-safe-noncef831c1926b2331ddb7ee4aa1315ba9317c613eddc980f58c4be7bf561671ecce
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTMwOkEyMEY5OkY4MzA0QjoxNEFBNTgxOjZCMDEwN0Y0IiwidmlzaXRvcl9pZCI6Ijc4NDUwMjk0ODA0NTUyNzY1MzIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac87ea82897a25824908356339995cb74e58c2dfe17ede011a8358a4e3a75abdf4
hovercard-subject-tagpull_request:93682951
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/12251/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/570951a947f326031b6fdbb3096eea69d155e124ee9179f72447d91b8529f39e/microsoft/TypeScript/pull/12251
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/570951a947f326031b6fdbb3096eea69d155e124ee9179f72447d91b8529f39e/microsoft/TypeScript/pull/12251
og:image:altThe special casing we implemented for instanceof in #10216 also ended up also applying to similar type predicates. This fix reverts type predicates to their original behavior. Fixes #12235.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameahejlsberg
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/12251#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F12251
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F12251
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/12251
Reloadhttps://github.com/microsoft/TypeScript/pull/12251
Reloadhttps://github.com/microsoft/TypeScript/pull/12251
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
masterhttps://github.com/microsoft/TypeScript/tree/master
fixTypePredicateStructuralMatchhttps://github.com/microsoft/TypeScript/tree/fixTypePredicateStructuralMatch
Conversationhttps://github.com/microsoft/TypeScript/pull/12251
Commits4 (4)https://github.com/microsoft/TypeScript/pull/12251/commits
Checkshttps://github.com/microsoft/TypeScript/pull/12251/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/12251/files
Fix type predicates with structurally identical typeshttps://github.com/microsoft/TypeScript/pull/12251#top
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
masterhttps://github.com/microsoft/TypeScript/tree/master
fixTypePredicateStructuralMatchhttps://github.com/microsoft/TypeScript/tree/fixTypePredicateStructuralMatch
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Nov 15, 2016https://github.com/microsoft/TypeScript/pull/12251#issue-189273532
#10216https://github.com/microsoft/TypeScript/pull/10216
#12235https://github.com/microsoft/TypeScript/issues/12235
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/12251
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
November 14, 2016 17:06https://github.com/microsoft/TypeScript/pull/12251#commits-pushed-6d28595
https://github.com/ahejlsberg
Add repro testhttps://github.com/microsoft/TypeScript/pull/12251/commits/6d28595e5a2ef4a396f83ba92c3d6ac3eaace31e
6d28595https://github.com/microsoft/TypeScript/pull/12251/commits/6d28595e5a2ef4a396f83ba92c3d6ac3eaace31e
https://github.com/ahejlsberg
Accept baselineshttps://github.com/microsoft/TypeScript/pull/12251/commits/2bcb6e9812659095d2a60cd53bb4a73f286ed74c
2bcb6e9https://github.com/microsoft/TypeScript/pull/12251/commits/2bcb6e9812659095d2a60cd53bb4a73f286ed74c
https://github.com/ahejlsberg
Revert type predicates to not have instanceof special casinghttps://github.com/microsoft/TypeScript/pull/12251/commits/d2c0952801dcefec7becaeb7f6f7822617e3dae0
d2c0952https://github.com/microsoft/TypeScript/pull/12251/commits/d2c0952801dcefec7becaeb7f6f7822617e3dae0
https://github.com/ahejlsberg
Accept new baselineshttps://github.com/microsoft/TypeScript/pull/12251/commits/b6b43610357ccefb797b6f500ca42680681c693c
b6b4361https://github.com/microsoft/TypeScript/pull/12251/commits/b6b43610357ccefb797b6f500ca42680681c693c
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-not-required https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required
Nov 15, 2016https://github.com/microsoft/TypeScript/pull/12251#event-858734782
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Nov 15, 2016 https://github.com/microsoft/TypeScript/pull/12251#pullrequestreview-8657020
View reviewed changes https://github.com/microsoft/TypeScript/pull/12251/files/b6b43610357ccefb797b6f500ca42680681c693c
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
73ada7ahttps://github.com/microsoft/TypeScript/commit/73ada7a78db1dcc2ff6b2e72785336330ee9dd21
Nov 15, 2016https://github.com/microsoft/TypeScript/pull/12251#event-860095080
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
November 15, 2016 21:20https://github.com/microsoft/TypeScript/pull/12251#event-860095132
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Nov 16, 2016 https://github.com/microsoft/TypeScript/pull/12251#ref-issue-189553077
Snapshot nightlies during the night #12283 https://github.com/microsoft/TypeScript/issues/12283
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 19, 2018https://github.com/microsoft/TypeScript/pull/12251#event-1689921272
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F12251
https://github.com/mhegazy
Mohamed Hegazy (mhegazy) https://github.com/mhegazy
https://github.com/microsoft/TypeScript/pull/12251/files/b6b43610357ccefb797b6f500ca42680681c693c
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/12251
Narrowing a type union with user-defined type guard https://github.com/microsoft/TypeScript/issues/12235
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/12251
https://github.com/ahejlsberg
https://github.com/mhegazy
https://github.com/msftclas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.