| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:cd54802d-e788-650b-2824-7b5035b804b6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C824:1F65:1B7E576:22F14B0:6B01AE77 |
| html-safe-nonce | b67811541aa5379efa2fa1fdeda61bc974758594dc3bf2053161cdc45ffc1c23 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDODI0OjFGNjU6MUI3RTU3NjoyMkYxNEIwOjZCMDFBRTc3IiwidmlzaXRvcl9pZCI6IjE4NTUyODk3NzkwMzg1NjM5NTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 551db441a916fe81b921a64c4f9afb1797f460242fa746859805001351ec7193 |
| hovercard-subject-tag | pull_request:87988127 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/11370/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/98203b99343142c7d37aa605b3b5d6a7623e10205e422d10983b9260c4eae19b/microsoft/TypeScript/pull/11370 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/98203b99343142c7d37aa605b3b5d6a7623e10205e422d10983b9260c4eae19b/microsoft/TypeScript/pull/11370 |
| og:image:alt | Bind the source file as external module only if not already done
Return type of require call is from external module resolution only if it doesn't resolve to local module
Fixes #10931
Note tha... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sheetalkamat |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/11370#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F11370 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F11370 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/11370 |
| Reload | https://github.com/microsoft/TypeScript/pull/11370 |
| Reload | https://github.com/microsoft/TypeScript/pull/11370 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests312 (312) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| Sheetal Nandi (sheetalkamat) | https://github.com/sheetalkamat |
| master | https://github.com/microsoft/TypeScript/tree/master |
| requireAsFunctionInExternalModule | https://github.com/microsoft/TypeScript/tree/requireAsFunctionInExternalModule |
| Conversation | https://github.com/microsoft/TypeScript/pull/11370 |
| Commits4 (4) | https://github.com/microsoft/TypeScript/pull/11370/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/11370/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/11370/files |
| Do not treat local resolution of require call as external module | https://github.com/microsoft/TypeScript/pull/11370#top |
| Sheetal Nandi (sheetalkamat) | https://github.com/sheetalkamat |
| master | https://github.com/microsoft/TypeScript/tree/master |
| requireAsFunctionInExternalModule | https://github.com/microsoft/TypeScript/tree/requireAsFunctionInExternalModule |
|
| https://github.com/sheetalkamat |
| Sheetal Nandi (sheetalkamat) | https://github.com/sheetalkamat |
| Oct 4, 2016 | https://github.com/microsoft/TypeScript/pull/11370#issue-181023609 |
| #10931 | https://github.com/microsoft/TypeScript/issues/10931 |
| #10931 | https://github.com/microsoft/TypeScript/issues/10931 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/11370 |
| Sheetal Nandi (sheetalkamat) | https://github.com/sheetalkamat |
| October 4, 2016 12:17 | https://github.com/microsoft/TypeScript/pull/11370#commits-pushed-a70624d |
|
| https://github.com/sheetalkamat |
| Add test when require is just a function in external module | https://github.com/microsoft/TypeScript/pull/11370/commits/a70624d4159e9de3f2c497d2f7ec52082fee7bf6 |
| a70624d | https://github.com/microsoft/TypeScript/pull/11370/commits/a70624d4159e9de3f2c497d2f7ec52082fee7bf6 |
|
| https://github.com/sheetalkamat |
| Bind the source file as external module only if not already done | https://github.com/microsoft/TypeScript/pull/11370/commits/a830c844b7846f56a785d0ed8a2e75d4bec7a14f |
| a830c84 | https://github.com/microsoft/TypeScript/pull/11370/commits/a830c844b7846f56a785d0ed8a2e75d4bec7a14f |
| #10931 | https://github.com/microsoft/TypeScript/issues/10931 |
| https://github.com/msftclas |
| Microsoft Contribution License Agreements (msftclas) | https://github.com/msftclas |
|
cla-not-required
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required |
| Oct 4, 2016 | https://github.com/microsoft/TypeScript/pull/11370#event-812522200 |
| https://github.com/mhegazy |
| Mohamed Hegazy (mhegazy) | https://github.com/mhegazy |
|
Oct 13, 2016
| https://github.com/microsoft/TypeScript/pull/11370#pullrequestreview-4180996 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/11370/files/a830c844b7846f56a785d0ed8a2e75d4bec7a14f |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/11370/files/a830c844b7846f56a785d0ed8a2e75d4bec7a14f#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Mohamed Hegazy (mhegazy) | https://github.com/mhegazy |
| Oct 13, 2016 | https://github.com/microsoft/TypeScript/pull/11370#discussion_r83329220 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/11370 |
| Sheetal Nandi (sheetalkamat) | https://github.com/sheetalkamat |
| Oct 13, 2016 | https://github.com/microsoft/TypeScript/pull/11370#discussion_r83335143 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/11370 |
| Mohamed Hegazy (mhegazy) | https://github.com/mhegazy |
| Oct 13, 2016 | https://github.com/microsoft/TypeScript/pull/11370#discussion_r83335373 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/11370 |
| Sheetal Nandi (sheetalkamat) | https://github.com/sheetalkamat |
| October 17, 2016 16:08 | https://github.com/microsoft/TypeScript/pull/11370#commits-pushed-28899f3 |
|
| https://github.com/sheetalkamat |
| Update the resolveName symbol flags for 'require' resolution | https://github.com/microsoft/TypeScript/pull/11370/commits/28899f386011353aeee3ccb17accab03a927f444 |
| 28899f3 | https://github.com/microsoft/TypeScript/pull/11370/commits/28899f386011353aeee3ccb17accab03a927f444 |
|
| https://github.com/sheetalkamat |
| Merge branch 'master' into requireAsFunctionInExternalModule | https://github.com/microsoft/TypeScript/pull/11370/commits/e72414ecabf717fadfdcbeec27e52f4e89dc347a |
| e72414e | https://github.com/microsoft/TypeScript/pull/11370/commits/e72414ecabf717fadfdcbeec27e52f4e89dc347a |
| https://github.com/mhegazy |
| Mohamed Hegazy (mhegazy) | https://github.com/mhegazy |
|
Oct 17, 2016
| https://github.com/microsoft/TypeScript/pull/11370#pullrequestreview-4577625 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/11370/files/e72414ecabf717fadfdcbeec27e52f4e89dc347a |
| https://github.com/sheetalkamat |
| Sheetal Nandi (sheetalkamat) | https://github.com/sheetalkamat |
| 28452d5 | https://github.com/microsoft/TypeScript/commit/28452d5a7b7aebaa5eb280a86135e037d7bf4561 |
| Oct 17, 2016 | https://github.com/microsoft/TypeScript/pull/11370#event-826737090 |
| https://github.com/sheetalkamat |
| Sheetal Nandi (sheetalkamat) | https://github.com/sheetalkamat |
| October 17, 2016 23:37 | https://github.com/microsoft/TypeScript/pull/11370#event-826737117 |
|
Code editing sequence matters for typing acquisition
#11744
| https://github.com/microsoft/TypeScript/issues/11744 |
|
commonjs module functionality is broken when project externally defined ambient require function
#11752
| https://github.com/microsoft/TypeScript/issues/11752 |
| https://github.com/vojtechhabarta |
| Vojtěch Habarta (vojtechhabarta) | https://github.com/vojtechhabarta |
|
Oct 24, 2016
| https://github.com/microsoft/TypeScript/pull/11370#ref-pullrequest-160772057 |
|
Completion list for JSON files imported using CommonJS require
#9221
| https://github.com/microsoft/TypeScript/pull/9221 |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Jun 19, 2018 | https://github.com/microsoft/TypeScript/pull/11370#event-1689915878 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F11370 |
|
| https://github.com/mhegazy |
|
Mohamed Hegazy (mhegazy)
| https://github.com/mhegazy |
|
| https://github.com/microsoft/TypeScript/pull/11370/files/e72414ecabf717fadfdcbeec27e52f4e89dc347a |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/11370 |
|
A require call that isn't the global require will clobber bindings
| https://github.com/microsoft/TypeScript/issues/10931 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/11370 |
|
| https://github.com/sheetalkamat |
|
| https://github.com/mhegazy |
|
| https://github.com/msftclas |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |