René's URL Explorer Experiment


Title: Improve instanceof with structurally identical types by ahejlsberg · Pull Request #10216 · microsoft/TypeScript · GitHub

Open Graph Title: Improve instanceof with structurally identical types by ahejlsberg · Pull Request #10216 · microsoft/TypeScript

X Title: Improve instanceof with structurally identical types by ahejlsberg · Pull Request #10216 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Improve instanceof with structurally identical types by ahejlsberg · Pull Request #10216 · microsoft/TypeScript

Open Graph Description: This PR improves typing of instanceof with structurally identical types. A type S is now considered to be an instance of a type T if S and T are the same type, or S is a subtype of T but not struc...

X Description: This PR improves typing of instanceof with structurally identical types. A type S is now considered to be an instance of a type T if S and T are the same type, or S is a subtype of T but not struc...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/10216

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4e3b732e-b029-4721-5865-d9e7484ec021
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB3BA:25A204:E4EDAF:12E5206:6B00FDF7
html-safe-nonce665a912666b221ac2dbf27641e5d52c625d6893e6fd7c57667ff3099ab3d9831
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCM0JBOjI1QTIwNDpFNEVEQUY6MTJFNTIwNjo2QjAwRkRGNyIsInZpc2l0b3JfaWQiOiI0MTMxMjM4NzI0OTUwMzU5NTQzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac39092832d15b117609c1649ca85ad18a6e4f3f1114d9d9bd8d18647c872bab89
hovercard-subject-tagpull_request:80545893
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/10216/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/fad8f7c3f268906fa6c86bd157527ce0c079138d04835287f61bfc83e0d24128/microsoft/TypeScript/pull/10216
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fad8f7c3f268906fa6c86bd157527ce0c079138d04835287f61bfc83e0d24128/microsoft/TypeScript/pull/10216
og:image:altThis PR improves typing of instanceof with structurally identical types. A type S is now considered to be an instance of a type T if S and T are the same type, or S is a subtype of T but not struc...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameahejlsberg
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/10216#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F10216
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F10216
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/10216
Reloadhttps://github.com/microsoft/TypeScript/pull/10216
Reloadhttps://github.com/microsoft/TypeScript/pull/10216
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
masterhttps://github.com/microsoft/TypeScript/tree/master
structurallyIdenticalInstanceofhttps://github.com/microsoft/TypeScript/tree/structurallyIdenticalInstanceof
Conversationhttps://github.com/microsoft/TypeScript/pull/10216
Commits4 (4)https://github.com/microsoft/TypeScript/pull/10216/commits
Checkshttps://github.com/microsoft/TypeScript/pull/10216/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/10216/files
Improve instanceof with structurally identical typeshttps://github.com/microsoft/TypeScript/pull/10216#top
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
masterhttps://github.com/microsoft/TypeScript/tree/master
structurallyIdenticalInstanceofhttps://github.com/microsoft/TypeScript/tree/structurallyIdenticalInstanceof
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Aug 9, 2016https://github.com/microsoft/TypeScript/pull/10216#issue-170058920
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/10216
#7271https://github.com/microsoft/TypeScript/issues/7271
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/10216
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
August 8, 2016 16:40https://github.com/microsoft/TypeScript/pull/10216#commits-pushed-624e52e
https://github.com/ahejlsberg
Improve instanceof for structurally identical typeshttps://github.com/microsoft/TypeScript/pull/10216/commits/624e52e8342947f49f9744de8904bad7917175c8
624e52ehttps://github.com/microsoft/TypeScript/pull/10216/commits/624e52e8342947f49f9744de8904bad7917175c8
https://github.com/ahejlsberg
Introduce isTypeInstanceOf functionhttps://github.com/microsoft/TypeScript/pull/10216/commits/5ebfad6e4aecc6bdea21d0c63e5769ae57caaecb
5ebfad6https://github.com/microsoft/TypeScript/pull/10216/commits/5ebfad6e4aecc6bdea21d0c63e5769ae57caaecb
https://github.com/ahejlsberg
Add testhttps://github.com/microsoft/TypeScript/pull/10216/commits/9277b3f5addac8380a6b6eb2c501d22d82554bf2
9277b3fhttps://github.com/microsoft/TypeScript/pull/10216/commits/9277b3f5addac8380a6b6eb2c501d22d82554bf2
https://github.com/ahejlsberg
Accept new baselineshttps://github.com/microsoft/TypeScript/pull/10216/commits/fe1854e4410d342d5e18f7c7d8a285941604743c
fe1854ehttps://github.com/microsoft/TypeScript/pull/10216/commits/fe1854e4410d342d5e18f7c7d8a285941604743c
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-not-required https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required
Aug 9, 2016https://github.com/microsoft/TypeScript/pull/10216#event-749213199
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Aug 9, 2016https://github.com/microsoft/TypeScript/pull/10216#issuecomment-238422690
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/10216
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Aug 9, 2016https://github.com/microsoft/TypeScript/pull/10216#issuecomment-238423032
Daniel Rosenwasser (@DanielRosenwasser)https://github.com/DanielRosenwasser
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/10216
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Aug 9, 2016https://github.com/microsoft/TypeScript/pull/10216#issuecomment-238455658
#10194https://github.com/microsoft/TypeScript/pull/10194
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/10216
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
3f1ec7ahttps://github.com/microsoft/TypeScript/commit/3f1ec7ad4bda8fb546beece999f5f20ef6fe9f24
Aug 9, 2016https://github.com/microsoft/TypeScript/pull/10216#event-749359674
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
August 9, 2016 05:14https://github.com/microsoft/TypeScript/pull/10216#event-749359709
https://github.com/yortus
Troy Gerwien (yortus)https://github.com/yortus
Aug 9, 2016 https://github.com/microsoft/TypeScript/pull/10216#ref-issue-136845222
instanceof typeguard fails if classes have similar structure #7271 https://github.com/microsoft/TypeScript/issues/7271
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Aug 10, 2016 https://github.com/microsoft/TypeScript/pull/10216#ref-issue-170452450
Type predicates fail to remove subclasses from unions for assumeTrue=false. #10254 https://github.com/microsoft/TypeScript/issues/10254
https://github.com/yortus
Troy Gerwien (yortus)https://github.com/yortus
Aug 19, 2016 https://github.com/microsoft/TypeScript/pull/10216#ref-issue-172019037
InstanceOf incorrectly narrow when two type extends same base class #10422 https://github.com/microsoft/TypeScript/issues/10422
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Sep 28, 2016 https://github.com/microsoft/TypeScript/pull/10216#ref-issue-179338189
Bug: Control flow type analysis regression. #11153 https://github.com/microsoft/TypeScript/issues/11153
https://github.com/yortus
Troy Gerwien (yortus)https://github.com/yortus
Oct 16, 2016 https://github.com/microsoft/TypeScript/pull/10216#ref-issue-183233946
Wrong type narrowing when types are compatibles #11664 https://github.com/microsoft/TypeScript/issues/11664
https://github.com/yortus
Troy Gerwien (yortus)https://github.com/yortus
Nov 8, 2016 https://github.com/microsoft/TypeScript/pull/10216#ref-issue-187746833
'Property does not exist on type 'never'." after updating to TS 2.0 #12083 https://github.com/microsoft/TypeScript/issues/12083
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Nov 15, 2016 https://github.com/microsoft/TypeScript/pull/10216#ref-pullrequest-189273532
Fix type predicates with structurally identical types #12251 https://github.com/microsoft/TypeScript/pull/12251
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 19, 2018https://github.com/microsoft/TypeScript/pull/10216#event-1689845172
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F10216
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/10216
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/10216
https://github.com/ahejlsberg
https://github.com/DanielRosenwasser
https://github.com/msftclas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.