René's URL Explorer Experiment


Title: Fix instanceof narrowing by ahejlsberg · Pull Request #10194 · microsoft/TypeScript · GitHub

Open Graph Title: Fix instanceof narrowing by ahejlsberg · Pull Request #10194 · microsoft/TypeScript

X Title: Fix instanceof narrowing by ahejlsberg · Pull Request #10194 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Fix instanceof narrowing by ahejlsberg · Pull Request #10194 · microsoft/TypeScript

Open Graph Description: This PR fixes three issues related to narrowing of types with the instanceof operator and user defined type guards: In an operation x instanceof T where x is of a non-union type, we now narrow the...

X Description: This PR fixes three issues related to narrowing of types with the instanceof operator and user defined type guards: In an operation x instanceof T where x is of a non-union type, we now narrow the...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/10194

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:575540d7-49e8-090c-7c81-efbec874d641
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE9A6:29FFA9:E69804:124E722:6B0107B5
html-safe-noncee60db5b2a8aa96cfe2d1e5decb5af43740af06ea0763ccb3e36f3c11510e323e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOUE2OjI5RkZBOTpFNjk4MDQ6MTI0RTcyMjo2QjAxMDdCNSIsInZpc2l0b3JfaWQiOiI4Njg5NTg5MzkyODE5NDIzMTU3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2efa718f9f22796eb6560191a9c3d8f57d96733725f613891b3b4271b05ec40d
hovercard-subject-tagpull_request:80371010
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/10194/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5259bf52a6d50db4785f5cd69b530bb153d75696462f44cdbdaa9caa057920db/microsoft/TypeScript/pull/10194
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5259bf52a6d50db4785f5cd69b530bb153d75696462f44cdbdaa9caa057920db/microsoft/TypeScript/pull/10194
og:image:altThis PR fixes three issues related to narrowing of types with the instanceof operator and user defined type guards: In an operation x instanceof T where x is of a non-union type, we now narrow the...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameahejlsberg
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/10194#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F10194
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F10194
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/10194
Reloadhttps://github.com/microsoft/TypeScript/pull/10194
Reloadhttps://github.com/microsoft/TypeScript/pull/10194
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
masterhttps://github.com/microsoft/TypeScript/tree/master
fixInstanceofNarrowinghttps://github.com/microsoft/TypeScript/tree/fixInstanceofNarrowing
Conversationhttps://github.com/microsoft/TypeScript/pull/10194
Commits6 (6)https://github.com/microsoft/TypeScript/pull/10194/commits
Checkshttps://github.com/microsoft/TypeScript/pull/10194/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/10194/files
Fix instanceof narrowinghttps://github.com/microsoft/TypeScript/pull/10194#top
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
masterhttps://github.com/microsoft/TypeScript/tree/master
fixInstanceofNarrowinghttps://github.com/microsoft/TypeScript/tree/fixInstanceofNarrowing
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Aug 7, 2016https://github.com/microsoft/TypeScript/pull/10194#issue-169803429
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/10194
#10145https://github.com/microsoft/TypeScript/issues/10145
#10167https://github.com/microsoft/TypeScript/issues/10167
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/10194
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
August 7, 2016 07:48https://github.com/microsoft/TypeScript/pull/10194#commits-pushed-01f865d
https://github.com/ahejlsberg
Fix instanceof operator narrowing issueshttps://github.com/microsoft/TypeScript/pull/10194/commits/01f865dee7f36f00ad79877b09661e6b8de08b21
01f865dhttps://github.com/microsoft/TypeScript/pull/10194/commits/01f865dee7f36f00ad79877b09661e6b8de08b21
https://github.com/ahejlsberg
Accept new baselineshttps://github.com/microsoft/TypeScript/pull/10194/commits/f50226b481900af204ed9f8d0c29e32a56827c54
f50226bhttps://github.com/microsoft/TypeScript/pull/10194/commits/f50226b481900af204ed9f8d0c29e32a56827c54
https://github.com/ahejlsberg
Add regression testhttps://github.com/microsoft/TypeScript/pull/10194/commits/67b3fe58fa9b0761da93d9ea6ab2e8019b6a4b22
67b3fe5https://github.com/microsoft/TypeScript/pull/10194/commits/67b3fe58fa9b0761da93d9ea6ab2e8019b6a4b22
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-not-required https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required
Aug 7, 2016https://github.com/microsoft/TypeScript/pull/10194#event-747712558
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Aug 7, 2016https://github.com/microsoft/TypeScript/pull/10194#issuecomment-238095469
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/10194
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Aug 7, 2016https://github.com/microsoft/TypeScript/pull/10194#issuecomment-238096962
Daniel Rosenwasser (@DanielRosenwasser)https://github.com/DanielRosenwasser
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/10194
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Aug 8, 2016https://github.com/microsoft/TypeScript/pull/10194#issuecomment-238161431
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/10194
DanielRosenwasserhttps://github.com/DanielRosenwasser
Aug 8, 2016 https://github.com/microsoft/TypeScript/pull/10194#discussion-diff-73833932
View reviewed changes https://github.com/microsoft/TypeScript/pull/10194/files/67b3fe58fa9b0761da93d9ea6ab2e8019b6a4b22#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/10194/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Aug 8, 2016https://github.com/microsoft/TypeScript/pull/10194#discussion_r73833932
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/10194
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Aug 8, 2016 https://github.com/microsoft/TypeScript/pull/10194#ref-issue-169396258
Different narrowing behaviour of user-defined type guards vs discriminated unions #10145 https://github.com/microsoft/TypeScript/issues/10145
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
August 8, 2016 09:44https://github.com/microsoft/TypeScript/pull/10194#commits-pushed-a0c5608
https://github.com/ahejlsberg
Update commenthttps://github.com/microsoft/TypeScript/pull/10194/commits/a0c5608770b911d357c745f4842e03b408a135fe
a0c5608https://github.com/microsoft/TypeScript/pull/10194/commits/a0c5608770b911d357c745f4842e03b408a135fe
https://github.com/ahejlsberg
Add more testshttps://github.com/microsoft/TypeScript/pull/10194/commits/ce5a3f466d281695d700fbd08dcb92a685340809
ce5a3f4https://github.com/microsoft/TypeScript/pull/10194/commits/ce5a3f466d281695d700fbd08dcb92a685340809
https://github.com/ahejlsberg
Accept new baselineshttps://github.com/microsoft/TypeScript/pull/10194/commits/ba521de66d8f654784be4f011814a5ca17b413a2
ba521dehttps://github.com/microsoft/TypeScript/pull/10194/commits/ba521de66d8f654784be4f011814a5ca17b413a2
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Aug 8, 2016https://github.com/microsoft/TypeScript/pull/10194#issuecomment-238338484
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/10194
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
8ea90abhttps://github.com/microsoft/TypeScript/commit/8ea90ab28b0ee3b50d7c771f9eabf9fdda29f549
Aug 8, 2016https://github.com/microsoft/TypeScript/pull/10194#event-748837233
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
August 8, 2016 18:51https://github.com/microsoft/TypeScript/pull/10194#event-748837539
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Aug 9, 2016 https://github.com/microsoft/TypeScript/pull/10194#ref-pullrequest-170058920
Improve instanceof with structurally identical types #10216 https://github.com/microsoft/TypeScript/pull/10216
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Sep 28, 2016 https://github.com/microsoft/TypeScript/pull/10194#ref-issue-179338189
Bug: Control flow type analysis regression. #11153 https://github.com/microsoft/TypeScript/issues/11153
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Jul 28, 2017 https://github.com/microsoft/TypeScript/pull/10194#ref-issue-244722197
instanceof should not exclude possible structural type #17344 https://github.com/microsoft/TypeScript/issues/17344
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 19, 2018https://github.com/microsoft/TypeScript/pull/10194#event-1689845092
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F10194
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/10194
Different narrowing behaviour of user-defined type guards vs discriminated unions https://github.com/microsoft/TypeScript/issues/10145
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/10194
https://github.com/ahejlsberg
https://github.com/DanielRosenwasser
https://github.com/RyanCavanaugh
https://github.com/msftclas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.