| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:575540d7-49e8-090c-7c81-efbec874d641 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E9A6:29FFA9:E69804:124E722:6B0107B5 |
| html-safe-nonce | e60db5b2a8aa96cfe2d1e5decb5af43740af06ea0763ccb3e36f3c11510e323e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOUE2OjI5RkZBOTpFNjk4MDQ6MTI0RTcyMjo2QjAxMDdCNSIsInZpc2l0b3JfaWQiOiI4Njg5NTg5MzkyODE5NDIzMTU3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 2efa718f9f22796eb6560191a9c3d8f57d96733725f613891b3b4271b05ec40d |
| hovercard-subject-tag | pull_request:80371010 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/10194/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/5259bf52a6d50db4785f5cd69b530bb153d75696462f44cdbdaa9caa057920db/microsoft/TypeScript/pull/10194 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5259bf52a6d50db4785f5cd69b530bb153d75696462f44cdbdaa9caa057920db/microsoft/TypeScript/pull/10194 |
| og:image:alt | This PR fixes three issues related to narrowing of types with the instanceof operator and user defined type guards:
In an operation x instanceof T where x is of a non-union type, we now narrow the... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ahejlsberg |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/10194#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F10194 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F10194 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/10194 |
| Reload | https://github.com/microsoft/TypeScript/pull/10194 |
| Reload | https://github.com/microsoft/TypeScript/pull/10194 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests309 (309) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| master | https://github.com/microsoft/TypeScript/tree/master |
| fixInstanceofNarrowing | https://github.com/microsoft/TypeScript/tree/fixInstanceofNarrowing |
| Conversation | https://github.com/microsoft/TypeScript/pull/10194 |
| Commits6 (6) | https://github.com/microsoft/TypeScript/pull/10194/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/10194/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/10194/files |
| Fix instanceof narrowing | https://github.com/microsoft/TypeScript/pull/10194#top |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| master | https://github.com/microsoft/TypeScript/tree/master |
| fixInstanceofNarrowing | https://github.com/microsoft/TypeScript/tree/fixInstanceofNarrowing |
|
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| Aug 7, 2016 | https://github.com/microsoft/TypeScript/pull/10194#issue-169803429 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/10194 |
| #10145 | https://github.com/microsoft/TypeScript/issues/10145 |
| #10167 | https://github.com/microsoft/TypeScript/issues/10167 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/10194 |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| August 7, 2016 07:48 | https://github.com/microsoft/TypeScript/pull/10194#commits-pushed-01f865d |
|
| https://github.com/ahejlsberg |
| Fix instanceof operator narrowing issues | https://github.com/microsoft/TypeScript/pull/10194/commits/01f865dee7f36f00ad79877b09661e6b8de08b21 |
| 01f865d | https://github.com/microsoft/TypeScript/pull/10194/commits/01f865dee7f36f00ad79877b09661e6b8de08b21 |
|
| https://github.com/ahejlsberg |
| Accept new baselines | https://github.com/microsoft/TypeScript/pull/10194/commits/f50226b481900af204ed9f8d0c29e32a56827c54 |
| f50226b | https://github.com/microsoft/TypeScript/pull/10194/commits/f50226b481900af204ed9f8d0c29e32a56827c54 |
|
| https://github.com/ahejlsberg |
| Add regression test | https://github.com/microsoft/TypeScript/pull/10194/commits/67b3fe58fa9b0761da93d9ea6ab2e8019b6a4b22 |
| 67b3fe5 | https://github.com/microsoft/TypeScript/pull/10194/commits/67b3fe58fa9b0761da93d9ea6ab2e8019b6a4b22 |
| https://github.com/msftclas |
| Microsoft Contribution License Agreements (msftclas) | https://github.com/msftclas |
|
cla-not-required
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required |
| Aug 7, 2016 | https://github.com/microsoft/TypeScript/pull/10194#event-747712558 |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Aug 7, 2016 | https://github.com/microsoft/TypeScript/pull/10194#issuecomment-238095469 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/10194 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| Aug 7, 2016 | https://github.com/microsoft/TypeScript/pull/10194#issuecomment-238096962 |
| Daniel Rosenwasser (@DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/10194 |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Aug 8, 2016 | https://github.com/microsoft/TypeScript/pull/10194#issuecomment-238161431 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/10194 |
| DanielRosenwasser | https://github.com/DanielRosenwasser |
|
Aug 8, 2016
| https://github.com/microsoft/TypeScript/pull/10194#discussion-diff-73833932 |
| View reviewed changes
| https://github.com/microsoft/TypeScript/pull/10194/files/67b3fe58fa9b0761da93d9ea6ab2e8019b6a4b22#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/10194/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Aug 8, 2016 | https://github.com/microsoft/TypeScript/pull/10194#discussion_r73833932 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/10194 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
|
Aug 8, 2016
| https://github.com/microsoft/TypeScript/pull/10194#ref-issue-169396258 |
|
Different narrowing behaviour of user-defined type guards vs discriminated unions
#10145
| https://github.com/microsoft/TypeScript/issues/10145 |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| August 8, 2016 09:44 | https://github.com/microsoft/TypeScript/pull/10194#commits-pushed-a0c5608 |
|
| https://github.com/ahejlsberg |
| Update comment | https://github.com/microsoft/TypeScript/pull/10194/commits/a0c5608770b911d357c745f4842e03b408a135fe |
| a0c5608 | https://github.com/microsoft/TypeScript/pull/10194/commits/a0c5608770b911d357c745f4842e03b408a135fe |
|
| https://github.com/ahejlsberg |
| Add more tests | https://github.com/microsoft/TypeScript/pull/10194/commits/ce5a3f466d281695d700fbd08dcb92a685340809 |
| ce5a3f4 | https://github.com/microsoft/TypeScript/pull/10194/commits/ce5a3f466d281695d700fbd08dcb92a685340809 |
|
| https://github.com/ahejlsberg |
| Accept new baselines | https://github.com/microsoft/TypeScript/pull/10194/commits/ba521de66d8f654784be4f011814a5ca17b413a2 |
| ba521de | https://github.com/microsoft/TypeScript/pull/10194/commits/ba521de66d8f654784be4f011814a5ca17b413a2 |
| https://github.com/RyanCavanaugh |
| Ryan Cavanaugh (RyanCavanaugh) | https://github.com/RyanCavanaugh |
| Aug 8, 2016 | https://github.com/microsoft/TypeScript/pull/10194#issuecomment-238338484 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/10194 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| 8ea90ab | https://github.com/microsoft/TypeScript/commit/8ea90ab28b0ee3b50d7c771f9eabf9fdda29f549 |
| Aug 8, 2016 | https://github.com/microsoft/TypeScript/pull/10194#event-748837233 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| August 8, 2016 18:51 | https://github.com/microsoft/TypeScript/pull/10194#event-748837539 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
|
Aug 9, 2016
| https://github.com/microsoft/TypeScript/pull/10194#ref-pullrequest-170058920 |
|
Improve instanceof with structurally identical types
#10216
| https://github.com/microsoft/TypeScript/pull/10216 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
|
Sep 28, 2016
| https://github.com/microsoft/TypeScript/pull/10194#ref-issue-179338189 |
|
Bug: Control flow type analysis regression.
#11153
| https://github.com/microsoft/TypeScript/issues/11153 |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
|
Jul 28, 2017
| https://github.com/microsoft/TypeScript/pull/10194#ref-issue-244722197 |
|
instanceof should not exclude possible structural type
#17344
| https://github.com/microsoft/TypeScript/issues/17344 |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Jun 19, 2018 | https://github.com/microsoft/TypeScript/pull/10194#event-1689845092 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F10194 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/10194 |
|
Different narrowing behaviour of user-defined type guards vs discriminated unions
| https://github.com/microsoft/TypeScript/issues/10145 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/10194 |
|
| https://github.com/ahejlsberg |
|
| https://github.com/DanielRosenwasser |
|
| https://github.com/RyanCavanaugh |
|
| https://github.com/msftclas |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |