René's URL Explorer Experiment


Title: Legitimate type assertion causes compiler error · Issue #7598 · microsoft/TypeScript · GitHub

Open Graph Title: Legitimate type assertion causes compiler error · Issue #7598 · microsoft/TypeScript

X Title: Legitimate type assertion causes compiler error · Issue #7598 · microsoft/TypeScript

Description: Typscript version Nuget package manager in Visual Studio reports it as v2.0.0 "tsc --v" reports it as v1.0.0.0 Code class Animal { public speak() { if (this instanceof Dog) { var dog: Dog = this; dog.woof(); } } } class Dog extends ...

Open Graph Description: Typscript version Nuget package manager in Visual Studio reports it as v2.0.0 "tsc --v" reports it as v1.0.0.0 Code class Animal { public speak() { if (this instanceof Dog) { var dog: Dog = th...

X Description: Typscript version Nuget package manager in Visual Studio reports it as v2.0.0 "tsc --v" reports it as v1.0.0.0 Code class Animal { public speak() { if (this instanceof Dog) { var dog: Dog...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/7598

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Legitimate type assertion causes compiler error","articleBody":"**Typscript version**\n  Nuget package manager in Visual Studio reports it as v2.0.0\n  \"tsc --v\" reports it as v1.0.0.0\n\n**Code**\n\n```\nclass Animal {\n\n    public speak() {\n        if (this instanceof Dog) {\n            var dog: Dog = \u003cDog>this;\n            dog.woof();\n        }\n    }\n}\n\nclass Dog extends Animal {\n    public woof() {}\n}\n```\n\n**Expected behavior:**\n\nShould compile without issue.  I expect to be able to assert that \"this\" is of type Dog, because it can be.  I also note that \"woof\" is referred to as a property in the error message, when perhaps it should be referred to as a method.\n\nObviously in this case, it would make sense to override Animal.speak() in Dog rather than check the type in Animal.speak(), but sometimes it makes sense to check the type of \"this\" explicitly, perhaps because you want to perform some action in the middle of a method in the base class, between various other actions, and overriding doesn't make that possible.\n\nIn any case, good practice or bad practice, it's valid code and should compile.\n\n**Actual behavior:** \n\nError   TS2352  Neither type 'this' nor type 'Dog' is assignable to the other.\n  Type 'Animal' is not assignable to type 'Dog'.\n    Property 'woof' is missing in type 'Animal'.\n","author":{"url":"https://github.com/philthy256","@type":"Person","name":"philthy256"},"datePublished":"2016-03-20T09:39:06Z","url":"https://github.com/microsoft/TypeScript/issues/7598"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:aa8b55be-4c96-26dc-7e3a-3ad60b0ce9c9
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idDFD6:187C1E:CE0445:110B474:6B01C9B8
html-safe-nonce90d8e2cd06e04e83eecd7bd13e8c4c23fac1071cab55a970139ff03eac9429a6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERkQ2OjE4N0MxRTpDRTA0NDU6MTEwQjQ3NDo2QjAxQzlCOCIsInZpc2l0b3JfaWQiOiI1Njk4NTkzMTM0NDYwNjUxOTYwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2eb999940c1f7981a402dfc004475a53e9ae717bad4169aee49da4c4ae8ed3fc
hovercard-subject-tagissue:142145548
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/7598/issue_layout
twitter:imagehttps://opengraph.githubassets.com/71b81b5817692b27dda01ec423e832266f8135d4da19567deebc6a8c03177712/microsoft/TypeScript/issues/7598
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/71b81b5817692b27dda01ec423e832266f8135d4da19567deebc6a8c03177712/microsoft/TypeScript/issues/7598
og:image:altTypscript version Nuget package manager in Visual Studio reports it as v2.0.0 "tsc --v" reports it as v1.0.0.0 Code class Animal { public speak() { if (this instanceof Dog) { var dog: Dog = th...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamephilthy256
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/7598#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F7598
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F7598
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/7598
Reloadhttps://github.com/microsoft/TypeScript/issues/7598
Reloadhttps://github.com/microsoft/TypeScript/issues/7598
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/7598
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/7598
Legitimate type assertion causes compiler errorhttps://github.com/microsoft/TypeScript/issues/7598#top
https://github.com/ahejlsberg
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
TypeScript 2.0https://github.com/microsoft/TypeScript/milestone/1
https://github.com/philthy256
philthy256https://github.com/philthy256
on Mar 20, 2016https://github.com/microsoft/TypeScript/issues/7598#issue-142145548
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
on Mar 20, 2016https://github.com/microsoft/TypeScript/issues/7598#issuecomment-198985108
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
#7422https://github.com/microsoft/TypeScript/pull/7422
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
on Mar 20, 2016https://github.com/microsoft/TypeScript/issues/7598#issuecomment-198985468
philthy256https://github.com/philthy256
Paul van Brenk (@paulvanbrenk)https://github.com/paulvanbrenk
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
on Mar 21, 2016https://github.com/microsoft/TypeScript/issues/7598#issuecomment-199372363
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
on Mar 21, 2016https://github.com/microsoft/TypeScript/issues/7598#issuecomment-199372798
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
on Mar 21, 2016https://github.com/microsoft/TypeScript/issues/7598#event-597432540
https://github.com/paulvanbrenk
Paul van Brenk (paulvanbrenk)https://github.com/paulvanbrenk
on Mar 21, 2016https://github.com/microsoft/TypeScript/issues/7598#issuecomment-199419758
philthy256https://github.com/philthy256
https://github.com/philthy256
philthy256https://github.com/philthy256
on Mar 21, 2016https://github.com/microsoft/TypeScript/issues/7598#issuecomment-199462500
Paul van Brenk (@paulvanbrenk)https://github.com/paulvanbrenk
https://cloud.githubusercontent.com/assets/17960787/13932838/0d3b8680-efa2-11e5-8b22-1b1f044caec6.jpg
https://github.com/philthy256
philthy256https://github.com/philthy256
on Mar 21, 2016https://github.com/microsoft/TypeScript/issues/7598#issuecomment-199465475
Daniel Rosenwasser (@DanielRosenwasser)https://github.com/DanielRosenwasser
https://github.com/paulvanbrenk
Paul van Brenk (paulvanbrenk)https://github.com/paulvanbrenk
on Mar 21, 2016https://github.com/microsoft/TypeScript/issues/7598#issuecomment-199490377
philthy256https://github.com/philthy256
Microsoft.TypeScript.Compilerhttps://www.nuget.org/packages/Microsoft.TypeScript.Compiler/
MSBuildhttps://www.nuget.org/packages/Microsoft.TypeScript.MSBuild/
https://github.com/philthy256
philthy256https://github.com/philthy256
on Mar 21, 2016https://github.com/microsoft/TypeScript/issues/7598#issuecomment-199510142
Paul van Brenk (@paulvanbrenk)https://github.com/paulvanbrenk
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
on Mar 23, 2016https://github.com/microsoft/TypeScript/issues/7598#event-600870333
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
TypeScript 2.0https://github.com/microsoft/TypeScript/milestone/1
on Mar 23, 2016https://github.com/microsoft/TypeScript/issues/7598#event-600870366
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
on Mar 23, 2016https://github.com/microsoft/TypeScript/issues/7598#event-600870436
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
on Mar 23, 2016https://github.com/microsoft/TypeScript/issues/7598#issuecomment-200528625
#7140https://github.com/microsoft/TypeScript/pull/7140
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Mar 23, 2016https://github.com/microsoft/TypeScript/issues/7598#event-600871311
https://github.com/philthy256
philthy256https://github.com/philthy256
on Mar 24, 2016https://github.com/microsoft/TypeScript/issues/7598#issuecomment-200748832
microsofthttps://github.com/microsoft
on Jun 19, 2018https://github.com/microsoft/TypeScript/issues/7598#event-1689644000
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/7598
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/7598
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
TypeScript 2.0https://github.com/microsoft/TypeScript/milestone/1
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.