Title: Symbols missing from nodes when SourceFile requested via LanguageService, but not via Program · Issue #7581 · microsoft/TypeScript · GitHub
Open Graph Title: Symbols missing from nodes when SourceFile requested via LanguageService, but not via Program · Issue #7581 · microsoft/TypeScript
X Title: Symbols missing from nodes when SourceFile requested via LanguageService, but not via Program · Issue #7581 · microsoft/TypeScript
Description: I got tripped up when using the compiler API, and I wanted to see if it was just me being confused or an actual bug. :) It seems like SourceFiles that are returned from LanguageService.getSourceFile() don't include symbols, whereas those...
Open Graph Description: I got tripped up when using the compiler API, and I wanted to see if it was just me being confused or an actual bug. :) It seems like SourceFiles that are returned from LanguageService.getSourceFil...
X Description: I got tripped up when using the compiler API, and I wanted to see if it was just me being confused or an actual bug. :) It seems like SourceFiles that are returned from LanguageService.getSourceFil...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/7581
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Symbols missing from nodes when SourceFile requested via LanguageService, but not via Program","articleBody":"I got tripped up when using the compiler API, and I wanted to see if it was just me being confused or an actual bug. :) It seems like `SourceFile`s that are returned from `LanguageService.getSourceFile()` don't include symbols, whereas those loaded via `Program.getSourceFile()` do.\n\nIf I request a file via:\n\n``` ts\nlanguageService.getSourceFile(\"example.ts\");\n```\n\n...it will be returned without symbols, so if I try calling any of `TypeChecker`'s methods on it, it will either throw errors or returned `undefined`. If instead I request files via:\n\n``` ts\nlanguageService.getProgram().getSourceFile(\"example.ts\");\n```\n\n..the returned file has the symbols and works fine with `TypeChecker`.\n\nI understand that mixing these two APIs is probably not a normal use case. I'm working on a tool that alters the source of a program as it's being compiled, so having access to `LanguageService` is really helpful, but I also need the `TypeChecker`.\n\n(Also, if this is just a problem with my implementation of `LanguageServiceHost`, please let me know!)\n\n**TypeScript Version:** Behavior appears on 1.8.7, 1.8.9, and 1.9.0-dev.20160318\n## Test Case\n\n**test.ts**\n\n``` ts\nimport * as ts from 'typescript';\nimport * as fs from 'fs';\n\ninterface ScriptInfo {\n text: string\n version: number\n}\n\nexport class LanguageServiceHost implements ts.LanguageServiceHost {\n\n files: { [name: string]: ScriptInfo } = {};\n\n constructor(protected rootFileNames: string[], protected options: ts.CompilerOptions) {\n for (const fileName of rootFileNames) {\n this.getScriptInfo(fileName);\n }\n }\n\n getCompilationSettings() {\n return this.options;\n }\n\n getScriptFileNames() {\n return this.rootFileNames;\n }\n\n getScriptVersion(fileName: string) {\n let info = this.getScriptInfo(fileName);\n return info.version.toString();\n }\n\n getScriptSnapshot(fileName: string) {\n let info = this.getScriptInfo(fileName);\n return ts.ScriptSnapshot.fromString(info.text);\n }\n\n getCurrentDirectory() {\n return process.cwd();\n }\n\n getDefaultLibFileName(options: ts.CompilerOptions) {\n return ts.getDefaultLibFilePath(options);\n }\n\n getScriptInfo(fileName: string): ScriptInfo {\n let info = this.files[fileName];\n if (!info) {\n this.files[fileName] = info = {\n text: fs.readFileSync(fileName).toString(),\n version: 1\n };\n }\n return info;\n }\n\n}\n\nconst languageServiceHost = new LanguageServiceHost(['case.ts'], {\n target: ts.ScriptTarget.ES5,\n module: ts.ModuleKind.CommonJS\n});\n\nconst languageService = ts.createLanguageService(languageServiceHost, ts.createDocumentRegistry());\nconst program = languageService.getProgram();\nconst checker = program.getTypeChecker();\n\nfunction listClassMethods(file: ts.SourceFile) {\n let visit = (node: ts.Node) => {\n if (node.kind == ts.SyntaxKind.ClassDeclaration) {\n const decl = \u003cts.ClassDeclaration> node;\n for (const member of decl.members) {\n if (member.kind == ts.SyntaxKind.MethodDeclaration) {\n const method = \u003cts.MethodDeclaration> member;\n const symbol = checker.getSymbolAtLocation(method.name);\n if (symbol) {\n console.log(symbol.getName());\n }\n else {\n console.log(\"Couldn't resolve symbol\")\n }\n }\n }\n }\n ts.forEachChild(node, visit);\n }\n ts.forEachChild(file, visit);\n}\n\nlistClassMethods(languageService.getSourceFile('case.ts'));\nlistClassMethods(program.getSourceFile('case.ts'));\n```\n\n**case.ts**\n\n``` ts\ninterface IExample {\n getName: () => string\n}\n\nclass A implements IExample {\n getName() {\n return 'A';\n }\n}\n\nclass B implements IExample {\n getName() {\n return 'B';\n }\n}\n```\n\n**Expected behavior:**\n\n```\n$ node test.js\ngetName\ngetName\ngetName\ngetName\n```\n\n**Actual behavior:** \n\n```\n$ node test.js\nCouldn't resolve symbol\nCouldn't resolve symbol\ngetName\ngetName\n```\n\nThanks for your help, and for the great work on TypeScript and the compiler API!\n","author":{"url":"https://github.com/nkohari","@type":"Person","name":"nkohari"},"datePublished":"2016-03-18T16:50:06Z","url":"https://github.com/microsoft/TypeScript/issues/7581"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:5f1c6af2-a762-2a41-4d07-3ca0d6a4ff23 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B9E0:317608:40A203:538072:6B00D468 |
| html-safe-nonce | 2ff69e6573d701c174c391e4e4f7dd33e280c88c7a9225bb68cebb174cbaa87f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOUUwOjMxNzYwODo0MEEyMDM6NTM4MDcyOjZCMDBENDY4IiwidmlzaXRvcl9pZCI6IjcwODgyMDE1MjA3MjE3NDUwMDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 27882012cc8f24e8ced3a77f70f88111c66e94fab7c0d01f8e26ae63fb3993d7 |
| hovercard-subject-tag | issue:141921376 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/7581/issue_layout |
| twitter:image | https://opengraph.githubassets.com/dedd78116cbef08ac80f9c916f39a431b0145d2ffb6bfc52342ca2d904a94b57/microsoft/TypeScript/issues/7581 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/dedd78116cbef08ac80f9c916f39a431b0145d2ffb6bfc52342ca2d904a94b57/microsoft/TypeScript/issues/7581 |
| og:image:alt | I got tripped up when using the compiler API, and I wanted to see if it was just me being confused or an actual bug. :) It seems like SourceFiles that are returned from LanguageService.getSourceFil... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | nkohari |
| hostname | github.com |
| expected-hostname | github.com |
| None | a481f62a1e04c9b9bdcb5628230682c66d59006f5b13b080f79cba84a176905b |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 84c8c5cc25e2fb7f2308428458538436baecc6d2 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width