René's URL Explorer Experiment


Title: Symbols missing from nodes when SourceFile requested via LanguageService, but not via Program · Issue #7581 · microsoft/TypeScript · GitHub

Open Graph Title: Symbols missing from nodes when SourceFile requested via LanguageService, but not via Program · Issue #7581 · microsoft/TypeScript

X Title: Symbols missing from nodes when SourceFile requested via LanguageService, but not via Program · Issue #7581 · microsoft/TypeScript

Description: I got tripped up when using the compiler API, and I wanted to see if it was just me being confused or an actual bug. :) It seems like SourceFiles that are returned from LanguageService.getSourceFile() don't include symbols, whereas those...

Open Graph Description: I got tripped up when using the compiler API, and I wanted to see if it was just me being confused or an actual bug. :) It seems like SourceFiles that are returned from LanguageService.getSourceFil...

X Description: I got tripped up when using the compiler API, and I wanted to see if it was just me being confused or an actual bug. :) It seems like SourceFiles that are returned from LanguageService.getSourceFil...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/7581

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Symbols missing from nodes when SourceFile requested via LanguageService, but not via Program","articleBody":"I got tripped up when using the compiler API, and I wanted to see if it was just me being confused or an actual bug. :) It seems like `SourceFile`s that are returned from `LanguageService.getSourceFile()` don't include symbols, whereas those loaded via `Program.getSourceFile()` do.\n\nIf I request a file via:\n\n``` ts\nlanguageService.getSourceFile(\"example.ts\");\n```\n\n...it will be returned without symbols, so if I try calling any of `TypeChecker`'s methods on it, it will either throw errors or returned `undefined`. If instead I request files via:\n\n``` ts\nlanguageService.getProgram().getSourceFile(\"example.ts\");\n```\n\n..the returned file has the symbols and works fine with `TypeChecker`.\n\nI understand that mixing these two APIs is probably not a normal use case. I'm working on a tool that alters the source of a program as it's being compiled, so having access to `LanguageService` is really helpful, but I also need the `TypeChecker`.\n\n(Also, if this is just a problem with my implementation of `LanguageServiceHost`, please let me know!)\n\n**TypeScript Version:**  Behavior appears on 1.8.7, 1.8.9, and 1.9.0-dev.20160318\n## Test Case\n\n**test.ts**\n\n``` ts\nimport * as ts from 'typescript';\nimport * as fs from 'fs';\n\ninterface ScriptInfo {\n  text: string\n  version: number\n}\n\nexport class LanguageServiceHost implements ts.LanguageServiceHost {\n\n  files: { [name: string]: ScriptInfo } = {};\n\n  constructor(protected rootFileNames: string[], protected options: ts.CompilerOptions) {\n    for (const fileName of rootFileNames) {\n      this.getScriptInfo(fileName);\n    }\n  }\n\n  getCompilationSettings() {\n    return this.options;\n  }\n\n  getScriptFileNames() {\n    return this.rootFileNames;\n  }\n\n  getScriptVersion(fileName: string) {\n    let info = this.getScriptInfo(fileName);\n    return info.version.toString();\n  }\n\n  getScriptSnapshot(fileName: string) {\n    let info = this.getScriptInfo(fileName);\n    return ts.ScriptSnapshot.fromString(info.text);\n  }\n\n  getCurrentDirectory() {\n    return process.cwd();\n  }\n\n  getDefaultLibFileName(options: ts.CompilerOptions) {\n    return ts.getDefaultLibFilePath(options);\n  }\n\n  getScriptInfo(fileName: string): ScriptInfo {\n    let info = this.files[fileName];\n    if (!info) {\n      this.files[fileName] = info = {\n        text: fs.readFileSync(fileName).toString(),\n        version: 1\n      };\n    }\n    return info;\n  }\n\n}\n\nconst languageServiceHost = new LanguageServiceHost(['case.ts'], {\n  target: ts.ScriptTarget.ES5,\n  module: ts.ModuleKind.CommonJS\n});\n\nconst languageService = ts.createLanguageService(languageServiceHost, ts.createDocumentRegistry());\nconst program = languageService.getProgram();\nconst checker = program.getTypeChecker();\n\nfunction listClassMethods(file: ts.SourceFile) {\n  let visit = (node: ts.Node) => {\n    if (node.kind == ts.SyntaxKind.ClassDeclaration) {\n      const decl = \u003cts.ClassDeclaration> node;\n      for (const member of decl.members) {\n        if (member.kind == ts.SyntaxKind.MethodDeclaration) {\n          const method = \u003cts.MethodDeclaration> member;\n          const symbol = checker.getSymbolAtLocation(method.name);\n          if (symbol) {\n            console.log(symbol.getName());\n          }\n          else {\n            console.log(\"Couldn't resolve symbol\")\n          }\n        }\n      }\n    }\n    ts.forEachChild(node, visit);\n  }\n  ts.forEachChild(file, visit);\n}\n\nlistClassMethods(languageService.getSourceFile('case.ts'));\nlistClassMethods(program.getSourceFile('case.ts'));\n```\n\n**case.ts**\n\n``` ts\ninterface IExample {\n  getName: () => string\n}\n\nclass A implements IExample {\n  getName() {\n    return 'A';\n  }\n}\n\nclass B implements IExample {\n  getName() {\n    return 'B';\n  }\n}\n```\n\n**Expected behavior:**\n\n```\n$ node test.js\ngetName\ngetName\ngetName\ngetName\n```\n\n**Actual behavior:** \n\n```\n$ node test.js\nCouldn't resolve symbol\nCouldn't resolve symbol\ngetName\ngetName\n```\n\nThanks for your help, and for the great work on TypeScript and the compiler API!\n","author":{"url":"https://github.com/nkohari","@type":"Person","name":"nkohari"},"datePublished":"2016-03-18T16:50:06Z","url":"https://github.com/microsoft/TypeScript/issues/7581"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:5f1c6af2-a762-2a41-4d07-3ca0d6a4ff23
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB9E0:317608:40A203:538072:6B00D468
html-safe-nonce2ff69e6573d701c174c391e4e4f7dd33e280c88c7a9225bb68cebb174cbaa87f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOUUwOjMxNzYwODo0MEEyMDM6NTM4MDcyOjZCMDBENDY4IiwidmlzaXRvcl9pZCI6IjcwODgyMDE1MjA3MjE3NDUwMDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac27882012cc8f24e8ced3a77f70f88111c66e94fab7c0d01f8e26ae63fb3993d7
hovercard-subject-tagissue:141921376
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/7581/issue_layout
twitter:imagehttps://opengraph.githubassets.com/dedd78116cbef08ac80f9c916f39a431b0145d2ffb6bfc52342ca2d904a94b57/microsoft/TypeScript/issues/7581
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/dedd78116cbef08ac80f9c916f39a431b0145d2ffb6bfc52342ca2d904a94b57/microsoft/TypeScript/issues/7581
og:image:altI got tripped up when using the compiler API, and I wanted to see if it was just me being confused or an actual bug. :) It seems like SourceFiles that are returned from LanguageService.getSourceFil...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamenkohari
hostnamegithub.com
expected-hostnamegithub.com
Nonea481f62a1e04c9b9bdcb5628230682c66d59006f5b13b080f79cba84a176905b
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release84c8c5cc25e2fb7f2308428458538436baecc6d2
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/7581#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F7581
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F7581
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/7581
Reloadhttps://github.com/microsoft/TypeScript/issues/7581
Reloadhttps://github.com/microsoft/TypeScript/issues/7581
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests307 (307)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/7581
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/7581
#7584https://github.com/microsoft/TypeScript/pull/7584
Symbols missing from nodes when SourceFile requested via LanguageService, but not via Programhttps://github.com/microsoft/TypeScript/issues/7581#top
#7584https://github.com/microsoft/TypeScript/pull/7584
Breaking ChangeWould introduce errors in existing codehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Breaking%20Change%22
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
Domain: APIRelates to the public API for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20API%22
TypeScript 2.0https://github.com/microsoft/TypeScript/milestone/1
https://github.com/nkohari
Nate Kohari (nkohari)https://github.com/nkohari
on Mar 18, 2016https://github.com/microsoft/TypeScript/issues/7581#issue-141921376
https://github.com/vladima
Vladimir Matveev (vladima)https://github.com/vladima
on Mar 18, 2016https://github.com/microsoft/TypeScript/issues/7581#issuecomment-198460962
Vladimir Matveev (vladima)https://github.com/vladima
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
Domain: APIRelates to the public API for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20API%22
Breaking ChangeWould introduce errors in existing codehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Breaking%20Change%22
on Mar 18, 2016https://github.com/microsoft/TypeScript/issues/7581#event-595211643
Vladimir Matveev (vladima)https://github.com/vladima
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#7584https://github.com/microsoft/TypeScript/pull/7584
on Mar 24, 2016https://github.com/microsoft/TypeScript/issues/7581#event-602343264
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
TypeScript 2.0https://github.com/microsoft/TypeScript/milestone/1
on Mar 24, 2016https://github.com/microsoft/TypeScript/issues/7581#event-602360225
microsofthttps://github.com/microsoft
on Jun 19, 2018https://github.com/microsoft/TypeScript/issues/7581#event-1689643812
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/7581
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/7581
Breaking ChangeWould introduce errors in existing codehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Breaking%20Change%22
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
Domain: APIRelates to the public API for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20API%22
TypeScript 2.0https://github.com/microsoft/TypeScript/milestone/1
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.