Title: Merged external modules break protected member access checking · Issue #6731 · microsoft/TypeScript · GitHub
Open Graph Title: Merged external modules break protected member access checking · Issue #6731 · microsoft/TypeScript
X Title: Merged external modules break protected member access checking · Issue #6731 · microsoft/TypeScript
Description: Having some difficulty utilizing the external module augmentations feature merged in #6213. Here is a test case to demonstrate the problem: // a.ts export class A { protected protected: any; public setProtected(val: any) { this.protected...
Open Graph Description: Having some difficulty utilizing the external module augmentations feature merged in #6213. Here is a test case to demonstrate the problem: // a.ts export class A { protected protected: any; public...
X Description: Having some difficulty utilizing the external module augmentations feature merged in #6213. Here is a test case to demonstrate the problem: // a.ts export class A { protected protected: any; public...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/6731
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Merged external modules break protected member access checking","articleBody":"Having some difficulty utilizing the external module augmentations feature merged in #6213. Here is a test case to demonstrate the problem:\n\n```\n// a.ts\nexport class A {\n protected protected: any;\n\n public setProtected(val: any) {\n this.protected = val;\n }\n}\n```\n\n```\n// b.ts\nimport {A} from './a'; // Only here to make b.ts an external module\n\ndeclare module \"./a\" {\n interface A { }\n}\n```\n\nThis results in the following error:\n\n> a.ts(5,9): error TS2446: Property 'protected' is protected and only accessible through an instance of class 'A'.\n\nIt looks like the problem is that [`checkClassPropertyAccess`](https://github.com/Microsoft/TypeScript/blob/1ae7d5ca092d883213f0a5f10c609fda7fa5cccc/src/compiler/checker.ts#L8777) in checker.ts ends up obtaining the merged interface as the enclosing class of the property access, rather than the actual enclosing class, then tries to ensure that this interface is derived from the class which declares the property, which isn't the case.\n","author":{"url":"https://github.com/masaeedu","@type":"Person","name":"masaeedu"},"datePublished":"2016-01-29T19:14:51Z","url":"https://github.com/microsoft/TypeScript/issues/6731"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:09374d90-e4c2-b094-0e56-ec1a9962a760 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A998:296654:D6FB79:12090ED:6B0101E8 |
| html-safe-nonce | 2f5464a316b58936dc4e2bf686e815e5ed207cb616508710f39aafd7ad844bc0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTk4OjI5NjY1NDpENkZCNzk6MTIwOTBFRDo2QjAxMDFFOCIsInZpc2l0b3JfaWQiOiIxODA1ODE3ODg5MDAxODk4NDcyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 8e6a5b6bb73c14cbd6da6a223bd89585baaa5a10b2849e9e712079067381fbc1 |
| hovercard-subject-tag | issue:129856121 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/6731/issue_layout |
| twitter:image | https://opengraph.githubassets.com/fcbc7a9c71c3b0e13fec71d99403fcaa18b7a911199c4498ec019c384b9bf55b/microsoft/TypeScript/issues/6731 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/fcbc7a9c71c3b0e13fec71d99403fcaa18b7a911199c4498ec019c384b9bf55b/microsoft/TypeScript/issues/6731 |
| og:image:alt | Having some difficulty utilizing the external module augmentations feature merged in #6213. Here is a test case to demonstrate the problem: // a.ts export class A { protected protected: any; public... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | masaeedu |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width