René's URL Explorer Experiment


Title: Merged external modules break protected member access checking · Issue #6731 · microsoft/TypeScript · GitHub

Open Graph Title: Merged external modules break protected member access checking · Issue #6731 · microsoft/TypeScript

X Title: Merged external modules break protected member access checking · Issue #6731 · microsoft/TypeScript

Description: Having some difficulty utilizing the external module augmentations feature merged in #6213. Here is a test case to demonstrate the problem: // a.ts export class A { protected protected: any; public setProtected(val: any) { this.protected...

Open Graph Description: Having some difficulty utilizing the external module augmentations feature merged in #6213. Here is a test case to demonstrate the problem: // a.ts export class A { protected protected: any; public...

X Description: Having some difficulty utilizing the external module augmentations feature merged in #6213. Here is a test case to demonstrate the problem: // a.ts export class A { protected protected: any; public...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/6731

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Merged external modules break protected member access checking","articleBody":"Having some difficulty utilizing the external module augmentations feature merged in #6213. Here is a test case to demonstrate the problem:\n\n```\n// a.ts\nexport class A {\n    protected protected: any;\n\n    public setProtected(val: any) {\n        this.protected = val;\n    }\n}\n```\n\n```\n// b.ts\nimport {A} from './a'; // Only here to make b.ts an external module\n\ndeclare module \"./a\" {\n    interface A { }\n}\n```\n\nThis results in the following error:\n\n> a.ts(5,9): error TS2446: Property 'protected' is protected and only accessible through an instance of class 'A'.\n\nIt looks like the problem is that [`checkClassPropertyAccess`](https://github.com/Microsoft/TypeScript/blob/1ae7d5ca092d883213f0a5f10c609fda7fa5cccc/src/compiler/checker.ts#L8777) in checker.ts ends up obtaining the merged interface as the enclosing class of the property access, rather than the actual enclosing class, then tries to ensure that this interface is derived from the class which declares the property, which isn't the case.\n","author":{"url":"https://github.com/masaeedu","@type":"Person","name":"masaeedu"},"datePublished":"2016-01-29T19:14:51Z","url":"https://github.com/microsoft/TypeScript/issues/6731"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:09374d90-e4c2-b094-0e56-ec1a9962a760
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA998:296654:D6FB79:12090ED:6B0101E8
html-safe-nonce2f5464a316b58936dc4e2bf686e815e5ed207cb616508710f39aafd7ad844bc0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTk4OjI5NjY1NDpENkZCNzk6MTIwOTBFRDo2QjAxMDFFOCIsInZpc2l0b3JfaWQiOiIxODA1ODE3ODg5MDAxODk4NDcyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac8e6a5b6bb73c14cbd6da6a223bd89585baaa5a10b2849e9e712079067381fbc1
hovercard-subject-tagissue:129856121
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/6731/issue_layout
twitter:imagehttps://opengraph.githubassets.com/fcbc7a9c71c3b0e13fec71d99403fcaa18b7a911199c4498ec019c384b9bf55b/microsoft/TypeScript/issues/6731
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fcbc7a9c71c3b0e13fec71d99403fcaa18b7a911199c4498ec019c384b9bf55b/microsoft/TypeScript/issues/6731
og:image:altHaving some difficulty utilizing the external module augmentations feature merged in #6213. Here is a test case to demonstrate the problem: // a.ts export class A { protected protected: any; public...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemasaeedu
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/6731#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F6731
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F6731
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/6731
Reloadhttps://github.com/microsoft/TypeScript/issues/6731
Reloadhttps://github.com/microsoft/TypeScript/issues/6731
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/6731
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/6731
#6736https://github.com/microsoft/TypeScript/pull/6736
Merged external modules break protected member access checkinghttps://github.com/microsoft/TypeScript/issues/6731#top
#6736https://github.com/microsoft/TypeScript/pull/6736
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
TypeScript 1.8.2https://github.com/microsoft/TypeScript/milestone/19
https://github.com/masaeedu
Asad Saeeduddin (masaeedu)https://github.com/masaeedu
on Jan 29, 2016https://github.com/microsoft/TypeScript/issues/6731#issue-129856121
#6213https://github.com/microsoft/TypeScript/pull/6213
checkClassPropertyAccesshttps://github.com/Microsoft/TypeScript/blob/1ae7d5ca092d883213f0a5f10c609fda7fa5cccc/src/compiler/checker.ts#L8777
Vladimir Matveev (vladima)https://github.com/vladima
on Jan 29, 2016https://github.com/microsoft/TypeScript/issues/6731#event-531884893
Vladimir Matveev (vladima)https://github.com/vladima
TypeScript 1.8.2https://github.com/microsoft/TypeScript/milestone/19
on Jan 29, 2016https://github.com/microsoft/TypeScript/issues/6731#event-531885116
Vladimir Matveev (vladima)https://github.com/vladima
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
on Jan 29, 2016https://github.com/microsoft/TypeScript/issues/6731#event-531885251
https://github.com/vladima
Vladimir Matveev (vladima)https://github.com/vladima
on Jan 29, 2016https://github.com/microsoft/TypeScript/issues/6731#issuecomment-176970090
Vladimir Matveev (vladima)https://github.com/vladima
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#6736https://github.com/microsoft/TypeScript/pull/6736
on Jan 29, 2016https://github.com/microsoft/TypeScript/issues/6731#event-531990950
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
on Jan 29, 2016https://github.com/microsoft/TypeScript/issues/6731#event-532054088
https://github.com/masaeedu
Asad Saeeduddin (masaeedu)https://github.com/masaeedu
on Jan 31, 2016https://github.com/microsoft/TypeScript/issues/6731#issuecomment-177354641
Vladimir Matveev (@vladima)https://github.com/vladima
https://github.com/vladima
Vladimir Matveev (vladima)https://github.com/vladima
on Jan 31, 2016https://github.com/microsoft/TypeScript/issues/6731#issuecomment-177357643
https://github.com/vladima
Vladimir Matveev (vladima)https://github.com/vladima
on Jan 31, 2016https://github.com/microsoft/TypeScript/issues/6731#issuecomment-177358536
#6762https://github.com/microsoft/TypeScript/issues/6762
microsofthttps://github.com/microsoft
on Jun 19, 2018https://github.com/microsoft/TypeScript/issues/6731#event-1689635659
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Vladimir Matveev (vladima)https://github.com/vladima
on Jun 19, 2018https://github.com/microsoft/TypeScript/issues/6731#event-1689635662
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/6731
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/6731
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
TypeScript 1.8.2https://github.com/microsoft/TypeScript/milestone/19
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.