Title: Fix: small edits reshuffle the `--checkers` partition · Issue #65559 · microsoft/TypeScript · GitHub
Open Graph Title: Fix: small edits reshuffle the `--checkers` partition · Issue #65559 · microsoft/TypeScript
X Title: Fix: small edits reshuffle the `--checkers` partition · Issue #65559 · microsoft/TypeScript
Description: Comment On 7.1.0-beta, changing a few nodes in one file can move hundreds of other files to a different checker. Total work stays the same, but the slowest checker changes, so Check time swings by a few percent for edits that have nothin...
Open Graph Description: Comment On 7.1.0-beta, changing a few nodes in one file can move hundreds of other files to a different checker. Total work stays the same, but the slowest checker changes, so Check time swings by ...
X Description: Comment On 7.1.0-beta, changing a few nodes in one file can move hundreds of other files to a different checker. Total work stays the same, but the slowest checker changes, so Check time swings by ...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/65559
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Fix: small edits reshuffle the `--checkers` partition","articleBody":"### Comment\n\nOn 7.1.0-beta, changing a few nodes in one file can move hundreds of other files to a different checker. Total work stays the same, but the slowest checker changes, so `Check time` swings by a few percent for edits that have nothing to do with types.\n\n7.0.2 assigned files round-robin and doesn't do this.\n\n### Cause\n\n`checkerpool.go` sorts files by their exact weight (`nodeCount + textLength/100 + imports`) before the greedy assignment. A one-node change can move a file in that order, and every assignment after it can then change.\n\n### Repro\n\nA generated project with 2,387 files and `--checkers 4`. Checker IDs come from `--generateTrace`.\n\n| Change | Files that switched checker |\n|---|---|\n| none (same input twice) | 0 |\n| add one `\u003cspan>` to one file | 419 |\n| a 2-line codegen change in 11 files | 395 |\n\nIn a real 2,338-file app, the 2-line change raised `Check time` from 2.73s to 2.83s. CPU and `--checkers 1` stayed the same.\n\n### Possible fix\n\nRound the weights before sorting, e.g. to buckets that grow by 1.125×. With that patch, both edits above move 0 files, and the max Types per checker stays within ±0.13% of the current result. Patch: (attach `quantized-weights.patch`)\n\nRemoving the sort alone doesn't help: the single-`\u003cspan>` edit still moved 471 files, and the balance got worse.\n\n\n```diff\n+++ internal/compiler/checkerpool.go\t2026-11-18 16:43:15\n@@ -297,7 +297,7 @@\n \t}\n \tfileWeights := make([]int, len(baseWeights))\n \tfor i, baseWeight := range baseWeights {\n-\t\tfileWeights[i] = baseWeight + importCounts[i]*importWeight\n+\t\tfileWeights[i] = quantizeCheckerAssociationWeight(baseWeight + importCounts[i]*importWeight)\n \t}\n \treturn fileWeights\n }\n@@ -515,3 +515,13 @@\n }\n \n func noop() {}\n+\n+// quantizeCheckerAssociationWeight snaps a weight to a geometric bucket (ratio\n+// 1.125) so that small edits keep the same stream order and checker loads.\n+func quantizeCheckerAssociationWeight(weight int) int {\n+\tif weight \u003c= 8 {\n+\t\treturn weight\n+\t}\n+\tconst ratio = 1.125\n+\treturn int(math.Pow(ratio, math.Floor(math.Log(float64(weight))/math.Log(ratio))))\n+}\n\n```","author":{"url":"https://github.com/ubugeeei","@type":"Person","name":"ubugeeei"},"datePublished":"2026-11-18T10:55:11Z","url":"https://github.com/microsoft/TypeScript/issues/65559"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:36a3742e-b13b-145f-9771-b4382e100b8c |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D690:1F7384:8C18CA:BB7B7D:6B00E14C |
| html-safe-nonce | 70de237a6b29825caebaecd0d44b93adbf0157fe159a904e56171dbc4d6a5256 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENjkwOjFGNzM4NDo4QzE4Q0E6QkI3QjdEOjZCMDBFMTRDIiwidmlzaXRvcl9pZCI6IjE2ODUwMDAwMjUxNzM3MTMyMjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 375ff09d9a2ec09cdcccae78edb953a5cdf162e302abe2b294c3a3460c2d58b7 |
| hovercard-subject-tag | issue:6465548199 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/65559/issue_layout |
| twitter:image | https://opengraph.githubassets.com/9224c0ad9a23e1355404a5253b32c5e1079635b2d46b575a9bcef3d1b6b4cced/microsoft/TypeScript/issues/65559 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9224c0ad9a23e1355404a5253b32c5e1079635b2d46b575a9bcef3d1b6b4cced/microsoft/TypeScript/issues/65559 |
| og:image:alt | Comment On 7.1.0-beta, changing a few nodes in one file can move hundreds of other files to a different checker. Total work stays the same, but the slowest checker changes, so Check time swings by ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ubugeeei |
| hostname | github.com |
| expected-hostname | github.com |
| None | 043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5425dc24e8bd8d6fca9641a12afc984825a43875 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width