René's URL Explorer Experiment


Title: Structural typing undermining type safety · Issue #5933 · microsoft/TypeScript · GitHub

Open Graph Title: Structural typing undermining type safety · Issue #5933 · microsoft/TypeScript

X Title: Structural typing undermining type safety · Issue #5933 · microsoft/TypeScript

Description: class Dog {furColor: string} class Cat {} function walk(d: Dog): void {} function pet(c: Cat): void {} const d: Dog = {furColor: "brown"}; const c: Cat = {}; walk(c); // error, good! pet(d); // no error, bad! Ryan and I have had extensiv...

Open Graph Description: class Dog {furColor: string} class Cat {} function walk(d: Dog): void {} function pet(c: Cat): void {} const d: Dog = {furColor: "brown"}; const c: Cat = {}; walk(c); // error, good! pet(d); // no ...

X Description: class Dog {furColor: string} class Cat {} function walk(d: Dog): void {} function pet(c: Cat): void {} const d: Dog = {furColor: "brown"}; const c: Cat = {}; walk(c); // error, good! pet(...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/5933

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Structural typing undermining type safety","articleBody":"``` javascript\nclass Dog {furColor: string}\nclass Cat {}\n\nfunction walk(d: Dog): void {}\nfunction pet(c: Cat): void {}\n\nconst d: Dog = {furColor: \"brown\"};\nconst c: Cat = {};\n\nwalk(c); // error, good!\npet(d); // no error, bad!\n```\n\nRyan and I have had extensive conversations about this problem.  In my opinion this should clearly fail since both Dog and Cat are classes.  Type safety should ensure that when we demand a class type the thing passed in should be in the inheritance chain.  Structural typing shouldn't apply to classes.\n\nThere's an argument to be made that this case also shouldn't be supported for interfaces, which I'm also sympathetic to.  This similar example proves the problem:\n\n``` javascript\ninterface Dog {furColor: string}\ninterface Cat {}\n\nfunction walk(d: Dog): void {}\nfunction pet(c: Cat): void {}\n\nconst d: Dog = {furColor: \"brown\"};\nconst c: Cat = {};\n\nwalk(c); // error, good!\npet(d); // no error, bad!\n```\n\nHowever, if we mark furColor as optional, I think there's a totally valid argument to be made that it should compile and the desired behavior is met, e.g.\n\n``` javascript\ninterface Dog {furColor?: string}\ninterface Cat {}\n\nfunction walk(d: Dog): void {}\nfunction pet(c: Cat): void {}\n\nconst d: Dog = {furColor: \"brown\"};\nconst c: Cat = {};\n\nwalk(c); // no error, good!\npet(d); // no error, good!\n```\n","author":{"url":"https://github.com/alexpomsft","@type":"Person","name":"alexpomsft"},"datePublished":"2015-12-04T16:23:38Z","url":"https://github.com/microsoft/TypeScript/issues/5933"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:3480a192-e172-954d-4f8f-babbaa69be30
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idCAD8:17FB7:5EE3E3:779F74:6B0111F1
html-safe-nonce8f80848c639030def11a2a028dac9e20a48bf7ef1028b3df85b24b9739946ea3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQUQ4OjE3RkI3OjVFRTNFMzo3NzlGNzQ6NkIwMTExRjEiLCJ2aXNpdG9yX2lkIjoiNzU5Mzg3MTgwMTcxMzc1ODcwNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac22d6141b1cf9c42b713b17200e2a9042cfa43729f36ad0039d0fc7aea004bfe6
hovercard-subject-tagissue:120435515
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/5933/issue_layout
twitter:imagehttps://opengraph.githubassets.com/9ed9bca520cff6b18358f218168fb2b2b4757f98d69c81416f8b42bd3272627d/microsoft/TypeScript/issues/5933
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9ed9bca520cff6b18358f218168fb2b2b4757f98d69c81416f8b42bd3272627d/microsoft/TypeScript/issues/5933
og:image:altclass Dog {furColor: string} class Cat {} function walk(d: Dog): void {} function pet(c: Cat): void {} const d: Dog = {furColor: "brown"}; const c: Cat = {}; walk(c); // error, good! pet(d); // no ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamealexpomsft
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/5933#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F5933
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F5933
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/5933
Reloadhttps://github.com/microsoft/TypeScript/issues/5933
Reloadhttps://github.com/microsoft/TypeScript/issues/5933
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests310 (310)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/5933
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/5933
Structural typing undermining type safetyhttps://github.com/microsoft/TypeScript/issues/5933#top
Needs ProposalThis issue needs a plan that clarifies the finer details of how it could be implemented.https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Needs%20Proposal%22
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
https://github.com/alexpomsft
Alex Pope (alexpomsft)https://github.com/alexpomsft
on Dec 4, 2015https://github.com/microsoft/TypeScript/issues/5933#issue-120435515
https://github.com/zpdDG4gta8XKpMCd
ZpdDG4gta (zpdDG4gta8XKpMCd)https://github.com/zpdDG4gta8XKpMCd
on Dec 5, 2015https://github.com/microsoft/TypeScript/issues/5933#issuecomment-162243375
https://github.com/Arnavion
Arnav Singh (Arnavion)https://github.com/Arnavion
on Dec 6, 2015https://github.com/microsoft/TypeScript/issues/5933#issuecomment-162336687
#3841https://github.com/microsoft/TypeScript/issues/3841
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Needs ProposalThis issue needs a plan that clarifies the finer details of how it could be implemented.https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Needs%20Proposal%22
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
on Dec 8, 2015https://github.com/microsoft/TypeScript/issues/5933#event-486052940
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
on Dec 8, 2015https://github.com/microsoft/TypeScript/issues/5933#issuecomment-162993822
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
on Jul 17, 2020https://github.com/microsoft/TypeScript/issues/5933#issuecomment-660363484
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Jul 17, 2020https://github.com/microsoft/TypeScript/issues/5933#event-3560075125
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/5933
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/5933
Needs ProposalThis issue needs a plan that clarifies the finer details of how it could be implemented.https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Needs%20Proposal%22
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.