René's URL Explorer Experiment


Title: empty return statement should be a compiler error when return type is specified · Issue #5916 · microsoft/TypeScript · GitHub

Open Graph Title: empty return statement should be a compiler error when return type is specified · Issue #5916 · microsoft/TypeScript

X Title: empty return statement should be a compiler error when return type is specified · Issue #5916 · microsoft/TypeScript

Description: Currently this function compiles just fine function foo(x): string { return; } I understand that it's happening because undefined is a valid result for a variable of type string, and this sort of related back to #185, but a midway point ...

Open Graph Description: Currently this function compiles just fine function foo(x): string { return; } I understand that it's happening because undefined is a valid result for a variable of type string, and this sort of r...

X Description: Currently this function compiles just fine function foo(x): string { return; } I understand that it's happening because undefined is a valid result for a variable of type string, and this sort ...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/5916

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"empty return statement should be a compiler error when return type is specified","articleBody":"Currently this function compiles just fine\n\n``` .ts\nfunction foo(x): string {\n    return;\n}\n```\n\nI understand that it's happening because `undefined` is a valid result for a variable of type `string`, and this sort of related back to #185, but a midway point could be to simply require the return statement to not be empty.\n\nSimilarly, this code fails to compile:\n\n``` .ts\nfunction foo(x): string {\n}\n```\n\nBut this one compiles:\n\n``` .ts\nfunction foo(x): string {\n    if(false) {\n        return;\n    }\n}\n```\n\nI think the expected behavior is that every branch should require an explicit return statement.\n\nA side benefit of this is that you can get exhausting matching completeness basically for free:\n\n``` .ts\nfunction foo(x: number | string | boolean): string {\n    if(typeof x === 'number') {\n        return x.toString();\n    } else if (typeof x === 'string') {\n        return x;\n    }\n}\n```\n\nCurrently the above compiles, but if TypeScript required an explicit return in every branch for non void return functions, there would be a compiler error because there are remaining types in the union. However this would compile:\n\n``` .ts\nfunction foo(x: number | string | boolean): string {\n    if(typeof x === 'number') {\n        return x.toString();\n    } else if (typeof x === 'string') {\n        return x;\n    } else if (typeof x === 'boolean') {\n        return ''+x;\n    }\n}\n```\n\nThis is pretty nice! There is one edge case still -- because of the implicit `void` included in `x`, calling `foo(null)` or `foo(undefined)` will return `undefined`. I don't know what to do about this because it relates pretty heavily to #185. I think for now it can be ignored, and whatever resolution that (hopefully) happens there will take care of it.\n","author":{"url":"https://github.com/tejacques","@type":"Person","name":"tejacques"},"datePublished":"2015-12-03T21:23:57Z","url":"https://github.com/microsoft/TypeScript/issues/5916"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:dade6ee7-b787-d0a6-9107-e5cb602310db
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE986:2E9831:473047:5E0128:6B0198E1
html-safe-nonce384029cc00cbe937d5ace2d1020e3e8ce9522bb01229ada5e96b00f50a43749d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTg2OjJFOTgzMTo0NzMwNDc6NUUwMTI4OjZCMDE5OEUxIiwidmlzaXRvcl9pZCI6IjM2NDM5MzU2NDM5NjY0Nzg1NjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd101642a3d90548c1f43f5cfb8253670cb98f83b4770c29b652e74df6878601b
hovercard-subject-tagissue:120273102
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/5916/issue_layout
twitter:imagehttps://opengraph.githubassets.com/c633013588c1a2a833fa654e94e9606483b531568ceca6878715e928ebb873f4/microsoft/TypeScript/issues/5916
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c633013588c1a2a833fa654e94e9606483b531568ceca6878715e928ebb873f4/microsoft/TypeScript/issues/5916
og:image:altCurrently this function compiles just fine function foo(x): string { return; } I understand that it's happening because undefined is a valid result for a variable of type string, and this sort of r...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametejacques
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/5916#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F5916
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F5916
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/5916
Reloadhttps://github.com/microsoft/TypeScript/issues/5916
Reloadhttps://github.com/microsoft/TypeScript/issues/5916
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/5916
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/5916
#7358https://github.com/microsoft/TypeScript/pull/7358
empty return statement should be a compiler error when return type is specifiedhttps://github.com/microsoft/TypeScript/issues/5916#top
#7358https://github.com/microsoft/TypeScript/pull/7358
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
TypeScript 2.0https://github.com/microsoft/TypeScript/milestone/1
https://github.com/tejacques
Tom Jacques (tejacques)https://github.com/tejacques
on Dec 3, 2015https://github.com/microsoft/TypeScript/issues/5916#issue-120273102
#185https://github.com/microsoft/TypeScript/issues/185
#185https://github.com/microsoft/TypeScript/issues/185
https://github.com/vladima
Vladimir Matveev (vladima)https://github.com/vladima
on Dec 3, 2015https://github.com/microsoft/TypeScript/issues/5916#issuecomment-161802368
https://github.com/tejacques
Tom Jacques (tejacques)https://github.com/tejacques
on Dec 3, 2015https://github.com/microsoft/TypeScript/issues/5916#issuecomment-161805553
Vladimir Matveev (@vladima)https://github.com/vladima
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
on Dec 3, 2015https://github.com/microsoft/TypeScript/issues/5916#issuecomment-161810284
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
on Dec 3, 2015https://github.com/microsoft/TypeScript/issues/5916#issuecomment-161810802
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
on Dec 3, 2015https://github.com/microsoft/TypeScript/issues/5916#issuecomment-161811029
Tom Jacques (@tejacques)https://github.com/tejacques
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
on Dec 3, 2015https://github.com/microsoft/TypeScript/issues/5916#issuecomment-161811455
https://github.com/tejacques
Tom Jacques (tejacques)https://github.com/tejacques
on Dec 3, 2015https://github.com/microsoft/TypeScript/issues/5916#issuecomment-161813417
Daniel Rosenwasser (@DanielRosenwasser)https://github.com/DanielRosenwasser
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
on Dec 3, 2015https://github.com/microsoft/TypeScript/issues/5916#issuecomment-161813702
Vladimir Matveev (@vladima)https://github.com/vladima
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
In DiscussionNot yet reached consensushttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22In%20Discussion%22
on Jan 7, 2016https://github.com/microsoft/TypeScript/issues/5916#event-508574601
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Accepting PRshttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Accepting%20PRs%22
In DiscussionNot yet reached consensushttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22In%20Discussion%22
on Feb 1, 2016https://github.com/microsoft/TypeScript/issues/5916#event-535038057
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
on Feb 1, 2016https://github.com/microsoft/TypeScript/issues/5916#event-535038078
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Effort: Easyhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Effort%3A%20Easy%22
on Feb 1, 2016https://github.com/microsoft/TypeScript/issues/5916#event-535038133
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
on Feb 1, 2016https://github.com/microsoft/TypeScript/issues/5916#issuecomment-178263930
https://github.com/basarat
Basarat Ali Syed (basarat)https://github.com/basarat
on Mar 3, 2016https://github.com/microsoft/TypeScript/issues/5916#issuecomment-191557653
#7140https://github.com/microsoft/TypeScript/pull/7140
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
TypeScript 2.0https://github.com/microsoft/TypeScript/milestone/1
on Mar 3, 2016https://github.com/microsoft/TypeScript/issues/5916#event-576810462
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
on Mar 3, 2016https://github.com/microsoft/TypeScript/issues/5916#event-576810623
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
on Mar 3, 2016https://github.com/microsoft/TypeScript/issues/5916#issuecomment-191948178
martinehttps://github.com/martine
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#7358https://github.com/microsoft/TypeScript/pull/7358
on Mar 3, 2016https://github.com/microsoft/TypeScript/issues/5916#event-576925650
https://github.com/nbarnwell
Neil Barnwell (nbarnwell)https://github.com/nbarnwell
on Nov 23, 2017https://github.com/microsoft/TypeScript/issues/5916#issuecomment-346598721
microsofthttps://github.com/microsoft
on Jun 19, 2018https://github.com/microsoft/TypeScript/issues/5916#event-1689626914
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/5916
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/5916
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
TypeScript 2.0https://github.com/microsoft/TypeScript/milestone/1
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.