René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"getSpecifierForModuleSymbol failing in 5.5 rc","articleBody":"### 🔎 Search Terms\n\ngetSpecifierForModuleSymbol, Debug Failure, False expression,\r\n\n\n### 🕗 Version \u0026 Regression Information\n\n- This is a crash\r\n- This changed between versions 5.5 beta and 5.5 rc\r\n\r\n\n\n### ⏯ Playground Link\n\nhttps://github.com/Agoric/agoric-sdk/actions/runs/9440222557/job/25999288161?pr=9476\n\n### 💻 Code\n\nMy only repro is half-way through the build of a large repo, so I don't think I can isolate it to a code snippet. \r\n\r\nhttps://github.com/Agoric/agoric-sdk/pull/9476 changed the `typescript` from,\r\n\r\n```diff\r\n- typescript@^5.5.0-beta\r\n-   version \"5.5.0-dev.20240426\"\r\n-  resolved \"https://registry.yarnpkg.com/typescript/-/typescript-5.5.0-dev.20240426.tgz#e9ba7d0b3cdaa54021faca61d1bc399e4766c93b\"\r\n-  integrity sha512-96cu+y3DrjSNhNSgB3t3nRiesCwBVjZpbjJ6DcQoCgt0crXXPrOMmJQH/E8TZ41U4JzaULD+cB1Z2owh5HANew==\r\n+ typescript@^5.5.1-rc:\r\n+   version \"5.5.1-rc\"\r\n+   resolved \"https://registry.yarnpkg.com/typescript/-/typescript-5.5.1-rc.tgz#4be420f1ecb5e66c52a7cb11444f06f02294c977\"\r\n+   integrity sha512-7cbqBhh2QH0RaI7AD0ElJ2Ww/iRdW1w2wH/S2dv6EbdNQQlv39fx+V5VOepxLgfUvRkU5D5pxzgPuvHSAQOdpQ==\r\n```\r\n\r\n[A CI job builds each package topologically](https://github.com/Agoric/agoric-sdk/blob/e7b0cebd17f093793e93f4f236921cb4a3f595b8/.github/workflows/test-all-packages.yml#L74-L77).\r\n\r\n\n\n### 🙁 Actual behavior\n\nThe job started failing with:\r\n```\r\nError: Debug Failure. False expression.\r\n    at first (/home/runner/work/agoric-sdk/agoric-sdk/node_modules/typescript/lib/tsc.js:605:9)\r\n    at getSpecifierForModuleSymbol (/home/runner/work/agoric-sdk/agoric-sdk/node_modules/typescript/lib/tsc.js:50904:21)\r\n    at rewriteModuleSpecifier (/home/runner/work/agoric-sdk/agoric-sdk/node_modules/typescript/lib/tsc.js:51977:22)\r\n    at visitExistingNodeTreeSymbolsWorker (/home/runner/work/agoric-sdk/agoric-sdk/node_modules/typescript/lib/tsc.js:51827:58)\r\n    at visitExistingNodeTreeSymbols (/home/runner/work/agoric-sdk/agoric-sdk/node_modules/typescript/lib/tsc.js:51535:24)\r\n    at visitArrayWorker (/home/runner/work/agoric-sdk/agoric-sdk/node_modules/typescript/lib/tsc.js:87695:49)\r\n    at visitNodes2 (/home/runner/work/agoric-sdk/agoric-sdk/node_modules/typescript/lib/tsc.js:87666:19)\r\n    at tryVisitTypeReference (/home/runner/work/agoric-sdk/agoric-sdk/node_modules/typescript/lib/tsc.js:51672:33)\r\n    at visitExistingNodeTreeSymbolsWorker (/home/runner/work/agoric-sdk/agoric-sdk/node_modules/typescript/lib/tsc.js:51811:26)\r\n    at visitExistingNodeTreeSymbols (/home/runner/work/agoric-sdk/agoric-sdk/node_modules/typescript/lib/tsc.js:51535:24)\r\n```\r\n\r\nIn the debugger I see that it happens while looking for `escapedName: 'globalThis'` in the context of [this file](https://github.com/Agoric/agoric-sdk/blob/master/packages/inter-protocol/src/psm/psm.js).\n\n### 🙂 Expected behavior\n\nContinues to build like the beta and past releases.\n\n### Additional information about the issue\n\nOur repo makes use of [a hack](https://stackoverflow.com/a/66588974) to make types available both ambiently and by explicit imports.\r\nhttps://github.com/Agoric/agoric-sdk/blob/e7b0cebd17f093793e93f4f236921cb4a3f595b8/packages/internal/exported.d.ts#L17-L29\r\n\r\nThe motivation for this is in transitioning from ambient types to define exportable types and retain backwards compatibility with consumers expecting ambients.","author":{"url":"https://github.com/turadg","@type":"Person","name":"turadg"},"datePublished":"2024-06-10T13:50:32.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/58819/TypeScript/issues/58819"}