Title: Performance regression in TS 5.4 · Issue #57781 · microsoft/TypeScript · GitHub
Open Graph Title: Performance regression in TS 5.4 · Issue #57781 · microsoft/TypeScript
X Title: Performance regression in TS 5.4 · Issue #57781 · microsoft/TypeScript
Description: 🔎 Search Terms performance regression 🕗 Version & Regression Information This changed in commit or PR 4bcbc16 ⏯ Playground Link No response 💻 Code I cannot share our repository nor can I feasibly pare it down to be shareable. 🙁 Actual be...
Open Graph Description: 🔎 Search Terms performance regression 🕗 Version & Regression Information This changed in commit or PR 4bcbc16 ⏯ Playground Link No response 💻 Code I cannot share our repository nor can I feasibly p...
X Description: 🔎 Search Terms performance regression 🕗 Version & Regression Information This changed in commit or PR 4bcbc16 ⏯ Playground Link No response 💻 Code I cannot share our repository nor can I feasib...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/57781
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Performance regression in TS 5.4","articleBody":"### 🔎 Search Terms\n\nperformance regression\n\n### 🕗 Version & Regression Information\n\n- This changed in commit or PR 4bcbc16cff6c65caf349f1c1df4dc7b6809468ae\r\n\n\n### ⏯ Playground Link\n\n_No response_\n\n### 💻 Code\n\nI cannot share our repository nor can I feasibly pare it down to be shareable.\n\n### 🙁 Actual behavior\n\nTypechecking time in our monorepo takes about 375 seconds on my local machine.\r\n\r\n\n\n### 🙂 Expected behavior\n\nTypechecking time used to be about 315 seconds on my local machine with the same code.\n\n### Additional information about the issue\n\nHere's my usage of every-ts to bisect the results. It narrows down to https://github.com/microsoft/TypeScript/pull/56087. cc @Andarist \r\n\r\n```js\r\n$ every-ts bisect start \r\nUpdating files: 100% (5762/5762), done.\r\nPrevious HEAD position was e441420483 Update package-lock.json\r\nHEAD is now at 9684ba6b0d Cherry-pick fix for cross-file inlay hints (#55476) to `release-5.2` and LKG (#55487)\r\nstatus: waiting for both good and bad commits\r\nBuilding TypeScript...\r\nTypeScript built successfully!\r\n\r\n$ every-ts bisect bad 5.4.2\r\nResolved 5.4.2 to v5.4.2\r\nstatus: waiting for good commit(s), bad commit known\r\n\r\n$ every-ts bisect good e44142048305d42ec4fc753457aa561f8e247e4f\r\nBisecting: 66 revisions left to test after this (roughly 6 steps)\r\nremote: Enumerating objects: 125, done.\r\nremote: Counting objects: 100% (101/101), done.\r\nremote: Compressing objects: 100% (65/65), done.\r\nremote: Total 125 (delta 42), reused 36 (delta 36), pack-reused 24\r\nReceiving objects: 100% (125/125), 1.68 MiB | 2.45 MiB/s, done.\r\nResolving deltas: 100% (57/57), done.\r\n[dad9f17c773f97426f90539dd75a6a5100d342d0] Update package-lock.json\r\nBuilding TypeScript...\r\nTypeScript built successfully!\r\n\r\n$ every-ts bisect bad # 368.143 s\r\nBisecting: 32 revisions left to test after this (roughly 5 steps)\r\nremote: Enumerating objects: 29, done.\r\nremote: Counting objects: 100% (25/25), done.\r\nremote: Compressing objects: 100% (24/24), done.\r\nremote: Total 29 (delta 1), reused 1 (delta 1), pack-reused 4\r\nReceiving objects: 100% (29/29), 1.31 MiB | 6.25 MiB/s, done.\r\nResolving deltas: 100% (1/1), done.\r\n[69f2e2ae651a13ad865727f42af8fac48c64e137] Issue better error when unresolvable package in `--moduleResolution node10` resolves with `--moduleResolution bundler` (#56949)\r\nBuilding TypeScript...\r\nTypeScript built successfully!\r\n\r\n$ every-ts bisect bad # 371.229 s \r\nBisecting: 16 revisions left to test after this (roughly 4 steps)\r\nremote: Enumerating objects: 6, done.\r\nremote: Counting objects: 100% (6/6), done.\r\nremote: Compressing objects: 100% (6/6), done.\r\nremote: Total 6 (delta 0), reused 0 (delta 0), pack-reused 0\r\nReceiving objects: 100% (6/6), 939.99 KiB | 5.08 MiB/s, done.\r\n[81793210e6337ad8d20f2b7e44e9489687c2d29c] Update package-lock.json\r\nBuilding TypeScript...\r\nTypeScript built successfully!\r\n\r\n$ every-ts bisect bad # 374.109 s\r\nBisecting: 7 revisions left to test after this (roughly 3 steps)\r\nremote: Enumerating objects: 4, done.\r\nremote: Counting objects: 100% (4/4), done.\r\nremote: Compressing objects: 100% (4/4), done.\r\nremote: Total 4 (delta 0), reused 0 (delta 0), pack-reused 0\r\nReceiving objects: 100% (4/4), 784.99 KiB | 6.04 MiB/s, done.\r\n[1e00399a383d253610ec18d3a77d08b671219fc2] Fixed emit of return statements with parenthesized assertions and comments (#56601)\r\nBuilding TypeScript...\r\nTypeScript built successfully!\r\n\r\n$ every-ts bisect good # 315.135 s\r\nBisecting: 3 revisions left to test after this (roughly 2 steps)\r\nremote: Enumerating objects: 1, done.\r\nremote: Counting objects: 100% (1/1), done.\r\nremote: Total 1 (delta 0), reused 0 (delta 0), pack-reused 0\r\nReceiving objects: 100% (1/1), 549.70 KiB | 6.04 MiB/s, done.\r\n[4557e34e7003f5dd11fd33881ae91d10451fb23a] Emit declarations using alternative containing modules for types exported using separate export statements (#56857)\r\nBuilding TypeScript...\r\nTypeScript built successfully!\r\n\r\n$ every-ts bisect good # 319.945 s\r\nBisecting: 1 revision left to test after this (roughly 1 step)\r\n[2c14a1c2250d0b891f743c1b6ae58ac951942206] fix(55650): Wrong/missing quick info in JSDoc @implements tag (#56884)\r\nBuilding TypeScript...\r\nTypeScript built successfully!\r\n\r\n$ every-ts bisect bad # 364.453 s\r\nBisecting: 0 revisions left to test after this (roughly 0 steps)\r\n[4bcbc16cff6c65caf349f1c1df4dc7b6809468ae] Use symbols of type aliases when emitting declarations (#56087)\r\nBuilding TypeScript...\r\nTypeScript built successfully!\r\n\r\n$ every-ts bisect bad # 368.270 s\r\n4bcbc16cff6c65caf349f1c1df4dc7b6809468ae is the first bad commit\r\ncommit 4bcbc16cff6c65caf349f1c1df4dc7b6809468ae\r\nAuthor: Mateusz Burzyński \u003cmateuszburzynski@gmail.com>\r\nDate: Tue Jan 9 22:02:52 2024 +0100\r\n\r\n Use symbols of type aliases when emitting declarations (#56087)\r\n\r\n src/compiler/checker.ts | 6 +++\r\n .../reference/declarationEmitUsingTypeAlias1.js | 47 ++++++++++++++++++++++\r\n .../declarationEmitUsingTypeAlias1.symbols | 46 +++++++++++++++++++++\r\n .../reference/declarationEmitUsingTypeAlias1.types | 43 ++++++++++++++++++++\r\n .../compiler/declarationEmitUsingTypeAlias1.ts | 30 ++++++++++++++\r\n 5 files changed, 172 insertions(+)\r\n create mode 100644 tests/baselines/reference/declarationEmitUsingTypeAlias1.js\r\n create mode 100644 tests/baselines/reference/declarationEmitUsingTypeAlias1.symbols\r\n create mode 100644 tests/baselines/reference/declarationEmitUsingTypeAlias1.types\r\n create mode 100644 tests/cases/compiler/declarationEmitUsingTypeAlias1.ts\r\nBuilding TypeScript...\r\nTypeScript built successfully!\r\n```","author":{"url":"https://github.com/MichaelMitchell-at","@type":"Person","name":"MichaelMitchell-at"},"datePublished":"2024-03-14T19:21:25Z","url":"https://github.com/microsoft/TypeScript/issues/57781"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:497dd041-ea94-1841-f9e0-6db056f6d71e |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A98C:240CD1:E86666:128B171:6B010A8F |
| html-safe-nonce | b7a7b2d1ecea3e36f233a25778452b6da0476d0691b246ea73a933b5732eea84 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOThDOjI0MENEMTpFODY2NjY6MTI4QjE3MTo2QjAxMEE4RiIsInZpc2l0b3JfaWQiOiI3MDc3MjQ2MzQ3NjM5ODUxNjY0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 5fc956615743c14d8d9a5cfa110d701fa05f6bea8202a163278403c6f9e01bce |
| hovercard-subject-tag | issue:2187109140 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/57781/issue_layout |
| twitter:image | https://opengraph.githubassets.com/d3fa8b6cd469f4495116eaf7f036c7798b55bc5a6d8a6d8a1b71d088c5da44c9/microsoft/TypeScript/issues/57781 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d3fa8b6cd469f4495116eaf7f036c7798b55bc5a6d8a6d8a1b71d088c5da44c9/microsoft/TypeScript/issues/57781 |
| og:image:alt | 🔎 Search Terms performance regression 🕗 Version & Regression Information This changed in commit or PR 4bcbc16 ⏯ Playground Link No response 💻 Code I cannot share our repository nor can I feasibly p... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | MichaelMitchell-at |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width