René's URL Explorer Experiment


Title: instanceof does not respect inherited `Symbol.hasInstance` · Issue #56536 · microsoft/TypeScript · GitHub

Open Graph Title: instanceof does not respect inherited `Symbol.hasInstance` · Issue #56536 · microsoft/TypeScript

X Title: instanceof does not respect inherited `Symbol.hasInstance` · Issue #56536 · microsoft/TypeScript

Description: 🔎 Search Terms hasinstance, instanceof, 2359, TS2359 🕗 Version & Regression Information I was unable to test this on prior versions because this is recent functionality introduced in #55052 ⏯ Playground Link https://www.typescriptlang.or...

Open Graph Description: 🔎 Search Terms hasinstance, instanceof, 2359, TS2359 🕗 Version & Regression Information I was unable to test this on prior versions because this is recent functionality introduced in #55052 ⏯ Playg...

X Description: 🔎 Search Terms hasinstance, instanceof, 2359, TS2359 🕗 Version & Regression Information I was unable to test this on prior versions because this is recent functionality introduced in #55052 ⏯ P...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/56536

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"instanceof does not respect inherited `Symbol.hasInstance`","articleBody":"### 🔎 Search Terms\r\n\r\nhasinstance, instanceof, 2359, TS2359\r\n\r\n### 🕗 Version & Regression Information\r\n\r\n- I was unable to test this on prior versions because this is recent functionality introduced in #55052\r\n\r\n\r\n### ⏯ Playground Link\r\n\r\nhttps://www.typescriptlang.org/play?declaration=false&target=9&module=7&ts=5.4.0-dev.20231124#code/C4TwDgpgBAEghgZwJIDsHDigxhA8gMygF4oBvAKCigG0BlEAWwCMB7AGwDoALRVdTHAF0AFAA8AXAFcUAaxQsA7igCU4qK3YRM5AL7lyAegNQWM8vmlZgASxYooDEHwzY8+MVNnylAGihZxeGQ0FxwCZQoqACcIYEko+1EoaxCBCBZCLF19I3Uo0wgUc0sbOwcnVNcCVGAIKIQIK1sUD2k5RRQ-AKDnNIIoADITJgArRuAIyigYuISoJJT+Vwz-bMNjJnyZQuLsUvtHXqr8AHFCuussAB4AYSgIUVqUABMEWF5KsPwAPlavDq64huk2isXiiWSn3SmV0QA\r\n\r\n### 💻 Code\r\n\r\n```ts\r\ntype HasInstanceOf = {\r\n  [Symbol.hasInstance](x:unknown): boolean\r\n}\r\n\r\n// ok\r\nfunction myInstanceOf(x:unknown, c:HasInstanceOf){\r\n  return x instanceof c\r\n}\r\n\r\n// broken\r\nfunction myInstanceOfIntersection(x:unknown, c:HasInstanceOf & object){\r\n  return x instanceof c\r\n}\r\n\r\n// broken\r\nfunction myInstanceOfGeneric\u003cC extends HasInstanceOf>(x:unknown, c:C){\r\n  return x instanceof c\r\n}\r\n```\r\n\r\n\r\n### 🙁 Actual behavior\r\n\r\nThe second and third examples give error TS2359\r\n> The right-hand side of an 'instanceof' expression must be either of type 'any', a class, function, or other type assignable to the 'Function' interface type, or an object type with a 'Symbol.hasInstance' method.\r\n\r\nIn all cases, the right-hand side *is* an object type with a `Symbol.hasInstance` method.\r\n\r\n### 🙂 Expected behavior\r\n\r\nI expect all three examples to typecheck.\r\n\r\n### Additional information about the issue\r\n\r\n_No response_","author":{"url":"https://github.com/rotu","@type":"Person","name":"rotu"},"datePublished":"2023-11-25T04:35:39Z","url":"https://github.com/microsoft/TypeScript/issues/56536"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:560c0f4a-8fef-299d-00b9-9481d804054e
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8052:361639:26F53E1:340C1B7:6B01B08C
html-safe-nonce2e4b26a40d9cdeab34463fe713abb112bc7b42e0d5759c66908ca705a81bfc8d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDUyOjM2MTYzOToyNkY1M0UxOjM0MEMxQjc6NkIwMUIwOEMiLCJ2aXNpdG9yX2lkIjoiODkyNTUxMjY5MzcxMzA1NTg4NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacdde4f375aba46c0d0ae1bc74923f843691727f59b335f6d89afd69947aec3fb9
hovercard-subject-tagissue:2010469930
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/56536/issue_layout
twitter:imagehttps://opengraph.githubassets.com/e0e63efd14402bccdcfbf0de6815f989096d1d54f3e9b244a0b6507ed1af4b81/microsoft/TypeScript/issues/56536
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e0e63efd14402bccdcfbf0de6815f989096d1d54f3e9b244a0b6507ed1af4b81/microsoft/TypeScript/issues/56536
og:image:alt🔎 Search Terms hasinstance, instanceof, 2359, TS2359 🕗 Version & Regression Information I was unable to test this on prior versions because this is recent functionality introduced in #55052 ⏯ Playg...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerotu
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/56536#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F56536
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F56536
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/56536
Reloadhttps://github.com/microsoft/TypeScript/issues/56536
Reloadhttps://github.com/microsoft/TypeScript/issues/56536
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/56536
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/56536
#57602https://github.com/microsoft/TypeScript/pull/57602
instanceof does not respect inherited Symbol.hasInstancehttps://github.com/microsoft/TypeScript/issues/56536#top
#57602https://github.com/microsoft/TypeScript/pull/57602
https://github.com/rbuckton
Fix AvailableA PR has been opened for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fix%20Available%22
TypeScript 5.4.0https://github.com/microsoft/TypeScript/milestone/193
https://github.com/rotu
Dan Rose (rotu)https://github.com/rotu
on Nov 25, 2023https://github.com/microsoft/TypeScript/issues/56536#issue-2010469930
Support custom 'Symbol.hasInstance' methods when narrowing 'instanceof' #55052https://github.com/microsoft/TypeScript/pull/55052
https://www.typescriptlang.org/play?declaration=false&target=9&module=7&ts=5.4.0-dev.20231124#code/C4TwDgpgBAEghgZwJIDsHDigxhA8gMygF4oBvAKCigG0BlEAWwCMB7AGwDoALRVdTHAF0AFAA8AXAFcUAaxQsA7igCU4qK3YRM5AL7lyAegNQWM8vmlZgASxYooDEHwzY8+MVNnylAGihZxeGQ0FxwCZQoqACcIYEko+1EoaxCBCBZCLF19I3Uo0wgUc0sbOwcnVNcCVGAIKIQIK1sUD2k5RRQ-AKDnNIIoADITJgArRuAIyigYuISoJJT+Vwz-bMNjJnyZQuLsUvtHXqr8AHFCuussAB4AYSgIUVqUABMEWF5KsPwAPlavDq64huk2isXiiWSn3SmV0QAhttps://www.typescriptlang.org/play?declaration=false&target=9&module=7&ts=5.4.0-dev.20231124#code/C4TwDgpgBAEghgZwJIDsHDigxhA8gMygF4oBvAKCigG0BlEAWwCMB7AGwDoALRVdTHAF0AFAA8AXAFcUAaxQsA7igCU4qK3YRM5AL7lyAegNQWM8vmlZgASxYooDEHwzY8+MVNnylAGihZxeGQ0FxwCZQoqACcIYEko+1EoaxCBCBZCLF19I3Uo0wgUc0sbOwcnVNcCVGAIKIQIK1sUD2k5RRQ-AKDnNIIoADITJgArRuAIyigYuISoJJT+Vwz-bMNjJnyZQuLsUvtHXqr8AHFCuussAB4AYSgIUVqUABMEWF5KsPwAPlavDq64huk2isXiiWSn3SmV0QA
https://github.com/fatcerberus
Bruce Pascoe (fatcerberus)https://github.com/fatcerberus
on Nov 25, 2023https://github.com/microsoft/TypeScript/issues/56536#issuecomment-1826213457
Playground linkhttps://www.typescriptlang.org/play?declaration=false&target=9&module=7&ts=5.4.0-dev.20231124#code/JYOwLgpgTgZghgYwgAgBJwM4EkQbHEJAeRmQG8AoZZAbQGUBPAWwCMB7AGwDoALTHPASQBdABQAPAFwBXEAGsQbAO4gAlJOTtOEAhQC+FCqEixEKHD2jBIAE3TZc+QhBLII4yCBsY0-R0JdSMgMKAHpQ5DY5ChhZBDBgNhBkJgYBJ2IYCRl5RRUAGmQESXt0gJJVSmooCDBpKGTxZFBBZzZSBH1DcMjo2MIEpJS0-2cSCytbbNkFZRBC4omoawg7P1bMyqpkGrqG5CaWjIh2oq6wiJYoKIgQGLjB5NSysZgcEwwIeMSQady5hYldbHVwAMkiLAAVl8wFtqrV6o1mqMkKdOiEelcbnd+t8hs8UYEAOK3KwIAA8AGE3B5bt5fA4NoEAHx-WYFIqSSlwnYI-aHQlo-RAA
https://github.com/rotu
Dan Rose (rotu)https://github.com/rotu
on Nov 25, 2023https://github.com/microsoft/TypeScript/issues/56536#issuecomment-1826218068
Bruce Pascoe (@fatcerberus)https://github.com/fatcerberus
Workbench Reprohttps://www.typescriptlang.org/dev/bug-workbench/#code/MYewdgzgLgBAKiADjAvDA3gbQMoE8C2ARiADYB0AFgIYQCSkUVYwApgLoBcAFAB4cCuYANZgQAdzABKFAD4uUAE78WMGjFANJAXwBQG6DABCIWGix4ipSjXrQmrTrwHDRE6XIBmVEhBVr9UNo6OgD0ITCECiBCLGA6HoLAUACW4DD4uLaMzCwA8h5OgiLiYAA06jAcMFC4iCwgHvBIMAA+1bX1jcaBOug6MDAKLFD8CmAwPDDJDPad6jpaQA
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Needs InvestigationThis issue needs a team member to investigate its status.https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Needs%20Investigation%22
on Nov 27, 2023https://github.com/microsoft/TypeScript/issues/56536#event-11076657949
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Ron Buckton (rbuckton)https://github.com/rbuckton
on Nov 27, 2023https://github.com/microsoft/TypeScript/issues/56536#event-11076659312
Andrew Branch (andrewbranch)https://github.com/andrewbranch
TypeScript 5.4.0https://github.com/microsoft/TypeScript/milestone/193
on Nov 27, 2023https://github.com/microsoft/TypeScript/issues/56536#event-11076660722
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Fix AvailableA PR has been opened for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fix%20Available%22
on Mar 1, 2024https://github.com/microsoft/TypeScript/issues/56536#event-11984405382
Ron Buckton (rbuckton)https://github.com/rbuckton
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#57602https://github.com/microsoft/TypeScript/pull/57602
on Mar 2, 2024https://github.com/microsoft/TypeScript/issues/56536#event-11985431284
Abram Sanderson (Abe27342)https://github.com/Abe27342
on Jul 16, 2024https://github.com/microsoft/TypeScript/issues/56536#event-13527054719
Expose .is() typeguard on SharedObjectKind (#21850)https://github.com/microsoft/FluidFramework/commit/6bdec1ac07d6f95ef2fbcbd66c12bf0dc53de1ad
#21850https://github.com/microsoft/FluidFramework/pull/21850
6bdec1ahttps://github.com/microsoft/FluidFramework/commit/6bdec1ac07d6f95ef2fbcbd66c12bf0dc53de1ad
Ron Buckton (rbuckton)https://github.com/rbuckton
Needs InvestigationThis issue needs a team member to investigate its status.https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Needs%20Investigation%22
on Oct 22, 2024https://github.com/microsoft/TypeScript/issues/56536#event-14787769182
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/56536
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/56536
Ron Buckton (rbuckton)https://github.com/rbuckton
Fix AvailableA PR has been opened for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fix%20Available%22
TypeScript 5.4.0https://github.com/microsoft/TypeScript/milestone/193
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.