Title: Design Meeting Notes, 11/1/2023 · Issue #56359 · microsoft/TypeScript · GitHub
Open Graph Title: Design Meeting Notes, 11/1/2023 · Issue #56359 · microsoft/TypeScript
X Title: Design Meeting Notes, 11/1/2023 · Issue #56359 · microsoft/TypeScript
Description: Parentheses Changes Result of Conditional Type #56270 #56271 If you parenthesize the right side of the extends clause in a conditional type, it changes distributivity. Tools like Prettier assume parentheses are purely stylistic unless it...
Open Graph Description: Parentheses Changes Result of Conditional Type #56270 #56271 If you parenthesize the right side of the extends clause in a conditional type, it changes distributivity. Tools like Prettier assume pa...
X Description: Parentheses Changes Result of Conditional Type #56270 #56271 If you parenthesize the right side of the extends clause in a conditional type, it changes distributivity. Tools like Prettier assume pa...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/56359
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Design Meeting Notes, 11/1/2023","articleBody":"# Parentheses Changes Result of Conditional Type\r\n\r\nhttps://github.com/microsoft/TypeScript/issues/56270\r\n \r\nhttps://github.com/microsoft/TypeScript/pull/56271\r\n\r\n* If you parenthesize the right side of the `extends` clause in a conditional type, it changes distributivity.\r\n* Tools like Prettier assume parentheses are purely stylistic unless it's meant to enforce precedence. They will remove them, which can change the meaning.\r\n* Claimed this was intentional; however, our docs only mention using `[]` to avoid distributivity.\r\n* Bracketing just falls out of the general rules of \"distributivity only happens on naked type variables\".\r\n * We added an optimization for `[]`, but parentheses were affected.\r\n * That seems unrelated!\r\n* Can we just get a more minimal repro?\r\n * Hard to get, need to work on this.\r\n* Let's recategorize as a bug, discuss further to ensure we're all on the same page.\r\n\r\n# Ambient module declarations for import assertions\r\n\r\nhttps://github.com/microsoft/TypeScript/issues/46135\r\n\r\n```ts\r\nimport styles from \"./styles.css\" with { type: \"css\" };\r\n\r\ndocument.adoptedStyleSheets = [...document.adoptedStyleSheets, styles];\r\n```\r\n\r\n* Browsers have either shipped or indicate positive support for this feature.\r\n* What is it? Basically want to be able to import assets like `css` files and bring them in as default imports in the form of `CSSStyleSheet` objects.\r\n* How do you convince TypeScript of this?\r\n* Maybe something like:\r\n\r\n ```ts\r\n declare module \"*\" with { type: \"css\" } {\r\n declare const _default: CSSStyleSheet;\r\n export default _default;\r\n }\r\n ```\r\n* How does this work with merging? Multiple declarations? Fallbacks?\r\n* Maybe there needs to be a lookup strategy.\r\n\r\n ```ts\r\n // globals.d.ts\r\n // No import attributes\r\n declare module \"*.css\" {\r\n declare const _default: CSSStyleSheet;\r\n export default _default;\r\n }\r\n\r\n // ...\r\n\r\n // Some modules\r\n // Has import attributes\r\n import styles from \"./styles.css\" with { type: \"css\" };\r\n ```\r\n* In other words, do\r\n\r\n ```ts\r\n import styles from \"./styles.css\" with { type: \"css\" };\r\n ```\r\n\r\n and\r\n \r\n ```ts\r\n import styles from \"./styles.css\";\r\n ```\r\n\r\n both resolve to the following declaration?\r\n\r\n ```ts\r\n declare module \"*.css\" {\r\n declare const _default: CSSStyleSheet;\r\n export default _default;\r\n }\r\n ```\r\n* Why can't you get away with just always using a `*.css` pattern?\r\n * Bundlers and browsers decide on different behavior - or rather, bundlers decide differently.\r\n* Stepping back, pattern ambient modules really mask over everything. Kind of heavy-handed. You *do* want TypeScript to resolve the `.css` file on disk and validate that it's there, right? Usually?\r\n* Want to express \"what is my bundler going to do here?\", and sometimes it is not best-served by what's in an ambient module, but rather what's on disk.\r\n * You can express that with `.d.css.ts` files under some settings.\r\n* What about something like\r\n\r\n ```ts\r\n declare with { type: \"css\" } {\r\n declare const _default: CSSStyleSheet;\r\n export default _default;\r\n }\r\n ```\r\n * Doesn't permit arbitrary paths for `*.css` imports, but does provide a well-understood shape.\r\n* Doesn't this need a special resolution mode?\r\n* How does this affect emit?\r\n * We don't emit `.json` files.\r\n * So we wouldn't copy over `.css` files from source?\r\n * No?\r\n * That's weird.\r\n * Mismatch between runtime and build time.\r\n * What about `.d.css.ts` generation?\r\n* How do `.json` imports work at all today?\r\n * Do people rarely do it?\r\n * If it's not a problem for JSON, is it not a problem for CSS?\r\n* Wait, we *do* copy JSON to outputs?\r\n * We coulda sworn we didn't...\r\n * Well we re-emit the JSON, it's not a naive copy.\r\n * We just don't overwrite the JSON if there's no `outDir`.\r\n* We do want a bit more context on how this should work in a larger project.\r\n * Maybe Justin in the original issue can give context (at least in the context of maybe lit)?\r\n* Conclusions?\r\n * Revisit real resolution/emit for certain file types, plus import attribute-y ambient modules\r\n\r\n ```ts\r\n declare with { type: \"css\" } {\r\n declare const _default: CSSStyleSheet;\r\n export default _default;\r\n }\r\n ```\r\n * Want to understand the full breadth of motivations","author":{"url":"https://github.com/DanielRosenwasser","@type":"Person","name":"DanielRosenwasser"},"datePublished":"2023-11-10T01:04:33Z","url":"https://github.com/microsoft/TypeScript/issues/56359"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:f53860c8-b6bf-b800-3382-8ca1fd2ecf28 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | ED6C:2C4BED:D01065:109BE7C:6B010203 |
| html-safe-nonce | b1b937f7403262ead144c0396377baec85beffd976223f544b5064ed61f75864 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDZDOjJDNEJFRDpEMDEwNjU6MTA5QkU3Qzo2QjAxMDIwMyIsInZpc2l0b3JfaWQiOiIxNzU5NjgwNjExNTczODkxNTg3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | dc8ae92d3fa438f109bd5efad8c5a54af891ed002fcc095d23efc0e43dc0e284 |
| hovercard-subject-tag | issue:1986656074 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/56359/issue_layout |
| twitter:image | https://opengraph.githubassets.com/93854b3fa62404998074a7b45211a65cb0df2b1754a62e26b922885ac77a472a/microsoft/TypeScript/issues/56359 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/93854b3fa62404998074a7b45211a65cb0df2b1754a62e26b922885ac77a472a/microsoft/TypeScript/issues/56359 |
| og:image:alt | Parentheses Changes Result of Conditional Type #56270 #56271 If you parenthesize the right side of the extends clause in a conditional type, it changes distributivity. Tools like Prettier assume pa... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | DanielRosenwasser |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width