René's URL Explorer Experiment


Title: Design Meeting Notes, 11/1/2023 · Issue #56359 · microsoft/TypeScript · GitHub

Open Graph Title: Design Meeting Notes, 11/1/2023 · Issue #56359 · microsoft/TypeScript

X Title: Design Meeting Notes, 11/1/2023 · Issue #56359 · microsoft/TypeScript

Description: Parentheses Changes Result of Conditional Type #56270 #56271 If you parenthesize the right side of the extends clause in a conditional type, it changes distributivity. Tools like Prettier assume parentheses are purely stylistic unless it...

Open Graph Description: Parentheses Changes Result of Conditional Type #56270 #56271 If you parenthesize the right side of the extends clause in a conditional type, it changes distributivity. Tools like Prettier assume pa...

X Description: Parentheses Changes Result of Conditional Type #56270 #56271 If you parenthesize the right side of the extends clause in a conditional type, it changes distributivity. Tools like Prettier assume pa...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/56359

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Design Meeting Notes, 11/1/2023","articleBody":"# Parentheses Changes Result of Conditional Type\r\n\r\nhttps://github.com/microsoft/TypeScript/issues/56270\r\n \r\nhttps://github.com/microsoft/TypeScript/pull/56271\r\n\r\n* If you parenthesize the right side of the `extends` clause in a conditional type, it changes distributivity.\r\n* Tools like Prettier assume parentheses are purely stylistic unless it's meant to enforce precedence. They will remove them, which can change the meaning.\r\n* Claimed this was intentional; however, our docs only mention using `[]` to avoid distributivity.\r\n* Bracketing just falls out of the general rules of \"distributivity only happens on naked type variables\".\r\n    * We added an optimization for `[]`, but parentheses were affected.\r\n    * That seems unrelated!\r\n* Can we just get a more minimal repro?\r\n    * Hard to get, need to work on this.\r\n* Let's recategorize as a bug, discuss further to ensure we're all on the same page.\r\n\r\n# Ambient module declarations for import assertions\r\n\r\nhttps://github.com/microsoft/TypeScript/issues/46135\r\n\r\n```ts\r\nimport styles from \"./styles.css\" with { type: \"css\" };\r\n\r\ndocument.adoptedStyleSheets = [...document.adoptedStyleSheets, styles];\r\n```\r\n\r\n* Browsers have either shipped or indicate positive support for this feature.\r\n* What is it? Basically want to be able to import assets like `css` files and bring them in as default imports in the form of `CSSStyleSheet` objects.\r\n* How do you convince TypeScript of this?\r\n* Maybe something like:\r\n\r\n  ```ts\r\n  declare module \"*\" with { type: \"css\" } {\r\n      declare const _default: CSSStyleSheet;\r\n      export default _default;\r\n  }\r\n  ```\r\n* How does this work with merging? Multiple declarations? Fallbacks?\r\n* Maybe there needs to be a lookup strategy.\r\n\r\n  ```ts\r\n  // globals.d.ts\r\n  // No import attributes\r\n  declare module \"*.css\" {\r\n      declare const _default: CSSStyleSheet;\r\n      export default _default;\r\n  }\r\n\r\n  // ...\r\n\r\n  // Some modules\r\n  // Has import attributes\r\n  import styles from \"./styles.css\" with { type: \"css\" };\r\n  ```\r\n* In other words, do\r\n\r\n  ```ts\r\n  import styles from \"./styles.css\" with { type: \"css\" };\r\n  ```\r\n\r\n  and\r\n  \r\n  ```ts\r\n  import styles from \"./styles.css\";\r\n  ```\r\n\r\n  both resolve to the following declaration?\r\n\r\n    ```ts\r\n  declare module \"*.css\" {\r\n      declare const _default: CSSStyleSheet;\r\n      export default _default;\r\n  }\r\n  ```\r\n* Why can't you get away with just always using a `*.css` pattern?\r\n    * Bundlers and browsers decide on different behavior - or rather, bundlers decide differently.\r\n* Stepping back, pattern ambient modules really mask over everything. Kind of heavy-handed. You *do* want TypeScript to resolve the `.css` file on disk and validate that it's there, right? Usually?\r\n* Want to express \"what is my bundler going to do here?\", and sometimes it is not best-served by what's in an ambient module, but rather what's on disk.\r\n    * You can express that with `.d.css.ts` files under some settings.\r\n* What about something like\r\n\r\n  ```ts\r\n  declare with { type: \"css\" } {\r\n      declare const _default: CSSStyleSheet;\r\n      export default _default;\r\n  }\r\n  ```\r\n    * Doesn't permit arbitrary paths for `*.css` imports, but does provide a well-understood shape.\r\n* Doesn't this need a special resolution mode?\r\n* How does this affect emit?\r\n    * We don't emit `.json` files.\r\n    * So we wouldn't copy over `.css` files from source?\r\n        * No?\r\n        * That's weird.\r\n        * Mismatch between runtime and build time.\r\n    * What about `.d.css.ts` generation?\r\n* How do `.json` imports work at all today?\r\n    * Do people rarely do it?\r\n    * If it's not a problem for JSON, is it not a problem for CSS?\r\n* Wait, we *do* copy JSON to outputs?\r\n    * We coulda sworn we didn't...\r\n    * Well we re-emit the JSON, it's not a naive copy.\r\n    * We just don't overwrite the JSON if there's no `outDir`.\r\n* We do want a bit more context on how this should work in a larger project.\r\n    * Maybe Justin in the original issue can give context (at least in the context of maybe lit)?\r\n* Conclusions?\r\n    * Revisit real resolution/emit for certain file types, plus import attribute-y ambient modules\r\n\r\n      ```ts\r\n      declare with { type: \"css\" } {\r\n          declare const _default: CSSStyleSheet;\r\n          export default _default;\r\n      }\r\n      ```\r\n    * Want to understand the full breadth of motivations","author":{"url":"https://github.com/DanielRosenwasser","@type":"Person","name":"DanielRosenwasser"},"datePublished":"2023-11-10T01:04:33Z","url":"https://github.com/microsoft/TypeScript/issues/56359"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:f53860c8-b6bf-b800-3382-8ca1fd2ecf28
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idED6C:2C4BED:D01065:109BE7C:6B010203
html-safe-nonceb1b937f7403262ead144c0396377baec85beffd976223f544b5064ed61f75864
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDZDOjJDNEJFRDpEMDEwNjU6MTA5QkU3Qzo2QjAxMDIwMyIsInZpc2l0b3JfaWQiOiIxNzU5NjgwNjExNTczODkxNTg3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacdc8ae92d3fa438f109bd5efad8c5a54af891ed002fcc095d23efc0e43dc0e284
hovercard-subject-tagissue:1986656074
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/56359/issue_layout
twitter:imagehttps://opengraph.githubassets.com/93854b3fa62404998074a7b45211a65cb0df2b1754a62e26b922885ac77a472a/microsoft/TypeScript/issues/56359
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/93854b3fa62404998074a7b45211a65cb0df2b1754a62e26b922885ac77a472a/microsoft/TypeScript/issues/56359
og:image:altParentheses Changes Result of Conditional Type #56270 #56271 If you parenthesize the right side of the extends clause in a conditional type, it changes distributivity. Tools like Prettier assume pa...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameDanielRosenwasser
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/56359#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F56359
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F56359
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/56359
Reloadhttps://github.com/microsoft/TypeScript/issues/56359
Reloadhttps://github.com/microsoft/TypeScript/issues/56359
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/56359
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/56359
Design Meeting Notes, 11/1/2023https://github.com/microsoft/TypeScript/issues/56359#top
Design NotesNotes from our design meetingshttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Design%20Notes%22
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
on Nov 10, 2023https://github.com/microsoft/TypeScript/issues/56359#issue-1986656074
#56270https://github.com/microsoft/TypeScript/issues/56270
#56271https://github.com/microsoft/TypeScript/pull/56271
#46135https://github.com/microsoft/TypeScript/issues/46135
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Design NotesNotes from our design meetingshttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Design%20Notes%22
on Nov 10, 2023https://github.com/microsoft/TypeScript/issues/56359#event-10919532852
https://github.com/bivens-dev
mdh (bivens-dev)https://github.com/bivens-dev
on Nov 12, 2023https://github.com/microsoft/TypeScript/issues/56359#issuecomment-1807056172
Justin Fagnani (@justinfagnani)https://github.com/justinfagnani
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Mar 15, 2024https://github.com/microsoft/TypeScript/issues/56359#event-12134171580
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/56359
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/56359
Design NotesNotes from our design meetingshttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Design%20Notes%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.