Title: Typescript development problem: Is specialized knowledge required to solve fourslash errors? · Issue #56283 · microsoft/TypeScript · GitHub
Open Graph Title: Typescript development problem: Is specialized knowledge required to solve fourslash errors? · Issue #56283 · microsoft/TypeScript
X Title: Typescript development problem: Is specialized knowledge required to solve fourslash errors? · Issue #56283 · microsoft/TypeScript
Description: Acknowledgement I acknowledge that issues using this template may be closed without further explanation at the maintainer's discretion. Comment I have a pull #56281 which involves changing src/lib/rs5.d.ts. I think because it changes tha...
Open Graph Description: Acknowledgement I acknowledge that issues using this template may be closed without further explanation at the maintainer's discretion. Comment I have a pull #56281 which involves changing src/lib/...
X Description: Acknowledgement I acknowledge that issues using this template may be closed without further explanation at the maintainer's discretion. Comment I have a pull #56281 which involves changing src/...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/56283
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Typescript development problem: Is specialized knowledge required to solve fourslash errors?","articleBody":"### Acknowledgement\n\n- [X] I acknowledge that issues using this template may be closed without further explanation at the maintainer's discretion.\n\n### Comment\n\nI have a pull #56281 which involves changing `src/lib/rs5.d.ts`.\r\nI think because it changes that file, there are a few fourslash errors similar to this one:\r\n```\r\n fourslash tests\r\n tests/cases/fourslash/completionListInTypeParameterOfClassExpression1.ts\r\n fourslash test completionListInTypeParameterOfClassExpression1.ts runs correctly:\r\n AssertionError: At marker \"4\": expected [ 'D', 'any', 'Array', …(138) ] to deeply equal [ 'D', 'any', 'Array', …(137) ]\r\n at _TestState.verifyCompletionsAreExactly (src/harness/fourslashImpl.ts:1213:16)\r\n at _TestState.verifyCompletionsWorker (src/harness/fourslashImpl.ts:1074:18)\r\n at _TestState.verifyCompletions (src/harness/fourslashImpl.ts:1009:25)\r\n at Verify.completions (src/harness/fourslashInterfaceImpl.ts:251:31)\r\n at eval (completionListInTypeParameterOfClassExpression1.js:8:8)\r\n at runCode (src/harness/fourslashImpl.ts:4607:9)\r\n at runFourSlashTestContent (src/harness/fourslashImpl.ts:4565:5)\r\n at runFourSlashTest (src/harness/fourslashImpl.ts:4548:5)\r\n at Context.\u003canonymous> (src/testRunner/fourslashRunner.ts:60:39)\r\n at processImmediate (node:internal/timers:478:21)\r\n```\r\nThey don't go away after `hereby baseline-accept`.\r\nDoes this require changing the LKG?\r\nOtherwise, how to inspect the differences and modify the baseline?\r\n","author":{"url":"https://github.com/craigphicks","@type":"Person","name":"craigphicks"},"datePublished":"2023-11-01T07:22:57Z","url":"https://github.com/microsoft/TypeScript/issues/56283"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:cbc1b74f-daf0-ebd2-ad80-c13c42f57a3d |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | CB50:2454CC:7CC826:A06009:6B00E7A7 |
| html-safe-nonce | ed3ef8c405401bab061d578661f1cf3cea383b146c043f79afcd49627fe844f8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQjUwOjI0NTRDQzo3Q0M4MjY6QTA2MDA5OjZCMDBFN0E3IiwidmlzaXRvcl9pZCI6IjU5NTM4NzY3NTYzNTUxNDc2ODciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 90c279a3c806fa48929321497e39dd89895306e5c98ef4b6ba11c658cb83fffc |
| hovercard-subject-tag | issue:1971845540 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/56283/issue_layout |
| twitter:image | https://opengraph.githubassets.com/e5d2390a2435349cfa3836a4a84ecfdeeeb39e85299ef19afb37b0a69e865717/microsoft/TypeScript/issues/56283 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e5d2390a2435349cfa3836a4a84ecfdeeeb39e85299ef19afb37b0a69e865717/microsoft/TypeScript/issues/56283 |
| og:image:alt | Acknowledgement I acknowledge that issues using this template may be closed without further explanation at the maintainer's discretion. Comment I have a pull #56281 which involves changing src/lib/... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | craigphicks |
| hostname | github.com |
| expected-hostname | github.com |
| None | 27088b6977484d0d3321d9a11c907c6d6637b315cfa359ef7952dbf6292f9b14 |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 624179fb8b88d26ba5bba08894eb60a1c5a1d93d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width