René's URL Explorer Experiment


Title: Design Meeting Notes, 9/15/2023 · Issue #55754 · microsoft/TypeScript · GitHub

Open Graph Title: Design Meeting Notes, 9/15/2023 · Issue #55754 · microsoft/TypeScript

X Title: Design Meeting Notes, 9/15/2023 · Issue #55754 · microsoft/TypeScript

Description: API for Skipping JSDoc #55739 (background is #52921) #52921 made it so that tsc can skip JSDoc so that fewer nodes need to be allocated. Nice reduction in memory use + allocation/GC time! Prettier and typescript-eslint care about comment...

Open Graph Description: API for Skipping JSDoc #55739 (background is #52921) #52921 made it so that tsc can skip JSDoc so that fewer nodes need to be allocated. Nice reduction in memory use + allocation/GC time! Prettier ...

X Description: API for Skipping JSDoc #55739 (background is #52921) #52921 made it so that tsc can skip JSDoc so that fewer nodes need to be allocated. Nice reduction in memory use + allocation/GC time! Prettier ...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/55754

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Design Meeting Notes, 9/15/2023","articleBody":"# API for Skipping JSDoc\r\n\r\n#55739\r\n\r\n(background is #52921)\r\n\r\n* #52921 made it so that `tsc` can skip JSDoc so that fewer nodes need to be allocated.\r\n    * Nice reduction in memory use + allocation/GC time!\r\n* Prettier and typescript-eslint care about comments, but they don't care about how TypeScript's parser populated comments.\r\n* In #55739, the proposal is to add a flag so that other 3rd party tools can call into `createSourceFile` while also skipping JSDoc nodes.\r\n* The downside is that it's more API surface area.\r\n* ESLint already has something similar to say whether or not to bother parsing comments.\r\n* 3 new modes:\r\n    * Skip-all\r\n    * Keep-all\r\n    * Keep *semantic only*.\r\n        * What is a semantic comment?\r\n        * Comments that contain `@see` or `@link`, or any comment outside of TS/TSX.\r\n        * Not \"safe\" to use in the services layer where you want quick info to display JSDOc and whatnot.\r\n* Could we do JSDoc population lazily?\r\n    * Complicated by the fact that JSDoc checking really expects the comments to be around for JS files.\r\n    * Probably best to keep it consistent for now.\r\n* Still a good improvement overall, excited to make 3rd party tools faster too.\r\n* Want to still bikeshed the name.\r\n\r\n# Enabling Implementations of Functions with Overloads and Conditional Return Types\r\n\r\nhttps://github.com/microsoft/TypeScript/issues/33014\r\nhttps://github.com/microsoft/TypeScript/issues/33912\r\n\r\nImagine (from our handbook)\r\n\r\n```js\r\n/**\r\n * @param idOrName {string | number}\r\n */\r\nfunction createLabel(idOrName) {\r\n    if (typeof idOrName === \"number\") {\r\n        return { id: idOrName };\r\n    }\r\n    return { name: idOrName };\r\n}\r\n```\r\n\r\n* Could do overloads\r\n\r\n  ```ts\r\n  function createLabel(id: number): LabelWithId;\r\n  function createLabel(name: string): LabelWithName;\r\n  function createLabel(isOrName: string | number): LabelWithId | LabelWithName;\r\n  function createLabel(isOrName: string | number): LabelWithId | LabelWithName {\r\n      // ...\r\n  }\r\n  ```\r\n    * But no checking that the overloads themselves correspond to the implementation.\r\n    * Can implement this incorrectly.\r\n* Conditional types can describe what will happen - but today you cannot usually assign to them without a type assertion/cast.\r\n    * When you introduce a cast, you are very likely to still make a mistake.\r\n    * Also very verbose - you have to rename the casted type over and over again between the declared return type and each `return` expression.\r\n* Easy to get this stuff wrong.\r\n* So do we have agree we should fix this? \r\n    * And if so, which? Overloads or conditional types?\r\n    * Would love to have both. If we had to pick one, conditional types because overloads don't play well with unions etc.\r\n* Have a prototype working for conditional types - can't cover every case, requires distributive conditional and the like.\r\n* There's also a question of type soundness - conditional types aren't quite sound.\r\n    * Still, today the workaround is to blast a wall instead of sneaking in through the air vent.\r\n","author":{"url":"https://github.com/DanielRosenwasser","@type":"Person","name":"DanielRosenwasser"},"datePublished":"2023-09-15T18:52:42Z","url":"https://github.com/microsoft/TypeScript/issues/55754"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:9897ab35-d177-a70e-4757-6d30b2a57e13
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id80B4:EDA7A:101E0D9:1486560:6B0112B0
html-safe-nonce615f4066d961d72e9f54d4378546b35c1ea96598362c88f5c697041acd9bddb0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MEI0OkVEQTdBOjEwMUUwRDk6MTQ4NjU2MDo2QjAxMTJCMCIsInZpc2l0b3JfaWQiOiI3NDMxMjMzNzA4MTgwNDQzODI0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac37a4f704f9b72b2f7e75a8e80a85f6c40dca57f19eebc40f741e7d2f27c52619
hovercard-subject-tagissue:1898922274
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/55754/issue_layout
twitter:imagehttps://opengraph.githubassets.com/c143ff9a6666d9f96da55a06662e1db7ee8d7ab22e5ab10816e1d83d1044ac54/microsoft/TypeScript/issues/55754
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c143ff9a6666d9f96da55a06662e1db7ee8d7ab22e5ab10816e1d83d1044ac54/microsoft/TypeScript/issues/55754
og:image:altAPI for Skipping JSDoc #55739 (background is #52921) #52921 made it so that tsc can skip JSDoc so that fewer nodes need to be allocated. Nice reduction in memory use + allocation/GC time! Prettier ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameDanielRosenwasser
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/55754#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F55754
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F55754
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/55754
Reloadhttps://github.com/microsoft/TypeScript/issues/55754
Reloadhttps://github.com/microsoft/TypeScript/issues/55754
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests310 (310)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/55754
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/55754
Design Meeting Notes, 9/15/2023https://github.com/microsoft/TypeScript/issues/55754#top
Design NotesNotes from our design meetingshttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Design%20Notes%22
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
on Sep 15, 2023https://github.com/microsoft/TypeScript/issues/55754#issue-1898922274
#55739https://github.com/microsoft/TypeScript/pull/55739
#52921https://github.com/microsoft/TypeScript/pull/52921
Skip parsing JSDoc when not needed #52921https://github.com/microsoft/TypeScript/pull/52921
Make JSDoc skipping public, plus more configurable #55739https://github.com/microsoft/TypeScript/pull/55739
#33014https://github.com/microsoft/TypeScript/issues/33014
#33912https://github.com/microsoft/TypeScript/issues/33912
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Design NotesNotes from our design meetingshttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Design%20Notes%22
on Sep 15, 2023https://github.com/microsoft/TypeScript/issues/55754#event-10386527891
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Oct 26, 2023https://github.com/microsoft/TypeScript/issues/55754#event-10782466896
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/55754
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/55754
Design NotesNotes from our design meetingshttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Design%20Notes%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.