René's URL Explorer Experiment


Title: Design Meeting Notes, 9/8/2023 · Issue #55689 · microsoft/TypeScript · GitHub

Open Graph Title: Design Meeting Notes, 9/8/2023 · Issue #55689 · microsoft/TypeScript

X Title: Design Meeting Notes, 9/8/2023 · Issue #55689 · microsoft/TypeScript

Description: Recognizing Symbol.hasInstance in instanceof Narrowing #55052 Previous discussion at #55325 TypeScript currently doesn't recognize anything about Symbol.hasInstance when performing an instanceof. PR considers [Symbol.hasInstance]-declare...

Open Graph Description: Recognizing Symbol.hasInstance in instanceof Narrowing #55052 Previous discussion at #55325 TypeScript currently doesn't recognize anything about Symbol.hasInstance when performing an instanceof. P...

X Description: Recognizing Symbol.hasInstance in instanceof Narrowing #55052 Previous discussion at #55325 TypeScript currently doesn't recognize anything about Symbol.hasInstance when performing an instanceo...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/55689

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Design Meeting Notes, 9/8/2023","articleBody":"# Recognizing `Symbol.hasInstance` in `instanceof` Narrowing\r\n\r\nhttps://github.com/microsoft/TypeScript/pull/55052\r\n\r\n* Previous discussion at https://github.com/microsoft/TypeScript/issues/55325\r\n* TypeScript currently doesn't recognize anything about `Symbol.hasInstance` when performing an `instanceof`.\r\n* PR considers `[Symbol.hasInstance]`-declared methods that are declared as type guards.\r\n* When you do this, it changes narrowing very slightly.\r\n    * Kind of merges the behavior of type predicates narrowing and narrowing via derivedness checks.\r\n    * Specific exceptions regarding `any`.\r\n* Seems okay, just needs review.\r\n\r\n# Improve portability of resolution-mode assertions automatically emitted in `nodenext`\r\n\r\nhttps://github.com/microsoft/TypeScript/issues/55579\r\n\r\n* Now seeing `/// \u003creference types=\"...\" />` directives getting generated with `resolution-mode=\"require\"` in declaration emit.\r\n* Not everyone is using the same TS version, resolution options.\r\n* Need to either make TS more lenient or generate these resolution-mode attributes appear less-often.\r\n* TypeScript will generate these `/// \u003creference types />` directives to ensure broader compatibility for consumers.\r\n* When TypeScript encounters `/// \u003creference types=\"chai\" />` from an ES module, we try to do an import to `chai`, not find a `.` export in `chai`'s `package.json`, and fall back to the CommonJS types anyway.\r\n* Could we just support `resolution-mode` regardless of any settings?\r\n    * Probably, and could even for `import type`.\r\n* Very weird that the `types` compiler option doesn't support this.\r\n\r\n# Tracking Recursion Identity of Homomorphic Mapped Types Based On Their Target Symbol\r\n\r\nhttps://github.com/microsoft/TypeScript/pull/55638\r\n\r\n```ts\r\ntype Id\u003cT> = { [K in keyof T]: Id\u003cT[K]> };\r\n\r\ntype Foo1 = Id\u003c{ x: { y: { z: { a: { b: { c: number } } } } } }>;\r\ntype Foo2 = Id\u003c{ x: { y: { z: { a: { b: { c: string } } } } } }>;\r\n\r\ndeclare const foo1: Foo1;\r\nconst foo2: Foo2 = foo1;  // Errors with PR, previously didn't.\r\n```\r\n\r\n* When tracking if `Foo2` is compatible with `Foo1`, we would say \"We saw `Id\u003c*Something*>` too many times\".\r\n    * This was based on using the identity of `Id` itself when tracking recursive instantiation.\r\n* Now, if `*Something*` is a type with a symbol, we use that as the identity.\r\n* Breaks the raphael package on DefinitelyTyped. Can be fixed with `in out`.\r\n    * Alternative fix is for these mapped types to be broken up into named types.\r\n* How does this work for nested mapped types?\r\n\r\n  ```ts\r\n  type Expand\u003cT> = {\r\n    [K in keyof T]: Expand\u003cExpand\u003cT[K]>>\r\n  };\r\n  ```\r\n    * We drill through to find the identity.\r\n    * Need a test case.\r\n* Technically you can still hit issues between non-identical mapped types.\r\n\r\n# Enabling `fetch` in Node.js\r\n\r\nhttps://github.com/DefinitelyTyped/DefinitelyTyped/issues/60924\r\n\r\n* The DOM has a global `fetch` function and a few related global classes.\r\n* As of Node 20, Node.js has a compatible global `fetch`.\r\n* They're compatible, but not *identical*.\r\n* This is a problem because a lot of users with front-end projects accidentically end up including Node's types - either via misconfiguration or a \"rogue\" package in `node_modules`.\r\n* Two solutions.\r\n    * One is through a level of indirection where the global types extend aliases from Unici. They are conditionally extended from Undici based on whether the global scope includes some amount of information from the DOM.\r\n        * Downside: hard dependency on Undici, which is fairly large as a package. 1MB because it doesn't just include types. Have to worry about versioning.\r\n        * Technically, Undici is shipped within Node.js, but only kinda exposed. Similarly, `fs.rm` is actually rimraf under the hood. (!)\r\n    * Alternatively, duplicate all the contents of `fetch`. About 600 lines, so not small.\r\n","author":{"url":"https://github.com/DanielRosenwasser","@type":"Person","name":"DanielRosenwasser"},"datePublished":"2023-09-08T19:15:38Z","url":"https://github.com/microsoft/TypeScript/issues/55689"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:8cd794d1-f85d-19cb-76f0-9d06f15dd577
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA132:E9D16:1F42972:279FA14:6B01A219
html-safe-nonceb8e20de42864d2ac40ad64c6c42c43ff29cf81a7a7c8d20f74f051920f6ec656
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTMyOkU5RDE2OjFGNDI5NzI6Mjc5RkExNDo2QjAxQTIxOSIsInZpc2l0b3JfaWQiOiIyMzEyODkzMTIxNDkzNDg4ODkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9732366bb29f75fe3e51b1929267721c685765164621f1f7e36b0a5db1708ce2
hovercard-subject-tagissue:1888194766
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/55689/issue_layout
twitter:imagehttps://opengraph.githubassets.com/dd184ebf2cd6d5bf3da7d2689b61118dbe8e102e84bbf19e52842f55f64b4c23/microsoft/TypeScript/issues/55689
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/dd184ebf2cd6d5bf3da7d2689b61118dbe8e102e84bbf19e52842f55f64b4c23/microsoft/TypeScript/issues/55689
og:image:altRecognizing Symbol.hasInstance in instanceof Narrowing #55052 Previous discussion at #55325 TypeScript currently doesn't recognize anything about Symbol.hasInstance when performing an instanceof. P...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameDanielRosenwasser
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/55689#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F55689
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F55689
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/55689
Reloadhttps://github.com/microsoft/TypeScript/issues/55689
Reloadhttps://github.com/microsoft/TypeScript/issues/55689
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/55689
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/55689
Design Meeting Notes, 9/8/2023https://github.com/microsoft/TypeScript/issues/55689#top
Design NotesNotes from our design meetingshttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Design%20Notes%22
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
on Sep 8, 2023https://github.com/microsoft/TypeScript/issues/55689#issue-1888194766
#55052https://github.com/microsoft/TypeScript/pull/55052
Design Meeting Notes, 8/9/2023 #55325https://github.com/microsoft/TypeScript/issues/55325
#55579https://github.com/microsoft/TypeScript/issues/55579
#55638https://github.com/microsoft/TypeScript/pull/55638
DefinitelyTyped/DefinitelyTyped#60924https://github.com/DefinitelyTyped/DefinitelyTyped/issues/60924
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Design NotesNotes from our design meetingshttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Design%20Notes%22
on Sep 8, 2023https://github.com/microsoft/TypeScript/issues/55689#event-10321428605
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
on Sep 8, 2023https://github.com/microsoft/TypeScript/issues/55689#issuecomment-1712119060
Wesley Wigham (@weswigham)https://github.com/weswigham
https://github.com/thw0rted
James Bromwell (thw0rted)https://github.com/thw0rted
on Sep 11, 2023https://github.com/microsoft/TypeScript/issues/55689#issuecomment-1714262055
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Oct 26, 2023https://github.com/microsoft/TypeScript/issues/55689#event-10782466820
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/55689
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/55689
Design NotesNotes from our design meetingshttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Design%20Notes%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.