René's URL Explorer Experiment


Title: Investigate making JSDoc parsing lazier and more optimal · Issue #52959 · microsoft/TypeScript · GitHub

Open Graph Title: Investigate making JSDoc parsing lazier and more optimal · Issue #52959 · microsoft/TypeScript

X Title: Investigate making JSDoc parsing lazier and more optimal · Issue #52959 · microsoft/TypeScript

Description: Not parsing JSDoc seems to unlock significant parsing wins. Surprisingly, we parse JSDoc unconditionally, even in .ts files for batch compilation. So there are a few things I want to investigate here: Can we optimize JSDoc parsing itself...

Open Graph Description: Not parsing JSDoc seems to unlock significant parsing wins. Surprisingly, we parse JSDoc unconditionally, even in .ts files for batch compilation. So there are a few things I want to investigate he...

X Description: Not parsing JSDoc seems to unlock significant parsing wins. Surprisingly, we parse JSDoc unconditionally, even in .ts files for batch compilation. So there are a few things I want to investigate he...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/52959

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Investigate making JSDoc parsing lazier and more optimal","articleBody":"[Not parsing JSDoc seems to unlock **significant** parsing wins.](https://github.com/microsoft/TypeScript/pull/52466#issuecomment-1407035947)\r\n\r\nSurprisingly, we parse JSDoc unconditionally, even in `.ts` files for batch compilation.\r\n\r\nSo there are a few things I want to investigate here:\r\n\r\n1. Can we optimize JSDoc parsing itself? Why is JSDoc parsing so slow in the first place? Even if we decided to always parse JSDoc comments, it should be fast because full time-to-interactivity in the language service is bottle-necked on parse time.\r\n\r\n   My naive theory is that JSDoc scanning today is \"chatty\", returning uninteresting tokens, making every request for the next token unnecessarily slow. But of course, this is without benchmarking. I would love to understand what exactly is the issue here.\r\n2. If it's not strictly required, can we make JSDoc parse in a lazier or optional fashion? It seems unavoidable in JavaScript files; but maybe in TypeScript files, JSDoc is only attempted to be attached in cases where we detect that trivia intersects with tag names we're interested in (e.g. `@deprecated`, `@see`, `@link`, maybe more). Maybe we only do this for the language service.","author":{"url":"https://github.com/DanielRosenwasser","@type":"Person","name":"DanielRosenwasser"},"datePublished":"2023-02-25T00:15:57Z","url":"https://github.com/microsoft/TypeScript/issues/52959"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:766bf2c0-3b95-e5a0-413a-b571b3b29d00
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB134:2454CC:ABFBB4:DBDC65:6B00F71B
html-safe-nonce6adf2d0e215b3cae263ef1475c527f176da376a6d91054ffbe3bba7f718729d7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTM0OjI0NTRDQzpBQkZCQjQ6REJEQzY1OjZCMDBGNzFCIiwidmlzaXRvcl9pZCI6IjEyNzkwNDEyMjgxODQyODcwMDMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac960f67e4989e74905d414024e76d5919061ba41919b7427e2757c855a0389b3a
hovercard-subject-tagissue:1599434681
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/52959/issue_layout
twitter:imagehttps://opengraph.githubassets.com/0faa46412bcaa446d46e547e4bd57f856bd0ff819eb10d5217ef00c5f049ca07/microsoft/TypeScript/issues/52959
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0faa46412bcaa446d46e547e4bd57f856bd0ff819eb10d5217ef00c5f049ca07/microsoft/TypeScript/issues/52959
og:image:altNot parsing JSDoc seems to unlock significant parsing wins. Surprisingly, we parse JSDoc unconditionally, even in .ts files for batch compilation. So there are a few things I want to investigate he...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameDanielRosenwasser
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/52959#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F52959
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F52959
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/52959
Reloadhttps://github.com/microsoft/TypeScript/issues/52959
Reloadhttps://github.com/microsoft/TypeScript/issues/52959
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/52959
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/52959
Investigate making JSDoc parsing lazier and more optimalhttps://github.com/microsoft/TypeScript/issues/52959#top
https://github.com/sandersn
https://github.com/jakebailey
Domain: PerformancePerformance relatedhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20Performance%22
ExperimentA fork with an experimental idea which might not make it into masterhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Experiment%22
TypeScript 5.1.0https://github.com/microsoft/TypeScript/milestone/178
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
on Feb 25, 2023https://github.com/microsoft/TypeScript/issues/52959#issue-1599434681
Not parsing JSDoc seems to unlock significant parsing wins.https://github.com/microsoft/TypeScript/pull/52466#issuecomment-1407035947
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
ExperimentA fork with an experimental idea which might not make it into masterhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Experiment%22
Domain: PerformancePerformance relatedhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20Performance%22
on Feb 25, 2023https://github.com/microsoft/TypeScript/issues/52959#event-8606707800
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jake Bailey (jakebailey)https://github.com/jakebailey
on Feb 25, 2023https://github.com/microsoft/TypeScript/issues/52959#event-8606707829
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
TypeScript 5.1.0https://github.com/microsoft/TypeScript/milestone/178
on Feb 25, 2023https://github.com/microsoft/TypeScript/issues/52959#event-8606831224
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
on Feb 27, 2023https://github.com/microsoft/TypeScript/issues/52959#issuecomment-1445554213
https://github.com/bradzacher
Brad Zacher (bradzacher)https://github.com/bradzacher
on Feb 27, 2023https://github.com/microsoft/TypeScript/issues/52959#issuecomment-1447025376
typescript-eslint (@typescript-eslint)https://github.com/typescript-eslint
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
on Feb 27, 2023https://github.com/microsoft/TypeScript/issues/52959#issuecomment-1447036110
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
on Feb 27, 2023https://github.com/microsoft/TypeScript/issues/52959#issuecomment-1447159564
#53007https://github.com/microsoft/TypeScript/pull/53007
https://github.com/bradzacher
Brad Zacher (bradzacher)https://github.com/bradzacher
on Feb 27, 2023https://github.com/microsoft/TypeScript/issues/52959#issuecomment-1447211078
typescript-eslint (@typescript-eslint)https://github.com/typescript-eslint
typescript-eslint (@typescript-eslint)https://github.com/typescript-eslint
TS_ESLINT_PARSE.cpuprofile.ziphttps://github.com/microsoft/TypeScript/files/10844808/TS_ESLINT_PARSE.cpuprofile.zip
https://speedscope.apphttps://speedscope.app
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
on Mar 7, 2023https://github.com/microsoft/TypeScript/issues/52959#issuecomment-1458466295
Save jsdoc comments in string, not array #53048https://github.com/microsoft/TypeScript/pull/53048
Lower jsdoc comment state #53065https://github.com/microsoft/TypeScript/pull/53065
Scan bigger/fewer jsdoc tokens #53081https://github.com/microsoft/TypeScript/pull/53081
Don't slice whitespace in jsdoc parser unless needed #53121https://github.com/microsoft/TypeScript/pull/53121
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
on Sep 13, 2023https://github.com/microsoft/TypeScript/issues/52959#issuecomment-1718422733
#52921https://github.com/microsoft/TypeScript/pull/52921
#55739https://github.com/microsoft/TypeScript/pull/55739
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
on Sep 19, 2023https://github.com/microsoft/TypeScript/issues/52959#issuecomment-1726528055
Jake Bailey (jakebailey)https://github.com/jakebailey
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Sep 19, 2023https://github.com/microsoft/TypeScript/issues/52959#event-10415771937
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/52959
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/52959
Jake Bailey (jakebailey)https://github.com/jakebailey
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Domain: PerformancePerformance relatedhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20Performance%22
ExperimentA fork with an experimental idea which might not make it into masterhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Experiment%22
TypeScript 5.1.0https://github.com/microsoft/TypeScript/milestone/178
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.