René's URL Explorer Experiment


Title: Wrong import suggestion in subpath pattern · Issue #52870 · microsoft/TypeScript · GitHub

Open Graph Title: Wrong import suggestion in subpath pattern · Issue #52870 · microsoft/TypeScript

X Title: Wrong import suggestion in subpath pattern · Issue #52870 · microsoft/TypeScript

Description: Does this issue occur when all extensions are disabled?: Yes VS Code Version: 1.75.1 OS Version: Darwin x64 22.1.0 (MacOS) Steps to Reproduce: Install @neo4j-ndl/react@1.0.0-alpha-fafbc08 Try to import an icon like

Open Graph Description: Does this issue occur when all extensions are disabled?: Yes VS Code Version: 1.75.1 OS Version: Darwin x64 22.1.0 (MacOS) Steps to Reproduce: Install @neo4j-ndl/react@1.0.0-alpha-fafbc08 Try to im...

X Description: Does this issue occur when all extensions are disabled?: Yes VS Code Version: 1.75.1 OS Version: Darwin x64 22.1.0 (MacOS) Steps to Reproduce: Install @neo4j-ndl/react@1.0.0-alpha-fafbc08 Try to im...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/52870

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Wrong import suggestion in subpath pattern","articleBody":"\u003c!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --\u003e\r\n\u003c!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --\u003e\r\n\u003c!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions --\u003e\r\n\u003c!-- 🔎 Search existing issues to avoid creating duplicates. --\u003e\r\n\u003c!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ --\u003e\r\n\u003c!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --\u003e\r\n\u003c!-- 🔧 Launch with `code --disable-extensions` to check. --\u003e\r\nDoes this issue occur when all extensions are disabled?: Yes\r\n\r\n\u003c!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --\u003e\r\n\u003c!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help \u003e Report Issue' dialog can assist with this. --\u003e\r\n- VS Code Version:  1.75.1\r\n- OS Version: Darwin x64 22.1.0 (MacOS)\r\n\r\nSteps to Reproduce:\r\n\r\n1. Install `@neo4j-ndl/react@1.0.0-alpha-fafbc08`\r\n2. Try to import an icon like `\u003cAdjustmentsHorizontalIconSolid /\u003e` in a JSX file.\r\n\r\nThe recommended import path is `@neo4j-ndl/react/lib/types/icons` while the correct based on the `exports` field would be `@neo4j-ndl/react/icons`\r\n\r\nThe modified `package.json` is looking like this:\r\n```json\r\n{\r\n  \"name\": \"@neo4j-ndl/react\",\r\n  \"version\": \"0.17.7\",\r\n  \"sideEffects\": false,\r\n  \"description\": \"React implementation of Neo4j Design System\",\r\n  \"keywords\": [\r\n    \"neo4j\",\r\n    \"react\",\r\n    \"design system\",\r\n    \"needle\",\r\n    \"ndl\"\r\n  ],\r\n  \"author\": \"Neo4j Inc.\",\r\n  \"homepage\": \"\",\r\n  \"license\": \"GPL-3.0\",\r\n  \"main\": \"./lib/cjs/index.js\",\r\n  \"module\": \"./lib/esm/index.js\",\r\n  \"types\": \"./lib/types/index.d.ts\",\r\n  \"exports\": {\r\n    \"./icons\": {\r\n      \"import\": \"./lib/esm/icons/index.js\",\r\n      \"require\": \"./lib/cjs/icons/index.js\",\r\n      \"types\": \"./lib/types/icons/index.d.ts\"\r\n    },\r\n    \".\": {\r\n      \"import\": \"./lib/esm/index.js\",\r\n      \"require\": \"./lib/cjs/index.js\",\r\n      \"types\": \"./lib/types/index.d.ts\"\r\n    }\r\n  },\r\n ...\r\n}\r\n```\r\n\r\nAs a library publishers tried it also with WebStorm to see how it behaves and I can see that there it is imported as expected (video):\r\n\r\n\r\nhttps://user-images.githubusercontent.com/12672541/219434237-a77ee748-c7b3-4995-a083-0690af3d9657.mp4\r\n\r\n\r\nAlso noticed, that if there is one module imported from `@neo4j-ndl/react/icons` then the suggestion works as expected (image): \r\n\u003cimg width=\"675\" alt=\"CleanShot 2023-02-16 at 18 00 20@2x\" src=\"https://user-images.githubusercontent.com/12672541/219435490-ab6b2993-f112-4b2b-8b72-4facbb6e5dc3.png\"\u003e\r\n \r\n","author":{"url":"https://github.com/konsalex","@type":"Person","name":"konsalex"},"datePublished":"2023-02-16T16:57:35.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":6},"url":"https://github.com/52870/TypeScript/issues/52870"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:82946cf7-f58c-c832-ed9a-3f66077a555d
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE1D6:2867:353F992:4994421:6A60DC67
html-safe-nonce3cc0692a1523ff8c0dbc07f580dd40fceae0caede836779574ce52fde81abffa
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMUQ2OjI4Njc6MzUzRjk5Mjo0OTk0NDIxOjZBNjBEQzY3IiwidmlzaXRvcl9pZCI6IjE0MTQxMTM4Njk0MTQwNjMyMDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1b8af10b679184f5e0fd9c8bde8eb29430abb182aabcd6f6ef39477de558eed7
hovercard-subject-tagissue:1592119421
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/52870/issue_layout
twitter:imagehttps://opengraph.githubassets.com/1a10a2201645e3d5158b2bcd0c666dd97393ff2891378c3aa1bc52fcbea32073/microsoft/TypeScript/issues/52870
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1a10a2201645e3d5158b2bcd0c666dd97393ff2891378c3aa1bc52fcbea32073/microsoft/TypeScript/issues/52870
og:image:altDoes this issue occur when all extensions are disabled?: Yes VS Code Version: 1.75.1 OS Version: Darwin x64 22.1.0 (MacOS) Steps to Reproduce: Install @neo4j-ndl/react@1.0.0-alpha-fafbc08 Try to im...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekonsalex
hostnamegithub.com
expected-hostnamegithub.com
None8302bdfafed4cf34ac9c1d3593108fafa53bc3f86b893907e38fa6bdd74361ac
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec3c2ff0c76b34772c83c9498a08cefee28f53da0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/52870#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F52870
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F52870
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/52870
Reloadhttps://github.com/microsoft/TypeScript/issues/52870
Reloadhttps://github.com/microsoft/TypeScript/issues/52870
Please reload this pagehttps://github.com/microsoft/TypeScript/issues/52870
microsoft https://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Notifications https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript
Fork 13.6k https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript
Star 110k https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript
Code https://github.com/microsoft/TypeScript
Issues 5k+ https://github.com/microsoft/TypeScript/issues
Pull requests 30 https://github.com/microsoft/TypeScript/pulls
Actions https://github.com/microsoft/TypeScript/actions
Projects https://github.com/microsoft/TypeScript/projects
Models https://github.com/microsoft/TypeScript/models
Wiki https://github.com/microsoft/TypeScript/wiki
Security and quality 0 https://github.com/microsoft/TypeScript/security
Insights https://github.com/microsoft/TypeScript/pulse
Code https://github.com/microsoft/TypeScript
Issues https://github.com/microsoft/TypeScript/issues
Pull requests https://github.com/microsoft/TypeScript/pulls
Actions https://github.com/microsoft/TypeScript/actions
Projects https://github.com/microsoft/TypeScript/projects
Models https://github.com/microsoft/TypeScript/models
Wiki https://github.com/microsoft/TypeScript/wiki
Security and quality https://github.com/microsoft/TypeScript/security
Insights https://github.com/microsoft/TypeScript/pulse
Wrong import suggestion in subpath patternhttps://github.com/microsoft/TypeScript/issues/52870#top
Needs InvestigationThis issue needs a team member to investigate its status.https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Needs%20Investigation%22
Backloghttps://github.com/microsoft/TypeScript/milestone/29
https://github.com/konsalex
konsalexhttps://github.com/konsalex
on Feb 16, 2023https://github.com/microsoft/TypeScript/issues/52870#issue-1592119421
https://user-images.githubusercontent.com/12672541/219435490-ab6b2993-f112-4b2b-8b72-4facbb6e5dc3.png
Needs InvestigationThis issue needs a team member to investigate its status.https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Needs%20Investigation%22
BacklogNo due datehttps://github.com/microsoft/TypeScript/milestone/29
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.