Title: `instanceof` narrows to `never` on `else` branch for `Function` extending class · Issue #52571 · microsoft/TypeScript · GitHub
Open Graph Title: `instanceof` narrows to `never` on `else` branch for `Function` extending class · Issue #52571 · microsoft/TypeScript
X Title: `instanceof` narrows to `never` on `else` branch for `Function` extending class · Issue #52571 · microsoft/TypeScript
Description: Bug Report 🔎 Search Terms insatnceof extends function 🕗 Version & Regression Information This changed between versions 5.0.0-dev.20221129 and 5.0.0-dev.20221130 ⏯ Playground Link Playground link with relevant code 💻 Code class PersonMixi...
Open Graph Description: Bug Report 🔎 Search Terms insatnceof extends function 🕗 Version & Regression Information This changed between versions 5.0.0-dev.20221129 and 5.0.0-dev.20221130 ⏯ Playground Link Playground link wi...
X Description: Bug Report 🔎 Search Terms insatnceof extends function 🕗 Version & Regression Information This changed between versions 5.0.0-dev.20221129 and 5.0.0-dev.20221130 ⏯ Playground Link Playground lin...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/52571
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`instanceof` narrows to `never` on `else` branch for `Function` extending class","articleBody":"# Bug Report\r\n\r\n\r\n### 🔎 Search Terms\r\n\r\ninsatnceof extends function \r\n\r\n### 🕗 Version & Regression Information\r\n- This changed between versions 5.0.0-dev.20221129 and 5.0.0-dev.20221130\r\n\r\n### ⏯ Playground Link\r\n\r\n[Playground link with relevant code](https://www.typescriptlang.org/play?ts=5.0.0-dev.20230202#code/MYGwhgzhAEAKCmAnCB7AdgWQJYA8tunhwBd40ATGAMQFc1hit1oBvAKGk+gAcaAjEFmDQA2gGUAngFs+KEADoAFpACSaCMTD14AXQAUKAFzQtEgJSsOXa4njEaiAsQnd4KAGbQU0ALx-oAEQofABW8AwB0ABkUV7QAIT+aDQgINGx3vgaWsBungjI6ADcVpwAvtZsZWzA6BrQoDA+0GjwAO5wSKiYuPh6ZiU14FCdhQTs1m0oiADW-cYAbihY5KwNdXLw8iAoAOZ6AVOzARbV1hBgEgASWPPQSytrteqb23sHNyfQ1dWgkDAAYTAiEs50uNzuD1WLHWLxAWx2+wCAHUPNBUe4vj82Gx3HQGEwnPANAZjAVutAAD7QIGICwTLhYTwGaBZTTaNGNemlayw1Dwt5IlQwcnoE4lXlcFmQUbdMzyI5zMw8s5ceAgCDwUGSvmvREHYU04EnHnWFDyC7XW4DaAAeltmRgrQWSFZBAArPIAAzydEy0UEam0t3QAAs8gAnCqqmxSCTWh0A8q48Q9AmjXSgA)\r\n\r\n### 💻 Code\r\n\r\n\u003c!-- Please post the relevant code sample here as well-->\r\n```ts\r\nclass PersonMixin extends Function {\r\n public [Symbol.hasInstance](o: any) {\r\n return typeof o === \"object\" && o !== null && o instanceof Person;\r\n } \r\n}\r\nconst cls = new PersonMixin();\r\n\r\nclass Person {\r\n work(): void { console.log(\"work\") }\r\n sayHi(): void { console.log(\"Hi\") }\r\n}\r\nclass Car {\r\n sayHi(): void { console.log(\"Wof Wof\") }\r\n}\r\n\r\nfunction test(o: Person | Car) {\r\n if (o instanceof cls) {\r\n console.log(\"Is Person\");\r\n (o as Person).work()\r\n }\r\n else {\r\n console.log(\"Is Car\")\r\n o.sayHi(); //o is never in 5.0. Was Person | Car in 4.9\r\n }\r\n}\r\ntest(new Person)\r\ntest(new Car)\r\n```\r\n\r\n### 🙁 Actual behavior\r\n\r\n`o` is `never` on the else branch. causing an error\r\n\r\n### 🙂 Expected behavior\r\n\r\n`o` is `Person | Car` as it was in 4.9 since the type guard doesn't really say a lot about the type of `o` in the type system.\r\n","author":{"url":"https://github.com/dragomirtitian","@type":"Person","name":"dragomirtitian"},"datePublished":"2023-02-02T15:16:22Z","url":"https://github.com/microsoft/TypeScript/issues/52571"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:92dc0eb2-bbea-cc33-b7c7-25f89bbcbace |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9DEA:1F65:1C8FB07:244E256:6B01B451 |
| html-safe-nonce | 299232c95853a377fc20fc74151263f463bb1d956189114a252aa4cd7b8ae230 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5REVBOjFGNjU6MUM4RkIwNzoyNDRFMjU2OjZCMDFCNDUxIiwidmlzaXRvcl9pZCI6IjU2OTA4NjY3ODg5NDI4NTMyMDIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 88e060d72f6a87a13ff6c85f664b87ff468ac7b1722728228e73dad571713c08 |
| hovercard-subject-tag | issue:1568242753 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/52571/issue_layout |
| twitter:image | https://opengraph.githubassets.com/c0f015f92c6e4b87facd57844854453ff2c85177dd2e2e5059692e5c9f859840/microsoft/TypeScript/issues/52571 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c0f015f92c6e4b87facd57844854453ff2c85177dd2e2e5059692e5c9f859840/microsoft/TypeScript/issues/52571 |
| og:image:alt | Bug Report 🔎 Search Terms insatnceof extends function 🕗 Version & Regression Information This changed between versions 5.0.0-dev.20221129 and 5.0.0-dev.20221130 ⏯ Playground Link Playground link wi... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | dragomirtitian |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width