René's URL Explorer Experiment


Title: Performance regression from #48044 · Issue #52345 · microsoft/TypeScript · GitHub

Open Graph Title: Performance regression from #48044 · Issue #52345 · microsoft/TypeScript

X Title: Performance regression from #48044 · Issue #52345 · microsoft/TypeScript

Description: Bug Report It seems like a fairly significant performance regression was introduced in this #48044, which was shipped in TS 4.7. In TS 4.6, it takes ~30 seconds to run yarn tsc in our repo, and the reported strict subtype cache size is 2...

Open Graph Description: Bug Report It seems like a fairly significant performance regression was introduced in this #48044, which was shipped in TS 4.7. In TS 4.6, it takes ~30 seconds to run yarn tsc in our repo, and the...

X Description: Bug Report It seems like a fairly significant performance regression was introduced in this #48044, which was shipped in TS 4.7. In TS 4.6, it takes ~30 seconds to run yarn tsc in our repo, and the...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/52345

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Performance regression from #48044","articleBody":"# Bug Report\r\n\r\nIt seems like a fairly significant performance regression was introduced in this https://github.com/microsoft/TypeScript/pull/48044, which was shipped in TS 4.7. In TS 4.6, it takes ~30 seconds to run `yarn tsc` in our repo, and the reported strict subtype cache size is 24_011. In TS 4.7, it takes 75+ seconds to run `yarn tsc` (~2.5x longer than previous), and the reported strict subtype cache size is 122_778 (~5x larger than previous).\r\n\r\nI verified that it was that specific PR that regressed the performance by taking a locally-installed 4.6.4 and applying the changes from that PR directly.\r\n\r\nAnother symptom is that several types (mostly spreads of objects into others) are now reporting as \"Expression produces a union type that is too complex to represent.\"\r\n\r\n### 🔎 Search Terms\r\n\r\n`Expression produces a union type that is too complex to represent`, `strict subtype cache size`\r\n\r\n### 🕗 Version & Regression Information\r\n\r\n- Regressed in https://github.com/microsoft/TypeScript/pull/48044\r\n- This changed between versions 4.6.4 and 4.7.3\r\n\r\n|Version|Time|Strict Subtype Cache Size|\r\n|-------|-----|--------------------------|\r\n|4.6.4  | 33s | 24011                                  |\r\n|4.7.3  | 75s | 122778                                 |\r\n|4.9.4  | 77s | 122869                                |\r\n|5.0.0-dev.20230120 | 78s | 122869 |\r\n\r\n### 💻 Code\r\n\r\nI haven't been able to narrow down a minimal reproduction of this issue, but if someone points me in the right direction I'm happy to work on it.\r\n\r\n### 🙁 Actual behavior\r\n\r\nRunning `yarn tsc --noEmit --extendedDiagnostics` takes ~75 seconds in our repo, with a Strict subtype cache size of 122778.\r\n\r\n### 🙂 Expected behavior\r\n\r\nRunning `yarn tsc --noEmit --extendedDiagnostics` takes ~30 seconds in our repo, with a Strict subtype cache size of 24011.\r\n\r\n\r\n\r\n\r\n","author":{"url":"https://github.com/epmatsw","@type":"Person","name":"epmatsw"},"datePublished":"2023-01-20T23:19:07Z","url":"https://github.com/microsoft/TypeScript/issues/52345"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:91f908a3-ebab-d300-e7c7-1e486922a915
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8E74:19F84C:E0598F:12079A1:6B00F535
html-safe-nonce67c56a314114257528184eef4a62532615fa63d6e363c322b3019e3c1f51eac2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RTc0OjE5Rjg0QzpFMDU5OEY6MTIwNzlBMTo2QjAwRjUzNSIsInZpc2l0b3JfaWQiOiIzOTQ0MjkyODU0OTYwNTkxODkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca9e587353a47b1af338e7deea9d61c23352f6b1b3c72ec2ab969fec7529475cc
hovercard-subject-tagissue:1551568591
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/52345/issue_layout
twitter:imagehttps://opengraph.githubassets.com/4f4b748ec51e3e5c52520e1ca717b343524abf17d4ebf6477af4f4e31b33f199/microsoft/TypeScript/issues/52345
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4f4b748ec51e3e5c52520e1ca717b343524abf17d4ebf6477af4f4e31b33f199/microsoft/TypeScript/issues/52345
og:image:altBug Report It seems like a fairly significant performance regression was introduced in this #48044, which was shipped in TS 4.7. In TS 4.6, it takes ~30 seconds to run yarn tsc in our repo, and the...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameepmatsw
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/52345#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F52345
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F52345
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/52345
Reloadhttps://github.com/microsoft/TypeScript/issues/52345
Reloadhttps://github.com/microsoft/TypeScript/issues/52345
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests308 (308)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/52345
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/52345
Performance regression from #48044https://github.com/microsoft/TypeScript/issues/52345#top
https://github.com/jakebailey
Domain: PerformancePerformance relatedhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20Performance%22
Needs InvestigationThis issue needs a team member to investigate its status.https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Needs%20Investigation%22
TypeScript 5.1.0https://github.com/microsoft/TypeScript/milestone/178
https://github.com/epmatsw
Will Stamper (epmatsw)https://github.com/epmatsw
on Jan 20, 2023https://github.com/microsoft/TypeScript/issues/52345#issue-1551568591
#48044https://github.com/microsoft/TypeScript/pull/48044
fix(48034): Get a literal string of type intersection in a template literal type #48044https://github.com/microsoft/TypeScript/pull/48044
Nexthttps://github.com/microsoft/TypeScript/issues/52345?timeline_page=1
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
on Jan 21, 2023https://github.com/microsoft/TypeScript/issues/52345#issuecomment-1399110467
https://github.com/microsoft/typescript-analyze-tracehttps://github.com/microsoft/typescript-analyze-trace
usage instructionshttps://github.com/microsoft/typescript-analyze-trace#usage
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Needs InvestigationThis issue needs a team member to investigate its status.https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Needs%20Investigation%22
on Jan 24, 2023https://github.com/microsoft/TypeScript/issues/52345#event-8348272308
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Jake Bailey (jakebailey)https://github.com/jakebailey
on Jan 24, 2023https://github.com/microsoft/TypeScript/issues/52345#event-8348272932
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
on Jan 26, 2023https://github.com/microsoft/TypeScript/issues/52345#issuecomment-1405699170
Will Stamper (@epmatsw)https://github.com/epmatsw
https://github.com/epmatsw
Will Stamper (epmatsw)https://github.com/epmatsw
on Jan 27, 2023https://github.com/microsoft/TypeScript/issues/52345#issuecomment-1405928953
https://github.com/epmatsw
Will Stamper (epmatsw)https://github.com/epmatsw
on Jan 27, 2023https://github.com/microsoft/TypeScript/issues/52345#issuecomment-1407184791
https://github.com/epmatsw
Will Stamper (epmatsw)https://github.com/epmatsw
on Jan 28, 2023https://github.com/microsoft/TypeScript/issues/52345#issuecomment-1407212744
https://github.com/epmatsw
Will Stamper (epmatsw)https://github.com/epmatsw
on Jan 28, 2023https://github.com/microsoft/TypeScript/issues/52345#issuecomment-1407214750
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
on Jan 28, 2023https://github.com/microsoft/TypeScript/issues/52345#issuecomment-1407216732
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
on Feb 16, 2023https://github.com/microsoft/TypeScript/issues/52345#issuecomment-1433660722
#48044https://github.com/microsoft/TypeScript/pull/48044
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
on Feb 18, 2023https://github.com/microsoft/TypeScript/issues/52345#issuecomment-1435493854
Will Stamper (@epmatsw)https://github.com/epmatsw
#52836 (comment)https://github.com/microsoft/TypeScript/pull/52836#issuecomment-1435762197
Jake Bailey (jakebailey)https://github.com/jakebailey
TypeScript 5.1.0https://github.com/microsoft/TypeScript/milestone/178
on Feb 18, 2023https://github.com/microsoft/TypeScript/issues/52345#event-8552436870
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Fix AvailableA PR has been opened for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fix%20Available%22
on Feb 18, 2023https://github.com/microsoft/TypeScript/issues/52345#event-8552438245
https://github.com/epmatsw
Will Stamper (epmatsw)https://github.com/epmatsw
on Feb 21, 2023https://github.com/microsoft/TypeScript/issues/52345#issuecomment-1439228894
https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/146938/artifacts?artifactName=tgz&fileId=E6600AFB90EEF24611686B292C01E0D427A0C8AA2B90E3E4B7E85880B3CF614102&fileName=/typescript-5.0.0-insiders.20230218.tgzhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/146938/artifacts?artifactName=tgz&fileId=E6600AFB90EEF24611686B292C01E0D427A0C8AA2B90E3E4B7E85880B3CF614102&fileName=/typescript-5.0.0-insiders.20230218.tgz
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
on Feb 21, 2023https://github.com/microsoft/TypeScript/issues/52345#issuecomment-1439231070
https://github.com/epmatsw
Will Stamper (epmatsw)https://github.com/epmatsw
on Sep 30, 2023https://github.com/microsoft/TypeScript/issues/52345#issuecomment-1741776429
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
on Sep 30, 2023https://github.com/microsoft/TypeScript/issues/52345#issuecomment-1741785555
https://github.com/epmatsw
Will Stamper (epmatsw)https://github.com/epmatsw
on Sep 30, 2023https://github.com/microsoft/TypeScript/issues/52345#issuecomment-1741788421
https://github.com/epmatsw
Will Stamper (epmatsw)https://github.com/epmatsw
on Sep 30, 2023https://github.com/microsoft/TypeScript/issues/52345#issuecomment-1741788963
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
on Oct 1, 2023https://github.com/microsoft/TypeScript/issues/52345#issuecomment-1741937246
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
TypeScript 5.1.0https://github.com/microsoft/TypeScript/milestone/178
TypeScript 5.3.1https://github.com/microsoft/TypeScript/milestone/194
on Oct 1, 2023https://github.com/microsoft/TypeScript/issues/52345#event-10518784247
https://github.com/epmatsw
Will Stamper (epmatsw)https://github.com/epmatsw
on Oct 2, 2023https://github.com/microsoft/TypeScript/issues/52345#issuecomment-1743730884
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
TypeScript 5.3.1https://github.com/microsoft/TypeScript/milestone/194
TypeScript 5.1.0https://github.com/microsoft/TypeScript/milestone/178
on Oct 2, 2023https://github.com/microsoft/TypeScript/issues/52345#event-10531339166
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
on Oct 12, 2023https://github.com/microsoft/TypeScript/issues/52345#issuecomment-1758876706
#55948https://github.com/microsoft/TypeScript/issues/55948
Jake Bailey (jakebailey)https://github.com/jakebailey
Domain: PerformancePerformance relatedhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20Performance%22
Fix AvailableA PR has been opened for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fix%20Available%22
on Oct 12, 2023https://github.com/microsoft/TypeScript/issues/52345#event-10626483094
https://github.com/epmatsw
Will Stamper (epmatsw)https://github.com/epmatsw
on Oct 12, 2023https://github.com/microsoft/TypeScript/issues/52345#issuecomment-1759987065
Jake Bailey (jakebailey)https://github.com/jakebailey
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Oct 12, 2023https://github.com/microsoft/TypeScript/issues/52345#event-10634258150
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/52345
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/52345
Jake Bailey (jakebailey)https://github.com/jakebailey
Domain: PerformancePerformance relatedhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20Performance%22
Needs InvestigationThis issue needs a team member to investigate its status.https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Needs%20Investigation%22
TypeScript 5.1.0https://github.com/microsoft/TypeScript/milestone/178
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.