Title: Second use of type guard produces different result · Issue #52232 · microsoft/TypeScript · GitHub
Open Graph Title: Second use of type guard produces different result · Issue #52232 · microsoft/TypeScript
X Title: Second use of type guard produces different result · Issue #52232 · microsoft/TypeScript
Description: Bug Report 🔎 Search Terms react child.props unknown ts 18046 reading child prop typescript user defined type guard fails after second time 🕗 Version & Regression Information Upgrading project to 4.9.4 from 4.2.4. This changed between ver...
Open Graph Description: Bug Report 🔎 Search Terms react child.props unknown ts 18046 reading child prop typescript user defined type guard fails after second time 🕗 Version & Regression Information Upgrading project to 4....
X Description: Bug Report 🔎 Search Terms react child.props unknown ts 18046 reading child prop typescript user defined type guard fails after second time 🕗 Version & Regression Information Upgrading project t...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/52232
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Second use of type guard produces different result","articleBody":"# Bug Report\r\n\r\n\u003c!--\r\n Please fill in each section completely. Thank you!\r\n-->\r\n\r\n### 🔎 Search Terms\r\n\r\n\u003c!--\r\n What search terms did you use when trying to find an existing bug report?\r\n List them here so people in the future can find this one more easily.\r\n-->\r\n\r\n`react child.props unknown`\r\n`ts 18046 reading child prop`\r\n`typescript user defined type guard fails after second time`\r\n\r\n### 🕗 Version & Regression Information\r\n\r\nUpgrading project to 4.9.4 from 4.2.4.\r\n\r\n- This changed between versions 4.7 and 4.8.2. I went through until I found where this changed.\r\n\r\n### ⏯ Playground Link\r\n\r\n\u003c!--\r\n A link to a TypeScript Playground \"Share\" link which shows this behavior\r\n\r\n The TypeScript Workbench can be used for more complex setups, try\r\n https://www.typescriptlang.org/dev/bug-workbench/\r\n\r\n As a last resort, you can link to a repo, but these will be slower for us to investigate.\r\n-->\r\n[Playground link with relevant code](https://www.typescriptlang.org/play?#code/FASwtgDg9gTgLgAgEoFMCGBjRAzGUwIDkM6WhA3MMBlAHYDOiGAFiADYAmAgjDGgJ4IAvAgDaAXQRp6U2oOnJScAHSpMcAHJQOKCZWqtOPPv2XZYAUUzMAFC3YdhAPgQBvYAgQ0GTQxxK0worqyiD0AGpobCAcFmwoYCi0cHZ+AJQIAGSZXn7KEHgQ9Mr2nAGUngD0lbkO+YUyYQhQ2Ahw-BAoCABEAK60ANa0UADutN0IKLywyggAkq0jXfQjaBBtrDLRtF0jIHDMHgjVG110XWgARlAAbl37ADSnk9MwCGC3KDJwUM9QB1MENszq0aDpZgB5WhsfhHE4AoEgHYIEbMKa7LokNCOUocepQIoIDhQL4IfZeWAkLAwtodLoIm5RXooZRwmoAWV6bDgIAg8QQWI4MhatU4+MJdGe2BAMEYiORUXovxGsAGCGlO1Znm8coKBIiTK6IjUWFCBuisXiiWSqQcGWyorxeqKykZbGZlAAvml9CcAOp8CAQJEAc2egpkewOzWRGCibDavzCkQtcQSSUQezYCfanQpvBQ1NhuOMAjMlmsts4zjcRxArRsJpUyaiMTT1pSuLSGXcniqNWGLzwsoQaJIR21dDluICQVx4uKM6SFT7OsQzvNzLneQ3rsNK89wG9+hLvDL5hgVhYVccQhcvYpPjJ5piQSbZpTbatGZvPrrDZbC0ewnR9pz8WcRHnXcl1oFdJyfDcUy3SCdwaPd3RQFcTjQbA4EBQVQ2eQDXzdLc0AQehCzoRweUSJ4oIaZ8EDZKQQzQJEEH6IZRloI5PUmNhKLJACXw4YC+1A3wHAgx0FxKcDlxAtcEEQw1tzqXdSMwvijx9IA)\r\n\r\n### 💻 Code\r\n\r\n\u003c!-- Please post the relevant code sample here as well-->\r\n```ts\r\n\r\nimport React from 'react';\r\n\r\nconst childArray = [] as any as React.ReactNode[];\r\n\r\nchildArray.forEach(child => {\r\n const children = React.isValidElement(child) && child.props.children;\r\n // child.props is of type \"unknown\" error. If we swap this line with\r\n // the one above it, the error moves to the other line of code. Only\r\n // the line where we read child.props does it correctly type the value.\r\n // Multiple reads of child.props on the first line also work fine.\r\n const propsValue = React.isValidElement(child) && child.props.value;\r\n});\r\n\r\n// Wrapping the reads with one call to isValidElement will type correctly\r\nchildArray.forEach(child => {\r\n if (React.isValidElement(child)) {\r\n // no errors here\r\n const children = child.props.children;\r\n const propsValue = child.props.value;\r\n }\r\n});\r\n\r\nchildArray.forEach(child => {\r\n const isValid = React.isValidElement(child);\r\n if (isValid) {\r\n const children = child.props.children;\r\n const propsValue = child.props.value;\r\n // after reading the isValid value a second time, child.props is \r\n // again unknown\r\n } else if (isValid) {\r\n const children = child.props.children;\r\n const propsValue = child.props.value;\r\n }\r\n});\r\n```\r\n\r\n### 🙁 Actual behavior\r\n\r\nAll examples fail after the second read of a type guard on `props`, whether re-running the function or just reading the variable.\r\n\r\n### 🙂 Expected behavior\r\n\r\nShould behave consistently no matter if this is the first or second read of the type guard.\r\n","author":{"url":"https://github.com/jasonaden","@type":"Person","name":"jasonaden"},"datePublished":"2023-01-14T00:00:55Z","url":"https://github.com/microsoft/TypeScript/issues/52232"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:2f4a68e9-928e-319a-103d-be11a1e051d4 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A0D2:D0E46:D27937:116FCA2:6B00F954 |
| html-safe-nonce | 09080f7e66ba8fce807f667a51e4459a576ed5cb1673298490c045f1d17a78b6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMEQyOkQwRTQ2OkQyNzkzNzoxMTZGQ0EyOjZCMDBGOTU0IiwidmlzaXRvcl9pZCI6IjY3MjQwMTQ1NjYzMzU5MDQwODQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | cc1393386b8a2ece2f8f59cfe116d14fff69cc65934d17c593de2134966645aa |
| hovercard-subject-tag | issue:1533047089 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/52232/issue_layout |
| twitter:image | https://opengraph.githubassets.com/c4152b38d62a16957b19cbd602cc1672db7b656abb48b93973be371512979514/microsoft/TypeScript/issues/52232 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c4152b38d62a16957b19cbd602cc1672db7b656abb48b93973be371512979514/microsoft/TypeScript/issues/52232 |
| og:image:alt | Bug Report 🔎 Search Terms react child.props unknown ts 18046 reading child prop typescript user defined type guard fails after second time 🕗 Version & Regression Information Upgrading project to 4.... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jasonaden |
| hostname | github.com |
| expected-hostname | github.com |
| None | e208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187 |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7dafd017fb7809a839c443dba08622af38e63c09 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width