René's URL Explorer Experiment


Title: Second use of type guard produces different result · Issue #52232 · microsoft/TypeScript · GitHub

Open Graph Title: Second use of type guard produces different result · Issue #52232 · microsoft/TypeScript

X Title: Second use of type guard produces different result · Issue #52232 · microsoft/TypeScript

Description: Bug Report 🔎 Search Terms react child.props unknown ts 18046 reading child prop typescript user defined type guard fails after second time 🕗 Version & Regression Information Upgrading project to 4.9.4 from 4.2.4. This changed between ver...

Open Graph Description: Bug Report 🔎 Search Terms react child.props unknown ts 18046 reading child prop typescript user defined type guard fails after second time 🕗 Version & Regression Information Upgrading project to 4....

X Description: Bug Report 🔎 Search Terms react child.props unknown ts 18046 reading child prop typescript user defined type guard fails after second time 🕗 Version & Regression Information Upgrading project t...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/52232

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Second use of type guard produces different result","articleBody":"# Bug Report\r\n\r\n\u003c!--\r\n  Please fill in each section completely. Thank you!\r\n-->\r\n\r\n### 🔎 Search Terms\r\n\r\n\u003c!--\r\n  What search terms did you use when trying to find an existing bug report?\r\n  List them here so people in the future can find this one more easily.\r\n-->\r\n\r\n`react child.props unknown`\r\n`ts 18046 reading child prop`\r\n`typescript user defined type guard fails after second time`\r\n\r\n### 🕗 Version & Regression Information\r\n\r\nUpgrading project to 4.9.4 from 4.2.4.\r\n\r\n- This changed between versions 4.7 and 4.8.2. I went through until I found where this changed.\r\n\r\n### ⏯ Playground Link\r\n\r\n\u003c!--\r\n  A link to a TypeScript Playground \"Share\" link which shows this behavior\r\n\r\n  The TypeScript Workbench can be used for more complex setups, try\r\n  https://www.typescriptlang.org/dev/bug-workbench/\r\n\r\n  As a last resort, you can link to a repo, but these will be slower for us to investigate.\r\n-->\r\n[Playground link with relevant code](https://www.typescriptlang.org/play?#code/FASwtgDg9gTgLgAgEoFMCGBjRAzGUwIDkM6WhA3MMBlAHYDOiGAFiADYAmAgjDGgJ4IAvAgDaAXQRp6U2oOnJScAHSpMcAHJQOKCZWqtOPPv2XZYAUUzMAFC3YdhAPgQBvYAgQ0GTQxxK0worqyiD0AGpobCAcFmwoYCi0cHZ+AJQIAGSZXn7KEHgQ9Mr2nAGUngD0lbkO+YUyYQhQ2Ahw-BAoCABEAK60ANa0UADutN0IKLywyggAkq0jXfQjaBBtrDLRtF0jIHDMHgjVG110XWgARlAAbl37ADSnk9MwCGC3KDJwUM9QB1MENszq0aDpZgB5WhsfhHE4AoEgHYIEbMKa7LokNCOUocepQIoIDhQL4IfZeWAkLAwtodLoIm5RXooZRwmoAWV6bDgIAg8QQWI4MhatU4+MJdGe2BAMEYiORUXovxGsAGCGlO1Znm8coKBIiTK6IjUWFCBuisXiiWSqQcGWyorxeqKykZbGZlAAvml9CcAOp8CAQJEAc2egpkewOzWRGCibDavzCkQtcQSSUQezYCfanQpvBQ1NhuOMAjMlmsts4zjcRxArRsJpUyaiMTT1pSuLSGXcniqNWGLzwsoQaJIR21dDluICQVx4uKM6SFT7OsQzvNzLneQ3rsNK89wG9+hLvDL5hgVhYVccQhcvYpPjJ5piQSbZpTbatGZvPrrDZbC0ewnR9pz8WcRHnXcl1oFdJyfDcUy3SCdwaPd3RQFcTjQbA4EBQVQ2eQDXzdLc0AQehCzoRweUSJ4oIaZ8EDZKQQzQJEEH6IZRloI5PUmNhKLJACXw4YC+1A3wHAgx0FxKcDlxAtcEEQw1tzqXdSMwvijx9IA)\r\n\r\n### 💻 Code\r\n\r\n\u003c!-- Please post the relevant code sample here as well-->\r\n```ts\r\n\r\nimport React from 'react';\r\n\r\nconst childArray = [] as any as React.ReactNode[];\r\n\r\nchildArray.forEach(child => {\r\n  const children = React.isValidElement(child) && child.props.children;\r\n  // child.props is of type \"unknown\" error. If we swap this line with\r\n  // the one above it, the error moves to the other line of code. Only\r\n  // the line where we read child.props does it correctly type the value.\r\n  // Multiple reads of child.props on the first line also work fine.\r\n  const propsValue = React.isValidElement(child) && child.props.value;\r\n});\r\n\r\n// Wrapping the reads with one call to isValidElement will type correctly\r\nchildArray.forEach(child => {\r\n  if (React.isValidElement(child)) {\r\n    // no errors here\r\n    const children = child.props.children;\r\n    const propsValue = child.props.value;\r\n  }\r\n});\r\n\r\nchildArray.forEach(child => {\r\n  const isValid = React.isValidElement(child);\r\n  if (isValid) {\r\n    const children = child.props.children;\r\n    const propsValue = child.props.value;\r\n  // after reading the isValid value a second time, child.props is \r\n  // again unknown\r\n  } else if (isValid) {\r\n    const children = child.props.children;\r\n    const propsValue = child.props.value;\r\n  }\r\n});\r\n```\r\n\r\n### 🙁 Actual behavior\r\n\r\nAll examples fail after the second read of a type guard on `props`, whether re-running the function or just reading the variable.\r\n\r\n### 🙂 Expected behavior\r\n\r\nShould behave consistently no matter if this is the first or second read of the type guard.\r\n","author":{"url":"https://github.com/jasonaden","@type":"Person","name":"jasonaden"},"datePublished":"2023-01-14T00:00:55Z","url":"https://github.com/microsoft/TypeScript/issues/52232"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:2f4a68e9-928e-319a-103d-be11a1e051d4
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA0D2:D0E46:D27937:116FCA2:6B00F954
html-safe-nonce09080f7e66ba8fce807f667a51e4459a576ed5cb1673298490c045f1d17a78b6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMEQyOkQwRTQ2OkQyNzkzNzoxMTZGQ0EyOjZCMDBGOTU0IiwidmlzaXRvcl9pZCI6IjY3MjQwMTQ1NjYzMzU5MDQwODQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaccc1393386b8a2ece2f8f59cfe116d14fff69cc65934d17c593de2134966645aa
hovercard-subject-tagissue:1533047089
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/52232/issue_layout
twitter:imagehttps://opengraph.githubassets.com/c4152b38d62a16957b19cbd602cc1672db7b656abb48b93973be371512979514/microsoft/TypeScript/issues/52232
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c4152b38d62a16957b19cbd602cc1672db7b656abb48b93973be371512979514/microsoft/TypeScript/issues/52232
og:image:altBug Report 🔎 Search Terms react child.props unknown ts 18046 reading child prop typescript user defined type guard fails after second time 🕗 Version & Regression Information Upgrading project to 4....
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejasonaden
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/52232#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F52232
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F52232
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/52232
Reloadhttps://github.com/microsoft/TypeScript/issues/52232
Reloadhttps://github.com/microsoft/TypeScript/issues/52232
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/52232
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/52232
Second use of type guard produces different resulthttps://github.com/microsoft/TypeScript/issues/52232#top
https://github.com/ahejlsberg
Working as IntendedThe behavior described is the intended behavior; this is not a bughttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Working%20as%20Intended%22
https://github.com/jasonaden
Jason Aden (jasonaden)https://github.com/jasonaden
on Jan 14, 2023https://github.com/microsoft/TypeScript/issues/52232#issue-1533047089
Playground link with relevant codehttps://www.typescriptlang.org/play#code/FASwtgDg9gTgLgAgEoFMCGBjRAzGUwIDkM6WhA3MMBlAHYDOiGAFiADYAmAgjDGgJ4IAvAgDaAXQRp6U2oOnJScAHSpMcAHJQOKCZWqtOPPv2XZYAUUzMAFC3YdhAPgQBvYAgQ0GTQxxK0worqyiD0AGpobCAcFmwoYCi0cHZ+AJQIAGSZXn7KEHgQ9Mr2nAGUngD0lbkO+YUyYQhQ2Ahw-BAoCABEAK60ANa0UADutN0IKLywyggAkq0jXfQjaBBtrDLRtF0jIHDMHgjVG110XWgARlAAbl37ADSnk9MwCGC3KDJwUM9QB1MENszq0aDpZgB5WhsfhHE4AoEgHYIEbMKa7LokNCOUocepQIoIDhQL4IfZeWAkLAwtodLoIm5RXooZRwmoAWV6bDgIAg8QQWI4MhatU4+MJdGe2BAMEYiORUXovxGsAGCGlO1Znm8coKBIiTK6IjUWFCBuisXiiWSqQcGWyorxeqKykZbGZlAAvml9CcAOp8CAQJEAc2egpkewOzWRGCibDavzCkQtcQSSUQezYCfanQpvBQ1NhuOMAjMlmsts4zjcRxArRsJpUyaiMTT1pSuLSGXcniqNWGLzwsoQaJIR21dDluICQVx4uKM6SFT7OsQzvNzLneQ3rsNK89wG9+hLvDL5hgVhYVccQhcvYpPjJ5piQSbZpTbatGZvPrrDZbC0ewnR9pz8WcRHnXcl1oFdJyfDcUy3SCdwaPd3RQFcTjQbA4EBQVQ2eQDXzdLc0AQehCzoRweUSJ4oIaZ8EDZKQQzQJEEH6IZRloI5PUmNhKLJACXw4YC+1A3wHAgx0FxKcDlxAtcEEQw1tzqXdSMwvijx9IA
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
on Jan 14, 2023https://github.com/microsoft/TypeScript/issues/52232#issuecomment-1382596754
https://github.com/tjjfvi
T6 (tjjfvi)https://github.com/tjjfvi
on Jan 14, 2023https://github.com/microsoft/TypeScript/issues/52232#issuecomment-1382603010
Here you go!https://www.typescriptlang.org/play#code/FAYw9gdgzgLgBCAFgSwDYBMCCAnbBDATwC44AlAUzxBgDkx1yBtAXTgF44WBuYYZCGOWwAzKuTKVqAUVTkAtuQEAeAArs4eCAQB8cAN7A4cAA7YwxqCRU8Avr36CRYiVRgqw2GHlRxyAD0EIdCgXaVkFAX1DBBQMbEUSClc6BlteGAJjcSTqFPEOHJgZeUV4AB9Qtw8vVF4GEFQ8eLhhAFcIamRIOGQoADVvZHRiiJglABVtAAowACMAK3JqEnaAawgwAHcIAEoSOcXqHpDCkdKJ7V4kNCxcQgA6YQ8pKkQp64x2XQMjcGh4D7oeIQdS9AaoIZnATvWLoHZwABkCJiN3upnMUHugOBPCMAHo8SiMGizBZjnAwMI4BksnAAERrDbbOm+XAee5wACSVM24igmzwxmpKBCEIg4k2yBgiGiBOF4kg4jwszAADdxFKADTy1lmbBwORq8ghGBgHVgaVCOBihVU8AMDkAeQgqAIssJlut-AliCEEvE8Tw6CJ6BJGLg6DAxp6AI88WorupmXEntV3la5Hu7rgAFlWqgYMhjLI4IHghS7bCw2Tup7hMhsLAveKNKgoGbNh5Vi1vVnfpAm+iLOCM6D+oNhuFSjCbvCkSHq5jsYpbDseMA5QB1fDGYz8ADmOrLIUl0opLZA3h8puO4MhU8iktQ1+TCDjSxgrtAsJw+AIj2eV4Z0+NhvmiZAqSmMEJyhGBgLheEfiMOA5Q2XUPBCX14mift-hDYF1EBRcsVhHEcLfPCh3HVBRw4IiqPuNMaPIXE4DsGw1yuH87n-J5sBeJB4K+KJcKbaCIWDDhxPvEpoUBTijAguAoOooZEPIv4m2XEE6KrBjtNY0T4Cokd8gXBimIzVi5TwYRHFLSh0APHVpODSylTgKAlkgYNCwUbV6NJEJejgbM8H3PB+DgRktggaIbFCxTINc9TkIorTSMUQi9KCkibjItLNOMoLTOy1ELPTFj4uADiuCAA
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
on Jan 14, 2023https://github.com/microsoft/TypeScript/issues/52232#issuecomment-1382603472
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
on Jan 14, 2023https://github.com/microsoft/TypeScript/issues/52232#issuecomment-1382605632
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
on Jan 14, 2023https://github.com/microsoft/TypeScript/issues/52232#issuecomment-1382610692
a4507c9https://github.com/microsoft/TypeScript/commit/a4507c9225a8c0746924acc5b544a28626ba2ff9
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
on Jan 14, 2023https://github.com/microsoft/TypeScript/issues/52232#issuecomment-1382611310
#50044https://github.com/microsoft/TypeScript/pull/50044
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Needs InvestigationThis issue needs a team member to investigate its status.https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Needs%20Investigation%22
on Jan 14, 2023https://github.com/microsoft/TypeScript/issues/52232#event-8225470856
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
on Jan 14, 2023https://github.com/microsoft/TypeScript/issues/52232#event-8225471072
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
on Jan 17, 2023https://github.com/microsoft/TypeScript/issues/52232#issuecomment-1386032961
#50044https://github.com/microsoft/TypeScript/pull/50044
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Working as IntendedThe behavior described is the intended behavior; this is not a bughttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Working%20as%20Intended%22
Needs InvestigationThis issue needs a team member to investigate its status.https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Needs%20Investigation%22
on Jan 17, 2023https://github.com/microsoft/TypeScript/issues/52232#event-8249656542
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
on Jan 17, 2023https://github.com/microsoft/TypeScript/issues/52232#issuecomment-1386034496
Ryan Cavanaugh (@RyanCavanaugh)https://github.com/RyanCavanaugh
https://github.com/jasonaden
Jason Aden (jasonaden)https://github.com/jasonaden
on Jan 19, 2023https://github.com/microsoft/TypeScript/issues/52232#issuecomment-1397229297
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
on Jan 19, 2023https://github.com/microsoft/TypeScript/issues/52232#issuecomment-1397432568
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
not plannedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Anot-planned
on Jan 19, 2023https://github.com/microsoft/TypeScript/issues/52232#event-8315008552
microsofthttps://github.com/microsoft
on Oct 22, 2025https://github.com/microsoft/TypeScript/issues/52232#event-20417650931
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/52232
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/52232
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Working as IntendedThe behavior described is the intended behavior; this is not a bughttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Working%20as%20Intended%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.