Title: Design Meeting Notes, 1/11/2023 · Issue #52199 · microsoft/TypeScript · GitHub
Open Graph Title: Design Meeting Notes, 1/11/2023 · Issue #52199 · microsoft/TypeScript
X Title: Design Meeting Notes, 1/11/2023 · Issue #52199 · microsoft/TypeScript
Description: Incorrectly Formatted Packages in --moduleResolution bundler/node16 #51973 Test to see what breaks if node is redirected to bundler. Previously types would have been resolved. Now the exports.import condition is resolved as per Node 16 r...
Open Graph Description: Incorrectly Formatted Packages in --moduleResolution bundler/node16 #51973 Test to see what breaks if node is redirected to bundler. Previously types would have been resolved. Now the exports.impor...
X Description: Incorrectly Formatted Packages in --moduleResolution bundler/node16 #51973 Test to see what breaks if node is redirected to bundler. Previously types would have been resolved. Now the exports.impor...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/52199
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Design Meeting Notes, 1/11/2023","articleBody":"# Incorrectly Formatted Packages in `--moduleResolution bundler/node16`\r\n\r\nhttps://github.com/microsoft/TypeScript/pull/51973\r\n\r\n* Test to see what breaks if `node` is redirected to `bundler`.\r\n* Previously `types` would have been resolved.\r\n * Now the `exports.import` condition is resolved as per Node 16 rules.\r\n* Now providing a better error message when we can detect this. You'd get the same error in `node16`.\r\n * The messages are still bad because we provide an absolute path to the file instead of a relative path.\r\n * Presumably we did this because the relative path isn't the correct thing when printing paths in the command line.\r\n* Aside: would be good to do the same tests for redirecting `node16`/`nodenext`\r\n\r\n# LKG versus `node_modules`\r\n\r\n* ESLint relies on `node_modules`, our builds rely on LKG builds in `lib`.\r\n* Would be nice if they could agree with each other!\r\n* Would also be nice to get rid of `lib` and use npm for boostrapping.\r\n * But then people can't clone TypeScript and just run from `lib`.\r\n * But we could just do that on `release` branches anyway.\r\n* Not great to snapshot 40MB of JS on every LKG!\r\n * Git doesn't store that as a diff!\r\n * Cloning takes a while these days\r\n * Though there are ways to make this easier: https://github.blog/2020-12-21-get-up-to-speed-with-partial-clone-and-shallow-clone/\r\n* So switch to nightlies on npm instead of building from `lib`?\r\n * Have to always `npm ci` on `git pull`\r\n * Technically true today, but it's rare that that even makes a difference. So you can get away with it.\r\n * But it would also be rare for us too. How often do we update LKG?\r\n * EXCEPT you still need to when you're bisecting!\r\n * Ugh - annoying. But might be worth it long term.\r\n* Edge case - ESLint looks at the current package `typescript/` instead of the `typescript/node_modules/typescript`.\r\n * Follow up on if this is true.\r\n* So\r\n * Switch to using npm and `node_modules`\r\n * Delete `lib`\r\n * `lib` gets `.gitignore`'d\r\n * We force-add `lib` on `release-X.Y` branches and commit it.\r\n * `lib` gets published on npm.\r\n * When we need to take advantage of a new feature sooner than the same day, we can publish an insiders or early nightly instead.","author":{"url":"https://github.com/DanielRosenwasser","@type":"Person","name":"DanielRosenwasser"},"datePublished":"2023-01-11T22:48:21.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/52199/TypeScript/issues/52199"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:c742cade-cae2-7084-b53f-b95b10a823e3 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | DA58:D629A:3824FC:4F8A5B:6A62028D |
| html-safe-nonce | c2fd8d1447590e05b18f32edf69d0152755e9925b011a547a99e54f3edd9b2a9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQTU4OkQ2MjlBOjM4MjRGQzo0RjhBNUI6NkE2MjAyOEQiLCJ2aXNpdG9yX2lkIjoiNjM0MjgwNTIyOTQ5OTg0OTA5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 59602fa2ecffcd5d213e206d571b43123a09e7a226d8e6579e81694e5f20c8b1 |
| hovercard-subject-tag | issue:1529823789 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/52199/issue_layout |
| twitter:image | https://opengraph.githubassets.com/ad39fb6e807e76b8971a8c6735db64cd221ba8d2b1c53e49f298cbd1808849c4/microsoft/TypeScript/issues/52199 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ad39fb6e807e76b8971a8c6735db64cd221ba8d2b1c53e49f298cbd1808849c4/microsoft/TypeScript/issues/52199 |
| og:image:alt | Incorrectly Formatted Packages in --moduleResolution bundler/node16 #51973 Test to see what breaks if node is redirected to bundler. Previously types would have been resolved. Now the exports.impor... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | DanielRosenwasser |
| hostname | github.com |
| expected-hostname | github.com |
| None | 92eeba52656842b5eb8a3f62fd6465e80107329999099c7144d43d7476b38ad0 |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 14dbe1e269fc16133b0b2bbc058e3a259cd85df4 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width