Title: Design Meeting Notes, 1/4/2023 · Issue #52131 · microsoft/TypeScript · GitHub
Open Graph Title: Design Meeting Notes, 1/4/2023 · Issue #52131 · microsoft/TypeScript
X Title: Design Meeting Notes, 1/4/2023 · Issue #52131 · microsoft/TypeScript
Description: Notes by @RyanCavanaugh strictFunctionTypes for our codebase #49929 Most unsoundness is around visitor-like patterns Performance of additional needed checkDefined calls is ~zero Some possible inference issues identified, Jake will reduce...
Open Graph Description: Notes by @RyanCavanaugh strictFunctionTypes for our codebase #49929 Most unsoundness is around visitor-like patterns Performance of additional needed checkDefined calls is ~zero Some possible infer...
X Description: Notes by @RyanCavanaugh strictFunctionTypes for our codebase #49929 Most unsoundness is around visitor-like patterns Performance of additional needed checkDefined calls is ~zero Some possible infer...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/52131
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Design Meeting Notes, 1/4/2023","articleBody":"*Notes by @RyanCavanaugh*\r\n\r\n# `strictFunctionTypes` for our codebase\r\n\r\nhttps://github.com/microsoft/TypeScript/pull/49929\r\n\r\n* Most unsoundness is around visitor-like patterns\r\n* Performance of additional needed `checkDefined` calls is ~zero\r\n* Some possible inference issues identified, Jake will reduce offline\r\n * Update: Fixed at #52123\r\n* Please code review, will merge for 5.0\r\n\r\n# Internal RWC Tests\r\n\r\n* What's the deal?\r\n * These are internal (nonpublic) codebases\r\n* Do we need this?\r\n * Probably not anymore\r\n * These codebases are *ancient* and are affected by 5.0 changes\r\n* Would greatly prefer if external contributors could see all test collateral/results\r\n* Sufficient coverage from top100, user, etc\r\n * Someone please write down the differences between all these\r\n* Let's remove\r\n\r\n# CI coverage in general\r\n\r\n* We need to be running ALL test suites on EVERY PR so we stop getting surprised\r\n* Please kick off these runs manually for now\r\n* TODO: Automate that\r\n* Performance testing\r\n* Current tests don't give an accurate statistical picture of what's happening\r\n* New perf tools tell you whether results are statistically significant or not, and to what degree\r\n* Getting apples-to-apples hardware is difficult\r\n* But we've inarguably \"drifted\" slower one unmeasurable step at a time\r\n * Option 1: Measure the unmeasurable\r\n * Pros: Would be good\r\n * Cons: Not possible\r\n * Option 2: Measure some proxy measure of performance instead (allocations, comparisons, clock cycles, etc)\r\n * Pros: Discrete, no error bars\r\n * Cons: Proxy measures might only roughly correlate\r\n * Option 3: Measure release-to-release to keep tabs on how we're doing \r\n * Pros: Works\r\n * Cons: Misses things when they happen\r\n* Consensus: Keep investigating perf and perf measures","author":{"url":"https://github.com/DanielRosenwasser","@type":"Person","name":"DanielRosenwasser"},"datePublished":"2023-01-06T20:44:43.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/52131/TypeScript/issues/52131"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:db7ea3fa-8e41-e9fc-45fa-597498f4c6dd |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8E3C:104DDB:48E4F1:66F808:6A620681 |
| html-safe-nonce | 5fe8998c8ad1220011df6bbf8660266f174eb45b92ca30af2f38e99affe3a622 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RTNDOjEwNEREQjo0OEU0RjE6NjZGODA4OjZBNjIwNjgxIiwidmlzaXRvcl9pZCI6Ijc0NzI0NzUxMzUxOTc0NDc4MDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 88e2202ea08d3245b55643b8292e43cd31343326b1de619ac3cfc3e1bf14a94b |
| hovercard-subject-tag | issue:1523142966 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/52131/issue_layout |
| twitter:image | https://opengraph.githubassets.com/072fc36608e1f92cc42307c956138e7554c55653097f36e06b5162cc920e3f51/microsoft/TypeScript/issues/52131 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/072fc36608e1f92cc42307c956138e7554c55653097f36e06b5162cc920e3f51/microsoft/TypeScript/issues/52131 |
| og:image:alt | Notes by @RyanCavanaugh strictFunctionTypes for our codebase #49929 Most unsoundness is around visitor-like patterns Performance of additional needed checkDefined calls is ~zero Some possible infer... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | DanielRosenwasser |
| hostname | github.com |
| expected-hostname | github.com |
| None | be9a4d9589756e22b427637ffbf1123a96e067050e57f5cec403e3080a650ca4 |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7b5509702f01f876c214a2cbb142690847de0019 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width