René's URL Explorer Experiment


Title: Allow use of const enums in value space when preserveConstEnums=true · Issue #51530 · microsoft/TypeScript · GitHub

Open Graph Title: Allow use of const enums in value space when preserveConstEnums=true · Issue #51530 · microsoft/TypeScript

X Title: Allow use of const enums in value space when preserveConstEnums=true · Issue #51530 · microsoft/TypeScript

Description: Background The TypeScript compiler uses const enums for the performance benefit of inlining, but then enables preserveConstEnums and modifies the output d.ts files to "lie" to API consumers and say that the enum is not const. This, and "...

Open Graph Description: Background The TypeScript compiler uses const enums for the performance benefit of inlining, but then enables preserveConstEnums and modifies the output d.ts files to "lie" to API consumers and say...

X Description: Background The TypeScript compiler uses const enums for the performance benefit of inlining, but then enables preserveConstEnums and modifies the output d.ts files to "lie" to API consume...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/51530

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Allow use of const enums in value space when preserveConstEnums=true","articleBody":"## Background\r\n\r\nThe TypeScript compiler uses const enums for the performance benefit of inlining, but then enables `preserveConstEnums` and modifies the output d.ts files to \"lie\" to API consumers and say that the enum is not const. This, and \"just don't export const enums\" are the recommended methods for library authors; the emitted code for const vs non-const enums is identical with the flag enabled.\r\n\r\nInternally, however, we use the enum values at runtime for Debug helpers. In order to make this work, we must write code like:\r\n\r\n```ts\r\nexport function formatSyntaxKind(kind: SyntaxKind | undefined): string {\r\n    return formatEnum(kind, (ts as any).SyntaxKind, /*isFlags*/ false);\r\n}\r\n```\r\n\r\nBut, we cannot write:\r\n\r\n```ts\r\nexport function formatSyntaxKind(kind: SyntaxKind | undefined): string {\r\n    return formatEnum(kind, SyntaxKind, /*isFlags*/ false);\r\n}\r\n// or\r\nexport function formatSyntaxKind(kind: SyntaxKind | undefined): string {\r\n    return formatEnum(kind, (SyntaxKind as any), /*isFlags*/ false);\r\n}\r\n```\r\n\r\nWithout using `// @ts-ignore-error` to silence:\r\n\r\n> 'const' enums can only be used in property or index access expressions or the right hand side of an import declaration or export assignment or type query\r\n\r\n## Proposal\r\n\r\nDon't issue the above error when `preserveConstEnums=true`.\r\n\r\nI believe that this change should be safe because this flag explicitly forces tsc to emit enums as though they had been written as non-const; not issuing the error lets you use it as a value.\r\n\r\n## Motivation\r\n\r\nIn the codebase pre-modules, `ts` was the namespace and was sometimes used intentionally, but now, this `ts as any` pattern is one of the only reasons why our codebase internally needs to refer to the namespace barrels and can't direct import everything everywhere.\r\n\r\nIf this error were disabled when `preserveConstEnums=true`, however, we could just use the enums directly and not have to jump through hoops (and potentially pull enum formatting out and drop the helpers, removing a cycle between debug and types).\r\n\r\n## Alternative considered\r\n\r\nAnother alternative to this (for the TS compiler itself) is to just not use const enums. This works because our current outputs are produced by esbuild, which doesn't care at all about whether or not enums are const; it will inline them if it can, and it will produce a non-const enum object if the enum itself is needed in value space. But, if we do _any_ other kind of build that isn't \"esbuild on src\" (e.g. change bundlers, run the bundler on tsc outputs, etc), using non-const enums would cause a performance regression. I also have no idea if there are behaviors one can have in const enums and not in regular enums, though I suspect there aren't any.\r\n\r\n## Related\r\n\r\n- #31353\r\n- #37282 (in that this proposal would effectively declare we won't do it, and will stick to the current behavior)\r\n- Probably some other issue I didn't find","author":{"url":"https://github.com/jakebailey","@type":"Person","name":"jakebailey"},"datePublished":"2022-11-14T22:49:17Z","url":"https://github.com/microsoft/TypeScript/issues/51530"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:ef2bc851-b33a-6ea4-b55a-428824a7f26b
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id98C2:2A7C1C:B4A92:EED70:6B0181A5
html-safe-noncec0536e6652e97fb3b1052add32321214de48e134c6a6854a06178e58a23210d4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OEMyOjJBN0MxQzpCNEE5MjpFRUQ3MDo2QjAxODFBNSIsInZpc2l0b3JfaWQiOiI0ODE4OTA2MzQ2NzM0ODQ2MzczIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2d27d358becf981c8415858577ca18d958720ac01342a53b6665e4fc8981d786
hovercard-subject-tagissue:1448882772
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/51530/issue_layout
twitter:imagehttps://opengraph.githubassets.com/d5d732bf7f6de2d6b6cf0d41f3333063c268d713a18468b6af55fbd86abc42a9/microsoft/TypeScript/issues/51530
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d5d732bf7f6de2d6b6cf0d41f3333063c268d713a18468b6af55fbd86abc42a9/microsoft/TypeScript/issues/51530
og:image:altBackground The TypeScript compiler uses const enums for the performance benefit of inlining, but then enables preserveConstEnums and modifies the output d.ts files to "lie" to API consumers and say...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejakebailey
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/51530#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F51530
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F51530
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/51530
Reloadhttps://github.com/microsoft/TypeScript/issues/51530
Reloadhttps://github.com/microsoft/TypeScript/issues/51530
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/51530
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/51530
Allow use of const enums in value space when preserveConstEnums=truehttps://github.com/microsoft/TypeScript/issues/51530#top
In DiscussionNot yet reached consensushttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22In%20Discussion%22
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
on Nov 14, 2022https://github.com/microsoft/TypeScript/issues/51530#issue-1448882772
when preserveConstEnums = true should allow use enum[key] #31353https://github.com/microsoft/TypeScript/issues/31353
Don't emit const enums with reverse mapping (under preserveConstEnum) #37282https://github.com/microsoft/TypeScript/issues/37282
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
on Nov 16, 2022https://github.com/microsoft/TypeScript/issues/51530#issuecomment-1317767595
esbuildhttps://esbuild.egoist.dev/#W1siaW5kZXgudHMiLHsiY29udGVudCI6ImltcG9ydCB7IHR5cGUgRm9vIH0gZnJvbSAnLi9zdW0nXG5cbmV4cG9ydCBkZWZhdWx0IEZvby5BIn1dLFsiZXNidWlsZC5jb25maWcuanNvbiIseyJjb250ZW50Ijoie1xuICBcImZvcm1hdFwiOiBcImVzbVwiLFxuICBcImNkblVybFwiOiBcImh0dHBzOi8vY2RuLnNreXBhY2suZGV2XCJcbn0ifV0sWyJzdW0udHMiLHsiY29udGVudCI6ImV4cG9ydCBjb25zdCBlbnVtIEZvbyB7XG4gIEEsIEIsIEMgXG59In1dXQ==
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
In DiscussionNot yet reached consensushttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22In%20Discussion%22
on Nov 17, 2022https://github.com/microsoft/TypeScript/issues/51530#event-7838603395
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/51530
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/51530
In DiscussionNot yet reached consensushttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22In%20Discussion%22
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.