Title: Typescript [4.8.2] is adding invalid javascript for *.cjs files · Issue #50647 · microsoft/TypeScript · GitHub
Open Graph Title: Typescript [4.8.2] is adding invalid javascript for *.cjs files · Issue #50647 · microsoft/TypeScript
X Title: Typescript [4.8.2] is adding invalid javascript for *.cjs files · Issue #50647 · microsoft/TypeScript
Description: Bug Report My project is set to emit ESNext modules. I have a variety of TS files, but I also have a single .cjs file, which needs to remain CommonJS to try and require legacy packages. My input looks like this: module.exports = { tryReq...
Open Graph Description: Bug Report My project is set to emit ESNext modules. I have a variety of TS files, but I also have a single .cjs file, which needs to remain CommonJS to try and require legacy packages. My input lo...
X Description: Bug Report My project is set to emit ESNext modules. I have a variety of TS files, but I also have a single .cjs file, which needs to remain CommonJS to try and require legacy packages. My input lo...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/50647
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Typescript [4.8.2] is adding invalid javascript for *.cjs files","articleBody":"# Bug Report\r\n\r\nMy project is set to emit ESNext modules. I have a variety of TS files, but I also have a single `.cjs` file, which needs to remain CommonJS to try and require legacy packages.\r\n\r\nMy input looks like this:\r\n\r\n```js\r\nmodule.exports = {\r\n tryRequire(modulePath) {\r\n return require(modulePath);\r\n },\r\n};\r\n```\r\n\r\nI expect the output I get from TypeScript 4.7.4:\r\n\r\n```js\r\nmodule.exports = {\r\n tryRequire(modulePath) {\r\n return require(modulePath);\r\n },\r\n};\r\n```\r\n\r\nWhen I upgrade to TypeScript 4.8.2, it now emits an extra `export {}` at the end of the .cjs file:\r\n\r\n```js\r\nmodule.exports = {\r\n tryRequire(modulePath) {\r\n return require(modulePath);\r\n },\r\n};\r\nexport {}\r\n```\r\n\r\nThis causes Node to fail parsing the `.cjs` file because `export` does not exist in the .cjs context.\r\n\r\n### 🕗 Version \u0026 Regression Information\r\n\r\nWorked in 4.7.4, broken in 4.8.2, also broken in current nightly (4.9.0-dev.20220905).\r\n\r\n### Repro here\r\n\r\nhttps://github.com/dzearing/ts-repro-cjs\r\n","author":{"url":"https://github.com/dzearing","@type":"Person","name":"dzearing"},"datePublished":"2022-09-06T00:44:49.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":22},"url":"https://github.com/50647/TypeScript/issues/50647"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:d5a618d9-3af1-37a2-5732-207c0beab712 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D25E:2B14D5:BDDB87:101F571:6A5B9636 |
| html-safe-nonce | 88b70e2a7292476e705a018133b6c8063bac90b9ea1e4e41b0381b0bff2c34d6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjVFOjJCMTRENTpCRERCODc6MTAxRjU3MTo2QTVCOTYzNiIsInZpc2l0b3JfaWQiOiIyMTA3NTY4MjE2NjAwMTg4NDcwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 92a756ec3f2cf1eed9479303ab0e3f5e9a7a8f89fec7f267fa83183a88bc86b7 |
| hovercard-subject-tag | issue:1362573036 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/50647/issue_layout |
| twitter:image | https://opengraph.githubassets.com/fd94c3dd8e16d88c53168e9cd37130a63b94c2d7c134c1d6cb9052f503d2e659/microsoft/TypeScript/issues/50647 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/fd94c3dd8e16d88c53168e9cd37130a63b94c2d7c134c1d6cb9052f503d2e659/microsoft/TypeScript/issues/50647 |
| og:image:alt | Bug Report My project is set to emit ESNext modules. I have a variety of TS files, but I also have a single .cjs file, which needs to remain CommonJS to try and require legacy packages. My input lo... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | dzearing |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width