René's URL Explorer Experiment


Title: Type narrowing not working properly for unions in let declarations · Issue #48038 · microsoft/TypeScript · GitHub

Open Graph Title: Type narrowing not working properly for unions in let declarations · Issue #48038 · microsoft/TypeScript

X Title: Type narrowing not working properly for unions in let declarations · Issue #48038 · microsoft/TypeScript

Description: Bug Report When you type a variable with a union type, typescript is too aggressive while narrowing it down. Specifically, it only considers assignments in the "main" flow, and ignores any other possibility. 🔎 Search Terms let, type guar...

Open Graph Description: Bug Report When you type a variable with a union type, typescript is too aggressive while narrowing it down. Specifically, it only considers assignments in the "main" flow, and ignores any other po...

X Description: Bug Report When you type a variable with a union type, typescript is too aggressive while narrowing it down. Specifically, it only considers assignments in the "main" flow, and ignores an...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/48038

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Type narrowing not working properly for unions in let declarations","articleBody":"# Bug Report\r\n\r\nWhen you type a variable with a union type, typescript is too aggressive while narrowing it down. Specifically, it only considers assignments in the \"main\" flow, and ignores any other possibility.\r\n\r\n### 🔎 Search Terms\r\n\r\nlet, type guard, type narrowing, never\r\n\r\n### 🕗 Version & Regression Information\r\n\r\nI've tried with different TS versions starting in `3.`, and it happens in all of them. I also tried with nightly (v4.7.0-dev.20220215)\r\n\r\n### ⏯ Playground Link\r\n\r\n[Playground link with relevant code](https://www.typescriptlang.org/play?ts=4.5.4#code/DYUwLgBAZg9jBcEDOYBOBLAdgcwgHwkwFcBbAIxFQgF4IAWAJgG4BYAKCiMwGMx0ZMEMgENUACgCUEAN7sI0ODQgByRstZsAvu3YjxEjQHpDCmEtUN1EYxHRQIAdxAQu3GCRIhMkMAAt0SAA0jiDKqM5QWCDsdhBiYACeAA4gMPawZtRZKigYOMpSsmzyGQB0WNzARAAmIEhiygAeBUzWJgAKqDApqIkqFVW1SMoQ1TB1hDCQII0BkAIQiSkqmCAAbpTKpezabEA)\r\n\r\n### 💻 Code\r\n\r\n```typescript\r\nlet foo: string | number = 42;\r\nfunction bar() {\r\n  foo = '42';\r\n}\r\n\r\nbar();\r\n// foo = '42'; // if we uncomment this, we're fine\r\nif (typeof foo === 'string') {\r\n  foo.includes('x'); // TS Error: property 'includes' does not exist on type 'never'\r\n}\r\n```\r\n\r\n### 🙁 Actual behavior\r\n\r\nTS shouldn't be so eager to narrow the type to `never`. \r\n\r\n### 🙂 Expected behavior\r\n\r\nDon't narrow unions based on assignments. Or, if it's not too hard to implement, do it only when you can be absolutely certain. I.e., no function after the assignment that caused the type narrowing.\r\n","author":{"url":"https://github.com/lgenzelis","@type":"Person","name":"lgenzelis"},"datePublished":"2022-02-25T13:59:37Z","url":"https://github.com/microsoft/TypeScript/issues/48038"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:4d58ebc8-b6bf-22fb-eb64-ee4986877b9d
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB24C:14700E:2B1FF16:36C26F5:6B01AB1D
html-safe-noncee5b71bf19a7403103062b3bd40c2c1c723d0184cea2b88a18e4c565970914928
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMjRDOjE0NzAwRToyQjFGRjE2OjM2QzI2RjU6NkIwMUFCMUQiLCJ2aXNpdG9yX2lkIjoiNzU4MDY1MjQ3NjQ5MjI2MjE3MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb655278a53e310484195d66c808f960dc5b09c5273447564e93aee9fdf2d321d
hovercard-subject-tagissue:1150477181
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/48038/issue_layout
twitter:imagehttps://opengraph.githubassets.com/fec4aa086d3904e2d04ace2d340b9e18bfe7dd1c649b339202b997d8a914d72f/microsoft/TypeScript/issues/48038
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fec4aa086d3904e2d04ace2d340b9e18bfe7dd1c649b339202b997d8a914d72f/microsoft/TypeScript/issues/48038
og:image:altBug Report When you type a variable with a union type, typescript is too aggressive while narrowing it down. Specifically, it only considers assignments in the "main" flow, and ignores any other po...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelgenzelis
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/48038#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F48038
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F48038
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/48038
Reloadhttps://github.com/microsoft/TypeScript/issues/48038
Reloadhttps://github.com/microsoft/TypeScript/issues/48038
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/48038
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/48038
Type narrowing not working properly for unions in let declarationshttps://github.com/microsoft/TypeScript/issues/48038#top
https://github.com/lgenzelis
Lucas Genzelis (lgenzelis)https://github.com/lgenzelis
on Feb 25, 2022https://github.com/microsoft/TypeScript/issues/48038#issue-1150477181
Playground link with relevant codehttps://www.typescriptlang.org/play?ts=4.5.4#code/DYUwLgBAZg9jBcEDOYBOBLAdgcwgHwkwFcBbAIxFQgF4IAWAJgG4BYAKCiMwGMx0ZMEMgENUACgCUEAN7sI0ODQgByRstZsAvu3YjxEjQHpDCmEtUN1EYxHRQIAdxAQu3GCRIhMkMAAt0SAA0jiDKqM5QWCDsdhBiYACeAA4gMPawZtRZKigYOMpSsmzyGQB0WNzARAAmIEhiygAeBUzWJgAKqDApqIkqFVW1SMoQ1TB1hDCQII0BkAIQiSkqmCAAbpTKpezabEA
Lucas Genzelis (lgenzelis)https://github.com/lgenzelis
on Feb 25, 2022https://github.com/microsoft/TypeScript/issues/48038#event-6139312705
Lucas Genzelis (lgenzelis)https://github.com/lgenzelis
on Feb 25, 2022https://github.com/microsoft/TypeScript/issues/48038#event-6139337872
https://github.com/MartinJohns
Martin Johns (MartinJohns)https://github.com/MartinJohns
on Feb 25, 2022https://github.com/microsoft/TypeScript/issues/48038#issuecomment-1050880870
#9998https://github.com/microsoft/TypeScript/issues/9998
https://github.com/lgenzelis
Lucas Genzelis (lgenzelis)https://github.com/lgenzelis
on Feb 25, 2022https://github.com/microsoft/TypeScript/issues/48038#issuecomment-1051100839
Martin Johns (@MartinJohns)https://github.com/MartinJohns
#9998https://github.com/microsoft/TypeScript/issues/9998
Lucas Genzelis (lgenzelis)https://github.com/lgenzelis
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Feb 25, 2022https://github.com/microsoft/TypeScript/issues/48038#event-6140997089
https://github.com/MartinJohns
Martin Johns (MartinJohns)https://github.com/MartinJohns
on Feb 25, 2022https://github.com/microsoft/TypeScript/issues/48038#issuecomment-1051103907
https://github.com/danny-does-stuff
Danny (danny-does-stuff)https://github.com/danny-does-stuff
on May 15, 2024https://github.com/microsoft/TypeScript/issues/48038#issuecomment-2113074457
microsofthttps://github.com/microsoft
on Oct 22, 2025https://github.com/microsoft/TypeScript/issues/48038#event-20417503110
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/48038
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/48038
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.