René's URL Explorer Experiment


Title: Suggestion: Type guard generic types · Issue #4742 · microsoft/TypeScript · GitHub

Open Graph Title: Suggestion: Type guard generic types · Issue #4742 · microsoft/TypeScript

X Title: Suggestion: Type guard generic types · Issue #4742 · microsoft/TypeScript

Description: Would it be good to have type guarding on generic types? Or was this decided against? Example 1 class Parent { prop1: string; } class Child extends Parent { childProp: string; } var t: Parent = new Child(); if (t instanceof Child) { t.ch...

Open Graph Description: Would it be good to have type guarding on generic types? Or was this decided against? Example 1 class Parent { prop1: string; } class Child extends Parent { childProp: string; } var t: Parent = new...

X Description: Would it be good to have type guarding on generic types? Or was this decided against? Example 1 class Parent { prop1: string; } class Child extends Parent { childProp: string; } var t: Parent = new...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/4742

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Suggestion: Type guard generic types","articleBody":"Would it be good to have type guarding on generic types? Or was this decided against?\n\n**Example 1**\n\n``` typescript\nclass Parent {\n    prop1: string;\n}\n\nclass Child extends Parent {\n    childProp: string;\n}\n\nvar t: Parent = new Child();\n\nif (t instanceof Child) {\n    t.childProp; // no error\n}\n\nfunction myFunction\u003cT extends Parent>(item: T) {\n    if (item instanceof Child) {\n        item.childProp; // error\n    }\n}\n```\n\nI realize this example could be rewritten without generics. It's just an example :)\n\n**Example 2**\n\nHere's a scenario I came across when creating a wrapper class:\n\n``` typescript\ninterface NedbItem {\n    _id: string;\n}\n\nfunction isNedbItem(item: any): item is NedbItem {\n    return item != null && typeof item._id === \"string\";\n}\n\nclass DatabaseWrapper\u003cT> {\n    getItems() {\n        const itemsFromDatabase: T[] = .....;\n\n        itemsFromDatabase.forEach(i => this.stripNedbID(i));\n\n        return itemsFromDatabase;\n    }\n\n    private stripNedbID(item: T) {\n        if (isNedbItem(item))\n        {\n            delete item._id; // error, _id does not exist on T\n        }\n    }\n}\n```\n\nMaybe a generic type with no constraint should be treated like an `any` type in this case? (Once type guards are fixed for any types -- See #4432)\n\nThis suggestion is probably very low on the priority scale.\n\nI couldn't find this issue discussed elsewhere so sorry if it was.\n","author":{"url":"https://github.com/dsherret","@type":"Person","name":"dsherret"},"datePublished":"2015-09-11T04:29:50Z","url":"https://github.com/microsoft/TypeScript/issues/4742"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:b9c47ee4-f6bd-4828-fc5c-c3996ca8b88d
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC7EA:2D40DE:1C27325:23CDD5B:6B0197CF
html-safe-noncef064bd625e0c6c8edc48a9b8bda9e24ca9249c806bcdb3343ad33ae9679b795b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDN0VBOjJENDBERToxQzI3MzI1OjIzQ0RENUI6NkIwMTk3Q0YiLCJ2aXNpdG9yX2lkIjoiODkyMjI4NTI1NzcxODMzOTUzNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca411783d2802c59eb32f4fc12a947d19bf771be2741e8dfd0233f2e810b0bdf2
hovercard-subject-tagissue:105943263
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/4742/issue_layout
twitter:imagehttps://opengraph.githubassets.com/6a87a546de9cde75ffb74af0797086fd0f208d536427765292bff962dcdb3aa7/microsoft/TypeScript/issues/4742
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6a87a546de9cde75ffb74af0797086fd0f208d536427765292bff962dcdb3aa7/microsoft/TypeScript/issues/4742
og:image:altWould it be good to have type guarding on generic types? Or was this decided against? Example 1 class Parent { prop1: string; } class Child extends Parent { childProp: string; } var t: Parent = new...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedsherret
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/4742#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F4742
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F4742
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/4742
Reloadhttps://github.com/microsoft/TypeScript/issues/4742
Reloadhttps://github.com/microsoft/TypeScript/issues/4742
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/4742
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/4742
Suggestion: Type guard generic typeshttps://github.com/microsoft/TypeScript/issues/4742#top
Effort: ModerateRequires experience with the TypeScript codebase, but feasible. Harder than "Effort: Casual".https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Effort%3A%20Moderate%22
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
Backloghttps://github.com/microsoft/TypeScript/milestone/29
https://github.com/dsherret
David Sherret (dsherret)https://github.com/dsherret
on Sep 11, 2015https://github.com/microsoft/TypeScript/issues/4742#issue-105943263
#4432https://github.com/microsoft/TypeScript/issues/4432
David Sherret (dsherret)https://github.com/dsherret
on Sep 11, 2015https://github.com/microsoft/TypeScript/issues/4742#event-406720283
https://github.com/dsherret
David Sherret (dsherret)https://github.com/dsherret
on Sep 11, 2015https://github.com/microsoft/TypeScript/issues/4742#issuecomment-139454715
David Sherret (dsherret)https://github.com/dsherret
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Sep 11, 2015https://github.com/microsoft/TypeScript/issues/4742#event-406739255
https://github.com/ziahamza
hamza zia (ziahamza)https://github.com/ziahamza
on Sep 11, 2015https://github.com/microsoft/TypeScript/issues/4742#issuecomment-139570502
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
on Sep 11, 2015https://github.com/microsoft/TypeScript/issues/4742#issuecomment-139611695
#1260https://github.com/microsoft/TypeScript/issues/1260
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
on Sep 11, 2015https://github.com/microsoft/TypeScript/issues/4742#event-407336269
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
In DiscussionNot yet reached consensushttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22In%20Discussion%22
on Sep 11, 2015https://github.com/microsoft/TypeScript/issues/4742#event-407338411
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Accepting PRshttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Accepting%20PRs%22
In DiscussionNot yet reached consensushttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22In%20Discussion%22
on Oct 19, 2015https://github.com/microsoft/TypeScript/issues/4742#event-439584956
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
on Oct 19, 2015https://github.com/microsoft/TypeScript/issues/4742#event-439638642
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Effort: ModerateRequires experience with the TypeScript codebase, but feasible. Harder than "Effort: Casual".https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Effort%3A%20Moderate%22
on Oct 19, 2015https://github.com/microsoft/TypeScript/issues/4742#event-439638709
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
on Oct 19, 2015https://github.com/microsoft/TypeScript/issues/4742#issuecomment-149349311
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
on Oct 23, 2015https://github.com/microsoft/TypeScript/issues/4742#event-444197437
https://github.com/JsonFreeman
Jason Freeman (JsonFreeman)https://github.com/JsonFreeman
on Dec 3, 2015https://github.com/microsoft/TypeScript/issues/4742#issuecomment-161580281
Ryan Cavanaugh (@RyanCavanaugh)https://github.com/RyanCavanaugh
https://github.com/hesselink
Erik Hesselink (hesselink)https://github.com/hesselink
on Dec 8, 2015https://github.com/microsoft/TypeScript/issues/4742#issuecomment-162892903
https://github.com/tiagoefmoraes
Tiago Moraes (tiagoefmoraes)https://github.com/tiagoefmoraes
on Jan 27, 2017https://github.com/microsoft/TypeScript/issues/4742#issuecomment-275657312
https://github.com/masaeedu
Asad Saeeduddin (masaeedu)https://github.com/masaeedu
on Jul 31, 2017https://github.com/microsoft/TypeScript/issues/4742#issuecomment-319001060
https://github.com/thorn0
Georgii Dolzhykov (thorn0)https://github.com/thorn0
on Jul 17, 2018https://github.com/microsoft/TypeScript/issues/4742#issuecomment-405673908
https://github.com/thorn0
Georgii Dolzhykov (thorn0)https://github.com/thorn0
on Jul 17, 2018https://github.com/microsoft/TypeScript/issues/4742#issuecomment-405675506
https://github.com/rolfvandekrol
Rolf van de Krol (rolfvandekrol)https://github.com/rolfvandekrol
on Sep 18, 2018https://github.com/microsoft/TypeScript/issues/4742#issuecomment-422366869
https://github.com/jack-williams
Jack Williams (jack-williams)https://github.com/jack-williams
on Sep 18, 2018https://github.com/microsoft/TypeScript/issues/4742#issuecomment-422403477
Rolf van de Krol (@rolfvandekrol)https://github.com/rolfvandekrol
#21483https://github.com/microsoft/TypeScript/pull/21483
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Communityhttps://github.com/microsoft/TypeScript/milestone/2
Backloghttps://github.com/microsoft/TypeScript/milestone/29
on Mar 7, 2019https://github.com/microsoft/TypeScript/issues/4742#event-2188551658
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
on Jan 7, 2020https://github.com/microsoft/TypeScript/issues/4742#event-2929423086
https://github.com/dartess
Sergey Kozlov (dartess)https://github.com/dartess
on Aug 26, 2020https://github.com/microsoft/TypeScript/issues/4742#issuecomment-680845057
https://stackoverflow.com/questions/63594468/type-guard-dont-work-with-generic-paramshttps://stackoverflow.com/questions/63594468/type-guard-dont-work-with-generic-params
https://github.com/Zzzen
Zzzen (Zzzen)https://github.com/Zzzen
on May 16, 2021https://github.com/microsoft/TypeScript/issues/4742#issuecomment-841805502
Georgii Dolzhykov (@thorn0)https://github.com/thorn0
https://github.com/parzhitsky
Dmytro Parzhytskyi (parzhitsky)https://github.com/parzhitsky
on Sep 17, 2021https://github.com/microsoft/TypeScript/issues/4742#issuecomment-922010490
thishttps://tsplay.dev/N52oMm
thishttps://tsplay.dev/wQKDvm
in generic functions as wellhttps://tsplay.dev/wED9ZW
thishttps://tsplay.dev/m0LkRm
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
on Mar 22, 2023https://github.com/microsoft/TypeScript/issues/4742#issuecomment-1479901191
#4742 (comment)https://github.com/microsoft/TypeScript/issues/4742#issuecomment-405675506
Andrew Branch (andrewbranch)https://github.com/andrewbranch
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Mar 22, 2023https://github.com/microsoft/TypeScript/issues/4742#event-8818979846
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/4742
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/4742
Effort: ModerateRequires experience with the TypeScript codebase, but feasible. Harder than "Effort: Casual".https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Effort%3A%20Moderate%22
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
BacklogNo due datehttps://github.com/microsoft/TypeScript/milestone/29
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.