René's URL Explorer Experiment


Title: Question: Desired behavior of triple-slash references in commonjs modules · Issue #4694 · microsoft/TypeScript · GitHub

Open Graph Title: Question: Desired behavior of triple-slash references in commonjs modules · Issue #4694 · microsoft/TypeScript

X Title: Question: Desired behavior of triple-slash references in commonjs modules · Issue #4694 · microsoft/TypeScript

Description: Here's an example demonstrating what I'm about to ask about. As of the TS 1.6 beta, we've started following package references for typings! Cool! This lets us use patterns more familiar to commonjs package consumers to distribute types, ...

Open Graph Description: Here's an example demonstrating what I'm about to ask about. As of the TS 1.6 beta, we've started following package references for typings! Cool! This lets us use patterns more familiar to commonjs...

X Description: Here's an example demonstrating what I'm about to ask about. As of the TS 1.6 beta, we've started following package references for typings! Cool! This lets us use patterns more familiar...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/4694

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Question: Desired behavior of triple-slash references in commonjs modules","articleBody":"[Here's an example](https://github.com/weswigham/typed-node) demonstrating what I'm about to ask about.\n\nAs of the TS 1.6 beta, we've started following package references for typings! Cool! This lets us use patterns more familiar to commonjs package consumers to distribute types, which is awesome! There's in interesting issue, though. I'm ignoring the global ambient module scoping problem - let's say I plan to use proper external modules all the time.\n\nWhen this is the case, if I _do_ want to pollute the global scope, it is impossible for me to do so _within the typings file found by TS_. (Since it's an external module, all its types are internal except those exported.) However, by `/// ref`'ing a file which globally pollutes, I can presently globally pollute. Given that external modules aren't supposed to leak types, this is... awkward. This is a result of how loosely we add `///ref`'d files versus those found via module resolution. While it works as a global scope pollution workaround at present, I think this behavior is something we should change/scope/specify _before_ the full release of TS 1.6, or it could result in some bad behavior in these cases.\n\nInterestingly, these globals don't get injected into the global scope until you add\n\n``` ts\nimport \"typed-node\";\n```\n\nwhich looks up the module (and injects the ref in the found module). Honestly, in an external module `.d.ts`, I'm not sure the behavior of this statement was ever really specced, which is why I'm bringing it up. The compiler would _never emit this statement itself_ into a `.d.ts` from what I can tell, yet we do interesting things when we read it in one.\n\nI have no issue with this statement in a `.d.ts`. Actually, I think this is quite nice from the perspective of how it gets used, using the import-for-side-effects to just pull in globals (AKA typesystem side effects) actually feels right. Here's the problem, though - when the module I've written that `import` in gets `import`ed (in any way), now the containing package has that ref file and its types in its scope, too.\n\nThis means that `import * as http from \"typed-http\"` inadvertently adds `Buffer` to the global scope! `Buffer`'s not even defined in that module! It's in a different package entirely! And `typed-http` _never explicitly exported it_, despite being a proper external module!\n\nWhat I'd like to see is that \"global\" Buffer available in packages which have _explicitly_ done `import \"typed-node\"`. In effect, importing a package for side effects could merge its globals into yours (but not the other way around), and those globals are _never_ leaked into a containing package otherwise. If this were the case, then different packages could rely on different versions of \"typed-node\" without fear. (Without polluting the environment of those who only access their explicit exports!)\n","author":{"url":"https://github.com/weswigham","@type":"Person","name":"weswigham"},"datePublished":"2015-09-08T19:08:50Z","url":"https://github.com/microsoft/TypeScript/issues/4694"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:6625d373-59c8-e0bf-8caf-26e040697b08
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC5AC:95C88:EAD011:13771F5:6B0101C6
html-safe-nonce61befc8bfe8cfdab1f4dbe26c20d0622040c825e1986aa312b6541ab8986a9c7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNUFDOjk1Qzg4OkVBRDAxMToxMzc3MUY1OjZCMDEwMUM2IiwidmlzaXRvcl9pZCI6IjYxMzM3NjQwOTU2NzkyMDE3MzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac0001cc67a50ebc7fa04395add0d4e6bee47a77a2eaa072aa35c57eaf618cc92a
hovercard-subject-tagissue:105450018
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/4694/issue_layout
twitter:imagehttps://opengraph.githubassets.com/7d45f165aa8c0fb395cfb1cc4c144f9b4ed7c23c8e9e3ee38439275bb2b06ec6/microsoft/TypeScript/issues/4694
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7d45f165aa8c0fb395cfb1cc4c144f9b4ed7c23c8e9e3ee38439275bb2b06ec6/microsoft/TypeScript/issues/4694
og:image:altHere's an example demonstrating what I'm about to ask about. As of the TS 1.6 beta, we've started following package references for typings! Cool! This lets us use patterns more familiar to commonjs...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameweswigham
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/4694#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F4694
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F4694
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/4694
Reloadhttps://github.com/microsoft/TypeScript/issues/4694
Reloadhttps://github.com/microsoft/TypeScript/issues/4694
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/4694
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/4694
Question: Desired behavior of triple-slash references in commonjs moduleshttps://github.com/microsoft/TypeScript/issues/4694#top
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
on Sep 8, 2015https://github.com/microsoft/TypeScript/issues/4694#issue-105450018
Here's an examplehttps://github.com/weswigham/typed-node
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
QuestionAn issue which isn't directly actionable in codehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Question%22
QuestionAn issue which isn't directly actionable in codehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Question%22
on Sep 8, 2015https://github.com/microsoft/TypeScript/issues/4694#event-404074231
https://github.com/jbrantly
James Brantly (jbrantly)https://github.com/jbrantly
on Sep 9, 2015https://github.com/microsoft/TypeScript/issues/4694#issuecomment-138757430
#4668https://github.com/microsoft/TypeScript/issues/4668
https://github.com/jbrantly
James Brantly (jbrantly)https://github.com/jbrantly
on Sep 9, 2015https://github.com/microsoft/TypeScript/issues/4694#issuecomment-138898629
Wesley Wigham (@weswigham)https://github.com/weswigham
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
on Sep 17, 2015https://github.com/microsoft/TypeScript/issues/4694#issuecomment-141275937
#4738https://github.com/microsoft/TypeScript/pull/4738
#4665https://github.com/microsoft/TypeScript/issues/4665
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Sep 17, 2015https://github.com/microsoft/TypeScript/issues/4694#event-412698515
microsofthttps://github.com/microsoft
on Jun 19, 2018https://github.com/microsoft/TypeScript/issues/4694#event-1689614405
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/4694
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/4694
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.