René's URL Explorer Experiment


Title: Module conversion work · Issue #46744 · microsoft/TypeScript · GitHub

Open Graph Title: Module conversion work · Issue #46744 · microsoft/TypeScript

X Title: Module conversion work · Issue #46744 · microsoft/TypeScript

Description: This issue is to keep track of the module conversion work, which is ongoing at #46567: Update the old conversion script to working state. Done, keep track of the code in a new fork to working state. Script the generation so it can be con...

Open Graph Description: This issue is to keep track of the module conversion work, which is ongoing at #46567: Update the old conversion script to working state. Done, keep track of the code in a new fork to working state...

X Description: This issue is to keep track of the module conversion work, which is ongoing at #46567: Update the old conversion script to working state. Done, keep track of the code in a new fork to working state...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/46744

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Module conversion work","articleBody":"This issue is to keep track of the module conversion work, which is ongoing at #46567:\r\n\r\n- [x] Update the [old conversion script](https://github.com/weswigham/typeformer) to working state. \\\r\n  Done, keep track of the code in [a new fork](https://github.com/elibarzilay/typeformer) to working state.\r\n- [x] Script the generation so it can be continuously rebased on the tip: done in the [run-transform](https://github.com/elibarzilay/typeformer/blob/master/run-transform) script.\r\n- [x] Make the tests run, similar to [1c3944343ee8](https://github.com/weswigham/TypeScript/commit/1c39443) in Wesley's PR: included in the current PR, and generated via the script.\r\n- [x] Fix treatment of newlines, mainly a bug that changes CRLF to LF if running on linux.\r\n- [ ] Make the diff more readable\r\n  - [x] [Pre-script](https://github.com/elibarzilay/typeformer/blob/master/src/unindent.ts) that unindents the code in a separate commit, which avoids a huge mass of mostly no-op changes.\r\n  - [x] Drop the many empty-line removals from the conversion diff.  Done by [another script](https://github.com/elibarzilay/typeformer/blob/master/src/filter-patch.ts) that filters the resulting patch before applying it.\r\n  - [ ] Possibly re-implement the conversion using [ts-morph](https://github.com/dsherret/ts-morph) to make it more well-behaved wrt unnecessary changes (adding/removing newlines, still some comments get dropped, minor issues like changing `,`s to `;`s or dropping a suffix `,` in argument lists).\r\n- [ ] Bundle results\r\n  - [x] Decide on a bundler: most likely [esbuild](https://esbuild.github.io/), since it fast enough to make multiple bundles (eg, for testing and for distributing) possible.\r\n  - [ ] Need to decide how to use it:\r\n    - Can run on the generated JS: will probably be sensitive to the generated format. \\\r\n      Main problem: the modules are expressed indirectly which is more likely to cause problems.\r\n    - A possibly better option is to run directly from the TS sources.  This has a big issue of not dog-fooding `tsc`, but that could possibly still be used for testing (but see below).\r\n  - [ ] Should also re-do the `src/tsserverlibrary` and `src/typescriptServices` stubs.\r\n  - [ ] Some other files that need to be sorted out:\r\n    - `src/instrumenter` (including `src/loggedIO/tsconfig-tsc-instrumented.json`)\r\n    - `src/services/exportAsModule.ts`\r\n- [ ] Running the tests takes around 1.5x more time with the modules.\r\n  - This might be resolved if running from a bundle, but if this and the actual bundles are done with esbuild then there's no dogfooding at all.\r\n- [ ] There are a few tests that still fail (12) -- should be resolved when there are bundles.\r\n- [ ] Make the parallel tests work.  (This depends on the resolution of the above, since it's an issue with how the tests are implemented wrt the global `describe` binding.)\r\n- [ ] API extractor.\r\n- [ ] Make the linter happy.\r\n- [ ] Possibly a cleanup step, like getting rid of re-exporting modules\r\n  for direct imports, and related (like `*Impl.ts` files).\r\n","author":{"url":"https://github.com/elibarzilay","@type":"Person","name":"elibarzilay"},"datePublished":"2021-11-09T13:08:11Z","url":"https://github.com/microsoft/TypeScript/issues/46744"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:75fe9e7a-8bc2-21b4-55f1-affd6d6bc391
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idABDC:36A3E:1ACE455:23B2985:6B015CD9
html-safe-nonceba33b9900d6434c78f34738414141dbe9e0ad208a031cdea38b6357dc9b65625
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQkRDOjM2QTNFOjFBQ0U0NTU6MjNCMjk4NTo2QjAxNUNEOSIsInZpc2l0b3JfaWQiOiI0MzAxMTE3MTU4Mzg3MTc4NzEzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac07a5a488c55d08b812e924699a58a906ce3eabc5de82373999c96713a9572f21
hovercard-subject-tagissue:1048586677
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/46744/issue_layout
twitter:imagehttps://opengraph.githubassets.com/a6296ddc896e1521029c6b77df3933a4b4c27de9ff9367b21eed27396996df0d/microsoft/TypeScript/issues/46744
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a6296ddc896e1521029c6b77df3933a4b4c27de9ff9367b21eed27396996df0d/microsoft/TypeScript/issues/46744
og:image:altThis issue is to keep track of the module conversion work, which is ongoing at #46567: Update the old conversion script to working state. Done, keep track of the code in a new fork to working state...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameelibarzilay
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/46744#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F46744
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F46744
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/46744
Reloadhttps://github.com/microsoft/TypeScript/issues/46744
Reloadhttps://github.com/microsoft/TypeScript/issues/46744
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/46744
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/46744
Module conversion workhttps://github.com/microsoft/TypeScript/issues/46744#top
https://github.com/jakebailey
DiscussionIssues which may not have code impacthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Discussion%22
https://github.com/elibarzilay
Eli Barzilay (elibarzilay)https://github.com/elibarzilay
on Nov 9, 2021https://github.com/microsoft/TypeScript/issues/46744#issue-1048586677
#46567https://github.com/microsoft/TypeScript/pull/46567
old conversion scripthttps://github.com/weswigham/typeformer
a new forkhttps://github.com/elibarzilay/typeformer
run-transformhttps://github.com/elibarzilay/typeformer/blob/master/run-transform
1c3944343ee8https://github.com/weswigham/TypeScript/commit/1c39443
Pre-scripthttps://github.com/elibarzilay/typeformer/blob/master/src/unindent.ts
another scripthttps://github.com/elibarzilay/typeformer/blob/master/src/filter-patch.ts
ts-morphhttps://github.com/dsherret/ts-morph
esbuildhttps://esbuild.github.io/
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
on Nov 9, 2021https://github.com/microsoft/TypeScript/issues/46744#issuecomment-964346978
herehttps://github.com/evanw/esbuild/issues/128
Andrew Branch (andrewbranch)https://github.com/andrewbranch
DiscussionIssues which may not have code impacthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Discussion%22
on Nov 9, 2021https://github.com/microsoft/TypeScript/issues/46744#event-5592081295
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Eli Barzilay (elibarzilay)https://github.com/elibarzilay
on Nov 9, 2021https://github.com/microsoft/TypeScript/issues/46744#event-5592081650
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
on Nov 9, 2021https://github.com/microsoft/TypeScript/issues/46744#issuecomment-964463242
Eli Barzilay (elibarzilay)https://github.com/elibarzilay
on Dec 2, 2021https://github.com/microsoft/TypeScript/issues/46744#event-5708971258
optimize `__createBinding`https://github.com/elibarzilay/TypeScript/commit/0dc4b0068923f9534b97e48b0e7ab509698574cb
0dc4b00https://github.com/elibarzilay/TypeScript/commit/0dc4b0068923f9534b97e48b0e7ab509698574cb
Eli Barzilay (elibarzilay)https://github.com/elibarzilay
on Jan 10, 2022https://github.com/microsoft/TypeScript/issues/46744#event-5868648181
optimize `__createBinding`https://github.com/elibarzilay/TypeScript/commit/77334527b203e6ab3ce86ceb6484436ac8afca8e
7733452https://github.com/elibarzilay/TypeScript/commit/77334527b203e6ab3ce86ceb6484436ac8afca8e
optimize `__createBinding`https://github.com/elibarzilay/TypeScript/commit/2a983d867eafa444bb5783ca6de881b40a324dd5
2a983d8https://github.com/elibarzilay/TypeScript/commit/2a983d867eafa444bb5783ca6de881b40a324dd5
optimize `__createBinding`https://github.com/elibarzilay/TypeScript/commit/0876b6bb7b032c04b1fb7d8e4a010f93c249b503
0876b6bhttps://github.com/elibarzilay/TypeScript/commit/0876b6bb7b032c04b1fb7d8e4a010f93c249b503
optimize `__createBinding`https://github.com/microsoft/TypeScript/commit/ce18254c776782a938bd55046d93871e176d6172
ce18254https://github.com/microsoft/TypeScript/commit/ce18254c776782a938bd55046d93871e176d6172
Jake Bailey (jakebailey)https://github.com/jakebailey
on Feb 7, 2022https://github.com/microsoft/TypeScript/issues/46744#event-6022856491
Jake Bailey (jakebailey)https://github.com/jakebailey
Eli Barzilay (elibarzilay)https://github.com/elibarzilay
on May 18, 2022https://github.com/microsoft/TypeScript/issues/46744#event-6636314694
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
on May 31, 2022https://github.com/microsoft/TypeScript/issues/46744#issuecomment-1142787418
#49332https://github.com/microsoft/TypeScript/issues/49332
Jake Bailey (jakebailey)https://github.com/jakebailey
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on May 31, 2022https://github.com/microsoft/TypeScript/issues/46744#event-6713811014
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/46744
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/46744
Jake Bailey (jakebailey)https://github.com/jakebailey
DiscussionIssues which may not have code impacthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Discussion%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.