René's URL Explorer Experiment


Title: Formatting error when JSX element contains invalid JS identifier · Issue #4636 · microsoft/TypeScript · GitHub

Open Graph Title: Formatting error when JSX element contains invalid JS identifier · Issue #4636 · microsoft/TypeScript

X Title: Formatting error when JSX element contains invalid JS identifier · Issue #4636 · microsoft/TypeScript

Description: If tests/cases/fourslash/formattingJsxElements.ts is amended as follows (adding data-id="test" to the

): /// //@Filename: file.tsx ////function () { //// return ( ////

Open Graph Description: If tests/cases/fourslash/formattingJsxElements.ts is amended as follows (adding data-id="test" to the

): /// //@Filename: file.tsx ////function () { //// retu...

X Description: If tests/cases/fourslash/formattingJsxElements.ts is amended as follows (adding data-id="test" to the <div>): /// <reference path='fourslash.ts' /> //@Filename: file.t...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/4636

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Formatting error when JSX element contains invalid JS identifier","articleBody":"If `tests/cases/fourslash/formattingJsxElements.ts` is amended as follows (adding `data-id=\"test\"` to the `\u003cdiv>`):\n\n``` typescript\n/// \u003creference path='fourslash.ts' />\n\n//@Filename: file.tsx\n////function () {\n////    return (\n////        \u003cdiv className=\"commentBox\" data-id=\"test\">\n////Hello, World!/*autoformat*/\n/////*indent*/\n////        \u003c/div>\n////    )\n////}\n////\n\n\nformat.document();\ngoTo.marker(\"autoformat\");\nverify.currentLineContentIs('            Hello, World!');\ngoTo.marker(\"indent\");\nverify.indentationIs(12);\n```\n\nand then run, we see a failure:\n\n```\n$ jake runtests tests=tests/cases/fourslash/formattingJsxElements.ts\nrm -rf tests/baselines/local/\nrm -rf internal/baselines/rwc/local\nRunning test(s): tests/cases/fourslash/formattingJsxElements.ts\nmocha -R mocha-fivemat-progress-reporter -g tests/cases/fourslash/formattingJsxElements.ts --colors  -t 20000 built/local/run.js\n\n    fourslash tests\n\nTest failure:\nfourslash test formattingJsxElements.ts runs correctly\n  [․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․]\n\n  0 passing (196ms)\n  1 failing\n\n  1) fourslash tests tests/cases/fourslash/formattingJsxElements.ts fourslash test formattingJsxElements.ts runs correctly:\n     Error: Debug Failure. False expression:\n      at Object.assert (eval at \u003canonymous> (built/local/run.js:54637:13), \u003canonymous>:1558:23)\n```\n\nThis backs up what we're seeing in actual `.tsx` files that are being formatted with [`typescript-formatter`](https://github.com/vvakame/typescript-formatter), i.e. that non-valid JS identifier attributes are causing the formatter to fall over. \n\nThis feels like something the formatter should be able to handle.\n\nThoughts?\n","author":{"url":"https://github.com/myitcv","@type":"Person","name":"myitcv"},"datePublished":"2015-09-04T09:09:12Z","url":"https://github.com/microsoft/TypeScript/issues/4636"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:76cee430-15df-adb7-56df-51bf33865b78
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD7F6:95C88:50277C:6CA712:6B00CD93
html-safe-nonce324ea27651a9dc7f82af079ad887509bb4eebd92e36e98e769f67c2199f023aa
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEN0Y2Ojk1Qzg4OjUwMjc3Qzo2Q0E3MTI6NkIwMENEOTMiLCJ2aXNpdG9yX2lkIjoiNDUwMDQ3OTMwMTA2NTQyODM3MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac81ab43b8a410b523de3744e7801a076cc93ef6391d0adec8fc8a1e67e6e9fd1b
hovercard-subject-tagissue:104854476
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/4636/issue_layout
twitter:imagehttps://opengraph.githubassets.com/b45694f43a0dcd2794f7917fbde5899e6cf6231338b8d986f16a888a5093d487/microsoft/TypeScript/issues/4636
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b45694f43a0dcd2794f7917fbde5899e6cf6231338b8d986f16a888a5093d487/microsoft/TypeScript/issues/4636
og:image:altIf tests/cases/fourslash/formattingJsxElements.ts is amended as follows (adding data-id="test" to the
): /// //@Filename: file.tsx ////function () { //// retu...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemyitcv
hostnamegithub.com
expected-hostnamegithub.com
None85bbdfe2b6ba16e234513bc6ceff5d848ef8449820c900692a2b4e67061931e5
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4943239a6d2c591325dad6e5c313e1cafda877f6
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/4636#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F4636
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F4636
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/4636
Reloadhttps://github.com/microsoft/TypeScript/issues/4636
Reloadhttps://github.com/microsoft/TypeScript/issues/4636
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests307 (307)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/4636
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/4636
Formatting error when JSX element contains invalid JS identifierhttps://github.com/microsoft/TypeScript/issues/4636#top
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
TypeScript 1.6.2https://github.com/microsoft/TypeScript/milestone/13
https://github.com/myitcv
Paul Jolly (myitcv)https://github.com/myitcv
on Sep 4, 2015https://github.com/microsoft/TypeScript/issues/4636#issue-104854476
typescript-formatterhttps://github.com/vvakame/typescript-formatter
Vladimir Matveev (vladima)https://github.com/vladima
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
on Sep 4, 2015https://github.com/microsoft/TypeScript/issues/4636#event-401304562
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
TypeScript 1.6.2https://github.com/microsoft/TypeScript/milestone/13
on Sep 4, 2015https://github.com/microsoft/TypeScript/issues/4636#event-401529739
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Vladimir Matveev (vladima)https://github.com/vladima
on Sep 4, 2015https://github.com/microsoft/TypeScript/issues/4636#event-401529765
Vladimir Matveev (vladima)https://github.com/vladima
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#4646https://github.com/microsoft/TypeScript/pull/4646
on Sep 4, 2015https://github.com/microsoft/TypeScript/issues/4636#event-401529793
Vladimir Matveev (vladima)https://github.com/vladima
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
on Sep 4, 2015https://github.com/microsoft/TypeScript/issues/4636#event-401529980
https://github.com/myitcv
Paul Jolly (myitcv)https://github.com/myitcv
on Sep 6, 2015https://github.com/microsoft/TypeScript/issues/4636#issuecomment-138108682
Vladimir Matveev (@vladima)https://github.com/vladima
microsofthttps://github.com/microsoft
on Jun 19, 2018https://github.com/microsoft/TypeScript/issues/4636#event-1689613807
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Vladimir Matveev (vladima)https://github.com/vladima
on Jun 19, 2018https://github.com/microsoft/TypeScript/issues/4636#event-1689613811
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/4636
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/4636
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
TypeScript 1.6.2https://github.com/microsoft/TypeScript/milestone/13
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.