//@Filename: file.tsx ////function () { //// retu...
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Formatting error when JSX element contains invalid JS identifier","articleBody":"If `tests/cases/fourslash/formattingJsxElements.ts` is amended as follows (adding `data-id=\"test\"` to the `\u003cdiv>`):\n\n``` typescript\n/// \u003creference path='fourslash.ts' />\n\n//@Filename: file.tsx\n////function () {\n//// return (\n//// \u003cdiv className=\"commentBox\" data-id=\"test\">\n////Hello, World!/*autoformat*/\n/////*indent*/\n//// \u003c/div>\n//// )\n////}\n////\n\n\nformat.document();\ngoTo.marker(\"autoformat\");\nverify.currentLineContentIs(' Hello, World!');\ngoTo.marker(\"indent\");\nverify.indentationIs(12);\n```\n\nand then run, we see a failure:\n\n```\n$ jake runtests tests=tests/cases/fourslash/formattingJsxElements.ts\nrm -rf tests/baselines/local/\nrm -rf internal/baselines/rwc/local\nRunning test(s): tests/cases/fourslash/formattingJsxElements.ts\nmocha -R mocha-fivemat-progress-reporter -g tests/cases/fourslash/formattingJsxElements.ts --colors -t 20000 built/local/run.js\n\n fourslash tests\n\nTest failure:\nfourslash test formattingJsxElements.ts runs correctly\n [․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․]\n\n 0 passing (196ms)\n 1 failing\n\n 1) fourslash tests tests/cases/fourslash/formattingJsxElements.ts fourslash test formattingJsxElements.ts runs correctly:\n Error: Debug Failure. False expression:\n at Object.assert (eval at \u003canonymous> (built/local/run.js:54637:13), \u003canonymous>:1558:23)\n```\n\nThis backs up what we're seeing in actual `.tsx` files that are being formatted with [`typescript-formatter`](https://github.com/vvakame/typescript-formatter), i.e. that non-valid JS identifier attributes are causing the formatter to fall over. \n\nThis feels like something the formatter should be able to handle.\n\nThoughts?\n","author":{"url":"https://github.com/myitcv","@type":"Person","name":"myitcv"},"datePublished":"2015-09-04T09:09:12Z","url":"https://github.com/microsoft/TypeScript/issues/4636"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:76cee430-15df-adb7-56df-51bf33865b78 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D7F6:95C88:50277C:6CA712:6B00CD93 |
| html-safe-nonce | 324ea27651a9dc7f82af079ad887509bb4eebd92e36e98e769f67c2199f023aa |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEN0Y2Ojk1Qzg4OjUwMjc3Qzo2Q0E3MTI6NkIwMENEOTMiLCJ2aXNpdG9yX2lkIjoiNDUwMDQ3OTMwMTA2NTQyODM3MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 81ab43b8a410b523de3744e7801a076cc93ef6391d0adec8fc8a1e67e6e9fd1b |
| hovercard-subject-tag | issue:104854476 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/issues_fragments/issue_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/4636/issue_layout |
| twitter:image | https://opengraph.githubassets.com/b45694f43a0dcd2794f7917fbde5899e6cf6231338b8d986f16a888a5093d487/microsoft/TypeScript/issues/4636 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b45694f43a0dcd2794f7917fbde5899e6cf6231338b8d986f16a888a5093d487/microsoft/TypeScript/issues/4636 |
| og:image:alt | If tests/cases/fourslash/formattingJsxElements.ts is amended as follows (adding data-id="test" to the ): /// //@Filename: file.tsx ////function () { //// retu... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | myitcv |
| hostname | github.com |
| expected-hostname | github.com |
| None | 85bbdfe2b6ba16e234513bc6ceff5d848ef8449820c900692a2b4e67061931e5 |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4943239a6d2c591325dad6e5c313e1cafda877f6 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
| Skip to content | https://github.com/microsoft/TypeScript/issues/4636#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F4636 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F4636 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/issues/4636 |
| Reload | https://github.com/microsoft/TypeScript/issues/4636 |
| Reload | https://github.com/microsoft/TypeScript/issues/4636 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests307 (307) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| New issue | https://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/4636 |
| New issue | https://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/4636 |
| Formatting error when JSX element contains invalid JS identifier | https://github.com/microsoft/TypeScript/issues/4636#top |
| BugA bug in TypeScript | https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22 |
| FixedA PR has been merged for this issue | https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22 |
| TypeScript 1.6.2 | https://github.com/microsoft/TypeScript/milestone/13 |
| https://github.com/myitcv |
| Paul Jolly (myitcv) | https://github.com/myitcv |
| on Sep 4, 2015 | https://github.com/microsoft/TypeScript/issues/4636#issue-104854476 |
| typescript-formatter | https://github.com/vvakame/typescript-formatter |
| Vladimir Matveev (vladima) | https://github.com/vladima |
| BugA bug in TypeScript | https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22 |
| on Sep 4, 2015 | https://github.com/microsoft/TypeScript/issues/4636#event-401304562 |
| Mohamed Hegazy (mhegazy) | https://github.com/mhegazy |
| TypeScript 1.6.2 | https://github.com/microsoft/TypeScript/milestone/13 |
| on Sep 4, 2015 | https://github.com/microsoft/TypeScript/issues/4636#event-401529739 |
| Mohamed Hegazy (mhegazy) | https://github.com/mhegazy |
| Vladimir Matveev (vladima) | https://github.com/vladima |
| on Sep 4, 2015 | https://github.com/microsoft/TypeScript/issues/4636#event-401529765 |
| Vladimir Matveev (vladima) | https://github.com/vladima |
| completed | https://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted |
| #4646 | https://github.com/microsoft/TypeScript/pull/4646 |
| on Sep 4, 2015 | https://github.com/microsoft/TypeScript/issues/4636#event-401529793 |
| Vladimir Matveev (vladima) | https://github.com/vladima |
| FixedA PR has been merged for this issue | https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22 |
| on Sep 4, 2015 | https://github.com/microsoft/TypeScript/issues/4636#event-401529980 |
| https://github.com/myitcv |
| Paul Jolly (myitcv) | https://github.com/myitcv |
| on Sep 6, 2015 | https://github.com/microsoft/TypeScript/issues/4636#issuecomment-138108682 |
| Vladimir Matveev (@vladima) | https://github.com/vladima |
| microsoft | https://github.com/microsoft |
| on Jun 19, 2018 | https://github.com/microsoft/TypeScript/issues/4636#event-1689613807 |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Vladimir Matveev (vladima) | https://github.com/vladima |
| on Jun 19, 2018 | https://github.com/microsoft/TypeScript/issues/4636#event-1689613811 |
| Sign up for free | https://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/4636 |
| Sign in to comment | https://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/4636 |
| BugA bug in TypeScript | https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22 |
| FixedA PR has been merged for this issue | https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22 |
| TypeScript 1.6.2 | https://github.com/microsoft/TypeScript/milestone/13 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |
.