Title: When using generic pick, object deconstruction does not provide valid keys to select · Issue #45663 · microsoft/TypeScript · GitHub
Open Graph Title: When using generic pick, object deconstruction does not provide valid keys to select · Issue #45663 · microsoft/TypeScript
X Title: When using generic pick, object deconstruction does not provide valid keys to select · Issue #45663 · microsoft/TypeScript
Description: Bug Report 🔎 Search Terms Generic pick on object, type part of object, deconstructing of pick shows all keys of object 🕗 Version & Regression Information This is a crash This first occured today when trying to make some generic object pi...
Open Graph Description: Bug Report 🔎 Search Terms Generic pick on object, type part of object, deconstructing of pick shows all keys of object 🕗 Version & Regression Information This is a crash This first occured today wh...
X Description: Bug Report 🔎 Search Terms Generic pick on object, type part of object, deconstructing of pick shows all keys of object 🕗 Version & Regression Information This is a crash This first occured toda...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/45663
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"When using generic pick, object deconstruction does not provide valid keys to select","articleBody":"# Bug Report\r\n\r\n\u003c!--\r\n Please fill in each section completely. Thank you!\r\n-->\r\n\r\n### 🔎 Search Terms\r\n\r\n\u003c!--\r\n What search terms did you use when trying to find an existing bug report?\r\n List them here so people in the future can find this one more easily.\r\n-->\r\n\r\nGeneric pick on object, type part of object, deconstructing of pick shows all keys of object\r\n\r\n### 🕗 Version & Regression Information\r\n\r\n\u003c!-- When did you start seeing this bug occur?\r\n\r\n\"Bugs\" that have existed in TS for a long time are very likely to be FAQs; refer to\r\n https://github.com/Microsoft/TypeScript/wiki/FAQ#common-bugs-that-arent-bugs\r\n\r\nIf possible, please try testing the nightly version of TS to see if it's already been fixed.\r\nFor npm: `typescript@next`\r\nThis is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly\r\n\r\nNote: The TypeScript Playground can be used to try older versions of TypeScript.\r\n\r\nPlease keep and fill in the line that best applies:\r\n-->\r\n- This is a crash\r\n- This first occured today when trying to make some generic object picker\r\n- It was tested on TS 4.3.5 and 4.4.2\r\n- It occures both in TypescriptPlayground and Visual Studio Code\r\n- It decrease developer experience as deconstruction can't be used\r\n\r\n### ⏯ Playground Link\r\n\r\n\u003c!--\r\n A link to a TypeScript Playground \"Share\" link which shows this behavior\r\n\r\n The TypeScript Workbench can be used for more complex setups, try\r\n https://www.typescriptlang.org/dev/bug-workbench/\r\n\r\n As a last resort, you can link to a repo, but these will be slower for us to investigate.\r\n-->\r\n[Playground link with relevant code](https://www.typescriptlang.org/play?ts=4.4.2#code/JYOwLgpgTgZghgYwgAgLJwA4egHgCrIC8ycIAngDTIBKRJ5AfMgN4BQyHyAFHFAOYAuZHgCUQ6gG5WAX1asYAVxAIwwAPYhkGYAgDWOAPJUCEAB6QQAEwDOyXRDJqYyAwy72y1oXgDaAXSo1ACMAKwB+IQMxZAAFHX0jYQYpRWVVDS14-DcPL2F-aPQsaBSlFXVNbT1DY2QzCxs7BycXHIc83wDkYPDIkRZ2TgQNazBMvWghIuwoGpZkHwBpZFBhP0ifPD9kaSZiAH0eoiYDUIgVADoIcChgCGsuQ9CRC6gISwUkLi41Kh8PKgANzgABs-P1CEw2JwYStnO52hdQAgQQpLPcEWQSLZRP01P8HNi1nRgSCpLDOG8wAooJo1OTONIqMxpES4tVEngGCIpIMOFSaXTQsgwuN7FAfs9kEIquKpLJWMMQKN5nAqEEdnRZVwfAByIK6rrMEhCXVwXXq00Gnb9AD0toAFtAUGAnSQFGA1NYFHw+PcxtYHWoFCDLMhA2oAO7IDUaEFkRUjMZHYjavUGo0m5Bmi0xq26m2sHoXODIe3IJ1vFZjYC2SNqKC6UB8LRQNQzeNExwKZAIUjdECd6wQEHnMZBOSsIA)\r\n\r\n### 💻 Code\r\n\r\n\u003c!-- Please post the relevant code sample here as well-->\r\n```ts\r\n// We can quickly address your report if:\r\n// - The code sample is short. Nearly all TypeScript bugs can be demonstrated in 20-30 lines of code!\r\n// - It doesn't use external libraries. These are often issues with the type definitions rather than TypeScript bugs.\r\n// - The incorrectness of the behavior is readily apparent from reading the sample.\r\n// Reports are slower to investigate if:\r\n// - We have to pare too much extraneous code.\r\n// - We have to clone a large repo and validate that the problem isn't elsewhere.\r\n// - The sample is confusing or doesn't clearly demonstrate what's wrong.\r\ninterface Mapper\u003cT = any, R = any> {\r\n (arg: T): R;\r\n}\r\n\r\nfunction pick\u003cO, T extends keyof O>(keys: T[], obj?: O): Pick\u003cO, T>;\r\nfunction pick\u003cT>(keys: T[]): Mapper;\r\nfunction pick\u003cO, T extends keyof O>(keys: T[], obj?: O) {\r\n const picker: Mapper\u003cO, { [K in T]: O[T] }> = _obj => Object.entries(_obj).reduce((o, [key, val]) => {\r\n if (keys.includes(key as T)) o[key as T] = val;\r\n return o;\r\n }, {} as Pick\u003cO, T>);\r\n\r\n return obj ? picker(obj) : picker;\r\n}\r\n\r\nconst { a, b } = pick(['b'], { a: 'a', b: 'b' }) //here the autosuggest should show b only\r\nconst obj = pick(['b'], { a: 'a', b: 'b' })\r\nobj.a // here it is working properly as you can only select b\r\n```\r\n\r\n### 🙁 Actual behavior\r\n\r\n\u003c!-- What happened, and why it was wrong -->\r\n\r\nWhen using the deconstruction construction after pick, I can select b as well as a. But the a is not in object returned from pick.\r\nWhen first assigning the return value to const, in later code I can only select b, which is expected.\r\n\r\n### 🙂 Expected behavior\r\n\r\n\u003c!-- What you expected to happen instead, and why -->\r\n\r\nIn deconstruction I should be able to select only keys, that I declared in pick function. The behaviour should be same as in second example, where the return object is first assigned to `obj` var and then refered.","author":{"url":"https://github.com/txantslusam","@type":"Person","name":"txantslusam"},"datePublished":"2021-08-31T19:52:19Z","url":"https://github.com/microsoft/TypeScript/issues/45663"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:f3afb420-1543-e6c7-f424-ce4e7d057d54 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B2E0:16AB79:1AA2BAA:21DB75F:6B014EE7 |
| html-safe-nonce | 4c9b4ed647eece56cc4e079d094d0e014eecb619ed6b9fed6d85e05ee25c8f57 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMkUwOjE2QUI3OToxQUEyQkFBOjIxREI3NUY6NkIwMTRFRTciLCJ2aXNpdG9yX2lkIjoiOTI2NDg2MjY4Mjc5MDY3OTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 1552e109a615a3f75497d4fe50eb9cbacc5bebbc4edb65e1292ced9efc383e87 |
| hovercard-subject-tag | issue:984246189 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/45663/issue_layout |
| twitter:image | https://opengraph.githubassets.com/8f36bb4362e07e0e99ccc883dcd1c38345c2876b497230910ee1b00c96a514af/microsoft/TypeScript/issues/45663 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8f36bb4362e07e0e99ccc883dcd1c38345c2876b497230910ee1b00c96a514af/microsoft/TypeScript/issues/45663 |
| og:image:alt | Bug Report 🔎 Search Terms Generic pick on object, type part of object, deconstructing of pick shows all keys of object 🕗 Version & Regression Information This is a crash This first occured today wh... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | txantslusam |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width