René's URL Explorer Experiment


Title: Breaking change to default useDefineForClassFields to true should be clearly documented · Issue #45653 · microsoft/TypeScript · GitHub

Open Graph Title: Breaking change to default useDefineForClassFields to true should be clearly documented · Issue #45653 · microsoft/TypeScript

X Title: Breaking change to default useDefineForClassFields to true should be clearly documented · Issue #45653 · microsoft/TypeScript

Description: Bug Report In some contexts (I'm not sure exactly which, but "target": "esnext" does it) useDefineForClassFields now defaults to true. This is a breaking change for any code with "experimentalDecorators": true, but I can't find documenta...

Open Graph Description: Bug Report In some contexts (I'm not sure exactly which, but "target": "esnext" does it) useDefineForClassFields now defaults to true. This is a breaking change for any code with "experimentalDecor...

X Description: Bug Report In some contexts (I'm not sure exactly which, but "target": "esnext" does it) useDefineForClassFields now defaults to true. This is a breaking change for any code...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/45653

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Breaking change to default useDefineForClassFields to true should be clearly documented","articleBody":"# Bug Report\r\n\r\nIn some contexts (I'm not sure exactly which, but `\"target\": \"esnext\"` does it) `useDefineForClassFields` now defaults to `true`.\r\n\r\nThis is a breaking change for any code with `\"experimentalDecorators\": true`, but I can't find documentation for it anywhere.\r\n\r\n### 🔎 Search Terms\r\n\r\n`useDefineForClassFields` `experimentalDecorators`\r\n\r\n### 🕗 Version & Regression Information\r\n\r\nThe `useDefineForClassFields` flag was introduced in 3.7 but defaulted to `false`: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html#the-usedefineforclassfields-flag-and-the-declare-property-modifier\r\n\r\nThis is a known breaking change when using decorators: https://github.com/microsoft/TypeScript/issues/35081\r\n\r\nIn https://github.com/microsoft/TypeScript/pull/42663 this was changed so that in some contexts `useDefineForClassFields` now defaults to `true`.\r\n\r\nThere is no mention of `useDefineForClassFields` on https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-4.html (or 4.3, or 4.2, or 4.1)\r\n\r\nThere is a mention on 4.0, but in as different context and the default change isn't mentioned https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-0.html#properties-overriding-accessors-and-vice-versa-is-an-error\r\n\r\nThis is a breaking change for all projects that use decorators, it should be clearly identified as a breaking change.\r\n\r\n### ⏯ Playground Link\r\n\r\nThis is missing documentation\r\n\r\n### 💻 Code\r\n\r\nThis is missing documentation\r\n\r\n### 🙁 Actual behavior\r\n\r\nRelease notes don't mention the breaking change. I'm not even sure which release they should be in.\r\n\r\n### 🙂 Expected behavior\r\n\r\nRelease notes should clearly document the breaking change.\r\n","author":{"url":"https://github.com/KeithHenry","@type":"Person","name":"KeithHenry"},"datePublished":"2021-08-31T07:44:39Z","url":"https://github.com/microsoft/TypeScript/issues/45653"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:bd31f73c-11a8-ad98-0624-37ef9366b468
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC6E8:22730:2807AC:36A59B:6AED48A2
html-safe-noncee46f14a5be2d6e5682a12ef72d2e06c52f19e52935ca5b69231774f16cfad17f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNkU4OjIyNzMwOjI4MDdBQzozNkE1OUI6NkFFRDQ4QTIiLCJ2aXNpdG9yX2lkIjoiODI3MzI2NDI1ODQ2ODEwNDM1NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9090f27b908079408138abbbc05f13568aa0007e12070aaec486e77c5e23f783
hovercard-subject-tagissue:983549392
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/45653/issue_layout
twitter:imagehttps://opengraph.githubassets.com/d8e99a7be207727ab47268cea87c534eaa43ea75d35b7baeddaf42f03f55307b/microsoft/TypeScript/issues/45653
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d8e99a7be207727ab47268cea87c534eaa43ea75d35b7baeddaf42f03f55307b/microsoft/TypeScript/issues/45653
og:image:altBug Report In some contexts (I'm not sure exactly which, but "target": "esnext" does it) useDefineForClassFields now defaults to true. This is a breaking change for any code with "experimentalDecor...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameKeithHenry
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/45653#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F45653
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F45653
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/45653
Reloadhttps://github.com/microsoft/TypeScript/issues/45653
Reloadhttps://github.com/microsoft/TypeScript/issues/45653
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests298 (298)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/pulse
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/45653
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/45653
Breaking change to default useDefineForClassFields to true should be clearly documentedhttps://github.com/microsoft/TypeScript/issues/45653#top
DocsThe issue relates to how you learn TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Docs%22
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
https://github.com/KeithHenry
Keith Henry (KeithHenry)https://github.com/KeithHenry
on Aug 31, 2021https://github.com/microsoft/TypeScript/issues/45653#issue-983549392
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html#the-usedefineforclassfields-flag-and-the-declare-property-modifierhttps://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html#the-usedefineforclassfields-flag-and-the-declare-property-modifier
#35081https://github.com/microsoft/TypeScript/issues/35081
#42663https://github.com/microsoft/TypeScript/pull/42663
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-4.htmlhttps://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-4.html
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-0.html#properties-overriding-accessors-and-vice-versa-is-an-errorhttps://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-0.html#properties-overriding-accessors-and-vice-versa-is-an-error
https://github.com/MartinJohns
Martin Johns (MartinJohns)https://github.com/MartinJohns
on Aug 31, 2021https://github.com/microsoft/TypeScript/issues/45653#issuecomment-909007719
https://github.com/KeithHenry
Keith Henry (KeithHenry)https://github.com/KeithHenry
on Aug 31, 2021https://github.com/microsoft/TypeScript/issues/45653#issuecomment-909161023
#45584https://github.com/microsoft/TypeScript/issues/45584
https://github.com/orta
Orta Therox (orta)https://github.com/orta
on Aug 31, 2021https://github.com/microsoft/TypeScript/issues/45653#issuecomment-909315769
https://www.typescriptlang.org/tsconfig#useDefineForClassFieldshttps://www.typescriptlang.org/tsconfig#useDefineForClassFields
microsoft/TypeScript-Website#2008https://github.com/microsoft/TypeScript-Website/pull/2008
https://github.com/MartinJohns
Martin Johns (MartinJohns)https://github.com/MartinJohns
on Aug 31, 2021https://github.com/microsoft/TypeScript/issues/45653#issuecomment-909330022
https://github.com/KeithHenry
Keith Henry (KeithHenry)https://github.com/KeithHenry
on Aug 31, 2021https://github.com/microsoft/TypeScript/issues/45653#issuecomment-909487372
Martin Johns (@MartinJohns)https://github.com/MartinJohns
own recommendation is the opposite of yourshttps://github.com/tc39/proposal-decorators/blob/master/README.md#how-should-i-use-decorators-in-transpilers-today
https://github.com/fatcerberus
Bruce Pascoe (fatcerberus)https://github.com/fatcerberus
on Aug 31, 2021https://github.com/microsoft/TypeScript/issues/45653#issuecomment-909525178
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
on Aug 31, 2021https://github.com/microsoft/TypeScript/issues/45653#issuecomment-909672498
Orta Therox (@orta)https://github.com/orta
Ron Buckton (@rbuckton)https://github.com/rbuckton
https://github.com/justinfagnani
Justin Fagnani (justinfagnani)https://github.com/justinfagnani
on Sep 7, 2021https://github.com/microsoft/TypeScript/issues/45653#issuecomment-913931866
Ron Buckton (@rbuckton)https://github.com/rbuckton
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
on Sep 7, 2021https://github.com/microsoft/TypeScript/issues/45653#issuecomment-913955758
https://github.com/justinfagnani
Justin Fagnani (justinfagnani)https://github.com/justinfagnani
on Sep 7, 2021https://github.com/microsoft/TypeScript/issues/45653#issuecomment-913991098
Ron Buckton (@rbuckton)https://github.com/rbuckton
Andrew Branch (andrewbranch)https://github.com/andrewbranch
DocsThe issue relates to how you learn TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Docs%22
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
on Sep 7, 2021https://github.com/microsoft/TypeScript/issues/45653#event-5267511369
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
on Sep 7, 2021https://github.com/microsoft/TypeScript/issues/45653#issuecomment-914547251
#45718https://github.com/microsoft/TypeScript/issues/45718
Andrew Branch (andrewbranch)https://github.com/andrewbranch
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Sep 7, 2021https://github.com/microsoft/TypeScript/issues/45653#event-5267527222
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/45653
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/45653
DocsThe issue relates to how you learn TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Docs%22
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.