Title: Design Meeting Notes, 7/14/2021 · Issue #45104 · microsoft/TypeScript · GitHub
Open Graph Title: Design Meeting Notes, 7/14/2021 · Issue #45104 · microsoft/TypeScript
X Title: Design Meeting Notes, 7/14/2021 · Issue #45104 · microsoft/TypeScript
Description: Increasing the Type Instantiation Depth Limit #45025 People keep doing more and more advanced patterns in type-space; the instantiation depth limiter is too low for these scenarios. For creating a union of characters as in the PR, type G...
Open Graph Description: Increasing the Type Instantiation Depth Limit #45025 People keep doing more and more advanced patterns in type-space; the instantiation depth limiter is too low for these scenarios. For creating a ...
X Description: Increasing the Type Instantiation Depth Limit #45025 People keep doing more and more advanced patterns in type-space; the instantiation depth limiter is too low for these scenarios. For creating a ...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/45104
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Design Meeting Notes, 7/14/2021","articleBody":"## Increasing the Type Instantiation Depth Limit\r\n\r\nhttps://github.com/microsoft/TypeScript/pull/45025\r\n\r\n* People keep doing more and more advanced patterns in type-space; the instantiation depth limiter is too low for these scenarios.\r\n* For creating a union of characters as in the PR,\r\n\r\n ```ts\r\n type GetChars\u003cS> = S extends `${infer Char}${infer Rest }` ? Char | GetChars\u003cRest> : never;\r\n ```\r\n\r\n you have 2 instantiations: the outer conditional type and the union in the true branch.\r\n * Means you can only get 24 characters deep before TypeScript gives you a 😢.\r\n* Other alternatives:\r\n * generators - slow, ugly output\r\n * explicit stack management - not a totally natural fit\r\n* Risks:\r\n * More memory usage\r\n * Slower non-termination of infinitely expanding types.\r\n * Can impact the language service.\r\n* Conservative estimate of about 100 bytes per stack frame.\r\n * Ball-parked from playing around with examples, but is variable.\r\n* Have we played with non-V8 engines?\r\n * Not much.\r\n * Does Safari do any better? It implements Tail Call Optimization\r\n * But our instantiation logic is not tail-recursive (even when instantiating a tail-recursive type).\r\n * There are certian places where functions hand off directly to another function though - in certain cases, yes, that would help - but only as far as inlining would help.\r\n* Concerns around LS still hold - but `instantiationCount` limit on source elements helps a bit.\r\n\r\n https://github.com/microsoft/TypeScript/blob/541e553163bb79fba64fdfd7c8a2c96f201c3b0a/src/compiler/checker.ts#16255\r\n * Still a much bigger limit than the instantiation depth limit as well.\r\n* Making the instantiation depth configurable?\r\n * Nope, not comfortable with that.\r\n* Shipping this in 4.5?\r\n * Would rather not make people wait for the change.\r\n * A small increase in depth limits in 4.3 would have saved people\r\n* Can we message this as a \"be cautious about relying strongly on this behavior\" in the release notes?\r\n * Seems hard to message that.\r\n* Could try type-call elimination to avoid blowing our own stack.\r\n\r\n## Auto-Imports and the `node:` Prefix\r\n\r\nhttps://github.com/microsoft/TypeScript/issues/43842\r\n\r\n* Concerns about module augmentations - need to come back to this when others on the team can bring up concerns.\r\n* Will be developing a \"more correct\" thing in the meantime.\r\n\r\n## Contextually Typing IIFEs\r\n\r\nhttps://github.com/microsoft/TypeScript/issues/44992\r\nhttps://github.com/microsoft/TypeScript/pull/45007\r\n\r\n* Not especially useful - unless you have an `async` function!\r\n* We already contextually type IIFE parameters.\r\n * Does that have any strange interactions?\r\n * Unclear right now - probably not.\r\n* Seems reasonable, but need to think about this a bit.\r\n\r\n## Import Assertions\r\n\r\nhttps://github.com/microsoft/TypeScript/pull/40698\r\n\r\n* History\r\n * Subresource integrity enforcement - had cascading effects.\r\n * JSON modules culminated in this proposal.\r\n * Right side of this looks like an expression, but isn't an expression.\r\n* Maybe the better direction would've been to just have a \"don't execute this\" assertion instead.","author":{"url":"https://github.com/DanielRosenwasser","@type":"Person","name":"DanielRosenwasser"},"datePublished":"2021-07-19T19:08:17Z","url":"https://github.com/microsoft/TypeScript/issues/45104"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:3034042b-6858-c5b2-7ed3-31a3c124c9ed |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | AC52:2C4BED:2E17DCE:3A90F45:6B01BCAE |
| html-safe-nonce | 2a44c5add071062bdc39d11944125db729099cc6d4a1fda8cfbe5a1436cf7f59 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzUyOjJDNEJFRDoyRTE3RENFOjNBOTBGNDU6NkIwMUJDQUUiLCJ2aXNpdG9yX2lkIjoiNTgxNTI3NjU4OTc1NTI1MTg4NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | efa2dc62acff03ceaa4595a2ecf22108bf820a7dda32102eade7346b6b2495d9 |
| hovercard-subject-tag | issue:947944171 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/45104/issue_layout |
| twitter:image | https://opengraph.githubassets.com/757112802979f02eafb5d27e81cb3621f24003a48f9e672dcdcc896b296b0dc6/microsoft/TypeScript/issues/45104 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/757112802979f02eafb5d27e81cb3621f24003a48f9e672dcdcc896b296b0dc6/microsoft/TypeScript/issues/45104 |
| og:image:alt | Increasing the Type Instantiation Depth Limit #45025 People keep doing more and more advanced patterns in type-space; the instantiation depth limiter is too low for these scenarios. For creating a ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | DanielRosenwasser |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width