Title: Cannot define getter and setter, getting an error: "circularly references itself in mapped type" · Issue #44906 · microsoft/TypeScript · GitHub
Open Graph Title: Cannot define getter and setter, getting an error: "circularly references itself in mapped type" · Issue #44906 · microsoft/TypeScript
X Title: Cannot define getter and setter, getting an error: "circularly references itself in mapped type" · Issue #44906 · microsoft/TypeScript
Description: Cannot define getter and setter, getting an error: "Type of property '..' circularly references itself in mapped type ..." interface User { firstName: string, level: number, get bestFriend(): User set bestFriend(user: SerializablePartial...
Open Graph Description: Cannot define getter and setter, getting an error: "Type of property '..' circularly references itself in mapped type ..." interface User { firstName: string, level: number, get bestFriend(): User ...
X Description: Cannot define getter and setter, getting an error: "Type of property '..' circularly references itself in mapped type ..." interface User { firstName: string, level: number, get b...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/44906
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Cannot define getter and setter, getting an error: \"circularly references itself in mapped type\"","articleBody":"Cannot define getter and setter, getting an error: \"Type of property '..' circularly references itself in mapped type ...\"\r\n```\r\ninterface User {\r\n firstName: string,\r\n level: number,\r\n get bestFriend(): User\r\n set bestFriend(user: SerializablePartial\u003cUser>)\r\n}\r\n\r\ntype FilteredKeys\u003cT> = { [K in keyof T]: T[K] extends number ? K : T[K] extends string ? K : T[K] extends boolean ? K : never }[keyof T];\r\n\r\ntype SerializablePartial\u003cT> = {\r\n [K in FilteredKeys\u003cT>]: T[K]\r\n};\r\n```\r\nError: `Type of property 'bestFriend' circularly references itself in mapped type '{ [K in keyof User]: User[K] extends number ? K : User[K] extends string ? K : User[K] extends boolean ? K : never; }'.(2615)`, [Link to playground](https://www.typescriptlang.org/play?#code/JYOwLgpgTgZghgYwgAgKoGdrIN4ChkHIzBTpgBycAthAFzJlSgDmANPoQDYQBuEn9EAFcqAI2jtCyZhDDJxZAGJMIIACYAKAJT0M0DgUxyFYZcFWahmKPQDK0YHE7AAXnFHcACnChhHnAB49KAA+LVwAX1xcMABPAAcURWBOSCgINQBpCFj0AIAVEOQAXhxkAG1M5FBkAGscgHsYZHyAXXp8ytbkCAAPSHV0ZGExLAB+ZCqOrp7+iyHGFmQJqZaZvoG1IdEGhu44EGXJ5EFeLAjy+timltaAbmi4xOR7JidXdy8fPycCotK8FJKtVDslUtAMtlcn92mtMq1IncgA)\r\n\r\nAnd here is almost the same valid example without error where I only changed getter `get bestFriend(): User` to method `getBestFriend(): User` and setter `set bestFriend(user: SerializablePartial\u003cUser>)` to method `setBestFriend(user: SerializablePartial\u003cUser>): void`. [Link to playground](https://www.typescriptlang.org/play?#code/JYOwLgpgTgZghgYwgAgKoGdrIN4ChkHIzBTpgBycAthAFzJlSgDmANPoQDYQBuEn9EAFcqAI2jtCyZhDAAhCGQBiTCCAAmACgCU9DNA4FM8xWBXA1WoZij0AytGBxOwAF5xR3AApwoYJ5wAPPpQAHy6yDwA9sDquAC+uLhgAJ4ADihKwJyQUBDqANIQKeiBACqhyAC8OMgA2gXIoMgA1sVRMMhlALr0ZQ3dyBAAHpAa6MjCYlgA-MiNfQNDo5YTjCzIcwtdSyNj6hOiUVHccCCb88iCvFjxdW0pHV3dANxJqRnIDkzObh7evn8znKlRqeCkDSa5yyOWg+SKJRBvR2BW6CReQA)\r\n```\r\ninterface User {\r\n firstName: string,\r\n level: number,\r\n getBestFriend(): User\r\n setBestFriend(user: SerializablePartial\u003cUser>): void\r\n}\r\n\r\ntype FilteredKeys\u003cT> = { [K in keyof T]: T[K] extends number ? K : T[K] extends string ? K : T[K] extends boolean ? K : never }[keyof T];\r\n\r\ntype SerializablePartial\u003cT> = {\r\n [K in FilteredKeys\u003cT>]: T[K]\r\n};\r\n```\r\nSo semantically it's all the same, the difference is only in syntactic sugar - using getter and setter instead of \"getX\" and \"setX\" methods and seems like it should have the same type checking path\r\n\r\n### 🔎 Search Terms\r\n\r\n`circularly references itself in mapped type`\r\n\r\n### 🕗 Version & Regression Information\r\n\r\nv4.3.5\r\n\r\n### ⏯ Playground Link\r\n\r\n[Playground link with bug](https://www.typescriptlang.org/play?ts=4.3.5#code/JYOwLgpgTgZghgYwgAgKoGdrIN4ChkHIzBTpgBycAthAFzJlSgDmANPoQDYQBuEn9EAFcqAI2jtCyZhDDJxZAGJMIIACYAKAJT0M0DgUxyFYZcFWahmKPQDK0YHE7AAXnFHcACnChhHnAB49KAA+LVwAX1xcMABPAAcURWBOSCgINQBpCFj0AIAVEOQAXhxkAG1M5FBkAGscgHsYZHyAXXp8ytbkCAAPSHV0ZGExLAB+ZCqOrp7+iyHGFmQJqZaZvoG1IdEGhu44EGXJ5EFeLAjy+timltaAbmi4xOR7JidXdy8fPycCotK8FJKtVDslUtAMtlcn92mtMq1IncgA)\r\n\r\n[Playground link with working get-set-methods version](https://www.typescriptlang.org/play?ts=4.3.5#code/JYOwLgpgTgZghgYwgAgKoGdrIN4ChkHIzBTpgBycAthAFzJlSgDmANPoQDYQBuEn9EAFcqAI2jtCyZhDAAhCGQBiTCCAAmACgCU9DNA4FM8xWBXA1WoZij0AytGBxOwAF5xR3AApwoYJ5wAPPpQAHy6yDwA9sDquAC+uLhgAJ4ADihKwJyQUBDqANIQKeiBACqhyAC8OMgA2gXIoMgA1sVRMMhlALr0ZQ3dyBAAHpAa6MjCYlgA-MiNfQNDo5YTjCzIcwtdSyNj6hOiUVHccCCb88iCvFjxdW0pHV3dANxJqRnIDkzObh7evn8znKlRqeCkDSa5yyOWg+SKJRBvR2BW6CReQA)\r\n\r\n\r\n### 🙁 Actual behavior\r\n\r\ngetting an error\r\n\r\n\r\n### 🙂 Expected behavior\r\n\r\nno error\r\n\r\n### Relevant issue \r\n\r\nThere already was some issue with \"circularly references itself in mapped type\" in https://github.com/microsoft/TypeScript/issues/38279 and it was fixed in https://github.com/microsoft/TypeScript/pull/38653 but seems like it was the fix only for methods not for getter/setters","author":{"url":"https://github.com/bgnx","@type":"Person","name":"bgnx"},"datePublished":"2021-07-06T06:05:50Z","url":"https://github.com/microsoft/TypeScript/issues/44906"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:7b238085-26f7-b971-d321-8e1834f5ae60 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | AF52:1C6C3E:D481A5:1194666:6B00F968 |
| html-safe-nonce | b73281c16912411a8c2a532a5e558b2ee57a8b0a458786e0635318f573693836 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjUyOjFDNkMzRTpENDgxQTU6MTE5NDY2Njo2QjAwRjk2OCIsInZpc2l0b3JfaWQiOiIzODg5ODI3NDA5MzM1MjIwNTg0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 8f98ba345952eff6e9280e6bcd8bf24952b90e62a92ae516c3e8c905e449e3f8 |
| hovercard-subject-tag | issue:937549040 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/44906/issue_layout |
| twitter:image | https://opengraph.githubassets.com/79ca8c4bdb4ac80100c1edac55781e32376265b1a409ae38e8f162cbda0ef56e/microsoft/TypeScript/issues/44906 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/79ca8c4bdb4ac80100c1edac55781e32376265b1a409ae38e8f162cbda0ef56e/microsoft/TypeScript/issues/44906 |
| og:image:alt | Cannot define getter and setter, getting an error: "Type of property '..' circularly references itself in mapped type ..." interface User { firstName: string, level: number, get bestFriend(): User ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bgnx |
| hostname | github.com |
| expected-hostname | github.com |
| None | e208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187 |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7dafd017fb7809a839c443dba08622af38e63c09 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width