Title: Compile errors in VS Code codebase with latest TS nightly · Issue #42225 · microsoft/TypeScript · GitHub
Open Graph Title: Compile errors in VS Code codebase with latest TS nightly · Issue #42225 · microsoft/TypeScript
X Title: Compile errors in VS Code codebase with latest TS nightly · Issue #42225 · microsoft/TypeScript
Description: 🕗 Version & Regression Information This changed between versions 4.2.0-dev.20201207 and 4.2.0-dev.20210105 Repo Update VS Code to use the latest nightly TypeScript version (yarn add typescript@next) Run compile in the codebase yarn run w...
Open Graph Description: 🕗 Version & Regression Information This changed between versions 4.2.0-dev.20201207 and 4.2.0-dev.20210105 Repo Update VS Code to use the latest nightly TypeScript version (yarn add typescript@next...
X Description: 🕗 Version & Regression Information This changed between versions 4.2.0-dev.20201207 and 4.2.0-dev.20210105 Repo Update VS Code to use the latest nightly TypeScript version (yarn add typescript@...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/42225
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Compile errors in VS Code codebase with latest TS nightly ","articleBody":"\r\n### 🕗 Version & Regression Information\r\n\r\n- This changed between versions 4.2.0-dev.20201207 and 4.2.0-dev.20210105\r\n\r\n### Repo\r\n- Update VS Code to use the latest nightly TypeScript version (yarn add typescript@next)\r\n- Run compile in the codebase `yarn run watch`\r\n\r\n\r\n### Issue\r\nThis produces around 16 compile errors. Most of these look like false positives to me:\r\n\r\n```\r\n[21:49:47] Error: vscode/src/vs/workbench/contrib/files/browser/views/explorerViewer.ts(1232,24): The left-hand side of an 'instanceof' expression must be of type 'any', an object type or a type parameter.\r\n[21:49:47] Error: vscode/src/vs/workbench/contrib/files/browser/views/explorerViewer.ts(1232,72): Argument of type 'undefined' is not assignable to parameter of type 'Uint8Array'.\r\n[21:49:47] Error: vscode/src/vs/base/browser/ui/dropdown/dropdownActionViewItem.ts(176,99): Property 'getActions' does not exist on type 'readonly IAction[] | IActionProvider'.\r\n Property 'getActions' does not exist on type 'readonly IAction[]'.\r\n[21:49:47] Error: vscode/src/vs/base/browser/ui/actionbar/actionbar.ts(267,9): Type '(readonly IAction[] & any[]) | (IAction & any[]) | (IAction | readonly IAction[])[]' is not assignable to type 'readonly IAction[]'.\r\n Type '(IAction | readonly IAction[])[]' is not assignable to type 'readonly IAction[]'.\r\n Type 'IAction | readonly IAction[]' is not assignable to type 'IAction'.\r\n Type 'readonly IAction[]' is missing the following properties from type 'IAction': id, label, tooltip, class, and 4 more.\r\n[21:49:47] Error: vscode/src/vs/workbench/api/common/extHostTypeConverters.ts(1249,24): Property 'language' does not exist on type 'DocumentFilter | readonly (string | DocumentFilter)[]'.\r\n Property 'language' does not exist on type 'readonly (string | DocumentFilter)[]'.\r\n[21:49:47] Error: vscode/src/vs/workbench/api/common/extHostTypeConverters.ts(1250,22): Property 'scheme' does not exist on type 'DocumentFilter | readonly (string | DocumentFilter)[]'.\r\n Property 'scheme' does not exist on type 'readonly (string | DocumentFilter)[]'.\r\n[21:49:47] Error: vscode/src/vs/workbench/api/common/extHostTypeConverters.ts(1251,30): Property 'pattern' does not exist on type 'DocumentFilter | readonly (string | DocumentFilter)[]'.\r\n Property 'pattern' does not exist on type 'readonly (string | DocumentFilter)[]'.\r\n[21:49:47] Error: vscode/src/vs/workbench/api/common/extHostTypeConverters.ts(1251,94): Property 'pattern' does not exist on type 'DocumentFilter | readonly (string | DocumentFilter)[]'.\r\n Property 'pattern' does not exist on type 'readonly (string | DocumentFilter)[]'.\r\n[21:49:47] Error: vscode/src/vs/workbench/api/common/extHostTypeConverters.ts(1252,25): Property 'exclusive' does not exist on type 'DocumentFilter | readonly (string | DocumentFilter)[]'.\r\n Property 'exclusive' does not exist on type 'readonly (string | DocumentFilter)[]'.\r\n[21:49:47] Error: vscode/src/vs/workbench/api/common/extHost.api.impl.ts(199,26): Property 'scheme' does not exist on type 'DocumentFilter | readonly (string | DocumentFilter)[]'.\r\n Property 'scheme' does not exist on type 'readonly (string | DocumentFilter)[]'.\r\n[21:49:47] Error: vscode/src/vs/workbench/api/common/extHost.api.impl.ts(202,58): Property 'exclusive' does not exist on type 'DocumentFilter | readonly (string | DocumentFilter)[]'.\r\n Property 'exclusive' does not exist on type 'readonly (string | DocumentFilter)[]'.\r\n[21:49:47] Error: vscode/src/vs/editor/common/modes/languageSelector.ts(58,11): Property 'language' does not exist on type 'LanguageFilter | readonly (string | LanguageFilter)[]'.\r\n[21:49:47] Error: vscode/src/vs/editor/common/modes/languageSelector.ts(58,21): Property 'pattern' does not exist on type 'LanguageFilter | readonly (string | LanguageFilter)[]'.\r\n[21:49:47] Error: vscode/src/vs/editor/common/modes/languageSelector.ts(58,30): Property 'scheme' does not exist on type 'LanguageFilter | readonly (string | LanguageFilter)[]'.\r\n[21:49:47] Error: vscode/src/vs/editor/common/modes/languageSelector.ts(58,38): Property 'hasAccessToAllModels' does not exist on type 'LanguageFilter | readonly (string | LanguageFilter)[]'.\r\n[21:49:47] Error: vscode/src/vs/editor/common/modes/languageFeatureRegistry.ts(28,21): Property 'exclusive' does not exist on type 'LanguageFilter | readonly (string | LanguageFilter)[]'.\r\n Property 'exclusive' does not exist on type 'readonly (string | LanguageFilter)[]'.\r\n```","author":{"url":"https://github.com/mjbvz","@type":"Person","name":"mjbvz"},"datePublished":"2021-01-06T06:06:49Z","url":"https://github.com/microsoft/TypeScript/issues/42225"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:93cac6b4-9b1d-2eb6-1f9b-71a9e9751ab8 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C2AE:19F84C:3254162:3FF9F71:6B01BE74 |
| html-safe-nonce | 3e26850448d271aea9fad7c892767208ff410f12930bd7f4dbccdaf6c26108eb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMkFFOjE5Rjg0QzozMjU0MTYyOjNGRjlGNzE6NkIwMUJFNzQiLCJ2aXNpdG9yX2lkIjoiMTkyNDQ0OTIyMzYzNDQzNTcwMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 65a2479a98788f428d64644597acf13fa088c09df103f9d6fbbbf7f2267ed7f0 |
| hovercard-subject-tag | issue:780091715 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/42225/issue_layout |
| twitter:image | https://opengraph.githubassets.com/ebba1b7723536adde97f94bced2fe8bd0fa85d7dc4f7c88adbe9aeb4e1e3d45e/microsoft/TypeScript/issues/42225 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ebba1b7723536adde97f94bced2fe8bd0fa85d7dc4f7c88adbe9aeb4e1e3d45e/microsoft/TypeScript/issues/42225 |
| og:image:alt | 🕗 Version & Regression Information This changed between versions 4.2.0-dev.20201207 and 4.2.0-dev.20210105 Repo Update VS Code to use the latest nightly TypeScript version (yarn add typescript@next... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mjbvz |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width