René's URL Explorer Experiment


Title: getSyntacticModifierFlags return value affected by getEffectiveModifierFlags · Issue #42189 · microsoft/TypeScript · GitHub

Open Graph Title: getSyntacticModifierFlags return value affected by getEffectiveModifierFlags · Issue #42189 · microsoft/TypeScript

X Title: getSyntacticModifierFlags return value affected by getEffectiveModifierFlags · Issue #42189 · microsoft/TypeScript

Description: Bug Report I don't know if this already causes a user-facing bug, but it might in the future. 🔎 Search Terms syntactic effective modifierflags 🕗 Version & Regression Information The API was introduced in #38403 by Ron Buckton (@rbuckton)...

Open Graph Description: Bug Report I don't know if this already causes a user-facing bug, but it might in the future. 🔎 Search Terms syntactic effective modifierflags 🕗 Version & Regression Information The API was introdu...

X Description: Bug Report I don't know if this already causes a user-facing bug, but it might in the future. 🔎 Search Terms syntactic effective modifierflags 🕗 Version & Regression Information The API was...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/42189

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"getSyntacticModifierFlags return value affected by getEffectiveModifierFlags","articleBody":"# Bug Report\r\n\r\nI don't know if this already causes a user-facing bug, but it might in the future.\r\n\r\n### 🔎 Search Terms\r\n\r\nsyntactic effective modifierflags\r\n\r\n### 🕗 Version & Regression Information\r\n\r\nThe API was introduced in #38403 by @rbuckton on 12th May 2020, I don't know which TS version that is\r\n\r\n### 💻 Code\r\n\r\n\u003c!-- Please post the relevant code sample here as well-->\r\n```ts\r\nclass C {\r\n  /** @private */\r\n  prop = 1;\r\n}\r\n```\r\n\r\nThe code snippets below assume that `node: ts.PropertyDeclaration` of property `prop`\r\n\r\n### 🙁 Actual behavior\r\n\r\nNote: I'm not talking about user code using compiler API as these APIs are not public. I'm talking about the compiler implementation itself.\r\n\r\nIf the above code is a TS file:\r\n\r\n* call `ts.getSyntacticModifierFlags(node)`, return `ts.ModifierFlags.None` (expected)\r\n* call `ts.getEffectiveModifierFlags(node)`, return `ts.ModifierFlags.None` (expected)\r\n* call `ts.getSyntacticModifierFlags(node)` again, returns `ts.ModifierFlags.None` (expected)\r\n\r\nIf the above code is a JS file:\r\n\r\n* call `ts.getSyntacticModifierFlags(node)`, return `ts.ModifierFlags.None` (expected)\r\n* call `ts.getEffectiveModifierFlags(node)`, return `ts.ModifierFlags.Private` (expected)\r\n* call `ts.getSyntacticModifierFlags(node)` again, returns `ts.ModifierFlags.Private` (**not** expected)\r\n\r\n(see https://runkit.com/ajafff/5ff204e2ac3559001a1407f7)\r\n\r\nThis is because both use the same property to cache the result. `getEffectiveModifierFlags` adds modifiers from JSDoc to the cached result. Calling `getSyntacticModifierFlags` afterwards cannot remove the modifiers from JSDoc, so it simply returns them too.\r\n\r\n### 🙂 Expected behavior\r\n\r\nLooking at the description of #38403, the intended use of `getSyntacticModifierFlags` is: \"get me the syntactic modifiers and **don't** include those from JSDoc\". Calling `getEffectiveModifierFlags` should not have a side-effect on `getSyntacticModifierFlags`.\r\n\r\nAlso there's `getEffectiveModifierFlagsAlwaysIncludeJSDoc` introduced in #38523 by @Kingwl. This affects TS files, making the original change in #38403 useless depending on execution order: \r\n* call `ts.getSyntacticModifierFlags(node)`, return `ts.ModifierFlags.None` (expected)\r\n* call `ts.getEffectiveModifierFlags(node)`, return `ts.ModifierFlags.None` (expected)\r\n* call `getEffectiveModifierFlagsAlwaysIncludeJSDoc`, return `ts.ModifierFlags.Private` (expected)\r\n* call `ts.getSyntacticModifierFlags(node)` again, returns `ts.ModifierFlags.Private` (**not** expected)\r\n* call `ts.getEffectiveModifierFlags(node)` again, returns `ts.ModifierFlags.Private` (**not** expected)\r\n","author":{"url":"https://github.com/ajafff","@type":"Person","name":"ajafff"},"datePublished":"2021-01-03T18:02:19Z","url":"https://github.com/microsoft/TypeScript/issues/42189"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:3a33407c-6c63-70fc-66ef-a1f003afedd7
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC47A:842EC:7BA38F:A6F656:6B00DF5F
html-safe-nonceb89bf1e38a6f8260fd853446ab33710602c0e88b6d9b0c20d688e751a09e4e2f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNDdBOjg0MkVDOjdCQTM4RjpBNkY2NTY6NkIwMERGNUYiLCJ2aXNpdG9yX2lkIjoiMTg2NDY2MTQ0MDYyODA1NTkwMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac36215fe9b14a7a8dc0b7854778065a95c31237d2ad511a78c90b6b9953e58e98
hovercard-subject-tagissue:777687452
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/42189/issue_layout
twitter:imagehttps://opengraph.githubassets.com/9ea07d3f9d69034b36880c6e97034550d9584dfff8da76acfaf263d95c857197/microsoft/TypeScript/issues/42189
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9ea07d3f9d69034b36880c6e97034550d9584dfff8da76acfaf263d95c857197/microsoft/TypeScript/issues/42189
og:image:altBug Report I don't know if this already causes a user-facing bug, but it might in the future. 🔎 Search Terms syntactic effective modifierflags 🕗 Version & Regression Information The API was introdu...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameajafff
hostnamegithub.com
expected-hostnamegithub.com
None043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5425dc24e8bd8d6fca9641a12afc984825a43875
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/42189#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F42189
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F42189
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/42189
Reloadhttps://github.com/microsoft/TypeScript/issues/42189
Reloadhttps://github.com/microsoft/TypeScript/issues/42189
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests308 (308)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/42189
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/42189
#56198https://github.com/microsoft/TypeScript/pull/56198
getSyntacticModifierFlags return value affected by getEffectiveModifierFlagshttps://github.com/microsoft/TypeScript/issues/42189#top
#56198https://github.com/microsoft/TypeScript/pull/56198
https://github.com/rbuckton
Fix AvailableA PR has been opened for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fix%20Available%22
Needs InvestigationThis issue needs a team member to investigate its status.https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Needs%20Investigation%22
RescheduledThis issue was previously scheduled to an earlier milestonehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Rescheduled%22
TypeScript 5.1.0https://github.com/microsoft/TypeScript/milestone/178
https://github.com/ajafff
Klaus Meinhardt (ajafff)https://github.com/ajafff
on Jan 3, 2021https://github.com/microsoft/TypeScript/issues/42189#issue-777687452
#38403https://github.com/microsoft/TypeScript/pull/38403
Ron Buckton (@rbuckton)https://github.com/rbuckton
https://runkit.com/ajafff/5ff204e2ac3559001a1407f7https://runkit.com/ajafff/5ff204e2ac3559001a1407f7
#38403https://github.com/microsoft/TypeScript/pull/38403
#38523https://github.com/microsoft/TypeScript/pull/38523
Wenlu Wang (@Kingwl)https://github.com/Kingwl
#38403https://github.com/microsoft/TypeScript/pull/38403
https://github.com/Kingwl
Wenlu Wang (Kingwl)https://github.com/Kingwl
on Jan 3, 2021https://github.com/microsoft/TypeScript/issues/42189#issuecomment-753657230
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Needs InvestigationThis issue needs a team member to investigate its status.https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Needs%20Investigation%22
on Jan 4, 2021https://github.com/microsoft/TypeScript/issues/42189#event-4166747204
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Ron Buckton (rbuckton)https://github.com/rbuckton
on Jan 4, 2021https://github.com/microsoft/TypeScript/issues/42189#event-4166747291
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
TypeScript 4.3.0https://github.com/microsoft/TypeScript/milestone/134
on Jan 4, 2021https://github.com/microsoft/TypeScript/issues/42189#event-4166747432
Andrew Branch (andrewbranch)https://github.com/andrewbranch
TypeScript 4.3.0https://github.com/microsoft/TypeScript/milestone/134
TypeScript 4.3.1https://github.com/microsoft/TypeScript/milestone/138
on Apr 2, 2021https://github.com/microsoft/TypeScript/issues/42189#event-4546272470
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
RescheduledThis issue was previously scheduled to an earlier milestonehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Rescheduled%22
on Jun 18, 2021https://github.com/microsoft/TypeScript/issues/42189#event-4910918202
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
TypeScript 4.3.1https://github.com/microsoft/TypeScript/milestone/138
TypeScript 4.4.1 (RC)https://github.com/microsoft/TypeScript/milestone/144
on Jun 18, 2021https://github.com/microsoft/TypeScript/issues/42189#event-4910936128
Andrew Branch (andrewbranch)https://github.com/andrewbranch
TypeScript 4.4.1 (RC)https://github.com/microsoft/TypeScript/milestone/144
TypeScript 4.5.0https://github.com/microsoft/TypeScript/milestone/147
on Aug 31, 2021https://github.com/microsoft/TypeScript/issues/42189#event-5229242676
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
TypeScript 4.5.0https://github.com/microsoft/TypeScript/milestone/147
TypeScript 4.6.0https://github.com/microsoft/TypeScript/milestone/151
on Dec 15, 2021https://github.com/microsoft/TypeScript/issues/42189#event-5768060466
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
TypeScript 4.6.0https://github.com/microsoft/TypeScript/milestone/151
TypeScript 4.6.1https://github.com/microsoft/TypeScript/milestone/158
on Feb 3, 2022https://github.com/microsoft/TypeScript/issues/42189#event-6005689108
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
TypeScript 4.6.1https://github.com/microsoft/TypeScript/milestone/158
TypeScript 4.8.0https://github.com/microsoft/TypeScript/milestone/163
on May 13, 2022https://github.com/microsoft/TypeScript/issues/42189#event-6607999887
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
TypeScript 4.8.0https://github.com/microsoft/TypeScript/milestone/163
TypeScript 5.1.0https://github.com/microsoft/TypeScript/milestone/178
on Feb 1, 2023https://github.com/microsoft/TypeScript/issues/42189#event-8413671098
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Fix AvailableA PR has been opened for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fix%20Available%22
on Oct 24, 2023https://github.com/microsoft/TypeScript/issues/42189#event-10747595397
Ron Buckton (rbuckton)https://github.com/rbuckton
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#56198https://github.com/microsoft/TypeScript/pull/56198
on Oct 25, 2023https://github.com/microsoft/TypeScript/issues/42189#event-10772911335
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/42189
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/42189
Ron Buckton (rbuckton)https://github.com/rbuckton
Fix AvailableA PR has been opened for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fix%20Available%22
Needs InvestigationThis issue needs a team member to investigate its status.https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Needs%20Investigation%22
RescheduledThis issue was previously scheduled to an earlier milestonehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Rescheduled%22
TypeScript 5.1.0https://github.com/microsoft/TypeScript/milestone/178
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.