Title: Issue with Array.isArray typeguard after upgrading from 4.1.2 to 4.1.3 · Issue #41984 · microsoft/TypeScript · GitHub
Open Graph Title: Issue with Array.isArray typeguard after upgrading from 4.1.2 to 4.1.3 · Issue #41984 · microsoft/TypeScript
X Title: Issue with Array.isArray typeguard after upgrading from 4.1.2 to 4.1.3 · Issue #41984 · microsoft/TypeScript
Description: TypeScript Version: 4.2.0-dev.20201211 Search Terms: re: Array.isArray Code interface TestCase
Open Graph Description: TypeScript Version: 4.2.0-dev.20201211 Search Terms: re: Array.isArray Code interface TestCase
X Description: TypeScript Version: 4.2.0-dev.20201211 Search Terms: re: Array.isArray Code interface TestCase<T extends string | number> { readonly val1: T | ReadonlyArray<T>; readonly val2: ReadonlyA...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/41984
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Issue with Array.isArray typeguard after upgrading from 4.1.2 to 4.1.3","articleBody":"**TypeScript Version:** 4.2.0-dev.20201211\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:**\r\n\r\nre: `Array.isArray`\r\n\r\n**Code**\r\n\r\n```ts repro\r\ninterface TestCase\u003cT extends string | number> {\r\n readonly val1: T | ReadonlyArray\u003cT>;\r\n readonly val2: ReadonlyArray\u003cT>;\r\n}\r\n\r\ninterface MultiCaseFixture\u003cT> {\r\n cases: T[];\r\n}\r\n\r\nfunction subDataFunc(): TestCase\u003cstring | number>[] {\r\n return [\r\n { val1: \"a\", val2: [\"a\", \"b\", \"c\"] },\r\n { val1: 2, val2: [1, 2, 3] },\r\n { val1: [\"a\", \"z\"], val2: [\"x\", \"y\", \"z\"] },\r\n { val1: [5, 10], val2: [10, 100, 1000] },\r\n ];\r\n}\r\n\r\nfunction dataFunc\u003cT>(subFunc: () => T[]): MultiCaseFixture\u003cT> {\r\n return { cases: subFunc() };\r\n}\r\n\r\nfunction testFunc() {\r\n const fixture = dataFunc\u003cTestCase\u003cstring | number>>(subDataFunc);\r\n fixture.cases.forEach(({ val1, val2 }) => {\r\n if (Array.isArray(val1)) {\r\n const reversedVal1 = val1.slice().reverse();\r\n console.log(reversedVal1);\r\n } else {\r\n console.log(val1);\r\n }\r\n console.log(val2);\r\n });\r\n}\r\n\r\ntestFunc();\r\n```\r\n\r\n**Expected behavior:**\r\n\r\nThis code should compile properly without issues. It compiles fine on `4.1.2` and also compiled fine on previous releases going all the way back to at least `3.8`.\r\n\r\n**Actual behavior:**\r\n\r\nI get this output from `tsc` with the command-line `yarn run tsc test.ts`. There is no `tsconfig.json` file in the folder at the time.\r\n\r\n```\r\ntest.ts:27:47 - error TS2339: Property 'reverse' does not exist on type 'string | any[]'.\r\n Property 'reverse' does not exist on type 'string'.\r\n\r\n27 const reversedVal1 = val1.slice().reverse();\r\n ~~~~~~~\r\n\r\n\r\nFound 1 error.\r\n```\r\n\r\n**Playground Link:** https://www.typescriptlang.org/play?ts=4.2.0-dev.20201211#code/JYOwLgpgTgZghgYwgAgCoQM5gMJwxAHlWQgA9IQATDZLKUAc2QB9kQBXAWwCNoA+ZAG8AUMjHIoEOJQD2IADYBPZADc48gIwAuNC2QAlKbIWKAglChxFRPgG5R4ydLlLV6gEw7Dzk+cvXUO2EAX2FhUEhYRBQAWXZ5MGBcfAAxYHJ2SRshBzEEPEwdVABtAF17UOEYdhAERLladm4AETgwOBSahAAKAEoizBwCgjpGPQ4efjKc8QkIMEyQZGLc2aE3TR0AIjgtgBoNz2Wd-eQt7lOthC3S5GC91dnBDe1kdwO1eSPijQP35AAzLd7o9xM9Pq9iicDlsAF43D4eHRQ0iXRSXeHAh5rMEvZEAVgOGgADKVEV9kSSicTidSaVjVuUQmFqrV6ktKG0Ol0bN0ME1OrUdH1kABeAQlUr9ZBxBJJAppDJZQIzRzzRbrfL4DA6fncQU9Xp3Cosrrs5CQLAGkUiWYIORYZAwdILSRi5Cc9oGoiDZKEUYgJisCa8KB8Ph8pqtL1dXr2WbOpUQAB0WswyZgMigAFFEAALbrdcHqX6HO5G8WqnHAGDIbp+KzJ4AYBuKboQ3pG204tb2kCOyQqaD4SgANRL7ohyYw8mASD6ycHw4gfXjPbtDpk8hT8hkDG6S6gI-HmjjoLEwRI8nwVfXyD7GC3O737ZLZ-XoXXD6fyd3+8+7jvuIwRnpUlpgNacZAA\r\n\r\n**Related Issues:**\r\n\r\nAccording to #40463 and #41808, an issue with `Array.isArray` has already been fixed and is supposedly in `4.1.3`.\r\n","author":{"url":"https://github.com/mwgamble","@type":"Person","name":"mwgamble"},"datePublished":"2020-12-16T00:53:43Z","url":"https://github.com/microsoft/TypeScript/issues/41984"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:c0715fe6-9a12-33dc-3c07-b921db2c6879 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B09C:22DB35:312F633:3EC7EB1:6B01BF47 |
| html-safe-nonce | b09b08d8b835f5d2ebdd0805f4e22a524f4031cb618d47e265d0fb62d5e02fa9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDlDOjIyREIzNTozMTJGNjMzOjNFQzdFQjE6NkIwMUJGNDciLCJ2aXNpdG9yX2lkIjoiOTIwMzc0NzYyODY5OTk5MTg3OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 2d4367bd3f324ce5b20a5785fe9f0d67cda969eb6f9c74ca728f31b3ff70676c |
| hovercard-subject-tag | issue:768347207 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/41984/issue_layout |
| twitter:image | https://opengraph.githubassets.com/69d50a47d5a237e969249e371c087285be58eb53aea701ba4d4509f79b7daf3e/microsoft/TypeScript/issues/41984 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/69d50a47d5a237e969249e371c087285be58eb53aea701ba4d4509f79b7daf3e/microsoft/TypeScript/issues/41984 |
| og:image:alt | TypeScript Version: 4.2.0-dev.20201211 Search Terms: re: Array.isArray Code interface TestCase |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mwgamble |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width