René's URL Explorer Experiment


Title: Incorrect narrowing when a type guard returns a type union · Issue #41871 · microsoft/TypeScript · GitHub

Open Graph Title: Incorrect narrowing when a type guard returns a type union · Issue #41871 · microsoft/TypeScript

X Title: Incorrect narrowing when a type guard returns a type union · Issue #41871 · microsoft/TypeScript

Description: TypeScript Version: 4.1.2 Search Terms: narrowing narrowed type guard type union Code MickeyPhoenix encountered this bug while implementing type guards for HBOMax data services. The original repro involves class inheritance, like this: p...

Open Graph Description: TypeScript Version: 4.1.2 Search Terms: narrowing narrowed type guard type union Code MickeyPhoenix encountered this bug while implementing type guards for HBOMax data services. The original repro ...

X Description: TypeScript Version: 4.1.2 Search Terms: narrowing narrowed type guard type union Code MickeyPhoenix encountered this bug while implementing type guards for HBOMax data services. The original repro ...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/41871

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Incorrect narrowing when a type guard returns a type union","articleBody":"**TypeScript Version:**  4.1.2\r\n\r\n**Search Terms:**\r\n\r\n`narrowing` `narrowed` `type guard` `type union`\r\n\r\n**Code**\r\n\r\n@MickeyPhoenix encountered this bug while implementing type guards for HBOMax data services. The original repro involves `class` inheritance, like this:\r\n\r\n[playground link](https://www.typescriptlang.org/play?#code/MYGwhgzhAECCB2BLAtmE0DeAoavoAcAnRANzABcBTaADwC5p4BXZAI0sOgF5oAGAbiwBfLKEgwAwhWiUaVeABMYCFGkw48+JqxCJg0AO4ALRBADWHCA2ZsO3aAEZBIsVGgAhQgHsvydXgJiMipoAE9rFnZOHicsDVwtHT1DE3NLCNtox0EAxN19IzBFEEoMqK4AZmc4gDMmeGByRC94aEKIAHVUi0IIAApEeC1yBhVUdAAfD29fAEoGQeHoU2gpcmgpzx8-bADCSnImQlbFpnXBiHIi4EovGtXpCanT8-hL69v7rd9qrDqGpotZYNLyEfaNAZDM6jJDjDbTbbzRiROy7PCIe59dpdUw9fovWazfwBPAAelJ0AAkgA5CQAeQASgyAKISAAqDDZRg41AgRi8TBACmg7GgYGgwF8+EQJU4HG8nG5+wANNB4iTySKztAAAYvHXQADmXlekrBlEaIFCjDAYK8BkowvIXl132QBvVAU1kMulDAwruurW8LdOtmnrw+0Ox2BwwAdIVipR+GqAkJU5GDkdWgBaWIiP71RrNVpm8HkSHDGGqSYIuZlVHqjHQSvai5XBqfB7rJ6xttvDs3QNuoloknQTX0pmsjm6xMKEoGlbwE1i6DISiZaCBnXBzYzd3KiO4TUQF3kbkSqUyuxli3kK3Qfb4UHkGBFGR2xU8uPHp9ZmMXgTIoF2TdV0ziPYANzfM4klAcJWkHh4EoAxuz6WZBE1AAFYh4DfaAACJ6gUSgakGR1CJFC0wCYCBqGAChgKTaAFEQBR4AAcnWMBGiYNBH1kUxyFEFozxKOMQC8Q1ITvCFGPIQlBCAA)\r\n```ts\r\nclass Animal {\r\n    private x: number = 0;\r\n}\r\nclass Cat extends Animal {\r\n    public whiskers: number = 1;\r\n}\r\nclass Broom {\r\n    private y: number = 1;\r\n\r\n    public whiskers: number = 1;\r\n    public handle: number=3;\r\n}\r\n\r\nfunction hasWhiskers(input: Animal | Broom): input is Cat | Broom {\r\n    return input instanceof Cat || input instanceof Broom;\r\n}\r\n\r\nfunction incorrect(input: Animal | Broom): number {\r\n    if (hasWhiskers(input)) {\r\n        // INCORRECT: There should be a compiler error here, \r\n        // but `input` got incorrectly narrowed to `Broom` \r\n        // (instead of `Cat | Broom`)\r\n        return input.handle; \r\n    } \r\n    return -1;\r\n}\r\n\r\nfunction correct(input: Animal | Broom): number {\r\n    if (input instanceof Cat || input instanceof Broom) {\r\n        // CORRECT: `handle` is not a member of `Cat | Broom`,\r\n        // so the compiler correctly reports an error here.\r\n        return input.handle;\r\n    } \r\n\r\n    return -1;\r\n}\r\n\r\nconst cat = new Cat();\r\n// Prints \"undefined\" because cat.handle didn't actually exist\r\nconsole.log(incorrect(cat));\r\n```\r\n\r\nBut it can also be reproduced using simpler `interface` inheritance, like this:\r\n\r\n[playground link](https://www.typescriptlang.org/play?#code/JYOwLgpgTgZghgYwgAgIImAWzgG2QbwChkTkcIBzAZwC5kQBXTAI2gG5CBfQ0SWRFAGE4YZBAAekEABMqaDNjxFSyAO4ALYFQDW0WvSasoHbr2jwkyAEJQA9rcwFipDVt1R9jFu2cl1cGXI6LyMTQkIYBhAEMGBbEGR-KgB1TR09AApQAAcGMDp0LFxkAB9rOwcASjocvOQtZGFRMpt7R2VSKAgwBigEgHlmACsIGIA6JP7VEAAFO2zoMABPMYRcHCyQXLAAGmQAcld0j33KsIiomLiE0ARbKC6Yze2ChWKWisxqg28oJxVgDBkBkkqk3JlamBKpV-ipSAB6eHIACSADlBP0AEqYgCiggAKnR8epoCgqOpbAwcNJkKxkHBkHdMNlgOQ-tA7H8SV09r44YjaXUAAaQoXICi2US3e6PMA4Jb0OAPWyqCA0sC2ZBC1oOMV8lQCzZUSBwGm2IFCpqlcptIWVfWdbq9G5bPITALSchsZB8zg+lRdHp9ZAAWgAjGEgA)\r\n```ts\r\ninterface Animal {\r\n    legs: number;\r\n}\r\ninterface Cat extends Animal {\r\n    whiskers: number;\r\n}\r\ninterface Broom {\r\n    whiskers: number;\r\n    handle: number;\r\n}\r\n\r\nfunction hasWhiskers(input: Animal | Broom): input is Cat | Broom {\r\n    return Object.hasOwnProperty.call(input, 'whiskers');\r\n}\r\n\r\nfunction incorrect(input: Animal | Broom): number {\r\n    if (hasWhiskers(input)) {\r\n        // INCORRECT: There should be a compiler error here, \r\n        // but `input` got incorrectly narrowed to `Broom` \r\n        // (instead of `Cat | Broom`)\r\n        return input.handle; \r\n    } \r\n    return -1;\r\n}\r\n\r\n```\r\n\r\n**Expected behavior:**\r\n\r\nOne would expect identical type narrowing when extracting this:\r\n```ts\r\nfunction f(input: Animal | Broom): number {\r\n    if (input instanceof Cat || input instanceof Broom) {\r\n    . . .\r\n```\r\n...into this:\r\n```ts\r\nfunction hasWhiskers(input: Animal | Broom): input is Cat | Broom {\r\n    return input instanceof Cat || input instanceof Broom;\r\n}\r\n\r\n. . .\r\n\r\nfunction f(input: Animal | Broom): number {\r\n    if (hasWhiskers(input)) {\r\n    . . .\r\n```\r\n\r\n**Actual behavior:**\r\n\r\nThe type is incorrectly narrowed to `Broom` instead of `Cat | Broom`.\r\n\r\nAs a result, clearly incorrect code compiles without any error.\r\n\r\n**Related Issues:** https://github.com/microsoft/TypeScript/issues/31156\r\n","author":{"url":"https://github.com/octogonz","@type":"Person","name":"octogonz"},"datePublished":"2020-12-08T05:42:05Z","url":"https://github.com/microsoft/TypeScript/issues/41871"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:b100d6f1-9d8f-33ee-4d67-1327553d0b58
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idDC20:4BB79:1A6E766:21B268C:6B01533B
html-safe-noncefd212ca0917ae0bcbfce6c5ce1f51ba7b84a169494886e186ad1960f276085cf
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzIwOjRCQjc5OjFBNkU3NjY6MjFCMjY4Qzo2QjAxNTMzQiIsInZpc2l0b3JfaWQiOiIxMjMwOTI3Mjg2NTQ3NjAwMTg3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac16f4308c49cc2731edd1b5ab05057d812579e3b17d1e84d46bdbb47a59733424
hovercard-subject-tagissue:759083558
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/41871/issue_layout
twitter:imagehttps://opengraph.githubassets.com/534f9f8ba5e4e155fb54da0e68482450c005b5472bb90fd986ad0b4f26b934c5/microsoft/TypeScript/issues/41871
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/534f9f8ba5e4e155fb54da0e68482450c005b5472bb90fd986ad0b4f26b934c5/microsoft/TypeScript/issues/41871
og:image:altTypeScript Version: 4.1.2 Search Terms: narrowing narrowed type guard type union Code MickeyPhoenix encountered this bug while implementing type guards for HBOMax data services. The original repro ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameoctogonz
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/41871#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F41871
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F41871
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/41871
Reloadhttps://github.com/microsoft/TypeScript/issues/41871
Reloadhttps://github.com/microsoft/TypeScript/issues/41871
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/41871
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/41871
#49625https://github.com/microsoft/TypeScript/pull/49625
Incorrect narrowing when a type guard returns a type unionhttps://github.com/microsoft/TypeScript/issues/41871#top
#49625https://github.com/microsoft/TypeScript/pull/49625
DuplicateAn existing issue was already createdhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Duplicate%22
https://github.com/octogonz
Pete Gonzalez (octogonz)https://github.com/octogonz
on Dec 8, 2020https://github.com/microsoft/TypeScript/issues/41871#issue-759083558
MickeyPhoenixhttps://github.com/MickeyPhoenix
playground linkhttps://www.typescriptlang.org/play#code/MYGwhgzhAECCB2BLAtmE0DeAoavoAcAnRANzABcBTaADwC5p4BXZAI0sOgF5oAGAbiwBfLKEgwAwhWiUaVeABMYCFGkw48+JqxCJg0AO4ALRBADWHCA2ZsO3aAEZBIsVGgAhQgHsvydXgJiMipoAE9rFnZOHicsDVwtHT1DE3NLCNtox0EAxN19IzBFEEoMqK4AZmc4gDMmeGByRC94aEKIAHVUi0IIAApEeC1yBhVUdAAfD29fAEoGQeHoU2gpcmgpzx8-bADCSnImQlbFpnXBiHIi4EovGtXpCanT8-hL69v7rd9qrDqGpotZYNLyEfaNAZDM6jJDjDbTbbzRiROy7PCIe59dpdUw9fovWazfwBPAAelJ0AAkgA5CQAeQASgyAKISAAqDDZRg41AgRi8TBACmg7GgYGgwF8+EQJU4HG8nG5+wANNB4iTySKztAAAYvHXQADmXlekrBlEaIFCjDAYK8BkowvIXl132QBvVAU1kMulDAwruurW8LdOtmnrw+0Ox2BwwAdIVipR+GqAkJU5GDkdWgBaWIiP71RrNVpm8HkSHDGGqSYIuZlVHqjHQSvai5XBqfB7rJ6xttvDs3QNuoloknQTX0pmsjm6xMKEoGlbwE1i6DISiZaCBnXBzYzd3KiO4TUQF3kbkSqUyuxli3kK3Qfb4UHkGBFGR2xU8uPHp9ZmMXgTIoF2TdV0ziPYANzfM4klAcJWkHh4EoAxuz6WZBE1AAFYh4DfaAACJ6gUSgakGR1CJFC0wCYCBqGAChgKTaAFEQBR4AAcnWMBGiYNBH1kUxyFEFozxKOMQC8Q1ITvCFGPIQlBCAA
playground linkhttps://www.typescriptlang.org/play#code/JYOwLgpgTgZghgYwgAgIImAWzgG2QbwChkTkcIBzAZwC5kQBXTAI2gG5CBfQ0SWRFAGE4YZBAAekEABMqaDNjxFSyAO4ALYFQDW0WvSasoHbr2jwkyAEJQA9rcwFipDVt1R9jFu2cl1cGXI6LyMTQkIYBhAEMGBbEGR-KgB1TR09AApQAAcGMDp0LFxkAB9rOwcASjocvOQtZGFRMpt7R2VSKAgwBigEgHlmACsIGIA6JP7VEAAFO2zoMABPMYRcHCyQXLAAGmQAcld0j33KsIiomLiE0ARbKC6Yze2ChWKWisxqg28oJxVgDBkBkkqk3JlamBKpV-ipSAB6eHIACSADlBP0AEqYgCiggAKnR8epoCgqOpbAwcNJkKxkHBkHdMNlgOQ-tA7H8SV09r44YjaXUAAaQoXICi2US3e6PMA4Jb0OAPWyqCA0sC2ZBC1oOMV8lQCzZUSBwGm2IFCpqlcptIWVfWdbq9G5bPITALSchsZB8zg+lRdHp9ZAAWgAjGEgA
#31156https://github.com/microsoft/TypeScript/issues/31156
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
on Dec 8, 2020https://github.com/microsoft/TypeScript/issues/41871#issuecomment-740798260
#31156https://github.com/microsoft/TypeScript/issues/31156
Andrew Branch (andrewbranch)https://github.com/andrewbranch
DuplicateAn existing issue was already createdhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Duplicate%22
on Dec 8, 2020https://github.com/microsoft/TypeScript/issues/41871#event-4086014189
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Dec 10, 2020https://github.com/microsoft/TypeScript/issues/41871#event-4096460311
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
on Dec 10, 2020https://github.com/microsoft/TypeScript/issues/41871#issuecomment-742691409
microsofthttps://github.com/microsoft
on Oct 21, 2025https://github.com/microsoft/TypeScript/issues/41871#event-20417351642
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/41871
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/41871
DuplicateAn existing issue was already createdhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Duplicate%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.