Title: Design Meeting Notes, 10/30/2020 · Issue #41342 · microsoft/TypeScript · GitHub
Open Graph Title: Design Meeting Notes, 10/30/2020 · Issue #41342 · microsoft/TypeScript
X Title: Design Meeting Notes, 10/30/2020 · Issue #41342 · microsoft/TypeScript
Description: Speed-Sensitive PRs Definite-Assignability #39577 Use a definitely-assignable relation in Material-UI If it is a correctness fix, and it's only 1%... that's probably not so terrible. Will manifest in codebases where people can't really e...
Open Graph Description: Speed-Sensitive PRs Definite-Assignability #39577 Use a definitely-assignable relation in Material-UI If it is a correctness fix, and it's only 1%... that's probably not so terrible. Will manifest ...
X Description: Speed-Sensitive PRs Definite-Assignability #39577 Use a definitely-assignable relation in Material-UI If it is a correctness fix, and it's only 1%... that's probably not so terrible. Will m...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/41342
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Design Meeting Notes, 10/30/2020","articleBody":"# Speed-Sensitive PRs\r\n\r\n## Definite-Assignability\r\n\r\nhttps://github.com/microsoft/TypeScript/pull/39577\r\n\r\n* Use a definitely-assignable relation in Material-UI\r\n* If it is a correctness fix, and it's only 1%... that's probably not so terrible.\r\n * Will manifest in codebases where people can't really even understand the types.\r\n* Definitely-assignable relation will never probe constraints for these.\r\n * Isn't this just because `any` is really `unknown` and `never`?\r\n * Maybe dual-behavior of `any` biting us.\r\n * The new relationship is about asking whether any given instantiation will break.\r\n* 4.2-bound if we want.\r\n\r\n## Cache Complex Union and Intersection Relations\r\n\r\nhttps://github.com/microsoft/TypeScript/pull/37910\r\n\r\n* We have never cached the results of relations between unions and intersections.\r\n * We only cache relations between constituents.\r\n* Could try caching all unions/intersections.\r\n * Made things slower in experiments.\r\n * Does a bunch of expensive caching - bad!\r\n * When relating `Foo | Bar | Baz` to `Target`, have to cache\r\n * `Foo | Bar | Baz` to `Target`\r\n * `Foo` to `Target`\r\n * `Bar` to `Target`\r\n * `Baz` to `Target`\r\n* Idea: as soon as we have more than 4 targets to check against, we'll cache.\r\n * Partial reasoning: avoiding `undefined | null | T`.\r\n* This change speeds up the compilers-with-unions test case.\r\n* Aside: any reason why compilers-with-unions was not in the perf suite?\r\n * Was crashing, should be good now.\r\n * Azure might be finally stable in perf numbers.\r\n * Can we get rid of Node 8/10?\r\n * And add Node 14/15\r\n * Perf test fast on LTS/perf test slow\r\n* Aside: maybe linked caches?\r\n* 4.2-bound!\r\n\r\n# Arbitrary Index Signatures (now that we have template string types)\r\n\r\nhttps://github.com/microsoft/TypeScript/pull/26797\r\n\r\n* Have this old PR.\r\n* Would be nice to be able to model `data-` and `aria-`.\r\n* We have two \"kinds\" of types: finite types and infinite types\r\n * `\"foo\"` - finite\r\n * `\"foo\" | \"bar\"` - finite\r\n * `string` - infinite\r\n * `` `aria-${string}` `` - infinite\r\n* Can imagine that mapped types on\r\n * finite types desugar to individual properties.\r\n * infinite types remain as index signatures.\r\n* The PR's original motivation was symbol types.\r\n* As a bonus, it handled string literal types and enums.\r\n * Those would expand out to keys.\r\n* Want to propose that index signatures are required to have an infinite type.\r\n * Including pattern-literal types like `` `aria-${string}` ``.\r\n* Mapped types would be the only thing that can represent keys in a higher-order manner.\r\n * We would not want to get into the business of `{ [x: T]: Type }` where `T` is generic.\r\n * Can't make meaningful statements about `T` in those cases.\r\n* We want to have a view that a mapped type can have some key type that can be finite and infinite.\r\n * At 0-order, these types desugar as described above.\r\n* But we're already \"equipped\" to handle these.\r\n * Index signatures are just another structural component of the type. The hard part is actually adding the index signatures.\r\n* Feels like we're \"ripping out the foundation\" to go higher-order.\r\n* We can ship this with 0-order.\r\n * Shipping PR with forbidden higher-order is more code.\r\n* You need to be able to reason about constraints.\r\n* Follow-up\r\n * Type with multiple index signatures\r\n * Every index signature that matches, you **union when reading**\r\n * Every index signature that matches, you **intersect when writing**\r\n* We have another relationship in the PR where `number` is assignable to `string`.\r\n * You could build it other ways technically.\r\n * Could do it differently before `isRelatedTo`\r\n * But `isRelatedTo` does the nice logic.\r\n* What about\r\n\r\n ```ts\r\n interface Foo {\r\n [x: `aria-${string}`]: string;\r\n [x: `aria-yadda-${string}`]: boolean;\r\n }\r\n ```\r\n * Would be nice if we could provide a nice error message!\r\n * Need to be able to relate pattern types to pattern types.\r\n * Could imagine some set of \"easier\" prefix/postfix.\r\n * \r\n\r\n# Partial Type Argument Inference\r\n\r\nhttps://github.com/microsoft/TypeScript/issues/26242\r\n\r\nOut-of-time","author":{"url":"https://github.com/DanielRosenwasser","@type":"Person","name":"DanielRosenwasser"},"datePublished":"2020-10-30T19:08:44Z","url":"https://github.com/microsoft/TypeScript/issues/41342"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:0e2910bd-9fff-04f8-2591-8cb44c7f7a02 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | BF68:76F02:28875E2:33D826F:6B0199F1 |
| html-safe-nonce | ad82cf3b78d4998b29b8de6047fc09296aa19e64fab3fd37d48fa365810c49b4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRjY4Ojc2RjAyOjI4ODc1RTI6MzNEODI2Rjo2QjAxOTlGMSIsInZpc2l0b3JfaWQiOiIxMDM1NzM2NTE5MTg2NDIyMjU3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 0e028d1352b6d49b1544dac2d7c3a8006f795fc381947a37f5a6a386ffee10eb |
| hovercard-subject-tag | issue:733445580 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/41342/issue_layout |
| twitter:image | https://opengraph.githubassets.com/4ef3f76308e38d0ae2ea676a5c6081d39cb7b770a826cd98b466afa0215f1d9a/microsoft/TypeScript/issues/41342 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4ef3f76308e38d0ae2ea676a5c6081d39cb7b770a826cd98b466afa0215f1d9a/microsoft/TypeScript/issues/41342 |
| og:image:alt | Speed-Sensitive PRs Definite-Assignability #39577 Use a definitely-assignable relation in Material-UI If it is a correctness fix, and it's only 1%... that's probably not so terrible. Will manifest ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | DanielRosenwasser |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width