René's URL Explorer Experiment


Title: emitDecoratorMetadata should emit type resolvers · Issue #41201 · microsoft/TypeScript · GitHub

Open Graph Title: emitDecoratorMetadata should emit type resolvers · Issue #41201 · microsoft/TypeScript

X Title: emitDecoratorMetadata should emit type resolvers · Issue #41201 · microsoft/TypeScript

Description: TypeScript Version: 4.1.0-dev.20201022 Search Terms: emitDecoratorMetadata, decorators, design:type, type, resolver, reflection Code: Suppose we are doing Node.js code and have a plain old circular dependency: classOne.ts import { proper...

Open Graph Description: TypeScript Version: 4.1.0-dev.20201022 Search Terms: emitDecoratorMetadata, decorators, design:type, type, resolver, reflection Code: Suppose we are doing Node.js code and have a plain old circular...

X Description: TypeScript Version: 4.1.0-dev.20201022 Search Terms: emitDecoratorMetadata, decorators, design:type, type, resolver, reflection Code: Suppose we are doing Node.js code and have a plain old circular...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/41201

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"emitDecoratorMetadata should emit type resolvers","articleBody":"**TypeScript Version:**  4.1.0-dev.20201022\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:** emitDecoratorMetadata, decorators, design:type, type, resolver, reflection\r\n\r\n**Code:**\r\n\r\nSuppose we are doing [Node.js](https://nodejs.org/en/) code and have a plain old circular dependency: \r\n#### **`classOne.ts`**\r\n```ts\r\nimport { property } from './utils';\r\nimport ClassTwo from './classTwo';\r\n\r\nexport default class ClassOne {\r\n  @property\r\n  property: ClassTwo;\r\n}\r\n```\r\n#### **`classTwo.ts`**\r\n```ts\r\nimport { property } from './utils';\r\nimport ClassOne from './classOne';\r\n\r\nexport default class ClassTwo {\r\n  @property\r\n  property: ClassOne;\r\n}\r\n```\r\nand suppose we want to bring a bit of reflection in our code:\r\n\r\n#### **`index.ts`**\r\n```ts\r\nimport 'reflect-metadata';\r\nimport { getDesignType } from './utils';\r\nimport ClassOne from './classOne';\r\nimport ClassTwo from './classTwo';\r\n\r\nconsole.log(`Hello World! ${ClassOne.name} and ${ClassTwo.name};)`);\r\n\r\nconsole.log(`--`);\r\n\r\nconsole.log(`${ClassOne.name} property is of type ${getDesignType(ClassOne, 'property')}`);\r\nconsole.log(`${ClassTwo.name} property is of type ${getDesignType(ClassTwo, 'property')}`);\r\n```\r\n#### **`utils.ts`**\r\n```ts\r\n/**\r\n * Use typescript emited metadata to get the type\r\n *\r\n * @param ctor\r\n * @param key\r\n */\r\nexport const getDesignType = (ctor: Function, key: string) => {\r\n  const type = Reflect.getMetadata('design:type', ctor.prototype, key);\r\n  return type?.name;\r\n}\r\n\r\n/**\r\n * Dummy decorator\r\n *\r\n * @param target\r\n * @param key\r\n */\r\nexport const property = (target: any, key: string) => { }\r\n```\r\n\r\n**Expected behavior:**\r\n```console\r\nfoo@bar:~$ node ./dist\r\nHello World! ClassOne and ClassTwo;)\r\n--\r\nClassOne property is of type ClassTwo\r\nClassTwo property is of type ClassOne\r\n```\r\n**Actual behavior:**\r\n```console\r\nfoo@bar:~$ node ./dist\r\nHello World! ClassOne and ClassTwo;)\r\n--\r\nClassOne property is of type ClassTwo\r\nClassTwo property is of type undefined\r\n```\r\n**Explanation:**\r\n\r\nWell it's not much a surprise, we are running into a circular import issue:\r\n- **index.ts** is importing **ClassOne**\r\n- **ClassOne** is importing **ClassTwo**\r\n- **ClassTwo** is importing **ClassOne**\r\n- Since ClassOne is being read, return the **cached value** of ClassOne\r\n- `__metadata(\"design:type\", classOne_1.default) ` is evaluated\r\n- `classOne_1.default` is evaluated to **undefined**\r\n- ...\r\n\r\n**Workaround:**\r\n\r\nThere is a simple workaround and it's already used by many libraries but unfortunately not by typescript. The idea is not to emit the type but to emit a **type resolver** ie. instead of emitting `ClassFoo` one should emit `() => ClassFoo`. This way we can evaluate the **type resolver** in _index.ts_ at a time where **ClassOne** import is already done.\r\n\r\n**Playground Link:** \u003c!-- A link to a TypeScript Playground \"Share\" link which demonstrates this behavior -->\r\n\r\nhttps://github.com/paeolo/typescript-emit-resolver\r\n\r\n**Related Issues:** \u003c!-- Did you find other bugs that looked similar? -->\r\n\r\nThis issue is the root of many issues. Solving this will enable a much better code where reflection is used by not introducing the type resolver as a redondancy.\r\n\r\nPlease note that trying to solve the circular import is not a good solution. Sometimes circular import are inherents and it's very hard to both focus on code and trying to solve every \"circular import\" related problems. tslib would benefit a lot from being more resilient to such issues.","author":{"url":"https://github.com/paeolo","@type":"Person","name":"paeolo"},"datePublished":"2020-10-22T18:12:53Z","url":"https://github.com/microsoft/TypeScript/issues/41201"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:af2ee80b-0c22-f5bb-dedd-a607ba1f252e
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id94FC:399E4B:2E885D9:3DCCD7B:6B01CE1F
html-safe-nonceb5d14e900b191c7aa4d7d3488de6a7a026d9897ef703366338ced1193ae9b631
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NEZDOjM5OUU0QjoyRTg4NUQ5OjNEQ0NEN0I6NkIwMUNFMUYiLCJ2aXNpdG9yX2lkIjoiMzExNDQ3MTYzMDcwMTcxMDg3OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5ce14b0dba1537761dbf85b8459eeafc6adc93ffb79409e3d9868d10970f713a
hovercard-subject-tagissue:727613841
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/41201/issue_layout
twitter:imagehttps://opengraph.githubassets.com/69edd9d1b30ef4eb68d799d9e51a7e8eaa8ab20578904c5c191ef38e6a1ae5d4/microsoft/TypeScript/issues/41201
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/69edd9d1b30ef4eb68d799d9e51a7e8eaa8ab20578904c5c191ef38e6a1ae5d4/microsoft/TypeScript/issues/41201
og:image:altTypeScript Version: 4.1.0-dev.20201022 Search Terms: emitDecoratorMetadata, decorators, design:type, type, resolver, reflection Code: Suppose we are doing Node.js code and have a plain old circular...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepaeolo
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/41201#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F41201
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F41201
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/41201
Reloadhttps://github.com/microsoft/TypeScript/issues/41201
Reloadhttps://github.com/microsoft/TypeScript/issues/41201
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/41201
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/41201
emitDecoratorMetadata should emit type resolvershttps://github.com/microsoft/TypeScript/issues/41201#top
DuplicateAn existing issue was already createdhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Duplicate%22
https://github.com/paeolo
Le Couteur Paul (paeolo)https://github.com/paeolo
on Oct 22, 2020https://github.com/microsoft/TypeScript/issues/41201#issue-727613841
Node.jshttps://nodejs.org/en/
https://github.com/paeolo/typescript-emit-resolverhttps://github.com/paeolo/typescript-emit-resolver
https://github.com/MartinJohns
Martin Johns (MartinJohns)https://github.com/MartinJohns
on Oct 22, 2020https://github.com/microsoft/TypeScript/issues/41201#issuecomment-714681094
#27519https://github.com/microsoft/TypeScript/issues/27519
https://github.com/paeolo
Le Couteur Paul (paeolo)https://github.com/paeolo
on Oct 23, 2020https://github.com/microsoft/TypeScript/issues/41201#issuecomment-715353972
Martin Johns (@MartinJohns)https://github.com/MartinJohns
#27519https://github.com/microsoft/TypeScript/issues/27519
Le Couteur Paul (paeolo)https://github.com/paeolo
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Oct 23, 2020https://github.com/microsoft/TypeScript/issues/41201#event-3914046678
Le Couteur Paul (paeolo)https://github.com/paeolo
on Oct 28, 2020https://github.com/microsoft/TypeScript/issues/41201#event-3930410895
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
DuplicateAn existing issue was already createdhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Duplicate%22
on Nov 4, 2020https://github.com/microsoft/TypeScript/issues/41201#event-3958410098
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Nov 6, 2020https://github.com/microsoft/TypeScript/issues/41201#event-3968329926
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
on Nov 6, 2020https://github.com/microsoft/TypeScript/issues/41201#issuecomment-723219005
microsofthttps://github.com/microsoft
on Oct 21, 2025https://github.com/microsoft/TypeScript/issues/41201#event-20417051407
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/41201
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/41201
DuplicateAn existing issue was already createdhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Duplicate%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.