Title: Commonjs import with destructuring ignores trailing property access · Issue #40578 · microsoft/TypeScript · GitHub
Open Graph Title: Commonjs import with destructuring ignores trailing property access · Issue #40578 · microsoft/TypeScript
X Title: Commonjs import with destructuring ignores trailing property access · Issue #40578 · microsoft/TypeScript
Description: Discovered in prettier/prettier#9207, where brodybits is investigating whether #40143 works. // @filename: mod1.js var o = { concat() { } } exports.builders = o // @filename: test.js const { concat } = require('./mod1').builders; Expecte...
Open Graph Description: Discovered in prettier/prettier#9207, where brodybits is investigating whether #40143 works. // @filename: mod1.js var o = { concat() { } } exports.builders = o // @filename: test.js const { concat...
X Description: Discovered in prettier/prettier#9207, where brodybits is investigating whether #40143 works. // @filename: mod1.js var o = { concat() { } } exports.builders = o // @filename: test.js const { concat...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/40578
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Commonjs import with destructuring ignores trailing property access","articleBody":"Discovered in https://github.com/prettier/prettier/pull/9207, where @brodybits is investigating whether #40143 works.\r\n\r\n```js\r\n// @filename: mod1.js\r\nvar o = {\r\n concat() { }\r\n}\r\nexports.builders = o\r\n// @filename: test.js\r\nconst { concat } = require('./mod1').builders;\r\n```\r\n\r\n**Expected behavior:**\r\n\r\n`concat: () => void`\r\n\r\n**Actual behavior:**\r\n\r\nError: module \"mod1\" has no exported member 'concat'.\r\n\r\nLooks like we miss the trailing property access and don't fall back to the faked import type.","author":{"url":"https://github.com/sandersn","@type":"Person","name":"sandersn"},"datePublished":"2020-09-15T23:03:25Z","url":"https://github.com/microsoft/TypeScript/issues/40578"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:681bfb42-39eb-dca1-3b2b-f4b11dc59e57 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | ECA2:1DC4CC:9040D5:C0815C:6B01B560 |
| html-safe-nonce | c221857ea4498e4cd99fcf5221db9235a59b7ae1bc9217c9498f884431ffdfea |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQ0EyOjFEQzRDQzo5MDQwRDU6QzA4MTVDOjZCMDFCNTYwIiwidmlzaXRvcl9pZCI6IjMyMjU3ODY5MDY3OTU3NjAwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 6829cf8d314dc1fc69b0ed932e998b06bdd52a77eab41eab50df5332bd7a3317 |
| hovercard-subject-tag | issue:702327413 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/40578/issue_layout |
| twitter:image | https://opengraph.githubassets.com/8ca5593b565899478461225259bf13cc93c4d7ec197a633b2cc2981cb02d8028/microsoft/TypeScript/issues/40578 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8ca5593b565899478461225259bf13cc93c4d7ec197a633b2cc2981cb02d8028/microsoft/TypeScript/issues/40578 |
| og:image:alt | Discovered in prettier/prettier#9207, where brodybits is investigating whether #40143 works. // @filename: mod1.js var o = { concat() { } } exports.builders = o // @filename: test.js const { concat... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sandersn |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width