Title: False positive in "variable is never read" when using object.defineProperty · Issue #40440 · microsoft/TypeScript · GitHub
Open Graph Title: False positive in "variable is never read" when using object.defineProperty · Issue #40440 · microsoft/TypeScript
X Title: False positive in "variable is never read" when using object.defineProperty · Issue #40440 · microsoft/TypeScript
Description: I was originally looking at the migration guide on how to fix accessors overriding properties in TS -> #33509 Part of that guidance was using object.defineProperty and defining the getter/setter over there but hit a strange compiler erro...
Open Graph Description: I was originally looking at the migration guide on how to fix accessors overriding properties in TS -> #33509 Part of that guidance was using object.defineProperty and defining the getter/setter ov...
X Description: I was originally looking at the migration guide on how to fix accessors overriding properties in TS -> #33509 Part of that guidance was using object.defineProperty and defining the getter/setter...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/40440
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"False positive in \"variable is never read\" when using object.defineProperty","articleBody":"\u003c!-- 🚨 STOP 🚨 STOP 🚨 STOP 🚨\r\n\r\nHalf of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common \"Bugs\" That Aren't Bugs section!\r\n\r\nPlease help us by doing the following steps before logging an issue:\r\n * Search: https://github.com/Microsoft/TypeScript/search?type=Issues\r\n * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ\r\n\r\nPlease fill in the *entire* template below.\r\n-->\r\n\r\n\u003c!--\r\nPlease try to reproduce the issue with the latest published version. It may have already been fixed.\r\nFor npm: `typescript@next`\r\nThis is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly\r\n-->\r\n\r\nI was originally looking at the migration guide on how to fix accessors overriding properties in TS -> https://github.com/microsoft/TypeScript/pull/33509#\r\n\r\nPart of that guidance was using object.defineProperty and defining the getter/setter over there but hit a strange compiler error.\r\n\r\n**TypeScript Version:** 3.8.3\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:**\r\n - object define property false positive\r\n- unread variable define property\r\n**Code**\r\n\r\n```ts\r\nexport class Foo {\r\n private _value: string | undefined;\r\n\r\n constructor() {\r\n Object.defineProperty(this, \"value\", {\r\n get() {\r\n return this._value;\r\n }\r\n });\r\n }\r\n}\r\n```\r\n\r\n**Expected behavior:**\r\n\r\nNo compiler errors as I am defining a setter for the _value so the value is being read somewhere\r\n\r\n**Actual behavior:**\r\n\r\n'_value' is declared but its value is never read.\r\n\r\nIf I remove `_value` I get \r\n\r\nProperty '_value' does not exist on type 'Foo'. Did you mean 'value'?\r\n\r\n**Playground Link:** \u003c!-- A link to a TypeScript Playground \"Share\" link which demonstrates this behavior -->\r\nhttps://www.typescriptlang.org/play?ts=3.8.3#code/KYDwDg9gTgLgBAYwDYEMDOa4DEITgbwFgAoOOMKASwDcUZg4B9WpAV2AC440YqA7AOZwAPnFZ8AJsABmlPsAkBuEiTIIIfHlFYIY0ABQBKAqrJwA8gCMAVsF0A6KbPkAFKBDDBYAT30wAFpRoADRwAEQs7GGhRKRmZALAMEYmcfFkUEmsUHxwAUH2zChswMppZgC+pmQVhmU1JBVAA\r\n\r\n**Related Issues:** \u003c!-- Did you find other bugs that looked similar? -->\r\n","author":{"url":"https://github.com/mastrzyz","@type":"Person","name":"mastrzyz"},"datePublished":"2020-09-08T21:12:47Z","url":"https://github.com/microsoft/TypeScript/issues/40440"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:9c78aeba-7ba3-421a-22bc-f8d0f2e0ebce |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A6F2:187C1E:12D5E8:190E13:6B0184EA |
| html-safe-nonce | 07a6d2008d2b4266b5bc3ba0af05e3da37ded52857a1803cb19fdaf27f464e0f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNkYyOjE4N0MxRToxMkQ1RTg6MTkwRTEzOjZCMDE4NEVBIiwidmlzaXRvcl9pZCI6IjcxMTY2MzgwMzUzMzIxMzgyMTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 3633837f4b5b007d61424cac6292b27baf9189a7004e4a9da59511f61db0c3ff |
| hovercard-subject-tag | issue:696181233 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/40440/issue_layout |
| twitter:image | https://opengraph.githubassets.com/9bdab10800906b088e6fd39bb172e33cb6a6734f59202156892d241fbc02eb72/microsoft/TypeScript/issues/40440 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9bdab10800906b088e6fd39bb172e33cb6a6734f59202156892d241fbc02eb72/microsoft/TypeScript/issues/40440 |
| og:image:alt | I was originally looking at the migration guide on how to fix accessors overriding properties in TS -> #33509 Part of that guidance was using object.defineProperty and defining the getter/setter ov... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mastrzyz |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width