Title: "Isolated" annotation for functions that only act on inputs (distinct from 'pure') · Issue #39949 · microsoft/TypeScript · GitHub
Open Graph Title: "Isolated" annotation for functions that only act on inputs (distinct from 'pure') · Issue #39949 · microsoft/TypeScript
X Title: "Isolated" annotation for functions that only act on inputs (distinct from 'pure') · Issue #39949 · microsoft/TypeScript
Description: Search Terms pure isolated functional testing functions Suggestion I'd like to be able to assert that a function is isolated, which I define as "acts only on arguments passed in as inputs". Isolated functions can be extracted more easily...
Open Graph Description: Search Terms pure isolated functional testing functions Suggestion I'd like to be able to assert that a function is isolated, which I define as "acts only on arguments passed in as inputs". Isolate...
X Description: Search Terms pure isolated functional testing functions Suggestion I'd like to be able to assert that a function is isolated, which I define as "acts only on arguments passed in as inputs&...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/39949
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"\"Isolated\" annotation for functions that only act on inputs (distinct from 'pure')","articleBody":"\u003c!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨\r\n\r\nHalf of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker.\r\n\r\nPlease help us by doing the following steps before logging an issue:\r\n * Search: https://github.com/Microsoft/TypeScript/search?type=Issues\r\n * Read the FAQ, especially the \"Common Feature Requests\" section: https://github.com/Microsoft/TypeScript/wiki/FAQ\r\n\r\n-->\r\n\r\n## Search Terms\r\n\r\n\u003c!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->\r\npure\r\nisolated\r\nfunctional\r\ntesting\r\nfunctions\r\n\r\n## Suggestion\r\n\r\nI'd like to be able to assert that a function is `isolated`, which I define as \"acts only on arguments passed in as inputs\". Isolated functions can be extracted more easily during refactors and can be tested in isolation from the rest of the codebase, opening the door to things like doctests.\r\n\r\nA function that applies inherited scope to arguments cannot be `isolated`. If you're using jquery for instance, you'd want to pass `$` in as an argument to your isolated functions even if it's available in the global scope.\r\n\r\n**NOTE**: Claiming that a function is `isolated` is not the same thing as claiming that it's `pure`. At first glimpse they seem like synonyms, but I don't see how a `pure` function is possible in javascript given that you can't control the side-effects of invoking methods on arguments, etc. Passing `$` in and then acting on it is by definition *NOT* a pure function, but we can still treat it as isolated! :)\r\n\r\nThe desired behavior is that if a function is annotated as `isolated` there'll be a compiler error thrown if it tries to access a value that's not one of its arguments.\r\n\r\n\r\n## Use Cases\r\n\r\n### Big Win: Easier Refactoring\r\nAn isolated function can be relocated into any source file without worrying about breaking its behavior by changing the scope it's situated in. It carries its own scope with it no matter where it lives. This opens the door too for interesting and novel approaches to the way code inhabits a filesystem. I'm imagining something like the Eve editor, where \"files\" are abstractions that may not be as helpful moving forward as they were in the past.\r\n\r\n### Bigger Win: Testing\r\nIf a function doesn't rely on external scope then testing it becomes trivial - every part of the function's behavior can be explored by tweaking input arguments. This not only makes the functions easier to test in the immediate case (simpler mocking, isolation etc) but also opens the door for things like doctests in the future. (see [Elixir's doctests](https://elixir-lang.org/getting-started/mix-otp/docs-tests-and-with.html#doctests) for an example of what I mean)\r\n\r\n## Examples\r\n\r\nThink of isolation as a less strict purity. Because this is javascript we can't control what happens when we e.g. call a method on an argument to our function. The runtime behavior is unpredictable enough that purity can't be guaranteed without adding significant runtime-breaking constraints.\r\n\r\nWhat we can do, though, is check to see if our function is only acting on inputs. \r\n```\r\n/*\r\n* @isolated \r\n*/\r\nfunction sum(x, y) { return x + y } // this works\r\n\r\n/*\r\n* @isolated\r\n*/\r\nfunction addX(value) { return value + x } // this throws a compiler error\r\n```\r\n\r\n### this\r\nAnything explicitly on `this` counts as an argument input, since you can always call/apply/bind to invoke it and pass a `this` value in. This would complicate refactoring if you're using prototypes, since you'd have to grab all references to the function not just the definition, but it still feels viable and useful to me?\r\n\r\nThis allows us to have the seeming contradiction of `isolated` methods on objects and instances, I _think_. There's probably some complexity here I'm not thinking about?\r\n```\r\n/*\r\n* @isolated \r\n*/\r\nfunction updateModel(delta) {\r\n this.model.patch(delta)\r\n}\r\n\r\n// and elsewhere\r\n\r\nupdateThisModel = updateModel.bind(model)\r\n```\r\n\r\n### Existing code\r\nBecause this is an opt-in assertion there are no changes to existing codebases. Further, because the goal is to throw a compiler error when isolation is violated there's a happy path for incremental adoption within a codebase. A lot of core behavior should already be fairly isolated, and being able to make that assertion would bring a lot of new stability to the codebase.\r\n\r\n```\r\n/*\r\n* @isolated\r\n*/\r\nfunction myReducer(accumulator, value) { return accumulator.push(value * 2) }\r\n```\r\n\r\n### Purity (and its conspicuous absence)\r\nLet's look at the following isolated function, which just does some JQuery shenanigans. We can assert that this function is `isolated` because `$`, `selector` and `value` are all passed in as arguments. But this code isn't `pure` because invoking jQuery like this has side effects.\r\n\r\nWe still get the benefit of isolation, though, because now we know we can test this function and all we have to do is mock `$`.\r\n\r\n```\r\n/*\r\n* @isolated\r\n*/\r\nfunction setValue($, selector, value) { $(selector).value(value) }\r\n```\r\n\r\n\r\n## Checklist\r\n\r\nMy suggestion meets these guidelines:\r\n\r\n* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code\r\n* [x] This wouldn't change the runtime behavior of existing JavaScript code\r\n* [x] This could be implemented without emitting different JS based on the types of the expressions\r\n* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)\r\n* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).\r\n","author":{"url":"https://github.com/mbilokonsky","@type":"Person","name":"mbilokonsky"},"datePublished":"2020-08-07T15:41:35Z","url":"https://github.com/microsoft/TypeScript/issues/39949"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:a9895c94-54d5-67d8-f98f-12358c143bd6 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | DC88:21BD98:2B5AAF1:370A02E:6B01E365 |
| html-safe-nonce | d5485a9f854f5622252ffe288135e6cd69ea845370dcc756df0652e92788fdc4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzg4OjIxQkQ5ODoyQjVBQUYxOjM3MEEwMkU6NkIwMUUzNjUiLCJ2aXNpdG9yX2lkIjoiODQ0NzIzMjE0OTMxMjEwMzI2OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | dd2ee2058623952839ffa0fec127bbbc6ae2a4a5b83e576de8c037f7b5774aec |
| hovercard-subject-tag | issue:675098265 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/39949/issue_layout |
| twitter:image | https://opengraph.githubassets.com/1e7e284ec5264211eeeb1eea261aeefc0b210052a9a8725c1a3ac34b2dffa909/microsoft/TypeScript/issues/39949 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1e7e284ec5264211eeeb1eea261aeefc0b210052a9a8725c1a3ac34b2dffa909/microsoft/TypeScript/issues/39949 |
| og:image:alt | Search Terms pure isolated functional testing functions Suggestion I'd like to be able to assert that a function is isolated, which I define as "acts only on arguments passed in as inputs". Isolate... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mbilokonsky |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width