Title: Design Meeting Notes, 7/31/2020 · Issue #39852 · microsoft/TypeScript · GitHub
Open Graph Title: Design Meeting Notes, 7/31/2020 · Issue #39852 · microsoft/TypeScript
X Title: Design Meeting Notes, 7/31/2020 · Issue #39852 · microsoft/TypeScript
Description: Make Direct Assignments to CommonJS Exports Considered Literal Contexts #39816 In JavaScript, module.exports.yadda = ... is considered read-only already. What about module.exports = { yadda: ... }? This PR makes it so we consider that wh...
Open Graph Description: Make Direct Assignments to CommonJS Exports Considered Literal Contexts #39816 In JavaScript, module.exports.yadda = ... is considered read-only already. What about module.exports = { yadda: ... }?...
X Description: Make Direct Assignments to CommonJS Exports Considered Literal Contexts #39816 In JavaScript, module.exports.yadda = ... is considered read-only already. What about module.exports = { yadda: ... }?...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/39852
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Design Meeting Notes, 7/31/2020","articleBody":"# Make Direct Assignments to CommonJS Exports Considered Literal Contexts\r\n\r\nhttps://github.com/microsoft/TypeScript/pull/39816\r\n\r\n* In JavaScript, `module.exports.yadda = ...` is considered read-only already.\r\n* What about `module.exports = { yadda: ... }`?\r\n* This PR makes it so we consider that when we decide the types are literals or unique symbols.\r\n* Technically a breaking change.\r\n * At earliest, 4.1\r\n* This would be the only place where we infer an object literal to have readonly properties.\r\n* Let's see how the user code suite works with this.\r\n* Because it's only CommonJS, maybe we should just leave it alone.\r\n* Probably merits no breakage if we see any.\r\n* Merge otherwise.\r\n\r\n# Variadic Tuples in `Promise.all`\r\n\r\nhttps://github.com/microsoft/TypeScript/issues/39796\r\n\r\n* With `Promise.all`, we have like 8 overloads.\r\n* They don't handle functions with optional members or with rest elements.\r\n * Means you end up with a weakly typed result from `Promise.all`.\r\n* Variadics can handle all these great cases that overloads can't!\r\n* Technically a breaking change because people could give explicit type arguments.\r\n* *Sounds* rare\r\n * 2 instances in VS Code\r\n* This also brings up a question about the `awaited` type.\r\n * How many levels should the approximated `Awaited` type in the PR handle?\r\n* We want `T | Promise\u003cT>` to ensure that `T` is not a `Promise`.\r\n * But `Promise` itself can be constructed with an unconstrained type parameter.\r\n* Will we ever solve this?\r\n* Would be willing to try in 4.1.\r\n\r\n# Auto-Imports Slowdown\r\n\r\nhttps://github.com/microsoft/TypeScript/pull/38923\r\n\r\n* We should always keep in mind that when these auto-magic features are supposed to make things really good, but then turn everything to crap.\r\n* We could have a threshold of packages that are not already imported. If you have more than N packages, we don't do the work.\r\n* We have a flag to turn things off: auto, off, and on.\r\n * Technically it's off, dependencies, devDependencies.\r\n* We could do a low threshold - like 10 packages.\r\n* Can we have editors communicate more than \"loading JS/TS language features\"?\r\n * Signaling exactly what we're working on to communicate that something can be turned on.\r\n* Have to discuss some sort of mitigation plan\r\n","author":{"url":"https://github.com/DanielRosenwasser","@type":"Person","name":"DanielRosenwasser"},"datePublished":"2020-07-31T20:03:09Z","url":"https://github.com/microsoft/TypeScript/issues/39852"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:c0a16545-5e38-6233-bc03-efc383f3a9ab |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | CCC6:20AA01:9EE016:CD72BE:6B00E141 |
| html-safe-nonce | 6d31ca625a2a8e66d430c7dcc3a6990228c4ff4635091ec899eabde5c7332b00 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQ0M2OjIwQUEwMTo5RUUwMTY6Q0Q3MkJFOjZCMDBFMTQxIiwidmlzaXRvcl9pZCI6IjI3Mzg5NjQ3MDE1OTY2NzIzMjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | ed809c4dd52f33471dedbd76f5b15c2bf11ee2eade22aa825601ffe1bdbd88c5 |
| hovercard-subject-tag | issue:670174294 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/39852/issue_layout |
| twitter:image | https://opengraph.githubassets.com/ae64efc0a874d36af89007af77174799e630c06a86decba8b3c79c8815dafe19/microsoft/TypeScript/issues/39852 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ae64efc0a874d36af89007af77174799e630c06a86decba8b3c79c8815dafe19/microsoft/TypeScript/issues/39852 |
| og:image:alt | Make Direct Assignments to CommonJS Exports Considered Literal Contexts #39816 In JavaScript, module.exports.yadda = ... is considered read-only already. What about module.exports = { yadda: ... }?... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | DanielRosenwasser |
| hostname | github.com |
| expected-hostname | github.com |
| None | 043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5425dc24e8bd8d6fca9641a12afc984825a43875 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width