Title: Types defining `Symbol.hasInstance` should be eligible to use with the `instanceof` operator · Issue #39064 · microsoft/TypeScript · GitHub
Open Graph Title: Types defining `Symbol.hasInstance` should be eligible to use with the `instanceof` operator · Issue #39064 · microsoft/TypeScript
X Title: Types defining `Symbol.hasInstance` should be eligible to use with the `instanceof` operator · Issue #39064 · microsoft/TypeScript
Description: TypeScript Version: 3.9.4 As specified here, https://tc39.es/ecma262/#sec-instanceofoperator, it should be sufficient for an object to define a function for the Symbol.hasInstance well-known symbol in order to be used as the right-hand s...
Open Graph Description: TypeScript Version: 3.9.4 As specified here, https://tc39.es/ecma262/#sec-instanceofoperator, it should be sufficient for an object to define a function for the Symbol.hasInstance well-known symbol...
X Description: TypeScript Version: 3.9.4 As specified here, https://tc39.es/ecma262/#sec-instanceofoperator, it should be sufficient for an object to define a function for the Symbol.hasInstance well-known symbol...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/39064
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Types defining `Symbol.hasInstance` should be eligible to use with the `instanceof` operator","articleBody":"\u003c!-- 🚨 STOP 🚨 STOP 🚨 STOP 🚨\r\n\r\nHalf of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common \"Bugs\" That Aren't Bugs section!\r\n\r\nPlease help us by doing the following steps before logging an issue:\r\n * Search: https://github.com/Microsoft/TypeScript/search?type=Issues\r\n * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ\r\n\r\nPlease fill in the *entire* template below.\r\n-->\r\n\r\n\u003c!--\r\nPlease try to reproduce the issue with the latest published version. It may have already been fixed.\r\nFor npm: `typescript@next`\r\nThis is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly\r\n-->\r\n**TypeScript Version:** 3.9.4\r\n\r\nAs specified here, https://tc39.es/ecma262/#sec-instanceofoperator, it should be sufficient for an object to define a function for the `Symbol.hasInstance` well-known symbol in order to be used as the right-hand side of the `instanceof` operator.\r\n\r\nIt seems like this was intended to be implemented based on these comments: https://github.com/microsoft/TypeScript/pull/12728#issuecomment-269801430\r\nbut for whatever reason that didn't happen it in the PR\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:** Symbol.hasInstance\r\n\r\n**Code**\r\n\r\n```ts\r\n({}) instanceof {[Symbol.hasInstance]: () => true}\r\n// Running this in the browser evaluates to `true`\r\n```\r\n\r\n**Expected behavior:**\r\nNo type-errors\r\n\r\n**Actual behavior:**\r\n```ts\r\n({}) instanceof {[Symbol.hasInstance]: () => true}\r\n ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\r\n!!! error TS2359: The right-hand side of an 'instanceof' expression must be of type 'any' or of a type assignable to the 'Function' interface type.\r\n```\r\n\r\n**Playground Link:** [Playground Link](https://www.typescriptlang.org/play/?ssl=1&ssc=1&pln=1&pc=51#code/BQbwvglABAlgdgZwC4EM4GMCmB7AZlEAbQGUBPAWwCNsAbAOgAsUEBJRVDTAXQC4phoAXgB8UJACcArpjBA)\r\n\r\n**Related Issues:** \u003c!-- Did you find other bugs that looked similar? -->\r\n","author":{"url":"https://github.com/lazytype","@type":"Person","name":"lazytype"},"datePublished":"2020-06-14T10:25:29Z","url":"https://github.com/microsoft/TypeScript/issues/39064"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:bb4c438d-d696-1748-edd6-2b9787422101 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | CD28:213839:2D21BA3:39B188E:6B01AC65 |
| html-safe-nonce | e36c49e04fba83f0b8f1c14d8abd327fc8790d759fec6b203009c50101c0240a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDI4OjIxMzgzOToyRDIxQkEzOjM5QjE4OEU6NkIwMUFDNjUiLCJ2aXNpdG9yX2lkIjoiMTM3NjY2ODM3NzQ0MzA1MjY0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 652cee9435d4758a89748bee5bb7b1d916b2ce26d24c606a4e081f932eea9358 |
| hovercard-subject-tag | issue:638324521 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/39064/issue_layout |
| twitter:image | https://opengraph.githubassets.com/9a7de12415097122176b00490cc9693110b674b7eea51a28d6685b9414436c37/microsoft/TypeScript/issues/39064 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9a7de12415097122176b00490cc9693110b674b7eea51a28d6685b9414436c37/microsoft/TypeScript/issues/39064 |
| og:image:alt | TypeScript Version: 3.9.4 As specified here, https://tc39.es/ecma262/#sec-instanceofoperator, it should be sufficient for an object to define a function for the Symbol.hasInstance well-known symbol... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | lazytype |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width