René's URL Explorer Experiment


Title: Support non-constructor JSX factory functions · Issue #37733 · microsoft/TypeScript · GitHub

Open Graph Title: Support non-constructor JSX factory functions · Issue #37733 · microsoft/TypeScript

X Title: Support non-constructor JSX factory functions · Issue #37733 · microsoft/TypeScript

Description: TypeScript Version: 3.3.3 to 3.8.3 Search Terms: jsx factory function constructor component ElementClass Expected behavior: I'm trying to pass a factory function instead of a class component as a JSX element constructor function. It shou...

Open Graph Description: TypeScript Version: 3.3.3 to 3.8.3 Search Terms: jsx factory function constructor component ElementClass Expected behavior: I'm trying to pass a factory function instead of a class component as a J...

X Description: TypeScript Version: 3.3.3 to 3.8.3 Search Terms: jsx factory function constructor component ElementClass Expected behavior: I'm trying to pass a factory function instead of a class component as...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/37733

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Support non-constructor JSX factory functions","articleBody":"**TypeScript Version:**  3.3.3  to 3.8.3\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:**\r\njsx factory function constructor component ElementClass \r\n\r\n**Expected behavior:**\r\nI'm trying to pass a factory function instead of a class component as a JSX element constructor function. It should be possible according to the Handbook, as described [here](https://www.typescriptlang.org/docs/handbook/jsx.html). See the example under the `Type checking -> class component` section (I can't deep-link with hash/anchor because the server isn't properly configured :( ). I should get no errors with the code provided below.\r\n\r\n**Actual behavior:**\r\nI get the following error:\r\n```\r\nJSX element type '{ render: () => { custom: string; }; }' is not a constructor function for JSX elements.\r\n  Property 'custom' is missing in type '{ render: () => { custom: string; }; }' but required in type 'Element'.(2605)\r\n```\r\nFrom what I can tell, this used to work, but the behavior broke somewhere between v3.1.6 and v3.3.3 (as tried in the Playground). I'm guessing there was some change that altered detection between React function components and class components and that change introduced this bug. I'm not even sure if React runtime even allows factory functions, but my use case is a custom library and I'm not using React at all. This error is the same regardless of using React or not.\r\n\r\nAlso, with the exact example from the Handbook, because the JSX.Element is not specified explicitly, there is no error, even when there should be one. See [Playground Link for Handbook example](https://www.typescriptlang.org/play/index.html?jsx=1&ts=3.3.3#code/CYUwxgNghgTiAEA7KBbEBnADlMCBSAygBrwDeAUPPAJaIAuIMAZjggKIQhr0DC066MpSrw4iUDABc8KIgCeAbmEBfcqvKQoA+AFk5PAPYpMBxCHpCqYiQAoAlGVWqmAV0Rg61U7rkAxHHQGMH5uHl6I9paiIHQuMIhk0eKM0pEAvAB8jvBO5OQAPHqGxqbmdPAA9BkKlRXwBgDWBXr+HkEh7p7eVTUVdY15mtoAcgZ0AIIAalAQ1MDFJmYWpM6hXQmjE9OzwK2Bwb5r4ZEUVjFxCStK6vmbUzNzC6UWPbXwjDBBBXfbc3vth064Uq1TeHy+QA)\r\n\r\n\u003c!-- Did you find other bugs that looked similar? -->\r\n**Related Issues:**\r\nhttps://github.com/microsoft/TypeScript/issues/5740\r\nhttps://github.com/microsoft/TypeScript/issues/5478\r\n\r\n**Code**\r\n```ts\r\ndeclare namespace JSX {\r\n  interface Element {\r\n    custom: string;\r\n  }\r\n  interface ElementClass {\r\n    render: () => Element;\r\n  }\r\n}\r\n\r\nclass MyComponent {\r\n  render() {\r\n    return {\r\n      custom: \"2\"\r\n    };\r\n  }\r\n}\r\nfunction MyFactoryFunction() {\r\n  return { render: () => { return { custom: \"2\" }; } }\r\n}\r\nfunction MyFunctionComponent() {\r\n  return { custom: \"2\" }\r\n}\r\n\r\n\u003cMyComponent />; // ok\r\n\u003cMyFactoryFunction />; // ok\r\n\u003cMyFunctionComponent />; // ok\r\n\r\nclass NotAValidComponent {}\r\nfunction NotAValidFactoryFunction() {\r\n  return {};\r\n}\r\n\r\n\u003cNotAValidComponent />; // error\r\n\u003cNotAValidFactoryFunction />; // error\r\n```\r\n\r\n\r\n\r\n\u003cdetails>\u003csummary>\u003cb>Output\u003c/b>\u003c/summary>\r\n\r\n```ts\r\n\"use strict\";\r\nclass MyComponent {\r\n    render() {\r\n        return {\r\n            custom: \"2\"\r\n        };\r\n    }\r\n}\r\nfunction MyFactoryFunction() {\r\n    return { render: () => { return { custom: \"2\" }; } };\r\n}\r\nfunction MyFunctionComponent() {\r\n    return { custom: \"2\" };\r\n}\r\n\u003cMyComponent />; // ok\r\n\u003cMyFactoryFunction />; // ok\r\n\u003cMyFunctionComponent />; // ok\r\nclass NotAValidComponent {\r\n}\r\nfunction NotAValidFactoryFunction() {\r\n    return {};\r\n}\r\n\u003cNotAValidComponent />; // error\r\n\u003cNotAValidFactoryFunction />; // error\r\n\r\n```\r\n\r\n\r\n\u003c/details>\r\n\r\n\r\n\u003cdetails>\u003csummary>\u003cb>Compiler Options\u003c/b>\u003c/summary>\r\n\r\n```json\r\n{\r\n  \"compilerOptions\": {\r\n    \"noImplicitAny\": true,\r\n    \"strictNullChecks\": true,\r\n    \"strictFunctionTypes\": true,\r\n    \"strictPropertyInitialization\": true,\r\n    \"strictBindCallApply\": true,\r\n    \"noImplicitThis\": true,\r\n    \"noImplicitReturns\": true,\r\n    \"useDefineForClassFields\": false,\r\n    \"alwaysStrict\": true,\r\n    \"allowUnreachableCode\": false,\r\n    \"allowUnusedLabels\": false,\r\n    \"downlevelIteration\": false,\r\n    \"noEmitHelpers\": false,\r\n    \"noLib\": false,\r\n    \"noStrictGenericChecks\": false,\r\n    \"noUnusedLocals\": false,\r\n    \"noUnusedParameters\": false,\r\n    \"esModuleInterop\": true,\r\n    \"preserveConstEnums\": false,\r\n    \"removeComments\": false,\r\n    \"skipLibCheck\": false,\r\n    \"checkJs\": false,\r\n    \"allowJs\": false,\r\n    \"declaration\": true,\r\n    \"experimentalDecorators\": false,\r\n    \"emitDecoratorMetadata\": false,\r\n    \"target\": \"ES2017\",\r\n    \"module\": \"ESNext\"\r\n  }\r\n}\r\n```\r\n\r\n\r\n\u003c/details>\r\n\r\n**Playground Link:** [Provided](https://www.typescriptlang.org/play/index.html?jsx=1#code/CYUwxgNghgTiAEA7KBbEBnADlMCBSAygBrwDeAUPPAJaIAuIMAZjggKIQhr1mVXxgArujoB7FAC54ImLQDmAbj4BfPrQbNW8DlxD0AwtHTpe-eHESgYUgBQBKeAF4AfNs7c6SqqtXlIUY3gAWQBPfXFMUUQ9OlNzPSt7OKo4OkEYRGT+IRFxKQAiACZ8vm8veB9yJkFEMDpqKOCQgDEcMRgWmrqGxCSKFJA0jLJ4y0ZbBxcR1PTM0gFhMUl4IvyKhQqK8lVq2vrG0Oau-cRwlEjo+j6+GeH5nKWC4q3fAB5Qs4uY+AB6Zw2fj94KIANbkd4tNqiDpHPY9X7-X5A0Hgw7HHqfKLfP4A5FgvxGEwAOVEdAAggA1KAQajATGXWKkHboxok8lUmnAVp1aGdOFRa4DIZzZRKN5synU2n07GIwHwRgwaHgiUc2nc9p87qNHFIhUwJUwIA)\r\n      ","author":{"url":"https://github.com/use-strict","@type":"Person","name":"use-strict"},"datePublished":"2020-04-01T14:17:31Z","url":"https://github.com/microsoft/TypeScript/issues/37733"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:6dda1dc7-7eb2-55a2-5a9d-ae88ec4d57aa
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idDC06:2F4BD9:ED77EF:13A65A5:6B0101B6
html-safe-nonce34ce7bbcff93afc98561b0fe9d111b55f20ad36af30977c684e34951d4f0caec
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzA2OjJGNEJEOTpFRDc3RUY6MTNBNjVBNTo2QjAxMDFCNiIsInZpc2l0b3JfaWQiOiIxNDYyNDM5ODkyMjUxMzc4MTAyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc44d0b3804d4e062af55f6e2a67916a760e2abd83bf948a0c1ee20d3b6167ddd
hovercard-subject-tagissue:591952138
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/37733/issue_layout
twitter:imagehttps://opengraph.githubassets.com/60178d10b03b4a000aae0f5ba0ebe2edeff72851c023ffd8fc5ada1cdef24492/microsoft/TypeScript/issues/37733
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/60178d10b03b4a000aae0f5ba0ebe2edeff72851c023ffd8fc5ada1cdef24492/microsoft/TypeScript/issues/37733
og:image:altTypeScript Version: 3.3.3 to 3.8.3 Search Terms: jsx factory function constructor component ElementClass Expected behavior: I'm trying to pass a factory function instead of a class component as a J...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameuse-strict
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/37733#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F37733
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F37733
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/37733
Reloadhttps://github.com/microsoft/TypeScript/issues/37733
Reloadhttps://github.com/microsoft/TypeScript/issues/37733
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/37733
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/37733
Support non-constructor JSX factory functionshttps://github.com/microsoft/TypeScript/issues/37733#top
Awaiting More FeedbackThis means we'd like to hear from more people who would be helped by this featurehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Awaiting%20More%20Feedback%22
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
https://github.com/use-strict
Alexandru Ciucă (use-strict)https://github.com/use-strict
on Apr 1, 2020https://github.com/microsoft/TypeScript/issues/37733#issue-591952138
herehttps://www.typescriptlang.org/docs/handbook/jsx.html
Playground Link for Handbook examplehttps://www.typescriptlang.org/play/index.html?jsx=1&ts=3.3.3#code/CYUwxgNghgTiAEA7KBbEBnADlMCBSAygBrwDeAUPPAJaIAuIMAZjggKIQhr0DC066MpSrw4iUDABc8KIgCeAbmEBfcqvKQoA+AFk5PAPYpMBxCHpCqYiQAoAlGVWqmAV0Rg61U7rkAxHHQGMH5uHl6I9paiIHQuMIhk0eKM0pEAvAB8jvBO5OQAPHqGxqbmdPAA9BkKlRXwBgDWBXr+HkEh7p7eVTUVdY15mtoAcgZ0AIIAalAQ1MDFJmYWpM6hXQmjE9OzwK2Bwb5r4ZEUVjFxCStK6vmbUzNzC6UWPbXwjDBBBXfbc3vth064Uq1TeHy+QA
#5740https://github.com/microsoft/TypeScript/issues/5740
#5478https://github.com/microsoft/TypeScript/issues/5478
Providedhttps://www.typescriptlang.org/play/index.html?jsx=1#code/CYUwxgNghgTiAEA7KBbEBnADlMCBSAygBrwDeAUPPAJaIAuIMAZjggKIQhr1mVXxgArujoB7FAC54ImLQDmAbj4BfPrQbNW8DlxD0AwtHTpe-eHESgYUgBQBKeAF4AfNs7c6SqqtXlIUY3gAWQBPfXFMUUQ9OlNzPSt7OKo4OkEYRGT+IRFxKQAiACZ8vm8veB9yJkFEMDpqKOCQgDEcMRgWmrqGxCSKFJA0jLJ4y0ZbBxcR1PTM0gFhMUl4IvyKhQqK8lVq2vrG0Oau-cRwlEjo+j6+GeH5nKWC4q3fAB5Qs4uY+AB6Zw2fj94KIANbkd4tNqiDpHPY9X7-X5A0Hgw7HHqfKLfP4A5FgvxGEwAOVEdAAggA1KAQajATGXWKkHboxok8lUmnAVp1aGdOFRa4DIZzZRKN5synU2n07GIwHwRgwaHgiUc2nc9p87qNHFIhUwJUwIA
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Awaiting More FeedbackThis means we'd like to hear from more people who would be helped by this featurehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Awaiting%20More%20Feedback%22
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
on Apr 1, 2020https://github.com/microsoft/TypeScript/issues/37733#event-3188859142
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
on Apr 1, 2020https://github.com/microsoft/TypeScript/issues/37733#event-3188860423
https://github.com/use-strict
Alexandru Ciucă (use-strict)https://github.com/use-strict
on Apr 7, 2020https://github.com/microsoft/TypeScript/issues/37733#issuecomment-610215699
Ryan Cavanaugh (@RyanCavanaugh)https://github.com/RyanCavanaugh
https://github.com/robbiespeed
Robbie Speed (robbiespeed)https://github.com/robbiespeed
on Apr 18, 2023https://github.com/microsoft/TypeScript/issues/37733#issuecomment-1512329133
playgroundhttps://www.typescriptlang.org/play?strictFunctionTypes=false&strictBindCallApply=false&jsx=1&ts=5.1.0-dev.20230417#code/CYUwxgNghgTiAEA7KBbEBnADlMCBSAygBrwDeAUPPAJaIAuIMAZjggKIQhr0DC066MpSrw4iUDABc8KIgCeAbmEBfYXTmZ2nbnQAqGhAF54AChMBKeIYB88DlxC9+6SwB9TiEAHdTlm3e1HOj4oAXMlKloGZlYAh3ohEXg6KABzaXQ6GFpUiPhVVUhQwQBZOR4AexRMCs8EiioxCQsyAvImAFdEMDpqWvgygDEcOgqYOUGunr7EFobREDoOmEQyBfFGaRb-UmV8pVUAHjLK6tqg+AB6awUry-gKgGtyY4mRsYmp3v7r28v7p5AA
#51328https://github.com/microsoft/TypeScript/pull/51328
class components sectionhttps://www.typescriptlang.org/docs/handbook/jsx.html#class-component
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/37733
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/37733
Awaiting More FeedbackThis means we'd like to hear from more people who would be helped by this featurehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Awaiting%20More%20Feedback%22
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.