Title: Support non-constructor JSX factory functions · Issue #37733 · microsoft/TypeScript · GitHub
Open Graph Title: Support non-constructor JSX factory functions · Issue #37733 · microsoft/TypeScript
X Title: Support non-constructor JSX factory functions · Issue #37733 · microsoft/TypeScript
Description: TypeScript Version: 3.3.3 to 3.8.3 Search Terms: jsx factory function constructor component ElementClass Expected behavior: I'm trying to pass a factory function instead of a class component as a JSX element constructor function. It shou...
Open Graph Description: TypeScript Version: 3.3.3 to 3.8.3 Search Terms: jsx factory function constructor component ElementClass Expected behavior: I'm trying to pass a factory function instead of a class component as a J...
X Description: TypeScript Version: 3.3.3 to 3.8.3 Search Terms: jsx factory function constructor component ElementClass Expected behavior: I'm trying to pass a factory function instead of a class component as...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/37733
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Support non-constructor JSX factory functions","articleBody":"**TypeScript Version:** 3.3.3 to 3.8.3\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:**\r\njsx factory function constructor component ElementClass \r\n\r\n**Expected behavior:**\r\nI'm trying to pass a factory function instead of a class component as a JSX element constructor function. It should be possible according to the Handbook, as described [here](https://www.typescriptlang.org/docs/handbook/jsx.html). See the example under the `Type checking -> class component` section (I can't deep-link with hash/anchor because the server isn't properly configured :( ). I should get no errors with the code provided below.\r\n\r\n**Actual behavior:**\r\nI get the following error:\r\n```\r\nJSX element type '{ render: () => { custom: string; }; }' is not a constructor function for JSX elements.\r\n Property 'custom' is missing in type '{ render: () => { custom: string; }; }' but required in type 'Element'.(2605)\r\n```\r\nFrom what I can tell, this used to work, but the behavior broke somewhere between v3.1.6 and v3.3.3 (as tried in the Playground). I'm guessing there was some change that altered detection between React function components and class components and that change introduced this bug. I'm not even sure if React runtime even allows factory functions, but my use case is a custom library and I'm not using React at all. This error is the same regardless of using React or not.\r\n\r\nAlso, with the exact example from the Handbook, because the JSX.Element is not specified explicitly, there is no error, even when there should be one. See [Playground Link for Handbook example](https://www.typescriptlang.org/play/index.html?jsx=1&ts=3.3.3#code/CYUwxgNghgTiAEA7KBbEBnADlMCBSAygBrwDeAUPPAJaIAuIMAZjggKIQhr0DC066MpSrw4iUDABc8KIgCeAbmEBfcqvKQoA+AFk5PAPYpMBxCHpCqYiQAoAlGVWqmAV0Rg61U7rkAxHHQGMH5uHl6I9paiIHQuMIhk0eKM0pEAvAB8jvBO5OQAPHqGxqbmdPAA9BkKlRXwBgDWBXr+HkEh7p7eVTUVdY15mtoAcgZ0AIIAalAQ1MDFJmYWpM6hXQmjE9OzwK2Bwb5r4ZEUVjFxCStK6vmbUzNzC6UWPbXwjDBBBXfbc3vth064Uq1TeHy+QA)\r\n\r\n\u003c!-- Did you find other bugs that looked similar? -->\r\n**Related Issues:**\r\nhttps://github.com/microsoft/TypeScript/issues/5740\r\nhttps://github.com/microsoft/TypeScript/issues/5478\r\n\r\n**Code**\r\n```ts\r\ndeclare namespace JSX {\r\n interface Element {\r\n custom: string;\r\n }\r\n interface ElementClass {\r\n render: () => Element;\r\n }\r\n}\r\n\r\nclass MyComponent {\r\n render() {\r\n return {\r\n custom: \"2\"\r\n };\r\n }\r\n}\r\nfunction MyFactoryFunction() {\r\n return { render: () => { return { custom: \"2\" }; } }\r\n}\r\nfunction MyFunctionComponent() {\r\n return { custom: \"2\" }\r\n}\r\n\r\n\u003cMyComponent />; // ok\r\n\u003cMyFactoryFunction />; // ok\r\n\u003cMyFunctionComponent />; // ok\r\n\r\nclass NotAValidComponent {}\r\nfunction NotAValidFactoryFunction() {\r\n return {};\r\n}\r\n\r\n\u003cNotAValidComponent />; // error\r\n\u003cNotAValidFactoryFunction />; // error\r\n```\r\n\r\n\r\n\r\n\u003cdetails>\u003csummary>\u003cb>Output\u003c/b>\u003c/summary>\r\n\r\n```ts\r\n\"use strict\";\r\nclass MyComponent {\r\n render() {\r\n return {\r\n custom: \"2\"\r\n };\r\n }\r\n}\r\nfunction MyFactoryFunction() {\r\n return { render: () => { return { custom: \"2\" }; } };\r\n}\r\nfunction MyFunctionComponent() {\r\n return { custom: \"2\" };\r\n}\r\n\u003cMyComponent />; // ok\r\n\u003cMyFactoryFunction />; // ok\r\n\u003cMyFunctionComponent />; // ok\r\nclass NotAValidComponent {\r\n}\r\nfunction NotAValidFactoryFunction() {\r\n return {};\r\n}\r\n\u003cNotAValidComponent />; // error\r\n\u003cNotAValidFactoryFunction />; // error\r\n\r\n```\r\n\r\n\r\n\u003c/details>\r\n\r\n\r\n\u003cdetails>\u003csummary>\u003cb>Compiler Options\u003c/b>\u003c/summary>\r\n\r\n```json\r\n{\r\n \"compilerOptions\": {\r\n \"noImplicitAny\": true,\r\n \"strictNullChecks\": true,\r\n \"strictFunctionTypes\": true,\r\n \"strictPropertyInitialization\": true,\r\n \"strictBindCallApply\": true,\r\n \"noImplicitThis\": true,\r\n \"noImplicitReturns\": true,\r\n \"useDefineForClassFields\": false,\r\n \"alwaysStrict\": true,\r\n \"allowUnreachableCode\": false,\r\n \"allowUnusedLabels\": false,\r\n \"downlevelIteration\": false,\r\n \"noEmitHelpers\": false,\r\n \"noLib\": false,\r\n \"noStrictGenericChecks\": false,\r\n \"noUnusedLocals\": false,\r\n \"noUnusedParameters\": false,\r\n \"esModuleInterop\": true,\r\n \"preserveConstEnums\": false,\r\n \"removeComments\": false,\r\n \"skipLibCheck\": false,\r\n \"checkJs\": false,\r\n \"allowJs\": false,\r\n \"declaration\": true,\r\n \"experimentalDecorators\": false,\r\n \"emitDecoratorMetadata\": false,\r\n \"target\": \"ES2017\",\r\n \"module\": \"ESNext\"\r\n }\r\n}\r\n```\r\n\r\n\r\n\u003c/details>\r\n\r\n**Playground Link:** [Provided](https://www.typescriptlang.org/play/index.html?jsx=1#code/CYUwxgNghgTiAEA7KBbEBnADlMCBSAygBrwDeAUPPAJaIAuIMAZjggKIQhr1mVXxgArujoB7FAC54ImLQDmAbj4BfPrQbNW8DlxD0AwtHTpe-eHESgYUgBQBKeAF4AfNs7c6SqqtXlIUY3gAWQBPfXFMUUQ9OlNzPSt7OKo4OkEYRGT+IRFxKQAiACZ8vm8veB9yJkFEMDpqKOCQgDEcMRgWmrqGxCSKFJA0jLJ4y0ZbBxcR1PTM0gFhMUl4IvyKhQqK8lVq2vrG0Oau-cRwlEjo+j6+GeH5nKWC4q3fAB5Qs4uY+AB6Zw2fj94KIANbkd4tNqiDpHPY9X7-X5A0Hgw7HHqfKLfP4A5FgvxGEwAOVEdAAggA1KAQajATGXWKkHboxok8lUmnAVp1aGdOFRa4DIZzZRKN5synU2n07GIwHwRgwaHgiUc2nc9p87qNHFIhUwJUwIA)\r\n ","author":{"url":"https://github.com/use-strict","@type":"Person","name":"use-strict"},"datePublished":"2020-04-01T14:17:31Z","url":"https://github.com/microsoft/TypeScript/issues/37733"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:6dda1dc7-7eb2-55a2-5a9d-ae88ec4d57aa |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | DC06:2F4BD9:ED77EF:13A65A5:6B0101B6 |
| html-safe-nonce | 34ce7bbcff93afc98561b0fe9d111b55f20ad36af30977c684e34951d4f0caec |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzA2OjJGNEJEOTpFRDc3RUY6MTNBNjVBNTo2QjAxMDFCNiIsInZpc2l0b3JfaWQiOiIxNDYyNDM5ODkyMjUxMzc4MTAyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | c44d0b3804d4e062af55f6e2a67916a760e2abd83bf948a0c1ee20d3b6167ddd |
| hovercard-subject-tag | issue:591952138 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/37733/issue_layout |
| twitter:image | https://opengraph.githubassets.com/60178d10b03b4a000aae0f5ba0ebe2edeff72851c023ffd8fc5ada1cdef24492/microsoft/TypeScript/issues/37733 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/60178d10b03b4a000aae0f5ba0ebe2edeff72851c023ffd8fc5ada1cdef24492/microsoft/TypeScript/issues/37733 |
| og:image:alt | TypeScript Version: 3.3.3 to 3.8.3 Search Terms: jsx factory function constructor component ElementClass Expected behavior: I'm trying to pass a factory function instead of a class component as a J... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | use-strict |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width