Title: Design Meeting Notes, 3/13/2020 · Issue #37389 · microsoft/TypeScript · GitHub
Open Graph Title: Design Meeting Notes, 3/13/2020 · Issue #37389 · microsoft/TypeScript
X Title: Design Meeting Notes, 3/13/2020 · Issue #37389 · microsoft/TypeScript
Description: Update on Intersections and Optional Properties #37195 Relating Instances of the Same Signature #31029 When we have signatures that have generic type parameters, we currently erase the type parameters before we compare them. This is an o...
Open Graph Description: Update on Intersections and Optional Properties #37195 Relating Instances of the Same Signature #31029 When we have signatures that have generic type parameters, we currently erase the type paramet...
X Description: Update on Intersections and Optional Properties #37195 Relating Instances of the Same Signature #31029 When we have signatures that have generic type parameters, we currently erase the type paramet...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/37389
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Design Meeting Notes, 3/13/2020","articleBody":"## Update on Intersections and Optional Properties\r\n\r\nhttps://github.com/microsoft/TypeScript/pull/37195\r\n\r\n## Relating Instances of the Same Signature\r\n\r\nhttps://github.com/microsoft/TypeScript/pull/31029\r\n\r\n* When we have signatures that have generic type parameters, we currently erase the type parameters before we compare them.\r\n* This is an old issue/PR, but it was pretty breaky.\r\n* Basically, the getter/setters make the types invariant.\r\n* This change would break completions and the like in addition to actual errors.\r\n* Introduces some breaks in Ember\r\n* Maybe we need a second pair of eyes\r\n* Could we put this under `strictFunctionTypes`?\r\n * Pretty sure that Ember already is under `strictFunctionTypes`.\r\n * But that means that users can't run with `strictFunctionTypes`.\r\n * But the API inherently has problems there.\r\n * Means that on top of changing the `.d.ts` files, users would have to upgrade.\r\n* Conclusion: try this under `strictFunctionTypes`, see if we can introduce a new flag instead.\r\n\r\n## Spread Elements and `const` assertions\r\n\r\nhttps://github.com/microsoft/TypeScript/issues/37357\r\n\r\n* A `const` assertion makes things `readonly`.\r\n* With a spread-in object literal, we give `readonly` properties.\r\n* Tuples spread into tuples...doesn't seem to work? Is this a bug?\r\n* Uh, looks like https://github.com/microsoft/TypeScript/pull/36861 fixes this.\r\n\r\n## Indexing with identical bindings of type `keyof Foo`\r\n\r\nhttps://github.com/microsoft/TypeScript/issues/32693\r\n\r\n* This one keeps coming up.\r\n* The code itself is reasonable.\r\n* If the `key` on both sides is the \"same\" for some meaning of \"same\", then this feels reasonable.\r\n * What does \"same\" mean?\r\n * Same identifier maybe. Clearly not the same type.\r\n* Maybe check against binary assignments.\r\n * But these can occur arbitrarily deep in an object literal.\r\n * People are typically just trying to copy over property declarations in bulk.\r\n* How does this work when an indexing expression has a type that's the intersection of each type's key?\r\n * source: { A, B }, target: { B, C }, index: \"B\"?\r\n* Conclusion: approved for the basic case.\r\n\r\n## `skipLibCheck` (and `pretty`?) in config files from `tsc --init`\r\n\r\nhttps://github.com/microsoft/TypeScript/issues/37361\r\n\r\n* Problems: hello world check time is >1s.\r\n* For `tsc --init`, we can always change this.\r\n* Seems good to turn it on there, but we must always make sure that `.d.ts` files are checked somewhere.\r\n * DefinitelyTyped, `lib.d.ts`\r\n* What else should we turn on in `tsc --init`?\r\n * `--incremental`?\r\n * Afraid people will check in their `.tsbuildinfo` files.\r\n* Ask is for `skipLibCheck` to be included in `tsc --init`, not that it's turned on.\r\n* 4 levels of `tsc --init` include-ness\r\n * Emitted with a comment\r\n * Emitted with a comment where it's not set to the default\r\n * Emitted with a value that's a default\r\n * Emitted with a value that's not a default\r\n* Conclusion\r\n * Should have a link to the tsconfig page on our website.\r\n","author":{"url":"https://github.com/DanielRosenwasser","@type":"Person","name":"DanielRosenwasser"},"datePublished":"2020-03-13T21:54:50Z","url":"https://github.com/microsoft/TypeScript/issues/37389"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:25de4be6-4db3-0efe-cc6e-4838e35a4ce5 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | E3D4:34EA7D:C394FA:FB7457:6B00EB93 |
| html-safe-nonce | b405c7741f5134d0e9d9d968ca6cc314d9519c71d4e5df9cb74386586fcff04a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFM0Q0OjM0RUE3RDpDMzk0RkE6RkI3NDU3OjZCMDBFQjkzIiwidmlzaXRvcl9pZCI6IjEwMTMwMTE4NzcyODgwMTI2OTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 7124bb0c7cb286ae35240b118862ad9521e093d8aaad67ace9d267e3c3ff6610 |
| hovercard-subject-tag | issue:580880784 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/37389/issue_layout |
| twitter:image | https://opengraph.githubassets.com/1f737a9f9613d30536b783f2fe091cf9aca90a45c195c33ac293cbd20a7e84c9/microsoft/TypeScript/issues/37389 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1f737a9f9613d30536b783f2fe091cf9aca90a45c195c33ac293cbd20a7e84c9/microsoft/TypeScript/issues/37389 |
| og:image:alt | Update on Intersections and Optional Properties #37195 Relating Instances of the Same Signature #31029 When we have signatures that have generic type parameters, we currently erase the type paramet... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | DanielRosenwasser |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width