Title: Don't emit `const enum`s with reverse mapping (under `preserveConstEnum`) · Issue #37282 · microsoft/TypeScript · GitHub
Open Graph Title: Don't emit `const enum`s with reverse mapping (under `preserveConstEnum`) · Issue #37282 · microsoft/TypeScript
X Title: Don't emit `const enum`s with reverse mapping (under `preserveConstEnum`) · Issue #37282 · microsoft/TypeScript
Description: Search Terms preserveConstEnums, const enum, enum Suggestion By default all const enums are preserved from output. One of the key differences of const enums is disallowing to looking up the reversed value: enum Enum { Zero, One, } consol...
Open Graph Description: Search Terms preserveConstEnums, const enum, enum Suggestion By default all const enums are preserved from output. One of the key differences of const enums is disallowing to looking up the reverse...
X Description: Search Terms preserveConstEnums, const enum, enum Suggestion By default all const enums are preserved from output. One of the key differences of const enums is disallowing to looking up the reverse...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/37282
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Don't emit `const enum`s with reverse mapping (under `preserveConstEnum`)","articleBody":"## Search Terms\r\n\r\npreserveConstEnums, const enum, enum\r\n\r\n## Suggestion\r\n\r\nBy default all `const enum`s are preserved from output. One of the key differences of `const enum`s is disallowing to looking up the reversed value:\r\n\r\n```ts\r\nenum Enum {\r\n Zero,\r\n One,\r\n}\r\n\r\nconsole.log(Enum[1]); // allowed, result is 'One'\r\n\r\nconst enum ConstEnum {\r\n Zero,\r\n One,\r\n}\r\n\r\nconsole.log(ConstEnum[1]); // Error\r\n```\r\n\r\nThis means that we can't access const enum's \"reversed\" member even if `preserveConstEnums` flag is enabled.\r\n\r\nJS code of `const enum` with enabled `preserveConstEnums` is pretty similar to just `enum`s right now and contains string literals (even they couldn't be accessed from the code):\r\n\r\n```js\r\nvar ConstEnum;\r\n(function (ConstEnum) {\r\n ConstEnum[ConstEnum[\"Zero\"] = 0] = \"Zero\";\r\n ConstEnum[ConstEnum[\"One\"] = 1] = \"One\";\r\n})(ConstEnum || (ConstEnum = {}));\r\n```\r\n\r\nMy feature request is change output of `const enum`s when `preserveConstEnums` is enabled and strip \"reversed\" values from it:\r\n\r\n```js\r\nvar ConstEnum;\r\n(function (ConstEnum) {\r\n ConstEnum[\"Zero\"] = 0;\r\n ConstEnum[\"One\"] = 1;\r\n})(ConstEnum || (ConstEnum = {}));\r\n```\r\n\r\nNote: actually tsc already has similar behaviour if you specify string constant value for every const enum's member, but the values are strings, not numbers - it is kind of workaround if your const enum is used to declare string constants.\r\n\r\n## Use Cases\r\n\r\nReversed values for const enums are useless and cannot be accessed in the TS code, so why we should emit them? 🤔 I guess in this case the behaviour of `const enum`s from types and from execution (JS) purposes will be the same.\r\n\r\n## Checklist\r\n\r\nMy suggestion meets these guidelines:\r\n\r\n* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code\r\n* [ ] This wouldn't change the runtime behavior of existing JavaScript code\r\n* [x] This could be implemented without emitting different JS based on the types of the expressions\r\n* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)\r\n* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).\r\n","author":{"url":"https://github.com/timocov","@type":"Person","name":"timocov"},"datePublished":"2020-03-08T16:06:52Z","url":"https://github.com/microsoft/TypeScript/issues/37282"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:bca9ae63-7cde-62d8-9763-d2b0bcac8cb3 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8E7C:5D487:18ABEE:211E6B:6B0189CD |
| html-safe-nonce | 88299d54e0cb298a427b884ab9f0d4bdb9bc07ef032d89607271ed925c6c2852 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RTdDOjVENDg3OjE4QUJFRToyMTFFNkI6NkIwMTg5Q0QiLCJ2aXNpdG9yX2lkIjoiMTIyMzAzODg5NjIwODcxMDA5MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 432946bf0fdd923ce17a539574417d760f5d965901ae696d56eca4a445673f7f |
| hovercard-subject-tag | issue:577523906 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/37282/issue_layout |
| twitter:image | https://opengraph.githubassets.com/2a6ee70dafd7aa89faba0d2baf643cd22f6bf81a15c748c34eb6c3edeb58b21a/microsoft/TypeScript/issues/37282 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2a6ee70dafd7aa89faba0d2baf643cd22f6bf81a15c748c34eb6c3edeb58b21a/microsoft/TypeScript/issues/37282 |
| og:image:alt | Search Terms preserveConstEnums, const enum, enum Suggestion By default all const enums are preserved from output. One of the key differences of const enums is disallowing to looking up the reverse... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | timocov |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width